From c11378ff2208fe7f131be7c31a96d4928ea0df9b Mon Sep 17 00:00:00 2001 From: Hiroaki Kawai Date: Tue, 18 Sep 2012 18:26:34 -0700 Subject: [PATCH] add logging for debugging. The default value for local.storage.path does not exists by default in CentOS 6. By default, this results in NullPointerException silently. Without this log message, administrator can't figure out the reason at all. Signed-off-by: Edison Su --- .../cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java index d6236a0d603..df295dd8eda 100644 --- a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java +++ b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java @@ -213,10 +213,11 @@ public class LibvirtStorageAdaptor implements StorageAdaptor { } } - private StoragePool CreateSharedStoragePool(Connect conn, String uuid, + private StoragePool createSharedStoragePool(Connect conn, String uuid, String host, String path) { String mountPoint = path; if (!_storageLayer.exists(mountPoint)) { + s_logger.error(mountPath + " does not exists. Check local.storage.path in agent.properties."); return null; } LibvirtStoragePoolDef spd = new LibvirtStoragePoolDef(poolType.DIR, @@ -550,7 +551,7 @@ public class LibvirtStorageAdaptor implements StorageAdaptor { sp = createNfsStoragePool(conn, name, host, path); } else if (type == StoragePoolType.SharedMountPoint || type == StoragePoolType.Filesystem) { - sp = CreateSharedStoragePool(conn, name, host, path); + sp = createSharedStoragePool(conn, name, host, path); } else if (type == StoragePoolType.RBD) { sp = createRBDStoragePool(conn, name, host, port, userInfo, path); } else if (type == StoragePoolType.CLVM) {