diff --git a/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java b/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java index 2b77b9b0b0d..9f0418a8d9c 100644 --- a/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java +++ b/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java @@ -384,6 +384,7 @@ public class ApiConstants { public static final String SENT = "sent"; public static final String SENT_BYTES = "sentbytes"; public static final String SERIAL = "serial"; + public static final String SERVICE_IP = "serviceip"; public static final String SERVICE_OFFERING_ID = "serviceofferingid"; public static final String SESSIONKEY = "sessionkey"; public static final String SHOW_CAPACITIES = "showcapacities"; diff --git a/api/src/main/java/org/apache/cloudstack/api/response/ManagementServerResponse.java b/api/src/main/java/org/apache/cloudstack/api/response/ManagementServerResponse.java index 0289e8f9e3b..330f91e69f3 100644 --- a/api/src/main/java/org/apache/cloudstack/api/response/ManagementServerResponse.java +++ b/api/src/main/java/org/apache/cloudstack/api/response/ManagementServerResponse.java @@ -72,6 +72,10 @@ public class ManagementServerResponse extends BaseResponse { @Param(description = "the running OS kernel version for this Management Server") private String kernelVersion; + @SerializedName(ApiConstants.SERVICE_IP) + @Param(description = "the IP Address for this Management Server") + private String serviceIp; + public String getId() { return this.id; } @@ -112,6 +116,10 @@ public class ManagementServerResponse extends BaseResponse { return lastBoot; } + public String getServiceIp() { + return serviceIp; + } + public void setId(String id) { this.id = id; } @@ -155,4 +163,8 @@ public class ManagementServerResponse extends BaseResponse { public void setKernelVersion(String kernelVersion) { this.kernelVersion = kernelVersion; } + + public void setServiceIp(String serviceIp) { + this.serviceIp = serviceIp; + } } diff --git a/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java b/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java index 047c6b5b69f..211e6db19c0 100644 --- a/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java +++ b/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java @@ -4444,6 +4444,7 @@ public class QueryManagerImpl extends MutualExclusiveIdsManagerBase implements Q mgmtResponse.setLastServerStart(mgmt.getLastJvmStart()); mgmtResponse.setLastServerStop(mgmt.getLastJvmStop()); mgmtResponse.setLastBoot(mgmt.getLastSystemBoot()); + mgmtResponse.setServiceIp(mgmt.getServiceIP()); mgmtResponse.setObjectName("managementserver"); return mgmtResponse; } diff --git a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java index e99f3c88956..cf4e7fdb2cc 100644 --- a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java +++ b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java @@ -1642,11 +1642,11 @@ StateListener, Configurable { // for each volume find list of suitable storage pools by calling the // allocators - Set originalAvoidPoolSet = avoid.getPoolsToAvoid(); - if (originalAvoidPoolSet == null) { - originalAvoidPoolSet = new HashSet(); + Set originalAvoidPoolSet = new HashSet<>(); + if (avoid.getPoolsToAvoid() != null) { + originalAvoidPoolSet.addAll(avoid.getPoolsToAvoid()); } - Set poolsToAvoidOutput = new HashSet(originalAvoidPoolSet); + Set poolsToAvoidOutput = new HashSet<>(originalAvoidPoolSet); for (VolumeVO toBeCreated : volumesTobeCreated) { s_logger.debug("Checking suitable pools for volume (Id, Type): (" + toBeCreated.getId() + "," + toBeCreated.getVolumeType().name() + ")"); @@ -1723,12 +1723,6 @@ StateListener, Configurable { DiskOfferingVO diskOffering = _diskOfferingDao.findById(toBeCreated.getDiskOfferingId()); - //FR123 check how is it different for service offering getTagsArray and disk offering's - //if ((vmProfile.getTemplate().getFormat() == Storage.ImageFormat.ISO || toBeCreated.getVolumeType() == Volume.Type.ROOT) - // && vmProfile.getServiceOffering().getTagsArray().length != 0) { - // diskOffering.setTagsArray(Arrays.asList(vmProfile.getServiceOffering().getTagsArray())); - //} - DiskProfile diskProfile = new DiskProfile(toBeCreated, diskOffering, vmProfile.getHypervisorType()); boolean useLocalStorage = false; if (vmProfile.getType() != VirtualMachine.Type.User) { diff --git a/ui/public/locales/en.json b/ui/public/locales/en.json index 17532b36a47..a55455823a7 100644 --- a/ui/public/locales/en.json +++ b/ui/public/locales/en.json @@ -1794,6 +1794,7 @@ "label.srx": "SRX", "label.srx.firewall": "Juniper SRX firewall", "label.ssh.key.pairs": "SSH key pairs", +"label.uefi.supported": "UEFI supported", "label.userdataid": "Userdata ID", "label.userdataname": "Userdata name", "label.userdatadetails": "Userdata details", diff --git a/ui/src/views/compute/DeployVM.vue b/ui/src/views/compute/DeployVM.vue index e7c479ae43d..9190d8b0c96 100644 --- a/ui/src/views/compute/DeployVM.vue +++ b/ui/src/views/compute/DeployVM.vue @@ -1844,7 +1844,7 @@ export default { this.form.networkids = ids }, updateDefaultNetworks (id) { - this.defaultNetwork = id + this.defaultnetworkid = id this.form.defaultnetworkid = id }, updateNetworkConfig (networks) { diff --git a/ui/src/views/infra/HostInfo.vue b/ui/src/views/infra/HostInfo.vue index a74407be7df..1d0b47eba95 100644 --- a/ui/src/views/infra/HostInfo.vue +++ b/ui/src/views/infra/HostInfo.vue @@ -104,7 +104,14 @@ - + +
+ {{ $t('label.uefi.supported') }} +
+ {{ host.ueficapability }} +
+
+