From c4677d5f809e0485a61dd57a82f315d919904b1f Mon Sep 17 00:00:00 2001
From: Sheng Yang <sheng.yang@cloud.com>
Date: Wed, 11 Jan 2012 14:26:37 -0800
Subject: [PATCH] Fix NPE in checkVirtualNetworkCidrOverlap()

---
 server/src/com/cloud/network/NetworkManagerImpl.java | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/server/src/com/cloud/network/NetworkManagerImpl.java b/server/src/com/cloud/network/NetworkManagerImpl.java
index 3e212b89dd7..da263257b12 100755
--- a/server/src/com/cloud/network/NetworkManagerImpl.java
+++ b/server/src/com/cloud/network/NetworkManagerImpl.java
@@ -2025,7 +2025,9 @@ public class NetworkManagerImpl implements NetworkManager, NetworkService, Manag
             if (network.getGuestType() != GuestType.Isolated) {
                 continue;
             }
-            networkToCidr.put(network.getId(), network.getCidr());
+            if (network.getCidr() != null) {
+                networkToCidr.put(network.getId(), network.getCidr());
+            }
         }
         if (networkToCidr == null || networkToCidr.isEmpty()) {
             return;
@@ -2041,7 +2043,7 @@ public class NetworkManagerImpl implements NetworkManager, NetworkService, Manag
             
             long cidrSizeToUse = currCidrSize < ntwkCidrSize ? currCidrSize : ntwkCidrSize;
             
-            String ntwkCidrSubnet = NetUtils.getCidrSubNet(getCidrAddress(ntwkCidr), cidrSizeToUse);
+            String ntwkCidrSubnet = NetUtils.getCidrSubNet(ntwkCidrAddress, cidrSizeToUse);
             String cidrSubnet = NetUtils.getCidrSubNet(currCidrAddress, cidrSizeToUse);
             
             if (cidrSubnet.equals(ntwkCidrSubnet)) {