address comments

This commit is contained in:
Pearl Dsilva 2024-01-18 11:24:52 -05:00
parent 767c16cde4
commit c4a51c8340
1 changed files with 3 additions and 3 deletions

View File

@ -105,8 +105,6 @@ public class NetworkACLServiceImpl extends ManagerBase implements NetworkACLServ
private VpcService _vpcSvc; private VpcService _vpcSvc;
@Inject @Inject
private NsxProviderDao nsxProviderDao; private NsxProviderDao nsxProviderDao;
@Inject
private NetworkACLDao networkACLDao;
private String supportedProtocolsForAclRules = "tcp,udp,icmp,all"; private String supportedProtocolsForAclRules = "tcp,udp,icmp,all";
@ -445,7 +443,9 @@ public class NetworkACLServiceImpl extends ManagerBase implements NetworkACLServ
return; return;
} }
if (icpmType == -1) { if (icpmType == -1) {
throw new InvalidParameterValueException("Passing -1 for ICMP type is not supported for NSX enabled zones"); String errorMsg = "Passing -1 for ICMP type is not supported for NSX enabled zones";
s_logger.error(errorMsg);
throw new InvalidParameterValueException(errorMsg);
} }
} }