etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

findbugs bitwise or guaranteed positively bitfields

This commit is contained in:
Daan Hoogland 2014-01-30 23:16:24 +01:00
parent 41fd0a2ab7
commit c6118ad92e
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
awsapi/src/com/cloud/bridge/io/DimeDelimitedInputStream.java
View File

@ -354,13 +354,19 @@ public class DimeDelimitedInputStream extends FilterInputStream {
}
//OPTIONS_LENGTH
int optionsLength = ((((int)header[2]) << 8) & 0xff00) | ((int)header[3]);
int oneButLastByte = (((int)header[2]) << 8) & 0xff00;
int lastByte = (int)header[3] & 0xff;
int optionsLength = oneButLastByte | lastByte;
//ID_LENGTH
int idLength = ((((int)header[4]) << 8) & 0xff00) | ((int)header[5]);
oneButLastByte = ((((int)header[4]) << 8) & 0xff00);
lastByte = ((int)header[5]) & 0xff;
int idLength = oneButLastByte | lastByte;
//TYPE_LENGTH
int typeLength = ((((int)header[6]) << 8) & 0xff00) | ((int)header[7]);
oneButLastByte = ((((int)header[6]) << 8) & 0xff00);
lastByte = ((int)header[7]) & 0xff;
int typeLength = oneButLastByte | lastByte;
//DATA_LENGTH
recordLength =