From ca42ed29b871d2f5caf188ab3dfdcf4cfcdd3b28 Mon Sep 17 00:00:00 2001 From: Rohit Yadav Date: Thu, 29 Oct 2015 12:45:04 +0530 Subject: [PATCH] metrics: don't sort on columns where all elements are same Signed-off-by: Rohit Yadav --- ui/scripts/ui/widgets/dataTable.js | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/ui/scripts/ui/widgets/dataTable.js b/ui/scripts/ui/widgets/dataTable.js index c85f2d26737..e89e72b0178 100644 --- a/ui/scripts/ui/widgets/dataTable.js +++ b/ui/scripts/ui/widgets/dataTable.js @@ -154,11 +154,22 @@ return $(this).index() == columnIndex; }); + var hasAllRowsSameValue = true; + var firstElem = $($elems[0]).html(); var sortData = []; $elems.each(function() { + if (hasAllRowsSameValue) { + if (firstElem !== $(this).html()) { + hasAllRowsSameValue = false; + } + } sortData.push($(this)); }); + if (hasAllRowsSameValue) { + return; + } + var stringComparator = function(a,b) { return a.html().localeCompare(b.html()); };