From ca7f22062bb25dfade1c607d7911e29a1b7310e8 Mon Sep 17 00:00:00 2001 From: Marcus Sorensen Date: Fri, 16 Aug 2013 23:22:15 -0600 Subject: [PATCH] CLOUDSTACK-4379: Reset VM states when host is removed from cluster If you shut down the agent while VMs are running, the management server assumes that the VMs are continuing to run. You can then delete the host while it is in 'disconnected' state, and those VMs will be unusable, forever in running state. They can't change state because the host no longer exists. This patch checks for any VMs that may have been tied to the removed host and resets their state so that cloudstack can continue to manage them. --- server/src/com/cloud/resource/ResourceManagerImpl.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/server/src/com/cloud/resource/ResourceManagerImpl.java b/server/src/com/cloud/resource/ResourceManagerImpl.java index d6069a4ef98..2a86ffd7439 100755 --- a/server/src/com/cloud/resource/ResourceManagerImpl.java +++ b/server/src/com/cloud/resource/ResourceManagerImpl.java @@ -872,6 +872,15 @@ public class ResourceManagerImpl extends ManagerBase implements ResourceManager, // Delete the associated entries in host ref table _storagePoolHostDao.deletePrimaryRecordsForHost(hostId); + // Make sure any VMs that were marked as being on this host are cleaned up + List vms = _vmDao.listByHostId(hostId); + for (VMInstanceVO vm : vms) { + // this is how VirtualMachineManagerImpl does it when it syncs VM states + vm.setState(State.Stopped); + vm.setHostId(null); + _vmDao.persist(vm); + } + // For pool ids you got, delete local storage host entries in pool table // where for (StoragePoolHostVO pool : pools) {