etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

vpc: prevent sourcenat ip disassociation for an active vpc (#6664) 

Fixes #6663

Source NAT IP should not be disassociated from an active vpc
This commit is contained in:
Abhishek Kumar 2022-08-24 13:23:01 +05:30 committed by GitHub
parent 814dbbaf86
commit cd37b135a0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server/src/main/java/com/cloud/network/NetworkServiceImpl.java
View File

@ -1075,7 +1075,11 @@ public class NetworkServiceImpl extends ManagerBase implements NetworkService, C
if (networkId != null) {
guestNetwork = getNetwork(networkId);
}
if (ipVO.isSourceNat() && guestNetwork != null && guestNetwork.getState() != Network.State.Allocated) {
Vpc vpc = null;
if (ipVO.getVpcId() != null) {
vpc = _vpcMgr.getActiveVpc(ipVO.getVpcId());
}
if (ipVO.isSourceNat() && ((guestNetwork != null && guestNetwork.getState() != Network.State.Allocated) || vpc != null)) {
throw new IllegalArgumentException("ip address is used for source nat purposes and can not be disassociated.");
}