diff --git a/server/src/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java b/server/src/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java index 8aad88a6b3a..81b6565c90c 100644 --- a/server/src/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java +++ b/server/src/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java @@ -22,13 +22,11 @@ import java.util.List; import org.apache.log4j.Logger; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Qualifier; +import org.springframework.stereotype.Component; -import com.cloud.dc.DataCenter; import com.cloud.deploy.DeployDestination; import com.cloud.exception.ResourceUnavailableException; import com.cloud.network.Network; -import com.cloud.network.lb.LoadBalancingRule; -import com.cloud.network.router.VirtualRouter; import com.cloud.network.rules.RuleApplier; import com.cloud.network.rules.RuleApplierWrapper; import com.cloud.network.rules.UserdataPwdRules; @@ -36,50 +34,8 @@ import com.cloud.vm.DomainRouterVO; import com.cloud.vm.NicProfile; import com.cloud.vm.VirtualMachineProfile; -public class AdvancedNetworkTopology implements NetworkTopology { - - @Override - public StringBuilder createGuestBootLoadArgs(final NicProfile guestNic, final String defaultDns1, final String defaultDns2, final DomainRouterVO router) { - return null; - } - - @Override - public String retrieveGuestDhcpRange(final NicProfile guestNic, final Network guestNetwork, final DataCenter dc) { - return null; - } - - @Override - public NicProfile retrieveControlNic(final VirtualMachineProfile profile) { - return null; - } - - @Override - public boolean configDhcpForSubnet(final Network network, final NicProfile nic, final VirtualMachineProfile profile, final DeployDestination dest, - final List routers) throws ResourceUnavailableException { - return false; - } - - @Override - public boolean applyDhcpEntry(final Network network, final NicProfile nic, final VirtualMachineProfile profile, final DeployDestination dest, - final List routers) throws ResourceUnavailableException { - return false; - } - - @Override - public boolean applyRules(final Network network, final List routers, final String typeString, final boolean isPodLevelException, final Long podId, - final boolean failWhenDisconnect, final RuleApplier applier) throws ResourceUnavailableException { - - AdvancedNetworkVisitor visitor = new AdvancedNetworkVisitor(this); - applier.accept(visitor, null); - - return false; - } - - @Override - public boolean sendCommandsToRouter(final VirtualRouter router, final List rules, final long id) { - // TODO Auto-generated method stub - return false; - } +@Component +public class AdvancedNetworkTopology extends BasicNetworkTopology { private static final Logger s_logger = Logger.getLogger(AdvancedNetworkTopology.class); diff --git a/server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java b/server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java index 54e61d03cd2..d19db06fca3 100644 --- a/server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java +++ b/server/src/org/apache/cloudstack/network/topology/BasicNetworkTopology.java @@ -25,6 +25,7 @@ import javax.inject.Inject; import org.apache.log4j.Logger; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Qualifier; +import org.springframework.stereotype.Component; import com.cloud.dc.DataCenter; import com.cloud.dc.DataCenter.NetworkType; @@ -63,6 +64,7 @@ import com.cloud.vm.VirtualMachine.State; import com.cloud.vm.VirtualMachineProfile; import com.cloud.vm.dao.UserVmDao; +@Component public class BasicNetworkTopology implements NetworkTopology { private static final Logger s_logger = Logger.getLogger(BasicNetworkTopology.class); diff --git a/server/src/org/apache/cloudstack/network/topology/NetworkTopologyContext.java b/server/src/org/apache/cloudstack/network/topology/NetworkTopologyContext.java index bbe58dda379..00acec89955 100644 --- a/server/src/org/apache/cloudstack/network/topology/NetworkTopologyContext.java +++ b/server/src/org/apache/cloudstack/network/topology/NetworkTopologyContext.java @@ -21,6 +21,9 @@ import java.util.Hashtable; import javax.inject.Inject; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.beans.factory.annotation.Qualifier; + import com.cloud.dc.DataCenter; import com.cloud.dc.DataCenter.NetworkType; @@ -28,10 +31,12 @@ public class NetworkTopologyContext { private final Hashtable _flyweight = new Hashtable();; - @Inject + @Autowired + @Qualifier("basicNetworkTopology") private BasicNetworkTopology _basicNetworkTopology; - @Inject + @Autowired + @Qualifier("advancedNetworkTopology") private AdvancedNetworkTopology _advancedNetworkTopology; public void init() {