From d2bf21065eb650ae2b58c5ab548c8c72a97b76b9 Mon Sep 17 00:00:00 2001 From: Rohit Yadav Date: Fri, 6 Feb 2015 14:20:32 +0530 Subject: [PATCH] DeployVmCmd: Fix NPE case Signed-off-by: Rohit Yadav --- .../apache/cloudstack/api/command/user/vm/DeployVMCmd.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java b/api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java index bb7b13cdad1..e1916cbe09f 100755 --- a/api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java +++ b/api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java @@ -300,8 +300,8 @@ public class DeployVMCmd extends BaseAsyncCreateCustomIdCmd { } public List getNetworkIds() { - if (ipToNetworkList != null) { - if (networkIds != null || ipAddress != null || getIp6Address() != null) { + if (ipToNetworkList != null && !ipToNetworkList.isEmpty()) { + if ((networkIds != null && !newtworkIds.isEmpty()) || ipAddress != null || getIp6Address() != null) { throw new InvalidParameterValueException("ipToNetworkMap can't be specified along with networkIds or ipAddress"); } else { List networks = new ArrayList();