From d53591c3fe2937488d555aeb096c6d245ee3e722 Mon Sep 17 00:00:00 2001 From: Pearl Dsilva Date: Thu, 26 Feb 2026 08:05:57 -0500 Subject: [PATCH] prevent creating a bkp offering of a bkp repo that already exists --- .../org/apache/cloudstack/backup/BackupManagerImpl.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java b/server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java index 5ec1df19e4b..db636c7f0f4 100644 --- a/server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java +++ b/server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java @@ -358,11 +358,11 @@ public class BackupManagerImpl extends ManagerBase implements BackupManager { if (!provider.isValidProviderOffering(zoneId, externalId)) { throw new CloudRuntimeException("Backup offering '" + externalId + "' does not exist on provider " + provider.getName() + " on zone " + zoneId); } + } - final BackupOffering existingOffering = backupOfferingDao.findByExternalId(externalId, zoneId); - if (existingOffering != null) { - throw new CloudRuntimeException("A backup offering with external ID '" + externalId + "' already exists in this zone"); - } + final BackupOffering existingOffering = backupOfferingDao.findByExternalId(externalId, zoneId); + if (existingOffering != null) { + throw new CloudRuntimeException("A backup offering with external ID '" + externalId + "' already exists in this zone"); } final BackupOfferingVO clonedOffering = new BackupOfferingVO(