From d5b04dd25a61afcaaef742dfbc95909ec3ca4409 Mon Sep 17 00:00:00 2001 From: Anthony Xu Date: Mon, 22 Nov 2010 20:45:59 -0800 Subject: [PATCH] bug 7295: seems like one agent attache is removed twice status 7295: resolved fixed --- server/src/com/cloud/agent/manager/AgentManagerImpl.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/server/src/com/cloud/agent/manager/AgentManagerImpl.java b/server/src/com/cloud/agent/manager/AgentManagerImpl.java index 724179b91f6..b961078d5fd 100755 --- a/server/src/com/cloud/agent/manager/AgentManagerImpl.java +++ b/server/src/com/cloud/agent/manager/AgentManagerImpl.java @@ -759,11 +759,14 @@ public class AgentManagerImpl implements AgentManager, HandlerFactory { return; } long hostId = attache.getId(); + if (s_logger.isDebugEnabled()) { + s_logger.debug("remove Agent : " + hostId); + } AgentAttache removed = null; boolean conflict = false; synchronized (_agents) { - removed = _agents.remove(hostId); - if( removed != attache ){ + removed = _agents.remove(hostId); + if( removed != null && removed != attache ){ conflict = true; _agents.put(hostId, removed); removed = attache;