From d746cc9194b3145d1aef114783d391ccda49f9f3 Mon Sep 17 00:00:00 2001 From: Pearl Dsilva Date: Fri, 15 Dec 2023 13:50:40 -0500 Subject: [PATCH] address sonar comment --- plugins/network-elements/nsx/pom.xml | 16 +++++++++++++++- .../service/NsxProviderServiceImplTest.java | 4 ++-- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/plugins/network-elements/nsx/pom.xml b/plugins/network-elements/nsx/pom.xml index 6a89afc407a..8be72484c04 100644 --- a/plugins/network-elements/nsx/pom.xml +++ b/plugins/network-elements/nsx/pom.xml @@ -29,7 +29,21 @@ 4.19.0.0-SNAPSHOT ../../pom.xml - + + + + org.jacoco + jacoco-maven-plugin + ${cs.jacoco-plugin.version} + + + **/org/apache/cloudstack/agent/api/** + **/org/apache/cloudstack/api/response/** + + + + + com.vmware diff --git a/plugins/network-elements/nsx/src/test/java/org/apache/cloudstack/service/NsxProviderServiceImplTest.java b/plugins/network-elements/nsx/src/test/java/org/apache/cloudstack/service/NsxProviderServiceImplTest.java index 6dfe9955693..6a18592885d 100644 --- a/plugins/network-elements/nsx/src/test/java/org/apache/cloudstack/service/NsxProviderServiceImplTest.java +++ b/plugins/network-elements/nsx/src/test/java/org/apache/cloudstack/service/NsxProviderServiceImplTest.java @@ -163,12 +163,12 @@ public class NsxProviderServiceImplTest { @Test public void testNetworkStateValidation() throws NoSuchMethodException, InvocationTargetException, IllegalAccessException { NetworkVO networkVO = Mockito.mock(NetworkVO.class); - + List networkVOList = List.of(networkVO); when(networkVO.getBroadcastDomainType()).thenReturn(Networks.BroadcastDomainType.NSX); when(networkVO.getState()).thenReturn(Network.State.Allocated); NsxProviderServiceImpl nsxProviderService = new NsxProviderServiceImpl(); - assertThrows(CloudRuntimeException.class, () -> nsxProviderService.validateNetworkState(List.of(networkVO))); + assertThrows(CloudRuntimeException.class, () -> nsxProviderService.validateNetworkState(networkVOList)); } }