etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CLOUDSTACK-5900: Failed to delete template/ISO that failed to download.

This commit is contained in:
Sanjay Tripathi 2014-01-28 19:09:26 +05:30
parent 53feecaa76
commit d7ee7a7431
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
services/secondary-storage/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
View File

@ -1716,16 +1716,16 @@ public class NfsSecondaryStorageResource extends ServerResourceBase implements S
parent += File.separator;
}
String absoluteTemplatePath = parent + relativeTemplatePath;
File tmpltParent = new File(absoluteTemplatePath).getParentFile();
File tmpltDir = new File(absoluteTemplatePath);
String details = null;
if (!tmpltParent.exists()) {
details = "template parent directory " + tmpltParent.getName() + " doesn't exist";
if (!tmpltDir.exists()) {
details = "template parent directory " + tmpltDir.getName() + " doesn't exist";
s_logger.debug(details);
return new Answer(cmd, true, details);
}
File[] tmpltFiles = tmpltParent.listFiles();
File[] tmpltFiles = tmpltDir.listFiles();
if (tmpltFiles == null || tmpltFiles.length == 0) {
details = "No files under template parent directory " + tmpltParent.getName();
details = "No files under template parent directory " + tmpltDir.getName();
s_logger.debug(details);
} else {
boolean found = false;
@ -1751,12 +1751,12 @@ public class NfsSecondaryStorageResource extends ServerResourceBase implements S
}
if (!found) {
details = "Can not find template.properties under " + tmpltParent.getName();
details = "Can not find template.properties under " + tmpltDir.getName();
s_logger.debug(details);
}
}
if (!tmpltParent.delete()) {
details = "Unable to delete directory " + tmpltParent.getName() + " under Template path " + relativeTemplatePath;
if (!tmpltDir.delete()) {
details = "Unable to delete directory " + tmpltDir.getName() + " under Template path " + relativeTemplatePath;
s_logger.debug(details);
return new Answer(cmd, false, details);
}