From dc80b25361e22845fafaaf28489cef9250ef2b05 Mon Sep 17 00:00:00 2001 From: Rohit Yadav Date: Tue, 25 Nov 2014 19:24:29 +0530 Subject: [PATCH] CLOUDSTACK-7581: Empty 'ID' parameters allowed in API calls Fix is to fail API calls with empty 'id' parameter value upfront rather than going ahead and failing with NPE later on. Backported using fix 4e07dd1dc4b4618fff2ef25c846ce6b95a8e580d by Koushik Das Signed-off-by: Rohit Yadav --- server/src/com/cloud/api/ApiDispatcher.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/server/src/com/cloud/api/ApiDispatcher.java b/server/src/com/cloud/api/ApiDispatcher.java index 9624c61cb9e..6fe031af53a 100755 --- a/server/src/com/cloud/api/ApiDispatcher.java +++ b/server/src/com/cloud/api/ApiDispatcher.java @@ -482,8 +482,6 @@ public class ApiDispatcher { field.set(cmdObj, listParam); break; case UUID: - if (paramObj.toString().isEmpty()) - break; Long internalId = translateUuidToInternalId(paramObj.toString(), annotation); field.set(cmdObj, internalId); break;