From dc97372d6f97a41fccd4546072387c2daaa4227d Mon Sep 17 00:00:00 2001 From: Rohit Yadav Date: Sun, 18 Jan 2015 17:20:09 +0530 Subject: [PATCH] engine/storage: add NPE check, break if parent snapshot is null Signed-off-by: Rohit Yadav (cherry picked from commit c06ca09b54b053b37db9d4fc47226558bf15c6ba) Signed-off-by: Rohit Yadav --- .../apache/cloudstack/storage/helper/VMSnapshotHelperImpl.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/engine/storage/src/org/apache/cloudstack/storage/helper/VMSnapshotHelperImpl.java b/engine/storage/src/org/apache/cloudstack/storage/helper/VMSnapshotHelperImpl.java index 9693e914cd4..b1c78dce202 100644 --- a/engine/storage/src/org/apache/cloudstack/storage/helper/VMSnapshotHelperImpl.java +++ b/engine/storage/src/org/apache/cloudstack/storage/helper/VMSnapshotHelperImpl.java @@ -138,6 +138,9 @@ public class VMSnapshotHelperImpl implements VMSnapshotHelper { VMSnapshotVO current = snapshot; while (current.getParent() != null) { VMSnapshotVO parent = snapshotMap.get(current.getParent()); + if (parent == null) { + break; + } currentTO.setParent(convert2VMSnapshotTO(parent)); current = snapshotMap.get(current.getParent()); currentTO = currentTO.getParent();