diff --git a/tools/marvin/marvin/integration/lib/factory/NetworkOfferingFactory.py b/tools/marvin/marvin/integration/lib/factory/NetworkOfferingFactory.py index 36738287a74..8b00819e0e8 100644 --- a/tools/marvin/marvin/integration/lib/factory/NetworkOfferingFactory.py +++ b/tools/marvin/marvin/integration/lib/factory/NetworkOfferingFactory.py @@ -60,7 +60,7 @@ class DefaultSharedNetworkOfferingWithSGServiceFactory(NetworkOfferingFactory): displaytext = factory.Sequence(lambda n : "DefaultSharedNetworkOfferingWithSGService" + random_gen()) name = factory.Sequence(lambda n : "DefaultSharedNetworkOfferingWithSGService" + random_gen()) availability = "Optional" - supportedservices = "SecurityGroup, Dns, Dhcp, UserData" + supportedservices = "SecurityGroup,Dns,Dhcp,UserData" guestiptype = "Shared" traffictype = "GUEST" diff --git a/tools/marvin/marvin/integration/lib/factory/test/testFactories.py b/tools/marvin/marvin/integration/lib/factory/test/testFactories.py index 1d183051708..1637020a53c 100644 --- a/tools/marvin/marvin/integration/lib/factory/test/testFactories.py +++ b/tools/marvin/marvin/integration/lib/factory/test/testFactories.py @@ -19,13 +19,13 @@ import unittest from marvin.cloudstackTestClient import cloudstackTestClient from marvin.integration.lib.factory.AccountFactory import * -from marvin.integration.lib.base.Account import * +from marvin.integration.lib.base.Account import Account from marvin.integration.lib.factory.ServiceOfferingFactory import * -from marvin.integration.lib.base.ServiceOffering import * +from marvin.integration.lib.base.ServiceOffering import ServiceOffering from marvin.integration.lib.factory.NetworkOfferingFactory import * -from marvin.integration.lib.base.NetworkOffering import * +from marvin.integration.lib.base.NetworkOffering import NetworkOffering class AccountFactoryTest(unittest.TestCase): def setUp(self): @@ -86,4 +86,10 @@ class NetworkOfferingFactoryTest(unittest.TestCase): self.assertTrue(snatOffering is not None, msg = "no network offering was created") self.assertEqual(snatOffering.name, snatOfferingFactory.name, msg="error in network offering factory creation") - snatOffering.update(self.apiClient, state='Enabled') + def test_defaultSGOfferingEnable(self): + sgOfferingFactory = DefaultSharedNetworkOfferingWithSGServiceFactory() + sgOffering = NetworkOffering.create(apiclient=self.apiClient, NetworkOfferingFactory=sgOfferingFactory) + sgOffering.update(self.apiClient, state='Enabled') + + def tearDown(self): + pass \ No newline at end of file