etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CLOUDSTACK-7129: Non-admin user can use deleteNetwork with shared 

networks

fix ensures only admin users can delete shared network

(cherry picked from commit 2f293f42d5)
This commit is contained in:
Murali Reddy 2014-07-18 17:51:02 +05:30 committed by Daan Hoogland
parent b2efdf20c0
commit de85c4d555
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
server/src/com/cloud/network/NetworkServiceImpl.java
View File

@ -1837,6 +1837,11 @@ public class NetworkServiceImpl extends ManagerBase implements NetworkService {
Account owner = _accountMgr.getAccount(network.getAccountId());
// Only Admin can delete Shared networks
if (network.getGuestType() == GuestType.Shared && !_accountMgr.isAdmin(caller.getId())) {
throw new InvalidParameterValueException("Only Admins can delete network with guest type " + GuestType.Shared);
}
// Perform permission check
_accountMgr.checkAccess(caller, null, true, network);