diff --git a/api/src/com/cloud/agent/api/PlugNicCommand.java b/api/src/com/cloud/agent/api/PlugNicCommand.java index 51f6dfc9bf3..aa5141eab8e 100644 --- a/api/src/com/cloud/agent/api/PlugNicCommand.java +++ b/api/src/com/cloud/agent/api/PlugNicCommand.java @@ -17,16 +17,11 @@ package com.cloud.agent.api; import com.cloud.agent.api.to.NicTO; -import com.cloud.agent.api.to.VirtualMachineTO; public class PlugNicCommand extends Command { - VirtualMachineTO vm; - NicTO nic; - - public VirtualMachineTO getVirtualMachine() { - return vm; - } + NicTO nic; + String instanceName; public NicTO getNic() { return nic; @@ -40,9 +35,12 @@ public class PlugNicCommand extends Command { protected PlugNicCommand() { } - public PlugNicCommand(VirtualMachineTO vm, NicTO nic) { - this.vm = vm; + public PlugNicCommand(NicTO nic, String instanceName) { this.nic = nic; + this.instanceName = instanceName; } + public String getVmName() { + return instanceName; + } } diff --git a/api/src/com/cloud/agent/api/UnPlugNicCommand.java b/api/src/com/cloud/agent/api/UnPlugNicCommand.java index ef0bd031de0..0530527d5ba 100644 --- a/api/src/com/cloud/agent/api/UnPlugNicCommand.java +++ b/api/src/com/cloud/agent/api/UnPlugNicCommand.java @@ -17,15 +17,10 @@ package com.cloud.agent.api; import com.cloud.agent.api.to.NicTO; -import com.cloud.agent.api.to.VirtualMachineTO; public class UnPlugNicCommand extends Command{ - VirtualMachineTO vm; NicTO nic; - - public VirtualMachineTO getVirtualMachine() { - return vm; - } + String instanceName; public NicTO getNic() { return nic; @@ -39,8 +34,12 @@ public class UnPlugNicCommand extends Command{ protected UnPlugNicCommand() { } - public UnPlugNicCommand(VirtualMachineTO vm, NicTO nic) { - this.vm = vm; + public UnPlugNicCommand(NicTO nic, String instanceName) { this.nic = nic; + this.instanceName = instanceName; + } + + public String getInstanceName() { + return instanceName; } } diff --git a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java index cb9832ee1d1..f74be8f0c09 100755 --- a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java +++ b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java @@ -1064,7 +1064,7 @@ public class VmwareResource implements StoragePoolResource, ServerResource, Vmwa try { VmwareHypervisorHost hyperHost = getHyperHost(context); - String vmName = cmd.getVirtualMachine().getName(); + String vmName = cmd.getVmName(); VirtualMachineMO vmMo = hyperHost.findVmOnHyperHost(vmName); if(vmMo == null) { @@ -1138,7 +1138,7 @@ public class VmwareResource implements StoragePoolResource, ServerResource, Vmwa try { VmwareHypervisorHost hyperHost = getHyperHost(context); - String vmName = cmd.getVirtualMachine().getName(); + String vmName = cmd.getInstanceName(); VirtualMachineMO vmMo = hyperHost.findVmOnHyperHost(vmName); if(vmMo == null) { diff --git a/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java b/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java index 8f3ca0b6426..f6e9540e15b 100644 --- a/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java +++ b/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java @@ -7252,8 +7252,7 @@ public abstract class CitrixResourceBase implements ServerResource, HypervisorRe */ private UnPlugNicAnswer execute(UnPlugNicCommand cmd) { Connection conn = getConnection(); - VirtualMachineTO vmto = cmd.getVirtualMachine(); - String vmName = vmto.getName(); + String vmName = cmd.getInstanceName(); try { Set vms = VM.getByNameLabel(conn, vmName); if ( vms == null || vms.isEmpty() ) { @@ -7288,8 +7287,7 @@ public abstract class CitrixResourceBase implements ServerResource, HypervisorRe */ private PlugNicAnswer execute(PlugNicCommand cmd) { Connection conn = getConnection(); - VirtualMachineTO vmto = cmd.getVirtualMachine(); - String vmName = vmto.getName(); + String vmName = cmd.getVmName(); try { Set vms = VM.getByNameLabel(conn, vmName); if ( vms == null || vms.isEmpty() ) { diff --git a/server/src/com/cloud/network/NetworkManagerImpl.java b/server/src/com/cloud/network/NetworkManagerImpl.java index 64031402d1d..880466c0ac3 100755 --- a/server/src/com/cloud/network/NetworkManagerImpl.java +++ b/server/src/com/cloud/network/NetworkManagerImpl.java @@ -2537,17 +2537,8 @@ public class NetworkManagerImpl implements NetworkManager, NetworkService, Manag _nicDao.expunge(nic.getId()); } } - - private String getCidrAddress(String cidr) { - String[] cidrPair = cidr.split("\\/"); - return cidrPair[0]; - } - - private int getCidrSize(String cidr) { - String[] cidrPair = cidr.split("\\/"); - return Integer.parseInt(cidrPair[1]); - } - + + @Override public void checkVirtualNetworkCidrOverlap(Long zoneId, String cidr) { if (zoneId == null) { diff --git a/server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java b/server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java index 5da75343b9f..d070a0a61d2 100644 --- a/server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java +++ b/server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java @@ -325,7 +325,7 @@ public class VpcVirtualNetworkApplianceManagerImpl extends VirtualNetworkApplian DomainRouterVO router = _routerDao.findById(vm.getId()); if (router.getState() == State.Running) { try { - PlugNicCommand plugNicCmd = new PlugNicCommand(vm, nic); + PlugNicCommand plugNicCmd = new PlugNicCommand(nic, vm.getName()); Commands cmds = new Commands(OnError.Stop); cmds.addCommand("plugnic", plugNicCmd); @@ -360,7 +360,7 @@ public class VpcVirtualNetworkApplianceManagerImpl extends VirtualNetworkApplian if (router.getState() == State.Running) { try { - UnPlugNicCommand unplugNicCmd = new UnPlugNicCommand(vm, nic); + UnPlugNicCommand unplugNicCmd = new UnPlugNicCommand(nic, vm.getName()); Commands cmds = new Commands(OnError.Stop); cmds.addCommand("unplugnic", unplugNicCmd); _agentMgr.send(dest.getHost().getId(), cmds); @@ -783,7 +783,7 @@ public class VpcVirtualNetworkApplianceManagerImpl extends VirtualNetworkApplian } } - PlugNicCommand plugNicCmd = new PlugNicCommand(_itMgr.toVmTO(profile), getNicTO(router, publicNic.getNetworkId(), publicNic.getBroadcastUri().toString())); + PlugNicCommand plugNicCmd = new PlugNicCommand(getNicTO(router, publicNic.getNetworkId(), publicNic.getBroadcastUri().toString()), router.getInstanceName()); cmds.addCommand(plugNicCmd); } @@ -796,7 +796,7 @@ public class VpcVirtualNetworkApplianceManagerImpl extends VirtualNetworkApplian for (Pair nicNtwk : guestNics) { Nic guestNic = nicNtwk.first(); //plug guest nic - PlugNicCommand plugNicCmd = new PlugNicCommand(_itMgr.toVmTO(profile), getNicTO(router, guestNic.getNetworkId(), null)); + PlugNicCommand plugNicCmd = new PlugNicCommand(getNicTO(router, guestNic.getNetworkId(), null), router.getInstanceName()); cmds.addCommand(plugNicCmd); if (!_networkMgr.isPrivateGateway(guestNic)) {