CLOUDSTACK-4473: allow_egress referenced before assignment

When deploying with networkids allow_egress gets no default value. This
is a regression caused by fix for CLOUDSTACK-4418

Signed-off-by: Prasanna Santhanam <tsp@apache.org>
This commit is contained in:
Prasanna Santhanam 2013-08-23 16:41:38 +05:30
parent 5b319ba0cb
commit e39156e4d6
2 changed files with 6 additions and 7 deletions

View File

@ -152,9 +152,8 @@ class TestNic(cloudstackTestCase):
zone = get_zone(self.apiclient, self.services)
self.services['mode'] = zone.networktype
if self.services['mode'] != 'Advanced':
self.debug("Cannot run this test with a basic zone, please use advanced!")
return
if zone.networktype != 'Advanced':
self.skipTest("Cannot run this test with a basic zone, please use advanced!")
#if local storage is enabled, alter the offerings to use localstorage
#this step is needed for devcloud
@ -224,13 +223,11 @@ class TestNic(cloudstackTestCase):
self.cleanup.insert(0, self.test_network2)
except Exception as ex:
self.debug("Exception during NIC test SETUP!: " + str(ex))
self.assertEqual(True, False, "Exception during NIC test SETUP!: " + str(ex))
@attr(tags = ["devcloud", "advanced", "advancedns", "smoke", "basic", "sg"])
def test_01_nic(self):
if self.services['mode'] != 'Advanced':
self.debug("Cannot run this test with a basic zone, please use advanced!")
return
"""Test to add and update added nic to a virtual machine"""
try:
self.virtual_machine = VirtualMachine.create(
self.apiclient,

View File

@ -344,8 +344,10 @@ class VirtualMachine:
if networkids:
cmd.networkids = networkids
allow_egress = False
elif "networkids" in services:
cmd.networkids = services["networkids"]
allow_egress = False
else:
# When no networkids are passed, network
# is created using the "defaultOfferingWithSourceNAT"