From e6ec6137abae006ee3fc73e03adc157d00cfa369 Mon Sep 17 00:00:00 2001 From: Alena Prokharchyk Date: Mon, 29 Jul 2013 13:55:33 -0700 Subject: [PATCH] CLOUDSTACK-3914: assignToLoadBalancer - return false, when empty vmIds list is passed in --- .../com/cloud/network/lb/LoadBalancingRulesManagerImpl.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java b/server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java index 3f7b70ffffc..afbcfa0831b 100755 --- a/server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java +++ b/server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java @@ -967,6 +967,11 @@ public class LoadBalancingRulesManagerImpl extends ManagerBase implements } List vmsToAdd = new ArrayList(); + + if (instanceIds == null || instanceIds.isEmpty()) { + s_logger.warn("List of vms to assign to the lb, is empty"); + return false; + } for (Long instanceId : instanceIds) { if (mappedInstanceIds.contains(instanceId)) {