From e786533b27abe64da6b17de9a6907ac9218efdea Mon Sep 17 00:00:00 2001
From: Nitin <nitin@cloud.com>
Date: Mon, 12 Sep 2011 14:26:15 +0530
Subject: [PATCH] bug 11190: Treating the max account limits with -1 values as
 infinite. When acquiring a lock to check for resourceLimitExceeded if the
 lock times out then return as limit exceeded.

---
 server/src/com/cloud/user/AccountManagerImpl.java | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/server/src/com/cloud/user/AccountManagerImpl.java b/server/src/com/cloud/user/AccountManagerImpl.java
index 7d89d52a8e8..2415ab4218f 100755
--- a/server/src/com/cloud/user/AccountManagerImpl.java
+++ b/server/src/com/cloud/user/AccountManagerImpl.java
@@ -377,7 +377,7 @@ public class AccountManagerImpl implements AccountManager, AccountService, Manag
                 AccountVO accountVo = _accountDao.findById(account.getAccountId());
                 long accountLimit = findCorrectResourceLimit(accountVo, type);
                 long potentialCount = _resourceCountDao.getAccountCount(account.getId(), type) + numResources;
-                if (potentialCount > accountLimit) {
+                if (accountLimit != -1 && potentialCount > accountLimit) {
                     return true;
                 }
 
@@ -394,12 +394,13 @@ public class AccountManagerImpl implements AccountManager, AccountService, Manag
                     DomainVO domain = _domainDao.findById(domainId);
                     domainId = domain.getParent();
                 }
+                return false;
             } finally {
                 m_resourceCountLock.unlock();
             }
         }
 
-        return false;
+        return true;
     }
 
     @Override