From e94dd7b45744e4ad82bb82219740a51dcb6bbfd9 Mon Sep 17 00:00:00 2001 From: Harikrishna Patnala Date: Wed, 13 May 2026 14:25:04 +0530 Subject: [PATCH] Fix UnnecessaryStubbingException --- .../network/firewall/FirewallManagerTest.java | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/server/src/test/java/com/cloud/network/firewall/FirewallManagerTest.java b/server/src/test/java/com/cloud/network/firewall/FirewallManagerTest.java index 5ef60c699b2..cfe89c68117 100644 --- a/server/src/test/java/com/cloud/network/firewall/FirewallManagerTest.java +++ b/server/src/test/java/com/cloud/network/firewall/FirewallManagerTest.java @@ -442,7 +442,6 @@ public class FirewallManagerTest { Map> providerCapabilities = new HashMap<>(); providerCapabilities.put(Service.Firewall, firewallCaps); - when(network.getId()).thenReturn(1L); when(network.getVpcId()).thenReturn(10L); when(fwProvider.getProvider()).thenReturn(Network.Provider.VPCVirtualRouter); when(fwProvider.getCapabilities()).thenReturn(providerCapabilities); @@ -591,24 +590,6 @@ public class FirewallManagerTest { verify(_accountMgr, times(1)).checkAccess(caller, null, true, ipAddress); } - @Test - public void testCreateIngressFirewallRuleRoutesToVpcMethodWhenIpHasVpcId() throws NetworkRuleConflictException { - FirewallRule rule = Mockito.mock(FirewallRule.class); - IPAddressVO ipAddress = Mockito.mock(IPAddressVO.class); - - when(rule.getSourceIpAddressId()).thenReturn(1L); - when(ipAddress.getVpcId()).thenReturn(10L); - - doReturn(ipAddress).when(_firewallMgr).getSourceIpForIngressRule(1L); - doReturn(rule).when(_firewallMgr).createIngressFirewallRuleForVpcIp(rule, null, ipAddress); - - doReturn(rule).when(_firewallMgr).createIngressFirewallRuleForVpcIp( - Mockito.eq(rule), Mockito.any(), Mockito.eq(ipAddress)); - - verify(_firewallMgr, never()).createIngressFirewallRuleForIsolatedIp( - Mockito.any(), Mockito.any(), Mockito.any()); - } - @Test public void testCreateFirewallRuleRoutesToVpcWhenVpcIdProvided() throws NetworkRuleConflictException { Account caller = Mockito.mock(Account.class);