etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #965 from DaanHoogland/CLOUDSTACK-8981 

CLOUDSTACK-8981 coded a more obscure host and clear failure message test fails when port is reachable so prevent it as much as possible
 making sure that all kinds of weird developers can work with it

* pr/965:
  CLOUDSTACK-8981 coded a more obscure host and clear failure message  test fails when port is reachable so prevent it as much as possible  making sure that all kinds of weird developers can work with it

Signed-off-by: Remi Bergsma <github@remi.nl>
This commit is contained in:
Remi Bergsma 2015-10-23 20:19:03 +02:00
parent fb0871bdca d0a1820394
commit ecc2e2f39d
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
utils/src/test/java/com/cloud/utils/rest/BasicRestClientTest.java
View File

@ -22,6 +22,7 @@ package com.cloud.utils.rest;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.notNullValue;
import static org.hamcrest.Matchers.sameInstance;
import static org.junit.Assert.fail;
import static org.mockito.Matchers.any;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock;
@ -41,7 +42,7 @@ import org.junit.Test;
public class BasicRestClientTest {
private static final String LOCALHOST = "fakelocalhost";
private static final String LOCALHOST = "fakelocalhost.fakelocaldomain";
private static final String HTTPS = HttpConstants.HTTPS;
private static final StatusLine HTTP_200_REPSONSE = new BasicStatusLine(new ProtocolVersion(HTTPS, 1, 1), 200, "OK");
@ -100,7 +101,10 @@ public class BasicRestClientTest {
.client(HttpClientHelper.createHttpClient(5))
.build();
restClient.execute(request);
final CloseableHttpResponse response = restClient.execute(request);
fail("A CloudstackRESTException should have been thrown by now."+
"\nWe got " + response.getStatusLine() +
"\nMake sure you cannot reach '" + request.getURI() + "' by method " + request.getMethod());
}
}