From ed197ae971b81a8ef20448f28dbd3282a03182fd Mon Sep 17 00:00:00 2001
From: anthony <anthony@cloud.com>
Date: Mon, 7 Feb 2011 17:33:11 -0800
Subject: [PATCH] bug 8458: check if attachISO is successful before update DB

status 8458: resolved fixed
---
 .../com/cloud/template/TemplateManagerImpl.java  | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/server/src/com/cloud/template/TemplateManagerImpl.java b/server/src/com/cloud/template/TemplateManagerImpl.java
index df78c7adf86..54bedcb8d95 100755
--- a/server/src/com/cloud/template/TemplateManagerImpl.java
+++ b/server/src/com/cloud/template/TemplateManagerImpl.java
@@ -1185,14 +1185,14 @@ public class TemplateManagerImpl implements TemplateManager, Manager, TemplateSe
     	VMTemplateVO iso = _tmpltDao.findById(isoId);
 
         boolean success = _vmMgr.attachISOToVM(vmId, isoId, attach);
-        
-        if (attach) {
-            vm.setIsoId(iso.getId());
-        } else {
-            vm.setIsoId(null);
-        }
-        _userVmDao.update(vmId, vm);
-        
+        if ( success ) {
+            if (attach) {
+                vm.setIsoId(iso.getId());
+            } else {
+                vm.setIsoId(null);
+            }
+            _userVmDao.update(vmId, vm);
+        }       
         return success;
     }