CLOUDSTACK-7143: cleanup cleanup.sh code

tools/appliance/definitions/systemvmtemplate/cleanup.sh

@@ -1,16 +1,33 @@
-# Clean up
-#apt-get -y remove linux-headers-$(uname -r) build-essential
-apt-get -y remove dictionaries-common busybox
-apt-get -y autoremove
-apt-get autoclean
-apt-get clean
+#!/bin/bash
+
+set -e
+set -x
+
+function cleanup_apt() {
+  #apt-get -y remove linux-headers-$(uname -r) build-essential
+  apt-get -y remove dictionaries-common busybox
+  apt-get -y autoremove
+  apt-get autoclean
+  apt-get clean
+}
 
 # Removing leftover leases and persistent rules
-echo "cleaning up dhcp leases"
-rm /var/lib/dhcp/*
+function cleanup_dhcp() {
+  rm -f /var/lib/dhcp/*
+}
 
 # Make sure Udev doesn't block our network
-echo "cleaning up udev rules"
-rm /etc/udev/rules.d/70-persistent-net.rules
-rm -rf /dev/.udev/
-rm /lib/udev/rules.d/75-persistent-net-generator.rules
+function cleanup_dev() {
+  echo "cleaning up udev rules"
+  rm -f /etc/udev/rules.d/70-persistent-net.rules
+  rm -rf /dev/.udev/
+  rm -f /lib/udev/rules.d/75-persistent-net-generator.rules
+}
+
+function cleanup() {
+  cleanup_apt
+  cleanup_dhcp
+  cleanup_dev
+}
+
+return 2>/dev/null || cleanup