From f71986125ad2cf844f5004a02e2fcbd6f52dbb02 Mon Sep 17 00:00:00 2001
From: anthony <anthony@cloud.com>
Date: Tue, 29 Mar 2011 17:43:46 -0700
Subject: [PATCH] bug 9210: remove storage pool entry if adding storage pool
 fails

status 9210: resolved fixed
---
 server/src/com/cloud/storage/StorageManagerImpl.java | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/server/src/com/cloud/storage/StorageManagerImpl.java b/server/src/com/cloud/storage/StorageManagerImpl.java
index f01dcd7b9a4..16637627e89 100755
--- a/server/src/com/cloud/storage/StorageManagerImpl.java
+++ b/server/src/com/cloud/storage/StorageManagerImpl.java
@@ -1111,9 +1111,7 @@ public class StorageManagerImpl implements StorageManager, StorageService, Manag
         pool.setClusterId(clusterId);
         pool.setStatus(StoragePoolStatus.Up);
         pool = _storagePoolDao.persist(pool, details);
-        if (allHosts.isEmpty()) {
-            return pool;
-        }
+
         boolean success = false;
         for (HostVO h : allHosts) {
             success = createStoragePool(h.getId(), pool);
@@ -1123,6 +1121,7 @@ public class StorageManagerImpl implements StorageManager, StorageService, Manag
         }
         if ( !success ) {
             s_logger.warn("Can not create storage pool " + pool + " on cluster " + clusterId);
+            _storagePoolDao.expunge(pool.getId());
             return null;
         }
         s_logger.debug("In createPool Adding the pool to each of the hosts");
@@ -1136,7 +1135,7 @@ public class StorageManagerImpl implements StorageManager, StorageService, Manag
 
         if (poolHosts.isEmpty()) {
             _storagePoolDao.expunge(pool.getId());
-            pool = null;
+            return null;
         } else {
             createCapacityEntry(pool);
         }