From ff735b4d8190f89ae70de63cbef6049465dfd36a Mon Sep 17 00:00:00 2001
From: Min Chen <min.chen@citrix.com>
Date: Mon, 13 May 2013 11:07:06 -0700
Subject: [PATCH] Fix a bug in searching for eligible image store when we pass
 a ZoneScope with scopeId = null.

---
 .../storage/image/db/ImageStoreDaoImpl.java           | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/engine/storage/src/org/apache/cloudstack/storage/image/db/ImageStoreDaoImpl.java b/engine/storage/src/org/apache/cloudstack/storage/image/db/ImageStoreDaoImpl.java
index d7478293fa2..e6a0e06a8bb 100644
--- a/engine/storage/src/org/apache/cloudstack/storage/image/db/ImageStoreDaoImpl.java
+++ b/engine/storage/src/org/apache/cloudstack/storage/image/db/ImageStoreDaoImpl.java
@@ -81,10 +81,13 @@ public class ImageStoreDaoImpl extends GenericDaoBase<ImageStoreVO, Long> implem
     public List<ImageStoreVO> findByScope(ZoneScope scope) {
         SearchCriteria<ImageStoreVO> sc = createSearchCriteria();
         sc.addAnd("role", SearchCriteria.Op.EQ, DataStoreRole.Image);
-        SearchCriteria<ImageStoreVO> scc = createSearchCriteria();
-        scc.addOr("scope", SearchCriteria.Op.EQ, ScopeType.REGION);
-        scc.addOr("dcId", SearchCriteria.Op.EQ, scope.getScopeId());
-        sc.addAnd("scope", SearchCriteria.Op.SC, scc);
+        if (scope.getScopeId() != null) {
+            SearchCriteria<ImageStoreVO> scc = createSearchCriteria();
+            scc.addOr("scope", SearchCriteria.Op.EQ, ScopeType.REGION);
+            scc.addOr("dcId", SearchCriteria.Op.EQ, scope.getScopeId());
+            sc.addAnd("scope", SearchCriteria.Op.SC, scc);
+        }
+        // we should return all image stores if cross-zone scope is passed (scopeId = null)
         return listBy(sc);
     }