Rajani Karuturi
b31b8425df
CLOUDSTACK-8525: NPE while updating the state of the volume after deletion
...
The volume is already deleted (may be by the cleanup thread) and hence
the NPE. Added a not null check for the volumevo and returning false
from the state transition
This closes #321
2015-06-03 11:45:02 +05:30
Mike Tutkowski
ac2bccd2a2
Removing unused imports
2015-05-07 13:52:25 -06:00
Daan Hoogland
1c408dec37
Merge branch '4.5' after 4.5.1 vote passes
2015-05-07 16:03:26 +02:00
Rohit Yadav
4ba72a877c
Updating pom.xml version numbers for release 4.5.2-SNAPSHOT
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-07 15:33:01 +02:00
Rohit Yadav
0eb4eb2370
Updating pom.xml version numbers for release 4.5.1
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-04 12:17:03 +02:00
Likitha Shetty
6c649ce3ae
CLOUDSTACK-8411. Unable to delete an uploaded volume after CCP fails to attach the volume to a VM.
...
Correctly update the status of an uploaded volume upon failure to attach it to a VM.
(cherry picked from commit 10a106f5d8 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-29 16:50:40 +02:00
Rajani Karuturi
0b8355920e
Merge branch 'volume-upload' into master
...
This closes #206
2015-04-29 11:12:53 +05:30
Likitha Shetty
10a106f5d8
CLOUDSTACK-8411. Unable to delete an uploaded volume after CCP fails to attach the volume to a VM.
...
Correctly update the status of an uploaded volume upon failure to attach it to a VM.
2015-04-28 09:52:06 +05:30
Koushik Das
bc399b981f
volume-upload: If SSVM is destroyed and started, then partially uploaded volumes/templates remain in
...
inconsistent state (NotUploaded or UploadInProgress) and doesn't transition to any terminal
state (Uploaded, Uploaded). As a result these volumes/templates cannot be removed. Fix is to handle such
volume/template entries correctly.
2015-04-22 19:28:51 +05:30
Likitha Shetty
326bb3e0a4
CLOUDSTACK-8320. Upon a failed migration, a dummy volume is created which remains in 'Expunging' state.
...
Set destination volume path as NULL while duplicating volume during migration.
If migration fails, destination volume will be marked as removed. And if migration succeeds, volume path will be rightly updated.
(cherry picked from commit d30d5644bb )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-17 15:42:02 +02:00
Rohit Yadav
c198dfdb7a
Update pom and version usage to 4.5.1-SNAPSHOT
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-12 12:13:18 +05:30
Likitha Shetty
d30d5644bb
CLOUDSTACK-8320. Upon a failed migration, a dummy volume is created which remains in 'Expunging' state.
...
Set destination volume path as NULL while duplicating volume during migration.
If migration fails, destination volume will be marked as removed. And if migration succeeds, volume path will be rightly updated.
2015-03-12 11:57:02 +05:30
Rohit Yadav
8cfd374f04
CLOUDSTACK-8224: Don't try to unlock if template is not locked
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-06 17:43:12 +05:30
Likitha Shetty
7de7885a54
CLOUDSTACK-8125. VM fails to start on the first attempt after a cold migration.
...
Update volume chain_info to NULL during cold migration.
Otherwise during VM start, CCP will configure and try to power-on the VM with wrong disk information.
(cherry picked from commit 7b32b8a268 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-05 15:30:49 +05:30
Damodar
01cc1b816d
CLOUDSTACK-7792: Usage Events to be captured based on Volume State Machine
...
(cherry picked from commit 781648fb10 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
2015-02-05 15:22:21 +05:30
Mike Tutkowski
1b51bbbf74
Update hypervisor snapshot reserve for the root volume earlier than when it is currently being set
2015-01-29 13:01:51 -07:00
Rajani Karuturi
a710743871
volume upload: persisting into volume store ref only when SSVM is found
2015-01-29 16:55:24 +05:30
Rajani Karuturi
b343fb79e3
volume upload: fixed NPE if SSVM is not up
2015-01-29 16:55:16 +05:30
Mike Tutkowski
0f84e042b9
Adding support for creating a volume from a snapshot when the snapshot is on managed storage
2015-01-20 15:24:33 -07:00
Rohit Yadav
4e01d61f87
engine: remove redundant import
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-20 11:45:34 +05:30
Min Chen
ff70ef797c
CLOUDSTACK-8101: volume sync not working as expected - MS restart during upload volume leaves volume in hung state.
...
(cherry picked from commit e559b15b6a )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
2015-01-20 11:43:36 +05:30
Nitin Mehta
1aeaf4dcc9
CLOUDSTACK-7920: NPE in the payload was causing the ssvm agent to not connect, fix it and also make sure that template/volume sync are robust that exceptions do not cause ssvm agent disconnect issues.
...
(cherry picked from commit 5213401ace )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
2015-01-20 11:39:34 +05:30
Rajani Karuturi
ad6b7b30cb
Volume upload: sending the nfsstore url in the metadata
...
decoding the metadata and deserialising it on receiving it
2015-01-19 18:04:14 +05:30
Likitha Shetty
7b32b8a268
CLOUDSTACK-8125. VM fails to start on the first attempt after a cold migration.
...
Update volume chain_info to NULL during cold migration.
Otherwise during VM start, CCP will configure and try to power-on the VM with wrong disk information.
2014-12-24 14:33:51 +05:30
Min Chen
e559b15b6a
CLOUDSTACK-8101: volume sync not working as expected - MS restart during upload volume leaves volume in hung state.
2014-12-19 16:51:41 -08:00
Min Chen
c5d3a73c67
CLOUDSTACK-8101: volume sync not working as expected - MS restart during
...
upload volume leaves volume in hung state.
2014-12-19 16:43:02 -08:00
Min Chen
ea634550fc
CLOUDSTACK-8101: volume sync not working as expected - MS restart during upload volume leaves volume in hung state.
2014-12-19 15:51:52 -08:00
Rajani Karuturi
9bb6cf8452
volume upload: persisting the volume metadata
...
on calling GetUploadParamsForVolume, persisting the metadata to db
validating the account limits and incrementing the appropriate limits
encoded the metadata on management server using preshared key
2014-12-18 17:50:51 +05:30
Min Chen
b85183ede7
CLOUDSTACK-7678:volumes are getting uploaded successfully with wrong
...
url.
2014-11-21 15:18:47 -08:00
Min Chen
9ac93d3e43
CLOUDSTACK-7678:volumes are getting uploaded successfully with wrong url.
2014-11-21 14:36:36 -08:00
Nitin Mehta
5213401ace
CLOUDSTACK-7920: NPE in the payload was causing the ssvm agent to not connect, fix it and also make sure that template/volume sync are robust that exceptions do not cause ssvm agent disconnect issues.
2014-11-14 16:19:10 -08:00
Damodar
781648fb10
CLOUDSTACK-7792: Usage Events to be captured based on Volume State Machine
2014-11-10 15:19:02 +05:30
Devdeep Singh
cf27ecd91d
CLOUDSTACK-7721. Runtime exception while trying to release lock on template_spool_ref.
...
When a template a copied from a secondary to primary, we were trying to release a lock
twice, once in the create/copy base image function and in the create/copy base image
complete callback routine. This caused the exception as reported in the bug. Fixed by
updating the code make sure we release the lock in copy base image function only as
this is the place we took acquired the lock.
2014-11-10 13:22:39 +05:30
Edison Su
885bba926c
should not duplicate vm instance id, during the volume migration
...
Conflicts:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
2014-11-06 15:36:58 -08:00
Sanjay Tripathi
a53d39c1b6
CLOUDSTACK-7835: Deleted volumes with null UUID and no removed timestamp in database still appear.
...
Also removed CREATING -> DESTROY via DESTROYREQUESTED, which was causing the volume to get stuck in expunging
state.
2014-11-04 17:57:31 +05:30
Sanjay Tripathi
1d503bb853
CLOUDSTACK-7835: Deleted volumes with null UUID and no removed timestamp in database still appear.
...
Also removed CREATING -> DESTROY via DESTROYREQUESTED, which was causing the volume to get stuck in expunging
state.
2014-11-04 17:02:50 +05:30
Edison Su
6b5c874fe9
should not duplicate vm instance id, during the volume migration
2014-10-30 21:27:51 -07:00
Hugo Trippaers
4ebaf0a583
Bump master version to 4.6.0-SNAPSHOT after branching 4.5.0-SNAPSHOT
2014-10-29 14:54:23 +01:00
Mike Tutkowski
57dacf99a2
Changed "boolean connectVolumeToHost(VolumeInfo, Host, DataStore)" to "boolean grantAccess(DataObject, Host, DataStore)"
...
Changed "void disconnectVolumeFromHost(VolumeInfo, Host, DataStore)" to "void revokeAccess(DataObject, Host, DataStore)"
2014-10-21 16:01:14 -06:00
Min Chen
0db0e5e3cc
CLOUDSTACK-7700: Volume Snapshot Async Job returns Success for a failed
...
operation.
2014-10-13 15:03:59 -07:00
Min Chen
1e20600eca
CLOUDSTACK-7700: Volume Snapshot Async Job returns Success for a failed
...
operation.
2014-10-13 14:26:27 -07:00
Hugo Trippaers
dc3f0cbc63
Improve the handling of the findbug exclude files
2014-09-03 10:41:22 +02:00
Santhosh Edukulla
7bbe7fc697
Fixed Coverity Issues Reported
2014-07-25 16:41:17 +05:30
amoghvk
c804660c74
CLOUDSTACK-7168: Revert "Fixed Coverity Issues reported" that broke CI
...
This reverts commit 4523490d44 .
2014-07-23 11:37:36 -07:00
Santhosh Edukulla
4523490d44
Fixed Coverity Issues reported
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-07-22 18:03:36 +05:30
Mike Tutkowski
b080eaf327
Updates to the way resizing a volume works
2014-07-17 21:09:19 -06:00
Nitin Mehta
c0f72b25c6
CLOUDSTACK-6530: Make Network and Volume implement Displayable interface. Iterate over all first class entities in the context to decide the display property for event display.
2014-05-08 15:37:20 -07:00
Koushik Das
c9a09f548c
CLOUDSTACK-6579: used_bytes column of storage_pool table is no longer used and should be removed
...
For now correctly setting used_bytes. Also fixed the corresponding simulator code
2014-05-06 20:27:41 +05:30
Marcus Sorensen
11f5bdd78d
CLOUDSTACK-6191 Add support for specifying volume provisioning
...
type (thin, sparse, fat) in disk/compute offerings.
Submitted-by: Yoshikazu Nojima <mail@ynojima.net>
Reviewed-by: Marcus Sorensen, Mike Tutowski
2014-04-10 09:23:04 -06:00
Mike Tutkowski
1577e75a3d
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-03-31 00:13:30 -06:00
Edison Su
25a6234a5b
fix build
2014-03-28 16:24:45 -07:00
Daan Hoogland
8b62b2cb92
findbugs: exclude known spiffy hacks a.k.a. false positives
2014-03-28 14:28:10 +01:00
Chris Suich
27008216fe
Revert "Issue CS-5825 Part Resolution"
...
This reverts commit 9a615ee7b2 which was breaking the build.
2014-03-20 15:47:13 -04:00
Alex Hitchins
9a615ee7b2
Issue CS-5825 Part Resolution
2014-03-20 13:30:42 -04:00
Min Chen
ae1d6a771b
Remove IAMEntityType to use existing VO interface class to annotate
...
entityType.
2014-03-17 17:19:55 -07:00
Hugo Trippaers
4402685e11
Update master to 4.5.0-SNAPSHOT
2014-03-14 14:55:26 +01:00
Devdeep Singh
2aff39f8c7
CLOUDSTACK-6143: Storage motion support for hyper-v. With these changes a volume on a shared
...
storage pool (SMB) and attached to a running vm can be live migrated to another shared storage
pool. Also a vm and its volumes can be live migrated to another host and storage pool respectively.
2014-03-14 16:27:58 +05:30
Alena Prokharchyk
6c23e201ad
1) More fixes for the problems found by findBugs
...
2) Corrected some logging in MidoNetPublicNetworkGuru - removed .toString method call on the objects in the log body as toString is called on the object by default when use log4j
2014-03-13 16:05:45 -07:00
Mike Tutkowski
b06e66c50a
CLOUDSTACK-6170
2014-03-05 13:55:12 -07:00
Min Chen
d0ae4d9a9f
CLOUDSTACK-5920:Add interface to ControlledEntity to return IAM
...
entity type.
2014-03-05 09:40:55 -08:00
Nitin Mehta
339c4f4c3f
CLOUDSTACK-6199: Action Events - hide them when display flag is off in the context of "Ability to have better control over first class objects in CS" feature.
...
For root admin - s/he should be able to see all the events despite the value of the flag.
2014-03-04 14:59:30 -08:00
Sanjay Tripathi
624139d8ef
CLOUDSTACK-6172: Volume is not retaining same uuid when migrating from one storage to another.
2014-02-26 14:42:34 +05:30
Daan Hoogland
ca1b340cef
findbugs make use of return of string manipulation
2014-02-04 11:21:01 +01:00
Hugo Trippaers
d56c5dfc13
Fix for a potential NPE
2014-01-31 09:37:11 +01:00
Mike Tutkowski
3ef560d925
CLOUDSTACK-5873: [Automation] Failed to attach volume to VM, if the vm is created with option startvm=false
2014-01-16 12:15:18 -07:00
Mike Tutkowski
ae35782ccd
Merge from 4.3: CLOUDSTACK-5662: XenServer can't discover iSCSI targets with different credentials
2014-01-09 21:36:34 -07:00
Mike Tutkowski
03118c2969
Merge from 4.3: CLOUDSTACK-4810: Enable hypervisor snapshots for CloudStack-managed storage (for XenServer and VMware)
2014-01-09 14:44:35 -07:00
Edison Su
0824c78761
CLOUDSTACK-4939 - Failed to create snapshot (KVM, Multiple hosts, Sharedstorage)
...
Conflicts:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java
plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/driver/CloudStackPrimaryDataStoreDriverImpl.java
Conflicts:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java
plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/driver/CloudStackPrimaryDataStoreDriverImpl.java
2013-12-19 14:17:30 -08:00
Alex Huang
be5e5cc641
All Checkstyle problems corrected
2013-12-12 12:26:07 -08:00
Min Chen
df1c34bf2b
CLOUDSTACK-5451:Restart MS after migrating NFS image store to S3,
...
previous Ready template is not ready anymore.
2013-12-11 14:18:06 -08:00
Alena Prokharchyk
bd6f706b72
CLOUDSTACK-5261: added support for Alert publishing via ROOT Admin API
...
Conflicts:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/discoverer/HypervServerDiscoverer.java
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
server/src/com/cloud/alert/AlertManagerImpl.java
server/src/com/cloud/alert/ConsoleProxyAlertAdapter.java
server/src/com/cloud/alert/SecondaryStorageVmAlertAdapter.java
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
server/src/com/cloud/ha/HighAvailabilityManagerExtImpl.java
server/src/com/cloud/ha/HighAvailabilityManagerImpl.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java
server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
server/src/com/cloud/vm/UserVmManagerImpl.java
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
usage/src/com/cloud/usage/UsageManagerImpl.java
listAlerts: introduced new parameter "name" to the alertResponse
Conflicts:
api/src/org/apache/cloudstack/api/command/admin/resource/ListAlertsCmd.java
server/src/com/cloud/alert/AlertManagerImpl.java
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
Added new Admin API - generateAlert. Available to ROOT admin only
Conflicts:
api/src/org/apache/cloudstack/alert/AlertService.java
api/src/org/apache/cloudstack/api/BaseCmd.java
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
listAlerts: implemented search by alert name
Conflicts:
api/src/org/apache/cloudstack/alert/AlertService.java
api/src/org/apache/cloudstack/api/command/admin/resource/ListAlertsCmd.java
engine/schema/src/com/cloud/alert/AlertVO.java
2013-12-04 10:05:46 -08:00
Alex Huang
433a631916
Reformat of source code to set a stable base for the future. I couldn't get checkstyle enabled. There's still about a thousand errors from checkstyle. Most of it from length errors from comments and strings. Will attempt to remove those tonight. This change is so large I just want to get it in before any merge nightmares. The changes are fairly minor though and I did a full compile and start a server with the reformat code.
2013-11-21 07:56:47 -08:00
Hugo Trippaers
cf715ff491
Bump 4.3.0 to 4.4.0 in master
2013-11-21 16:01:15 +01:00
Alex Huang
d620df2bdd
Reformatted all of the code.
2013-11-21 06:15:26 -08:00
Wido den Hollander
1edaa36cc6
CLOUDSTACK-1302: Allow a cache mode per disk offering
...
Per disk offering the setting none, writeback or writethrough can be set
This allows for both safety and performance for writes.
2013-11-20 17:11:10 +01:00
Alex Huang
8d62744681
Reformat all source code. Added checkstyle to check the source code
2013-11-20 07:26:53 -08:00
Mike Tutkowski
10c513a259
CLOUDSTACK-4810: Enable hypervisor snapshots for CloudStack-managed storage (for XenServer and VMware)
2013-11-06 21:02:39 -07:00
Min Chen
eb9cfffd24
Fix NPE due to race condition during system vm launch.
2013-11-04 14:27:04 -08:00
Min Chen
9a62239a92
CLOUDSTACK-5017: Throw CloudRuntimeException in case of template/volume
...
download when ssvm is not ready so that caller can remove some leftover
entries in template_store_ref and volume_store_ref.
2013-11-04 12:32:05 -08:00
Min Chen
6eecb0b3b5
CLOUDSTACK-5017: If SSVM is unavailable DownloadCommands will be routed
...
to mgmt server.
2013-11-01 18:07:00 -07:00
Edison Su
7c99b88926
Don't use cast to PrimarydataStoreTO on the resource code
2013-11-01 15:13:16 -07:00
Min Chen
6be228a438
CLOUDSTACK-4024:Provide a way to upgrade from existing NFS secondary
...
storage to S3.
2013-10-28 21:01:31 -07:00
Edison Su
51a8086cf6
Merge branch 'pluggable_vm_snapshot'
...
Conflicts:
client/tomcatconf/applicationContext.xml.in
engine/storage/integration-test/test/org/apache/cloudstack/storage/test/SnapshotTest.java
engine/storage/integration-test/test/resources/storageContext.xml
server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
2013-10-25 16:47:17 -07:00
Edison Su
a6ce66e55a
move a lot of code into vmsnapshot strategy
...
fix compile
fix compile
add vm_snapshot_details table in db
add vmsnapshot test cases
2013-10-25 15:09:04 -07:00
Darren Shepherd
e3280bdba2
Merge remote-tracking branch 'origin/spring-modularization'
...
Conflicts:
client/tomcatconf/applicationContext.xml.in
client/tomcatconf/nonossComponentContext.xml.in
client/tomcatconf/simulatorComponentContext.xml.in
framework/db/src/com/cloud/utils/db/Transaction.java
plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockAgentManagerImpl.java
server/src/com/cloud/api/ApiServer.java
server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
2013-10-23 11:14:42 -07:00
Nitin Mehta
17dd9a832b
CLOUDSTACK-3737:
...
Delete the uploaded volume once its copied successfully to the primary storage.
Signed off by : nitin mehta<nitin.mehta@citrix.com>
2013-10-21 14:54:42 -07:00
Min Chen
ec3302afd6
CLOUDSTACK-3472: [Object_Store_Refactor] System VMs are not coming up in
...
initial attempt, but they are coming up after multiple attempts.
2013-10-17 15:59:10 -07:00
Darren Shepherd
67186429e1
Spring Modularization
...
ACS is now comprised of a hierarchy of spring application contexts.
Each plugin can contribute configuration files to add to an existing
module or create it's own module.
Additionally, for the mgmt server, ACS custom AOP is no longer used
and instead we use Spring AOP to manage interceptors.
2013-10-02 15:41:04 -07:00
Edison Su
9baa45308c
CLOUDSTACK-4650: change volume state during snapshot only
2013-09-25 16:33:10 -07:00
Edison Su
2227eb191a
CLOUDSTACK-3535: fix regression introduced in 5d9fa5d42e
2013-09-25 16:16:34 -07:00
Edison Su
a82b179878
add table lock on snapshot, during taking snapshot
...
Conflicts:
engine/storage/src/org/apache/cloudstack/storage/image/db/SnapshotDataStoreDaoImpl.java
2013-09-25 16:03:59 -07:00
Edison Su
b5f7e307a1
CLOUDSTACK-4456:
...
CLOUDSTACK-4457:
CLOUDSTACK-4459:
harden kvm getvolume. It's possible that one volume created on other kvm host, won't show up on another host, try more times to refresh storage pool if volume won't shown up
Conflicts:
engine/storage/integration-test/test/org/apache/cloudstack/storage/test/FakeDriverTestConfiguration.java
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
2013-09-25 16:01:45 -07:00
Min Chen
6fccd74ae8
CLOUDSTACK-4534:[object_store_refactor] Deleting uploaded volume is not
...
deleting the volume from backend.
2013-09-17 15:20:20 -07:00
Min Chen
a20097b967
CLOUDSTACK-4534:[object_store_refactor] Deleting uploaded volume is not
...
deleting the volume from backend.
2013-09-11 10:25:57 -07:00
Nitin Mehta
654c90f4e5
CLOUDSTACK-4327:
...
Check for the all the transition states for Maintenance. Also corrected the isMaintenance function for StoragePoolVo
Signed off by : nitin mehta<nitin.mehta@citrix.com>
2013-09-05 12:43:36 +05:30
Min Chen
b0fc3114f4
Fix build error.
2013-08-28 12:18:21 -07:00
Min Chen
6a9caf7487
CLOUDSTACK-4430:[Automation][vmware] Failed to deploy vm, if one host is
...
down in a cluster.
2013-08-28 11:52:06 -07:00
Edison Su
4fd09cb344
CLOUDSTACK-4324: delete snapshot_store_ref, if create snapshot failed on primary storage
2013-08-19 15:26:18 -07:00
Edison Su
0040c4adef
CLOUDSTACK-4363: fix possible NPE, if copy volume failed.
2013-08-19 15:25:20 -07:00
Min Chen
3937a7b5a5
CLOUDSTACK-4400:[object_store_refactor] Three entries for one template
...
in template_store_ref when MS was restarting during template download.
2013-08-19 15:01:57 -07:00
Edison Su
81fedcfa3e
CLOUDSTACK-4338: catch up exception in case of deleting volume in parallel: it's possible that two threads can delete one volume at the same time, if the volume state is in Expunging
2013-08-14 18:16:08 -07:00
Wido den Hollander
04f378bcff
CLOUDSTACK-4114: Use RAW disk images for RBD instead of QCOW2
2013-08-13 16:14:45 +02:00
Hugo Trippaers
d57796b94f
Fix XML validation errors
2013-08-13 08:25:45 +02:00
Nitin Mehta
ab5ea3febd
CLOUDSTACK-4133
...
Introduce a global lock on template and pool id so that concurrent threads wont be inserting the same row in DB and hit MySQLIntegrityConstraintViolationException
Signed off by : nitin mehta<nitin.mehta@citrix.com>
2013-08-09 14:03:43 +05:30
Min Chen
bf6961255a
CLOUDSTACK-4190:[Object_store_refactor] volume should be deleted from
...
staging storage after successfule volume migration .
2013-08-08 16:16:36 -07:00
Alex Huang
5495f10bce
Revert "Reverting the range of commits that broke the build"
...
This reverts commit b59e3aaefc .
2013-08-08 15:02:40 -07:00
Prasanna Santhanam
b59e3aaefc
Reverting the range of commits that broke the build
...
This reverts commits 30c33415..f6a2c817bc
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-08-08 14:46:56 +05:30
Edison Su
e851f4a930
CLOUDSTACK-4109: fix upload volume to s3 for vmware
2013-08-07 19:14:18 -07:00
Min Chen
98041dba46
CLOUDSTACK-4109:[Object_store_refactor] Extract volume failed with NPE.
2013-08-07 17:11:40 -07:00
Alex Huang
942f282a6e
Moved config into it's own package
2013-08-07 16:41:02 -07:00
Edison Su
a8ee45de7c
CLOUDSTACK-4074: if hypervisor doesn't return size of volume/template, don't update it into db
2013-08-06 15:53:57 -07:00
Min Chen
ec89e23665
CLOUDSTACK-4116: don't update db if hypervisor storage processor does
...
not return volume size.
2013-08-06 15:42:18 -07:00
Min Chen
a8990cffd4
CLOUDSTACK-4003: We should not delete a READY data object from object
...
store ref table in case of any operation failure related to this data
object.
2013-08-06 15:04:57 -07:00
Edison Su
239c6cef45
CLOUDSTACK-4008: fix snapshot npe if its volume is deleted
2013-08-01 13:59:41 -07:00
Chip Childers
8225374138
Updating pom.xml version numbers for release 4.3.0-SNAPSHOT
...
Signed-off-by: Chip Childers <chipchilders@apache.org>
2013-08-01 10:35:00 -04:00
Mice Xia
51e4f597e0
fix CLOUDSTACK-3591 add usage recording for VM snapshots
...
Conflicts:
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
setup/db/db/schema-410to420.sql
2013-08-01 10:47:36 +08:00
Min Chen
c2192808aa
CLOUDSTACK-3686: Registering a template does not generate a usage event.
2013-07-30 17:35:12 -07:00
Alex Huang
c2752ba93c
Removed mysql as any dependency
2013-07-26 20:35:48 -07:00
Alex Huang
3f7c558de5
Removed all the extra mockito, inject, and junit dependencies. Changed any test/resource to test/resources and rely on the master pom to tell us where the resources are instead of each individual project
2013-07-26 16:34:08 -07:00
Koushik Das
deb701b7e0
CLOUDSTACK-3493: [storage ref] Attach volume to VM is failing in case of Primary-Localstorage .
...
Some existing scenarios for root and data volume combination was not working. These are
a. Local root + Shared data
b. Shared root + Local data
Enabled these scenarios as part of this fix
2013-07-25 17:10:20 +05:30
Edison Su
be3883b678
fix create template from snapshot if it's swift
2013-07-24 09:48:07 -07:00
Min Chen
956e8301c2
CLOUDSTACK-3716: State of expunged volumes are not consistent in volumes
...
table and volume_store_ref.
Conflicts:
server/src/com/cloud/storage/VolumeManagerImpl.java
2013-07-23 15:06:34 -07:00
Min Chen
cc99a83d71
CLOUDSTACK-3716:NPE triggered in DownloadListener.
2013-07-22 17:26:33 -07:00
Min Chen
181fb03e7e
CLOUDSTACK-3716:NPE triggered in DownloadListener
2013-07-22 17:14:30 -07:00
Min Chen
f8b5a4159b
CLOUDSTACK-3419: [Object_Store_Refactor] Uploaded volume is being
...
deleted while attaching it to guest VM.
2013-07-20 12:16:55 -07:00
Vijayendra Bhamidipati
6bad34c509
CLOUDSTACK-3110: [VMWARE]NPE while adding primary storage(scope=cluster) with Invalid hostname
...
Description:
When retrieving primary datastore, handle case for non-existing datastores/hosts.
Throw exception and handle the exception in datastore mgmt layer and pass onward
to create storage pool API.
2013-07-03 09:43:00 -04:00
Prasanna Santhanam
de38cd815f
Fix typo in class name
...
AsyncRpcConext -> AsyncRpcContext
Signed-off-by: Prasanna Santhanam <tsp@apache.org>
2013-06-29 13:50:25 +05:30
Mike Tutkowski
99227f7b3e
SolidFire plug-in and related changes
...
SolidFire plug-in
SolidFire plug-in related
2013-06-28 16:59:21 -06:00
Min Chen
b09f69d917
CLOUDSTACK-3249: [Object_Store_Refactor] Unable to deployVm from
...
template when the management server was restarted in the middle of
Secondary to Primary storage template download.
2013-06-27 17:36:02 -07:00
Min Chen
de44a77878
Gracefully handle racing condition in updating state of dataobject and
...
data store mapping table.
2013-06-26 17:16:25 -07:00
Edison Su
9aec9c605c
merge to master
2013-06-19 18:16:47 -07:00
Edison Su
c2da4eac89
fix NPE for cache ref cnt
2013-06-14 17:24:31 -07:00
Edison Su
a715eb8121
clean up storage related code, and add lru replacement algorithm for cache storage
2013-06-14 15:55:59 -07:00
Min Chen
3bf15bd1ff
Code cleanup.
2013-06-10 18:03:15 -07:00
Min Chen
cc0de88088
Remove old DeleteTemplateCommand, DeleteVolumeCommand,
...
DeleteSnapshotBackupCommand, replaced by DeleteCommand.
2013-06-10 17:55:30 -07:00
Sanjay Tripathi
da5c4619c3
CLOUDSTACK-2286: Volume created from snapshot state is in allocated state instead of Ready state which is letting Primary storage not to increment the resources.
2013-06-07 17:17:54 +05:30
Min Chen
66e702222d
Simplify various DeleteTemplateCommnad, DeleteVolumeCommand and
...
DeleteSnapshotBackupCommand to use one DeleteCommand, also provide
BaseImageStoreDriverImpl class for plugin to inherit to avoid code
duplication.
2013-06-06 18:00:38 -07:00
Sateesh Chodapuneedi
7998413f48
CLOUDSTACK-2029 zone wide primary storage support for cloudstack over vmware deployments
...
Added hypervisor type to CreateStoragePoolCmd & Storage pool responses.
DatastoreLifeCycle would consider hypervisor type while attaching datastore to zone.
ZoneWideStoragePoolAllocator would filter zone wide primary storage pools by hypervisor type along with tags in disk profile.
hypervisor type is mandatory parameter if scope is specified as ZONE while creating primary storage pool.
As of now KVM, VMware are allowed to use ZoneWideStoragePoolAllocator.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-06-01 00:05:27 +05:30
Min Chen
eb93efdaa4
Add convenient delete methods in DataObject to delete dangling data
...
object.
2013-05-30 14:51:03 -07:00
Min Chen
614e08e19f
Fix ExtractVolume bug for S3 as secondary storage.
2013-05-30 14:19:59 -07:00
Min Chen
efbf9c8635
Move ExtractVolumeCmd from ManagementServerImpl to VolumeManagerImpl,
...
also add support for S3 for ExtractVolumeCmd.
2013-05-29 22:27:07 -07:00
Edison Su
0a5228922b
clean up storage related coded
2013-05-29 18:04:37 -07:00
Edison Su
0ed441c690
CLOUDSTACK-2637: fix upload volume
2013-05-24 19:00:52 -07:00
Edison Su
3ec52807f1
CLOUDSTACK-2593: fix migrate volume between pools through secondary storage
2013-05-23 18:26:16 -07:00
Edison Su
5af888c67a
add image format in volumevo
2013-05-22 13:38:11 -07:00
Min Chen
f23f341922
Handle CopyCmdAnswer in VolumeObject.processEvent for image and
...
imageCache, and fix a bug in selecting endpoint.
2013-05-21 22:15:36 -07:00
Min Chen
8f549db518
Clean up entries in template_store_ref, volume_store_ref and
...
snapshot_store_ref in case of operation failure.
2013-05-21 12:00:04 -07:00
Min Chen
5be7f7ddb1
VolumeObject.processEvent for ImageCache should only change state in
...
volume_store_ref, not volume table itself.
2013-05-20 21:25:59 -07:00
Rajesh Battala
107f492475
Fixed CLOUDSTACK-2081 Volume which is added thru upload volume is failed to attach to the instance saying Volume state must be in Allocated, Ready or in Uploaded state( Though uploaded Volume state is uploaded)
2013-05-17 14:58:25 +05:30
Edison Su
c476d7866e
CLOUDSTACK-2482: fix create volume from snapshot
2013-05-15 19:41:50 -07:00
Min Chen
b66c484905
Fix size issue in copying template from S3 to cache storage to make
...
system vm up.
2013-05-15 18:54:55 -07:00
Edison Su
a0c3d280b4
merge to master
2013-05-15 00:40:53 -07:00
Edison Su
68ffe1c706
fix bug in create volume from snapshot
2013-05-14 16:38:02 -07:00
Rajesh Battala
756a4179e2
Fixed CLOUDSTACK-2189 Volume is stuck in resizing state
...
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-05-13 14:41:00 +05:30
Min Chen
0b9e0c0f3a
Override getRootDir in LocalNfsSecondaryStorageResource to make mount
...
successfully on MS side. Now S3 is working.
2013-05-12 17:41:44 -07:00
Min Chen
1bd216fc48
Merge with latest code rebased from master
2013-05-11 21:05:54 -07:00
Min Chen
8a9a7a4adc
Fix a bug in create cache object for S3.
2013-05-10 17:53:32 -07:00
Alex Huang
342624e0eb
Merged with head
2013-05-10 16:33:57 -07:00
Alex Huang
3047929367
Merged
2013-05-10 16:21:43 -07:00
Edison Su
42e25a22fc
refactor kvm/vmware resource code
2013-05-09 23:10:05 -07:00
Sanjay Tripathi
3aed20c9d2
CLOUDSTACK-1603: Management server .log Java Exceptions are displayed with Alerts
2013-05-10 10:18:37 +05:30
Edison Su
0e28772957
fix race condition, when multiple vms on the same templates are started at the same time
2013-05-06 19:04:41 -07:00
Edison Su
9f7bad2cef
fix creating snapshot
2013-05-06 18:27:15 -07:00
Edison Su
2d544e7127
volume related operation works
2013-05-06 18:27:15 -07:00
Min Chen
a221ecb484
Workaround an issue of null url when ListTemplateCommand is received on
...
SSVM side, also fix a bug in listTemplates with id passed.
2013-05-04 23:09:23 -07:00
Edison Su
acafccfbc6
fix volume state change
2013-05-03 15:01:09 -07:00
Min Chen
df7a56d63f
Removed redundant getInstallPath to use getPath in VolumeInfo.
2013-05-03 10:01:23 -07:00
Edison Su
0c6e87c701
download template to primary storage works now
2013-05-03 09:45:31 -07:00
Min Chen
c60c373a38
Modify DownloadCommand to pass DataTO.
2013-05-02 23:05:19 -07:00
Edison Su
4d992fd18f
fix template download to primary storage
2013-05-01 17:51:24 -07:00
Min Chen
8a5bd9e8f8
Fix a sql bug in selecting end point to send message.
2013-05-01 16:04:40 -07:00
Edison Su
2f689171e0
refactor snapshot
2013-04-29 18:51:14 -07:00
Edison Su
37cbe8890f
refactor snapshot
2013-04-29 18:51:13 -07:00
Edison Su
4029e7af44
refactor data motion service for volumes
2013-04-24 18:53:57 -07:00
Edison Su
b8c5c67fbc
add copycommand at resouce side
2013-04-22 19:12:50 -07:00
Min Chen
9c584b5500
Use EndPoint to send local/remote command, and hide agentMgr message
...
passing.
2013-04-22 13:21:28 -07:00
Edison Su
abf40435f3
refactor downloadlistener, sync system vm templates when adding a new image store
2013-04-21 22:46:02 -07:00
Devdeep Singh
b01f63123f
CS-1879: NPE while migrating volume. The state transitions on the volume that has to be migrated were incorrect. A volume to be migrated is in ready state and cannot be transitioned to copying state. Similarly, the duplicated volume is in ready state too and cannot be transitioned to creating state. Fixed it by transitioning the volume to migrating state when a migrateVolume api call is made. Also, a volume has to be destroyed first before it can be expunged. Fixed that too.
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-04-19 16:15:24 +05:30
Devdeep Singh
21ce3befc8
Storage motion for Xenserver changes: 1. Implemented Api findStoragePoolsForMigration. Added a new response objects to list storage pools available for migration. 2. Updated migrateVolume api for allowing migrating volumes of running vms. These changes are integrated into the latest storage refactoring changes. 3. Added the implementation for findHostsForMigration api. It lists the hosts to which an instance can be migrated, including hosts from within and across clusters to which an instance may be migrated with storage motion. The work of migrating a volume of a running vm is also done in copyAsync. 4. Updated the listHosts api for backward compatibility. 5. Added the implementation for migrateVirtualMachineWithVolume api. It migrates an instance with its volumes within a cluster and also across clusters. Also introduced a new XenServerStorageMotionStrategy for migrating volumes of a vm. When a vm is being migrated with its volumes, the vm is put in migrating state and a request is send to the volume manager to migrate the vm and its volumes. Volume manager calls into the volume service which forwards the request to data motion service after moving all the volumes to migrating state. Data motion service enumerates the strategies and the request reaches the XenServerStorageMotionStrategy. It calls in to the resource to complete the operation. 6. Resolved an issue where storage xenmotion of 2nd VM created from the same template to a host was failing with duplicate_vm exception. Made changes to remove the mac_seed key value pair from other_config when vms are created. This is was storage motion to fail. 7. Updated the db upgrade schema script. 8. Added the right permissions in commands.properties 9. Marvin tests for testing storage motion. Following scenarios are tested. 9.1. A virtual machine is migrated to another host. Its volumes are also migrated to another storage pool. 9.2. Just the volumes of a vm are migrated to another storage pool while the vm continues to run on the same host. 10. Unit tests for testing migration of a vm with its volumes.
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-04-19 11:36:42 +05:30
Min Chen
14b5f0da19
Rename ImageDataFactoryxxx to TemplateDataFactory to have consistent
...
naming conventions for Template data factory class.
2013-04-17 11:45:25 -07:00
Min Chen
fe3b01ece1
Update DataObjectInStore interface and unify implementation of
...
ImageDataFactory, VolumeDataFactory and SnapshotDataFactory
implementations.
2013-04-17 11:40:57 -07:00
Min Chen
1b3994e180
Fix copyTemplateCmd.
2013-04-16 16:38:14 -07:00
Min Chen
593337565e
Add S3 code to handle DownloadCommand for registerTemplate.
2013-04-15 14:44:39 -07:00
Pascal Borreli
20614598bf
Fixed typos
...
Signed-off-by: Milamber <milamber@apache.org>
2013-04-13 13:28:32 +00:00
Min Chen
2dd8e2cb97
add getStoreTO into each DataStoreDriver, and add implementation for 3
...
data store plugins.
2013-04-12 18:22:23 -07:00
Min Chen
2ff01a79ca
Rename TemplateTO/VolumeTO in cloud-engine-storage to
...
TemplateObjectTO/VolumeObjectTO to avoid name conflicting with the one
in cloud-api.
2013-04-12 17:10:19 -07:00
Edison Su
b81fa6d9ea
add copy template to cache store
2013-04-12 16:03:30 -07:00
Min Chen
bb64672715
Refactor DownloadMonitorImpl code, move some functionalities to
...
TemplateServiceImpl and VolumeServiceImpl.
2013-04-11 18:09:42 -07:00
Edison Su
1c448cd6e3
add cache storage
2013-04-11 11:01:29 -07:00
Edison Su
e5bf38ed05
add cache storage
2013-04-11 10:52:53 -07:00
Min Chen
02686583cf
First draft of register template using image store.
2013-04-10 18:02:53 -07:00
Min Chen
2a177de2bc
Remove unused DataStoreProviderDao since provider does not has its own
...
db table.
2013-04-09 14:59:07 -07:00
Min Chen
86a3840412
Fix AddSecondaryStorageCmd to use CloudStack default secondary storage
...
store plugin.
2013-04-05 11:18:33 -07:00
Min Chen
5b31a45ebc
Some further naming refactoring.
2013-04-05 11:18:32 -07:00
Min Chen
a5416797ab
Move previous AncientImageDataStore provider and DefaultImageDataStore
...
provider code into plugins.
2013-04-05 11:18:32 -07:00
Edison Su
3ed6200ef8
move default primary storage plugin into its own pom
2013-03-20 17:21:40 -07:00
Edison Su
c60ef79321
CLOUDSTACK-1608: don't support attach volume between different storage scopes
2013-03-19 14:36:37 -07:00
Deepti Dohare
27b753a434
CLOUDSTACK-1575 Failed to transit volume with uploadVolume
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-03-13 10:40:08 +05:30
Edison Su
409ec9c6b6
CLOUDSTACK-1426: We has strong implication that VO must implement an interface, otherwise EntityManagerImpl can't the vo
2013-03-07 18:25:57 -08:00
Kelven Yang
cc91d826df
Fix conflicts in storage subsystem with Spring
2013-03-05 19:03:31 -05:00