Commit Graph

36479 Commits

Author SHA1 Message Date
Abhishek Kumar 7f760cc395
test: add nic validation in import vm test (#6964)
Add smoke test to prevent any regression such as #6951.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-12-09 18:10:46 +05:30
Wei Zhou 11d27a5a3a
systemvm: vpc router fix /etc/network/interfaces is misconfigured (#6435)
This PR fixes that the /etc/network/interfaces is misconfigured in VPC VR startup, which causes VPC VR to be stuck for 1 minute and continue working.

The issue is because ifup eth0 and ifdown eth0 do not work when /etc/network/interfaces is not correct in VPC VR.
2022-12-09 18:10:20 +05:30
Abhishek Kumar b7f845ab13
server: fix nic device id fro imported vm (#6953)
Fixes #6951

Adds deviceid for NICs of an imported VM. Device Id will be set 0..n in the order which they are returned by hypervisor.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-12-08 22:29:32 +05:30
mprokopchuk ffe2fa51d5
When VM is created and ROOT volume is created it should emit a VOLUME.CREATE event (#6939)
* When VM is created and ROOT volume is created it should emit a VOLUME.CREATE event

Co-authored-by: Maxim Prokopchuk <mprokopchuk@apple.com>
2022-12-08 09:14:17 -07:00
Wei Zhou 74623aa3d3 Merge remote-tracking branch 'apache/4.17' 2022-12-07 13:37:30 +01:00
Abhishek Kumar a4d3780143
ui: fix incorrect hypervisor in deploy VM wizard (#6952)
Fixes #6756

Pass hypervisor parameter for deployVirtualMachine API only when ISO is selected and not for a template.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-12-07 17:40:50 +05:30
Abhishek Kumar 9fd2d82af9
vmware: fix vmware vm snapshot operations for datastorecluster (#6912)
Fixes #6894

Fixes NPE observed when VM volume is present on the same child datastore.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-12-07 14:43:44 +05:30
Rahul Agarwal 90413cb307
client: Improve cloudstack-setup-management message (#6822)
Improve the cloudstack-setup-management output message

Co-authored-by: Rahul Agarwal <rahul.agarwal@shapeblue.com>
Co-authored-by: Rohit Yadav <rohityadav89@gmail.com>
Co-authored-by: Stephan Krug <stekrug@icloud.com>
2022-12-07 13:17:40 +05:30
GaOrtiga 684f3f4c49
Improvements and cleanup on the javadocs of QemuImg (#6917)
* Cleanup in the javadocs of QemuImg

* Update QemuImg.java

* Apply suggestions from code review

Co-authored-by: Stephan Krug <stekrug@icloud.com>

Co-authored-by: cloudstack-lab-gabriel <gabriel.fernandes@scclouds.com.br>
Co-authored-by: Stephan Krug <stekrug@icloud.com>
2022-12-06 17:59:03 -03:00
João Jandre 7c61d8aeaf
Set root volume as destroyed when destroying a VM (#6868)
* Set root volume as destroyed when destroying a VM

* Address review

* Address review

Co-authored-by: João Jandre <joao@scclouds.com.br>
2022-12-06 17:48:35 -03:00
Wei Zhou d182eacf86
host affinity: fix vm cannot be started if a vm is stopped in the affinity group (#6936) 2022-12-06 10:05:49 +01:00
Wei Zhou a63b2aba7a
VM Autoscaling with virtual router (#6571) 2022-12-05 15:23:03 +01:00
Rohit Yadav 3d8ea4f3b3 Merge remote-tracking branch 'origin/4.17'
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-11-30 21:02:17 +05:30
Daniel Augusto Veronezi Salvador cf32f77e3d
systemvm: Fix C2S VPN in parallel to S2S VPN (#6907)
PR #5375, introduced in version 4.15.2.0, removed parameter %any of VPNs client-to-site (C2S) IPSec secrets:

structure before PR vr: ipsec/l2tp vpn secret with no ID selectors #5375:
<IP> %any : PSK "<PSK>"
structure after PR vr: ipsec/l2tp vpn secret with no ID selectors #5375:
<IP> : PSK "<PSK>"
Because of that, when a VPN site-so-site (S2S) is created in parallel to a VPN C2S in the same network, the C2S will not handle any IP (%any) anymore and, as the network is being tunneled to the other VPN, the connection will be handled by the final peer. This way, when a VPN S2S is created in parallel to a VPN C2S in the same network, it is only possible to connect to the C2S with the S2S PSK.

As ACS is only able to implement a single C2S per network (ACS allows setting more than one IP of the network as VPN, however, only the first will be implemented) and every S2S has its own secret file, the secrets structure of C2S was changed to contain only the PSK:

: PSK "<PSK>"
By doing that, StrongSwan will handle correctly C2S connections from any IP and still will use the correct PSK for S2S.

Co-authored-by: GutoVeronezi <daniel@scclouds.com.br>
2022-11-30 18:29:05 +05:30
vivekcek 4abb8b9ebf
python command not working in ubuntu 20.04 for apidocs and marvin (#6889)
Co-authored-by: Vivek Ps <vivekcek@gail.com>
2022-11-30 09:12:03 +01:00
yannizhou05 94fd03df13
fix flaky tests (#6905)
Co-authored-by: Yanni <yz97@illinois.edu>
2022-11-30 08:53:11 +01:00
Abhishek Kumar 47946db888
server: fix volume migration on user vm scale (#6704)
Fixes #6701

When volume migration is initiated by system, account check is not needed.

Introduces a new global setting - allow.diskoffering.change.during.scale.vm. This determines whether to allow or disallow disk offering change for root volume during scaling of a stopped or running VM.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Co-authored-by: Harikrishna Patnala <harikrishna.patnala@gmail.com>
Co-authored-by: Rohit Yadav <rohityadav89@gmail.com>
Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-11-30 12:58:48 +05:30
Craig Squire dbc2032077
server: Check for null poolid (#6879)
Extract retrieveDatastore method

Add unit test for null poolId

Fixes #6878

Co-authored-by: Craig Squire <craig.squire@ticketmaster.com>
Co-authored-by: Stephan Krug <stekrug@icloud.com>
2022-11-30 12:45:35 +05:30
Stephan Krug adec811052
Fix time format (#6893)
Co-authored-by: Stephan Krug <stephan.krug@scclouds.com.br>
2022-11-28 16:14:22 +01:00
Codegass ea8fdc20cf
Bring in the JUnit Assume Feature to CABackgroundTaskTest (#6883) 2022-11-28 16:13:40 +01:00
Codegass 7aeb5b0810
Simplify Test Case ApplicationLoadBalancerTest.searchForNonExistingLoadBalancer (#6882) 2022-11-28 16:06:50 +01:00
Abhishek Kumar 6c436ec90e
server: fix domain shared public template check (#6916)
Fixes #6885

Fixes the incorrect inverted check.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-11-25 14:19:16 +05:30
Rohit Yadav a880109d50
Update README.md 2022-11-24 21:25:38 +05:30
Abhishek Kumar c8d27765d8
orchestration: fix diskoffering for vr rootdisk (#6853)
Fixes incorrect call of using service offering's ID while trying to retrieve linked disk offering.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-11-24 15:08:20 +05:30
Abhishek Kumar fca5715db1
ui: fix guest traffic vlan input (#6895)
Fixes VLAN input while adding guest traffic type for the physical network in the zone wizard.
When adding a zone physical network is not updated with the guest traffic vlan, resulting in network, vm deployments failures.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-11-23 19:03:52 +05:30
mprokopchuk c5e657ddd8
VOLUME.DETACH, created during VM removal has type VirtualMachine instead of Volume and has "Vm Id: XXX" in the description. (#199) (#6891)
Co-authored-by: Maxim Prokopchuk <mprokopchuk@apple.com>
(cherry picked from commit 1fcd32fa33
2022-11-13 11:46:08 +01:00
John Bampton 60420b0dd8
gha(python): fix `W391` blank line at end of file (#6897)
flake8 --select=W291,W292,W293,W391 .

./test/integration/smoke/test_register_userdata.py:766:1: W391 blank line at end of file

./test/integration/component/test_network_vpc_custom_dns.py:732:1: W391 blank line at end of file
2022-11-13 11:44:07 +01:00
John Bampton 8e538028b2
Enable Flake8 rule W391 (#6606)
Best practice is to have one blank line at the end of Python files.

Remove unneeded blank lines from the end of files
2022-11-13 11:00:07 +01:00
John Bampton e65c22d883
Fix spelling (#6860) 2022-11-13 10:56:15 +01:00
Daniel Augusto Veronezi Salvador b8b66b7a3d
Fix typos and improve javadocs on ByteScaleUtils (#6877)
Co-authored-by: GutoVeronezi <daniel@scclouds.com.br>
2022-11-10 10:14:24 +01:00
Eduardo Zanetta 982450ed81
Remove password change notice on SSH Key Pair reset (#6862)
Co-authored-by: Eduardo Zanetta <eduardo.zanetta@scclouds.com.br>
2022-11-10 09:17:35 +01:00
José Flauzino 1843632c24
Fix memory stats for KVM (#6358)
Co-authored-by: joseflauzino <jose@scclouds.com.br>
2022-11-09 18:00:12 +01:00
yannizhou05 5b09340420
Fix flaky tests in SMTPMailSenderTest.java and ReflectionToStringBuilderUtilsTest.java (#6875) 2022-11-09 14:04:31 +01:00
fermosan 4c5a2ba3a6
Updated Hellenic (Greek) Translation Draft (for 4.18) (#6843) 2022-11-08 15:23:55 +01:00
Codegass 1ee58ec347
Introducing Hamcrest API to simplify assertion in ImplicitPlannerTest (#6676)
Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
2022-11-04 21:41:54 +01:00
Wei Zhou 296035d9a5
XenServer/XCP-ng: fix vm memory usage is always 99.9x% (#6852)
According to https://docs.citrix.com/en-us/citrix-hypervisor/monitor-performance.html
The metrics "memory_internal_free" is already in KiB, no need to convert.

"Memory used as reported by the guest agent (KiB). Enabled by default"
2022-11-02 09:36:16 +01:00
John Bampton fa39e61a4c
Fix spelling (#6609) 2022-11-01 08:30:01 +01:00
dahn 0c93a85b3a
add ip rule for VPC extra IPs (#6846) 2022-10-31 15:13:19 +01:00
Harikrishna d7dedfff1f
Changed userdata names on Add instance page (#6854)
* Changed userdata names on Add instance page
2022-10-30 19:54:06 +01:00
Bryan Lima 23033fbb74
Add live migration of system VMs (KVM) (#6491)
Co-authored-by: Rodrigo D. Lopez <19981369+RodrigoDLopez@users.noreply.github.com>
2022-10-28 13:14:09 +02:00
Bryan Lima f580a8d7a2
Quota enable config to user/domain scope (#6690)
* Add quota plugin to accout/domain scope

* Add check in quota usage calculation to skip accounts with quota disabled

* Set quota config enabled default to true

* Fix if condition

* Update condition to use primitive boolean expression

Co-authored-by: dahn <daan.hoogland@gmail.com>

* Remove unused var

* Add quota state as a column in the Quota Summary view

* Remove trailling spaces

* Address review

Co-authored-by: dahn <daan.hoogland@gmail.com>
2022-10-27 08:48:54 -03:00
Rodrigo D. Lopez adfaa730b1
Externalizes logrotate service frequency timer in VR (#6507)
Co-authored-by: Lopez <rodrigo@scclouds.com.br>
2022-10-26 09:04:12 +02:00
João Jandre 14937e1adb
Fixed NPE on volume creation from snapshot (#6839)
Co-authored-by: João Jandre <joao@scclouds.com.br>
2022-10-26 08:44:01 +02:00
dahn 13d22c2f54
Set network state to implemented when no services (#6838)
Co-authored-by: Nicolas Vazquez <nicovazquez90@gmail.com>
Co-authored-by: Wei Zhou <weizhou@apache.org>
2022-10-24 08:59:17 +02:00
Stephan Krug c37709c44b
Removing extra details in error message (#6835)
Co-authored-by: Stephan Krug <stephan.krug@scclouds.com.br>
2022-10-23 11:54:08 +02:00
dahn 4a06363749
Ova download fix (#6758) 2022-10-21 14:31:19 +02:00
Wei Zhou 48ffa5dc0b
Support multiple ceph monitors (#6792) 2022-10-21 10:37:30 +02:00
Bryan Lima 17fe98432d
Remove unnecessary escape method (#6692) 2022-10-20 14:37:05 +02:00
Daan Hoogland ce84336ef6 Merge release branch 4.17 to main
* 4.17:
  UI: Fix Volume Snapshot from user VM as admin (#6824)
2022-10-20 11:14:43 +02:00
Daniel Augusto Veronezi Salvador 2ca164ac96
Quota custom tariffs (#5909)
Co-authored-by: GutoVeronezi <daniel@scclouds.com.br>
Co-authored-by: dahn <daan.hoogland@gmail.com>
2022-10-17 10:03:50 +02:00