Commit Graph

34727 Commits

Author SHA1 Message Date
Wei Zhou 8952cd5955
kvm: add hosts using cloudstack ssh private key (ccc21 hackathon) (#5684)
This PR provides the option to add kvm hosts with empty or wrong password.
To support this, the cloudstack ssh public key needs to be added in the ~/.ssh/authorized_keys on host.

Feature work:

1. get cloudstack public key from management server (/var/lib/cloudstack/management/.ssh/id_rsa.pub)

![image](https://user-images.githubusercontent.com/57355700/141449653-85f644b5-c32e-44ca-9c6b-77570262c046.png)


2. add the key to ~/.ssh/authorized_keys on kvm hosts

![image](https://user-images.githubusercontent.com/57355700/141449722-e906eea5-74fd-4f81-a4d3-41563beeb79c.png)

3. add kvm host with empty password

<img src="https://user-images.githubusercontent.com/57355700/141449865-6ffee1f0-b0d7-4ea4-b11a-32df42e2fe91.png" height="50%" width="50%">

Tested as:
1. add host, with correct password,  works as expected.
2. put host to maitenance, stop cloudstack-agent, cancel maintenance, remove the host. all work.
3. add host, with empty password (ssh public key is added to  ~/.ssh/authorized_keys),   works as expected.
4. put host to maitenance, stop cloudstack-agent, cancel maintenance. all work as expected.
2021-12-30 16:20:04 +05:30
Wei Zhou 9798fa08b5
kvm: support qemu-system-x86>=5.2 (#5755) 2021-12-30 16:16:08 +05:30
Nicolas Vazquez c0ddda361a
[VMware] Fix service offerings listing on appliances deployment options (#5752)
* Fix list service offerings for VMware deployment options

* UI fix to allow selecting offerings
2021-12-30 16:13:41 +05:30
Marcus Sorensen dcdcd09058
Randomize managed volume copy host (#5789)
* Randomize managed volume copy host

* Managed volume copy was always returning first host that could see storage pools

* Fix null value in logging for ScaleIOPrimaryDataStoreDriver due to if/else logic error

Signed-off-by: Marcus Sorensen <mls@apple.com>

* Use String.format for ScaleIO debug message

Signed-off-by: Marcus Sorensen <mls@apple.com>

* Update debug message for ScaleIO copy methods

Signed-off-by: Marcus Sorensen <mls@apple.com>

Co-authored-by: Marcus Sorensen <mls@apple.com>
2021-12-30 16:11:00 +05:30
Gabriel Beims Bräscher 62089767f6
Fix UI issue 5777 Root disk size is not shown as 'Disk Size' on VM deployment. (#5796)
In the UI, when selecting a service offering that has a root disk enforced, stills show the root disk size of the template (or the custom size gave by the user). This PR fixes this issue, that thas been reported in #5777.
Fixes: #5777
2021-12-30 15:21:11 +05:30
Abhishek Kumar d13057ace5
ui: show tags only for supported resources (#5798)
* ui: prevent incorrect tags displa for primary storage

Tags in info card of the UI are related to tags functionality(create/delete/lsitTags API)
UI was incorrectly showing storage tags as these tags in the UI.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* remove logging

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* ui: show tags only for supported resources

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2021-12-30 15:20:37 +05:30
Rohit Yadav 6728b696cd
kvm: don't always force scsi controller for aarch64 VMs (#5802)
* kvm: don't force scsi controller for aarch64 VMs

This would allow use of virtio disk controller with Ceph, etc or as
defined in the VM's root disk controller setting, rather than always
enforce SCSI.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* remove test that doesn't apply now

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* address review comment

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2021-12-30 15:19:32 +05:30
Pearl Dsilva 9a5a0738b0
ui: Fix configure Sticky policy form (#5814) 2021-12-30 10:31:24 +01:00
Hoang Nguyen ae62e1dd5e
fixes cannot add new port forwarding rules after auto select VM next time (#5690) 2021-12-30 09:53:51 +01:00
Wei Zhou 7823868746
network: update ip in lb/pf/dnat tables when update vm nic ip (#5757)
* network: update ip in lb/pf/dnat tables when update vm nic ip

* Update: create 3 separated methods for DNAT/LB/PF update

* Update: invert if condition to reduce code indentation
2021-12-28 01:35:29 +05:30
Gabriel Beims Bräscher 19325d0286
Change UI VM deployment to show SSH keys only if user has keys (#5804) 2021-12-28 01:23:36 +05:30
Rakesh 8ba5b92a83
server: Fix NPE while deleting a domain (#5753)
* server: Fix NPE while deleting a domain

While deleting a domain, if vlan ip range cant be found
then this will throw NPE. Just return false if vlan ip
range cant be found

* return true if vlan is not found

* change output message

Co-authored-by: Rakesh Venkatesh <rakeshv@apache.org>
2021-12-28 01:21:43 +05:30
Rakesh 9607ae9639
server: Fix NPE while adding network to VPC (#5723)
* server: Fix NPE while adding network to VPC

Sometimes adding network to VPC fails because of libirt error.
In that case the new network wont have any VR's associated with it
and hence it will return null.

* use collectionutils

Co-authored-by: Rakesh Venkatesh <rakeshv@apache.org>
2021-12-25 19:57:18 +05:30
Hoang Nguyen 12d95a2027
Remove unused gravatar fetch (#5806) 2021-12-24 17:07:14 +05:30
sureshanaparti 9b0a1418ec
Provision to sort ISOs from UI, and Updated Templates/ISOs API response to return in the order of sortkey (#5800) 2021-12-24 12:44:50 +05:30
dahn f03ed8c721
cleanup of unused code and cleanup of cleanup procedure (#5562)
* cleanup of unused code and cleanup of cleanup procedure

* remove unnecessary egress rule

* remove rule and add rule removal

Co-authored-by: Daan Hoogland <dahn@onecht.net>
2021-12-23 10:10:38 +05:30
sureshanaparti 39e41f6b6e
Allow force reboot VM from user account, to start VM on the same host (#5791) 2021-12-22 17:43:02 +01:00
Pearl Dsilva 936ebbb90f
api: Fix search cluster by name (#5782) 2021-12-22 10:41:06 +05:30
Gabriel Beims Bräscher 995ce06cb7
Enhance log message in FirstFitPlanner (#5762)
* Enhance log message in FirstFitPlanner

When cluster reached capacity threshold the message is:
"capacity threshold defined at each cluster/ at global value for capacity Type : 0"

Admins hardly remember the Capacity Type and it can take a while to look at which is the resource for the respective ID. This enhancement addes log message pointing to the capacity name (e.g. Memory / CPU) as well as global settings parameter name and value to be looked at.

* Change formatation in String 'warnMessageForClusterReachedCapacityThreshold'
2021-12-22 10:10:40 +05:30
Hoang Nguyen 29c7518613
UI: Fixes error when delete domain (#5710)
* fixes error when delete domain with polljob response not have jobstatus

* fix listdomain not refresh after deleted
2021-12-20 12:35:32 +05:30
Daniel Augusto Veronezi Salvador 79d924f3ee
Insert correct template size when live migrating VM with volumes (#5758)
Co-authored-by: GutoVeronezi <daniel@scclouds.com.br>
2021-12-16 20:21:38 +05:30
Wei Zhou cc856277de
UI: fix create Isolated/L2 network form (#5779) 2021-12-16 11:24:11 +05:30
Gabriel Beims Bräscher 8ace2722e7
Set length for parameters that expect a list of domain ids. (#5763)
Currently, when updating a service offering there is a limitation of the number of domains the offering can be updated.

Multiple domain ids lead to the following API error:
Error: (HTTP 431, error code 9999) Unable to execute API command updateserviceoffering due to invalid value. Value greater than max allowed length 255 for param: domainIds"
2021-12-15 13:38:15 +05:30
Wei Zhou d49f67ceb9
travis: install python3-setuptools (#5767) 2021-12-13 16:22:21 +01:00
dahn 8bc69e919c
conditional broadcastUri (#5745)
* conditional broadcastUri

* add filter to keep order and apply to details as well

* use global isAdmin method

Co-authored-by: Daan Hoogland <dahn@onecht.net>
2021-12-08 10:27:58 +05:30
dahn a47e53fcee
internal ref replaced by uuid (#5738)
* internal ref replaced by uuid

* remove all internal DB IDs from usage records

* remove superfluent .append(")")

Co-authored-by: Daan Hoogland <dahn@onecht.net>
2021-12-07 10:09:38 +05:30
Abhishek Kumar 93f4ecab84
vmware: fix cpu reservation during vm scale (#5708)
Fixes #5706

Correctly set CPU reservation while scaling a dynamically scalable VM.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2021-12-07 09:47:00 +05:30
Hoang Nguyen 19880687b7
UI fix: button next not working when adding more physical networks (#5734) 2021-12-06 12:31:38 +05:30
sureshanaparti 00c6ad2733
vmware: Perform volume file search in the VM directory on the datastore while computing the VM snapshot chain size. (#5735)
This PR improves the volume file search on the datastore while computing the VM snapshot chain size in VMware. The file search is now performed in the VM directory on the datastore, instead of all the directories on the datastore (which is leading to incorrect VM snapshot chain size computation when VM id has 6 digits).
2021-12-03 16:46:31 +05:30
Wei Zhou a277e4e08c
server: fix non-root users are able to list system networks by id (#5729) 2021-12-03 10:36:33 +01:00
Wei Zhou 46fa7f473d
UI bug fix: 'Invalid ip address' when change vm ip address (#5744) 2021-12-03 06:58:42 +01:00
dahn 14d09a9fab
check security groups in basic zones (#5746)
Co-authored-by: Daan Hoogland <dahn@onecht.net>
2021-12-03 11:17:55 +05:30
Wei Zhou 458082234d
UI: Enable cancel host maintenance when resource state is 'ErrorInPrepareForMaintenance' (#5737) 2021-12-03 06:46:25 +01:00
Wei Zhou 4d99f84273
server: update capacity_state of host cpu core after disable/enable a host (#5701) 2021-12-03 06:45:53 +01:00
davidjumani dfd75d7bc0
api: Fix wrong logger class in *Cmd.java (#5740)
This PR changes the incorrect class name used in the logger in ListHypervisorsCmd
2021-12-02 15:16:28 +05:30
Harikrishna 867ccf6f48
Merge pull request #5720 from shapeblue/remove-redundant-call-for-snapshot-chain-size
Removed redundant call for VM snapshot chain size, in VMware.
2021-12-02 10:08:28 +05:30
Harikrishna 4beca925d7
Fix NPE on scale VM operation after the corresponding template is deleted (#5736) 2021-12-01 17:53:09 +01:00
Suresh Kumar Anaparti e3459b5c01 Removed redundant call for VM snapshot chain size, in VMware. 2021-11-26 11:19:13 +05:30
Wei Zhou 965316b842
server bug fix: remove network details when network is removed (#5675) 2021-11-25 21:15:51 +01:00
Wei Zhou 2b54b587fc
engine/schema: fix findActiveAccountById in AccountDaoImpl.java (#5704) 2021-11-25 12:20:48 +01:00
DH Park a85a00bed9
kvm: Fixes UEFI XML Definition Error (#5692)
UEFI bootMode 추가
2021-11-23 16:44:32 +05:30
Apurv Gupta babf94f801
UI: Autoscroll to Error Field (#5200)
Fixes #4798
2021-11-18 14:01:22 +05:30
Wei Zhou dd458feeb8
IPv6: fix deploy vm issue in ipv6-only networks without VR (#5648)
* IPv6: fix deploy vm issue in ipv6-only networks

* Update #5648: add method setNicPropertiesFromNetwork
2021-11-18 13:53:55 +05:30
Wei Zhou c95f8e263a
server: set network rate for additional public IPs (#5670)
This PR fixes #5669
2021-11-18 13:45:37 +05:30
Peinthor Rene e93d67444d
ui-primary-storage: hide provider if Linstor protocol (#5672)
* ui-primary-storage: hide provider if Linstor protocol

If Linstor protocol is selected it makes no sense to show other
providers as Linstor only works with the Linstor provider.

This was removed with the fix for #5613, that probably resulted from a
bad merge resolving from my part.

* ui-wizard: set correct provider for Linstor protocol
2021-11-18 13:44:52 +05:30
DH Park a8e7315e53
UI : Fix SSL certificate submit button not working (#5682)
* Updating pom.xml version numbers for release 4.17.0.0-SNAPSHOT

Signed-off-by: nicolas <nicovazquez90@gmail.com>

* Fix build and version numbers

* SSL Certificates 버튼이 작동하지않는 버그

SSL Certificates 버튼이 작동하지않는 버그

* Revert "Updating pom.xml version numbers for release 4.17.0.0-SNAPSHOT"

This reverts commit e4dba9fb95.

* Revert "Fix build and version numbers"

This reverts commit fd6161a9df.

Co-authored-by: nicolas <nicovazquez90@gmail.com>
Co-authored-by: Dajeong-Park <ekwjd7182@gmail.com>
2021-11-18 13:44:25 +05:30
Hoang Nguyen 0684aff529
ui: fix incorrect auto-select (#5693) 2021-11-18 13:42:24 +05:30
Wei Zhou 4568a68d83
CsDhcp.py: fix runtests.sh error (#5671)
$ cd systemvm/test
$ bash -x runtests.sh
......
../debian/opt/cloud/bin/cs/CsDhcp.py:114:25: E266 too many leading '#' for block comment
+ '[' 1 -gt 0 ']'
+ echo 'pycodestyle failed, please check your code'
2021-11-17 14:05:20 +01:00
nicolas bdab51424a
New upgrade schema path and workaround for system VM template auto registration 2021-11-10 12:56:52 -03:00
nicolas 462e0511f4
Fix version and add schema upgrade path 2021-11-10 11:49:02 -03:00