Commit Graph

1207 Commits

Author SHA1 Message Date
Daan Hoogland fc52e641d8 try-with-resource to prevent resource leaks
(cherry picked from commit 39f775c381)
2014-06-06 19:24:08 +02:00
sedukull 91d054cb00 CLOUDSTACK-6793: Fixed an invalid Domain Id Issue
Signed-off-by: sedukull <santhosh.edukulla@gmail.com>
2014-06-06 14:09:51 +02:00
Alena Prokharchyk 66df43572e CLOUDSTACK-6676: cleanup ip address details on ip disassoc 2014-06-05 17:26:01 -07:00
Alena Prokharchyk 03623fe57e CLOUDSTACK-6853: Search for non-removed nics only when check if the running vm belongs to a certain network 2014-06-05 17:07:52 -07:00
Rajesh Battala d59cc1ff8f CLOUDSTACK-6831 [Hyper-V] Improve the logging for VM snapshot failures as it is not supported. Right now it is throwing NPEs 2014-06-05 15:06:24 +05:30
Daan Hoogland 0329bebac5 update vlan uris
Conflicts:
	engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java

(cherry picked from commit 44012ddadf)
2014-06-03 15:41:47 +02:00
Rajani Karuturi bd5cd69517 Fixed ResouceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity
Fixed another leak which might occur due to outer while loop.

Signed-off-by: Daan Hoogland <daan@onecht.net>
(cherry picked from commit 004e0cbf61)
(cherry picked from commit fa3bbe9a19)
2014-06-03 15:41:24 +02:00
Rajani Karuturi d511847cfe Fixed Resource leak (RESOURCE_LEAK) 11. overwrite_var: Overwriting "pstmt" in "pstmt = conn.prepareStatement("INSERT INTO `cloud`.`ldap_configuration`(hostname, port) VALUES(?,?)")" leaks the resource that "pstmt" refers to.
Signed-off-by: Koushik Das <koushik@apache.org>
2014-06-03 17:32:43 +05:30
Rajani Karuturi 67d92726cb Fixed ResouceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-06-03 09:19:29 +02:00
Nitin Mehta be765ce868 CLOUDSTACK-6599: Add the column in Java upgrade path since 4.2 already has the extract template/volume columns 2014-05-30 14:53:42 -07:00
Nitin Mehta 48ea9e0b5e CLOUDSTACK-6599:
1. Adding the missing Template/Volume URLs expiration functionality
2. Improvement - While deleting the volume during expiration use rm -rf as vmware now contains directoy
3. Improvement - Use standard Answer so that the error gets logged in case deletion of expiration link didnt work fine.
4. Improvement - In case of domain change, expire the old urls
2014-05-30 10:23:50 -07:00
Devdeep Singh f5ce280da3 CLOUDSTACK-6810: Fix storage migration of a vm with volume on local was failing. When a plan
with hostid included was passed to the local storage pool allocator, it returned all the local
storage pools in the cluster, instead of just the local pool on the given host in the plan.
This was happening the search at a host level was happening only for data disk. Fixed this.
Additionally, the query to list the storage pools on a host was failing if the pool did have
tags. Fixed the query too.

CLOUDSTACK-6802: Fix for not being able to attach data disk on local. This issue gets fixed
with the above issue too. The query to list pools on a host was failing if there were no
tags on the storage pool.
2014-05-30 14:34:53 +05:30
Rajani Karuturi c91780449a FIXED CLOUDSTACK-6781 [Automation] integration.smoke.test_portable_publicip.TestPortablePublicIPRange.test_createPortablePublicIPRange failing on 4.4
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2014-05-28 10:46:18 +05:30
Rajani Karuturi 2ab7bcade2 Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted ip range 2014-05-27 09:32:05 +05:30
Koushik Das 120da605b0 CLOUDSTACK-6740: Direct agent command throttling improvements
List of changes:
1. Created a separate thread pool for handling cron and ping tasks. The size of the pool is based on direct.agent.pool.size. The existing direct agent pool will run all commands other than cron and ping.
2. For normal tasks (generated as part of user/admin API calls), if throttle limit is reached then tasks get queued up for subsequent execution once threads are available.
3. For cron and ping tasks (internally generated by MS like ping, VM sync etc.), if throttle limit is reached then these gets rejected. Since these are internally generated these can be rejected without any issues.
2014-05-22 14:07:13 +05:30
Min Chen f748a552e9 Disable IAM feature from 4.4 release. 2014-05-19 16:27:50 -07:00
Nitin Mehta d5425e1a4a CLOUDSTACK-6699: listResouceDetails - enhance it to list by (key,value) pair - allowed to Admin only. 2014-05-18 23:20:12 -07:00
Prachi Damle 3448ab7f1c CLOUDSTACK-6476: Basic Zone with Multiple Pods Setup: DHCP server doesnt get deployed in the pod where the VM gets deployed
Changes:
PodId in which the router should get started was not being saved to the DB due to the VO's setter method not following the setXXX format. So when planner loaded the router from DB, it always got podId as null and that would allow planner to deploy the router in any pod. If the router happens to start in a different pod than the user VM, the Vm fails to start since the Dhcp service check fails.

Fixed the VO's setPodId method, that was causing the DB save operation fail.
2014-05-16 16:48:53 -07:00
Murali Reddy 4e72ec9983 CLOUDSTACK-6686:NetworkACLItemCidrsDaoImpl uses firewallRuleId instead
of networkAclItemId

fix uses networkAclItemId instead of firewallRuleId
2014-05-15 16:42:49 +05:30
Sanjay Tripathi e7e1ae254a CLOUDSTACK-6649: CS is not giving the system-wide capacity for GPU reosurce. 2014-05-14 15:02:59 +05:30
Amogh Vasekar 594f66d125 This patch disallows deleting / modifying system defined guest OS mappings
Local env
1. Create user defined mapping
2. Delete / modify user defined mapping. Should pass
3. Delete / modify system defined mapping. Should fail

Signed off by :- Nitin Mehta<nitin.mehta@citrix.com>
2014-05-12 22:43:49 -07:00
Daan Hoogland 4f0820b865 be able to remove vpc as owning entity of a network 2014-05-09 17:04:57 +02:00
Devdeep Singh 98df3e55b9 CLOUDSTACK-6622: After a volume was live migrated, the destination smb storage path was added to
the folder column. For an smb share the smb credentials are in the query string of the path.
Before adding the path, smb shares query string should be cleaned up.
2014-05-09 15:54:56 +05:30
Nitin Mehta da0545ff86 CLOUDSTACK-6530: Make Network and Volume implement Displayable interface. Iterate over all first class entities in the context to decide the display property for event display. 2014-05-08 15:36:25 -07:00
Saksham Srivastava 84135cd302 CLOUDSTACK-6575: Deploy VM failed with NPE while using custom compute offering 2014-05-08 11:37:46 +05:30
Alena Prokharchyk 515fa261ba CLOUDSTACK-6596: UUID and display flag update support for LBStickinessPolicy and LBHealthCheckPolicy 2014-05-07 15:38:17 -07:00
Amogh Vasekar 5949e33578 CLOUDSTACK-6358: As a part of supporting dynamic guest OS defined by user, removing the hard-coded dependencies.
This patch is for KVM

1. Local testing on KVM
2. Successfully got up system VMs
3. Successfully created a CentOS VM
4. Snapshots are not supported for KVM

 Signed off by :- Nitin Mehta<nitin.mehta@citrix.com>
2014-05-07 15:17:47 -07:00
Amogh Vasekar 8f37841eb4 CLOUDSTACK-6358: As a part of supporting dynamic guest OS defined by user, removing the hard-coded dependencies.
This patch is for XenServer.

1. Local testing on XenServer 6.0.2
2. Successfully got up system VMs
3. Successfully created a CentOS VM
4. Created VM snapshot and reverted to snapshot
5. Manipulated guest_os_hypervisor table for mapping, and checked for correct propagation of platform emulator.

Signed off by :- Nitin Mehta<nitin.mehta@citrix.com>
2014-05-07 14:55:35 -07:00
Devdeep Singh 681e628543 CLOUDSTACK-6510: Fix gson serialization exception in storage migration. Gson couldn't serialize
a map with volume and storagepool objects for logging. Fixed by using volume and storage pool
ids instead of objects in the map.
2014-05-07 14:07:36 +05:30
Jayapal 3ec8de9b85 CLOUDSTACK-6582 updated the table network_acl_item_cidrs name in Upgrade430to440 2014-05-07 10:45:45 +05:30
Alena Prokharchyk 8ffb2c1148 CLOUDSTACK-6585: added missing metadata support for LBStickiness/LBHealthcheck policies 2014-05-06 17:04:03 -07:00
Jayapal 4c304324a3 fixed network acl cidr issues 2014-05-06 22:29:42 +02:00
Daan Hoogland 0c0a0c2562 cidr field removed 2014-05-06 22:29:13 +02:00
Koushik Das 64ccf4b48e CLOUDSTACK-6579: used_bytes column of storage_pool table is no longer used and should be removed
For now correctly setting used_bytes. Also fixed the corresponding simulator code
2014-05-06 20:24:08 +05:30
Bharat Kumar 489bb0c7ed Cloudstack-5077: reserve cpu and memory only when vmware.reserve.cpu/mem are set to true. Insted of setting the ovecommit values to one on upgrade, we popultate them from the global values.
Conflicts:
	engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java
	engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java
	plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
2014-05-05 11:32:51 +05:30
Daan Hoogland 9c2768756c CLOUDSTACK-6549: ommission due to insufficient tests in CLOUDSTACK-6231 2014-05-01 09:42:54 +02:00
Daan Hoogland 3852afa717 CLOUDSTACK-6231: network acl item cidrs loaded from a seperate table 2014-04-30 14:55:56 +02:00
Min Chen f3e9c84cdd CLOUDSTACK-6478: Failed to download Template when having 3 SSVM's in one
zone on Vmware.
2014-04-22 19:14:55 -07:00
Alena Prokharchyk 3e2c5bb2e6 Revert "Return isolation methods as a part of listPhysicalNetworks call"
This reverts commit d47a11a7eb.
2014-04-22 18:12:35 -07:00
Alena Prokharchyk d47a11a7eb Return isolation methods as a part of listPhysicalNetworks call 2014-04-22 16:13:33 -07:00
Amogh Vasekar 3419c812ae CLOUDSTACK-6437:
Add ability to distinguish between user defined and system defined guest OS and mappings
Add default mappings for XenServer

Local testing with
1. Add new guest OS by API
2. Add new guest OS mapping by API
2014-04-18 11:33:42 -07:00
Harikrishna Patnala bc9737ec8a CLOUDSTACK-6211: Xenserver - HA - SSVM fails to start due to running out of management Ip ranges when testing host down scenarios
Signed-off-by: Koushik Das <koushik@apache.org>
2014-04-18 17:43:49 +05:30
Saksham Srivastava 406c289d15 CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool
Signed-off-by: Koushik Das <koushik@apache.org>
2014-04-16 16:20:04 +05:30
Koushik Das 800e9dbac5 CLOUDSTACK-6402: Fix StopCommand so that VMs are not removed accidentally as part of vmsync
Added a new flag 'checkBeforeCleanup' to StopCommand based on which check is done to see if VM is running in HV host.
If VM is running then in this case it is not stopped and the operation bails out.
Also modified the MS code to call the StopCommand with appropriate value for the flag based on the context.
Currently it is only set to 'true' when called from the new vmsync logic based on powerstate of VM. For rest it
is set to 'false' meaning no change in behaviour.
2014-04-14 16:12:35 +05:30
Sanjay Tripathi 127196e95d CLOUDSTACK-6366: add vgpuTypes details in vgpu_types table. 2014-04-09 18:22:06 +05:30
Harikrishna Patnala 68c80e28c0 CLOUDSTACK-6253: Optimizing VR alerts getting algorithm In addition to this a new configuration parameter is added router.alerts.check.interval defaulted to 30minutes to check for alerts in Virtual Router 2014-04-09 18:11:24 +05:30
Koushik Das e0a2fcabcc CLOUDSTACK-6362: Parallel VM deployment - direct.agent.thread.cap needs to default to 1.0 (currently 0.1) to allow for parallel Vm deployments. 2014-04-09 11:41:43 +05:30
Sanjay Tripathi 156fb7ebd3 CLOUDSTACK-6357: Not able to select GPU card in case of GPU-passthrough. 2014-04-08 22:08:17 +05:30
Sanjay Tripathi ce966c8b38 CLOUDSTACK-6345: Non gpu enabled VMs are getting deployed in gpu enabled Hosts. 2014-04-07 16:05:58 +05:30
Jayapal 936de7e1c5 CLOUDSTACK-6327: Updated the removeFromLoadBalancerRule and listLoadBalancerRuleInstances API
Updated these APIs to use VM primary/secondary details on LB rule.

listLoadBalancerRuleInstances API lists the vm ips which are assigned to lb rule when passed
listlbvmips
removeFromLoadBalancerRule is updated to remove the spcific vm ip entry assinged to LB rule.
Added new param vmidipmap to this API
2014-04-04 18:32:43 +05:30