8649fa005a
Fix findbugs findings in cloud-plugin-network-elb
...
Findings:
- comparing Longs by reference
- possible null pointer dereference
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
ef2ced7564
Fix findbugs findings in cloud-plugin-network-ovs
...
OvsTunnelManagerImpl.java:456, RC_REF_COMPARISON, Priority: High
Serveral low priority fixes
2014-02-14 18:37:46 +01:00
9b841af529
Findbugs : A map can't retrieve an object by index, so get(0) would
...
return null. Changed to retrieve the first entry in the map.
Removed the ExecutionException try catch, this would prevent the
unittest from giving accurate information on exceptions. Avoid catching
checked exceptions in a unittest, use expected keyword on @Test instead.
2014-02-14 18:37:45 +01:00
c1cfaa2d1c
Contrail Event Interceptor fix
...
When project/domains are created, our plugin code won't get invoked. Our
contrail plugin uses Event infrastructure provided by cloudstack to
receive these events and handle them accordingly. It is must to create
domains/projects before creating a virtual network/vm object in contrail
implementation. Hence our plugin must need a way to get notified about
project/domain events.
2014-02-10 22:43:38 -07:00
3b58a45e04
Merge branch 'master' into rbac.
2014-02-07 13:43:36 -08:00
64c61c7202
Fix two NPE exceptions in the Contrail Plugin when contrail is not providing any services on the network.
2014-02-06 16:51:20 +01:00
356daf3eed
Review 16080 Move Netscaler plugin from non-oss to oss and upgrade the nitro API to 10.1
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-05 14:03:49 +01:00
0d222b14a1
stratosphere-ssp plugin: Fix HttpClient4 connection leak
...
Replaced HttpClient#execute(HttpUriRequest) with
HttpClient#execute(HttpUriRequest,ResponseHandler<T>).
The former requires extra EntityUtils#consume(HttpEntity).
2014-02-05 16:23:32 +09:00
7f34282dfa
Removed references to secondarystoragevmmanager from code that doesn't use it.
2014-02-05 01:39:15 +00:00
cc8bde2421
Do not initialize contrail plugin component functionality like db sync, network offerring creation when contrail is not installed
2014-02-04 12:35:29 -08:00
f84375442e
Merge branch 'master' into rbac
...
Conflicts:
api/src/org/apache/cloudstack/api/command/user/autoscale/ListAutoScaleVmProfilesCmd.java
api/src/org/apache/cloudstack/api/command/user/volume/ResizeVolumeCmd.java
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
server/src/com/cloud/api/ApiServer.java
server/src/com/cloud/api/query/QueryManagerImpl.java
server/src/com/cloud/template/TemplateAdapterBase.java
setup/db/db/schema-430to440.sql
tools/apidoc/gen_toc.py
2014-02-04 12:07:32 -08:00
836a9caa72
add charset arg to InputStreamReader constructor
...
thanks to findbugs.
2014-01-31 12:57:13 +09:00
ed3e1b95b0
VPC Support for contrail networking
...
Signed-off-by: Sheng Yang <sheng.yang@citrix.com>
2014-01-30 18:13:48 -08:00
cb048f4108
Some rework stratosphere ssp plugin
...
* add missing command entry in commands.properties
* migrate httpclient 3.x to 4.x
* fix the broken SspClient
* add webapp session checking in mock ssp server
2014-01-30 21:31:44 +09:00
cc98125067
These are additional fixes to make Juniper Contrail plugin work
2014-01-28 08:58:22 +00:00
0502d2f375
CLOUDSTACK-5697 This patchset fixes a bug with the recently merged
...
vxlan code. Users can set a physical network to isolation type 'vxlan',
put public traffic on that physical network, and it will still attempt
to use 'vlan' isolation on the KVM hosts. This is going to be an issue
for other isolation types as well, but I'm not familiar with them, so
I'm just fixing vxlan for now.
2014-01-27 12:11:18 -07:00
af14699c4c
fixing the build _ AffinityGroup command changes
2014-01-23 18:17:43 -08:00
5fc03211ff
Findbugs finding: the collections should have been made static
2014-01-23 15:52:46 +00:00
33cd1ab921
Merge branch 'master' into rbac
2014-01-22 11:23:51 -08:00
49124bdb7d
Fix license formatting to work with the mycila license check for nvp and opendaylight
2014-01-22 11:24:37 +01:00
d3cd73d861
Add license check plugin to root pom. Disabled for the entire project, except for poms that override it (opendaylight, nvp)
2014-01-22 11:22:42 +01:00
7ab3e277c4
Cosmetics
2014-01-22 10:11:20 +01:00
452c20b242
Configuration: define "host" global config parameter in cloud-api package instead of ClusterManager as the parameter is mostly used by sevices components running remotely (consoleProxy, secondarystorage), or by third party integrators.
...
Also intoroduced one more global config parameter - api.servlet.endpoint (default value is "http://localhost:8080/client/api ?"). The parameter defines API end point. Can be used by CS components/services deployed remotely, for sending CS API requests
2014-01-20 13:37:52 -08:00
929fbabaa2
Merge branch 'master' into rbac.
2014-01-17 14:37:08 -08:00
07f73ec054
Null-safety in http header handling
...
The http Content-Type header may not always be present in the response, in such cases the getResponseHeader will return null and this leads to NPE, therefore the presence of the header must be checked.
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-01-17 00:19:17 +01:00
fcd21eb7f3
CLOUDSTACK-5747 Fixed network restart issue with SRX
2014-01-16 11:29:03 +05:30
cc2b1c4961
Contrail plugin fixes -master branch, single commit, no transaction wrappers
...
Signed-off-by: Sheng Yang <sheng.yang@citrix.com>
2014-01-15 14:11:49 -08:00
6c1849f4bf
Fix Spring wiring issues in starting up MS.
2014-01-14 16:20:30 -08:00
0bff705621
Add L3VPN isolation method for contrail plugin
...
Signed-off-by: Sheng Yang <sheng.yang@citrix.com>
2014-01-14 13:55:35 -08:00
68b8891c62
Removed all reminants of the IdentityService. Created the KeysManager to move the management
...
of keys out of management server
2014-01-14 13:11:35 -08:00
bae498c89e
Handle search of those entities without db view created using new ACL
...
model.
2014-01-13 21:55:56 -08:00
af657b3d71
CLOUDSTACK-5861: networks that failed to implement can not be destroyed
...
introduces a force option in delete network to forcifully delete a
network. This comes handy in rare cases where network fails to implenet
and network is in shutdown state, but network shutdown to rollback
implement process fails as well.
Conflicts:
api/src/org/apache/cloudstack/api/command/user/network/DeleteNetworkCmd.java
server/src/com/cloud/user/DomainManagerImpl.java
2014-01-13 23:28:35 +05:30
3bea60435e
Remove commented elements
2014-01-13 12:16:37 +01:00
16d333f06d
Fix coverity issue 606007, 606008
2014-01-13 12:16:37 +01:00
044a2078a1
Fix coverity issue 573580
2014-01-13 12:16:37 +01:00
15a08107d8
Fix coverity issue 600070
2014-01-13 12:16:37 +01:00
4683de5a92
Fix coverity issues 569415, 569416, 569417
2014-01-13 12:16:36 +01:00
be49a2fa6d
CLOUDSTACK-5647 Adding F5 device to network service provider fails with
...
NoClassDefFoundError
adding back missing (removed from 4.3) dependency 'commons-discovery'
2014-01-10 22:05:22 +05:30
ae8560b195
Moved security out into its own jar. Will be adding more to it. Fixed a few white space issues brought up by checkstyle in eclipse.
2014-01-09 16:12:25 -08:00
7c8facf3c9
Change checkstyle to run on every sub project, so it will also run when you build an individual module
2014-01-09 17:00:11 +01:00
612a41e3f5
Add UI interface for managing the OpenDaylight provider and controllers.
...
Fix several bugs in the code related to the api handling.
Conflicts:
ui/scripts/system.js
ui
2014-01-08 17:08:37 +01:00
8ddcc9ba80
Set unique gre key for every network.
...
Set interface id to nic uuid when creating the vif.
2014-01-08 16:00:59 +01:00
f3f93a96f5
Adding OpenDayLight Neutron API. It includes 24 unit tests and 3 integration tests. Everythin passed the build.
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-01-08 16:00:39 +01:00
1f9528bad3
Add a network plugin for OpenDaylight
...
This plugin is a technology preview and designed to work with the OVSDB module
2014-01-08 15:57:46 +01:00
5dc0c60239
Fix missing / in api url
2014-01-08 11:01:20 +01:00
6d0dbf5968
check for BroadcastDomainTypes on sourceNatIp
2014-01-06 22:13:51 +01:00
d69a35086f
another issue with vlan-number vs vlan-uri
2014-01-06 15:25:35 +01:00
50be9a447a
Apply proper license header and formatting to the new contrail tests #2
2013-12-30 09:38:10 +01:00
4e88197459
Apply proper license header and formatting to the new contrail tests
2013-12-30 09:15:06 +01:00
7f9683af85
Added Virtual-Network and Virtual-Machine Model unit test.
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2013-12-30 08:57:21 +01:00
ad33f0ad66
CLOUDSTACK-2560: Adding duplicate ASA device entity failure should be handled with API
...
Handling duplicate ASA appliance addition gracefully
2013-12-26 17:21:58 +05:30
dad4249498
SecurityProfile and ACL for NiciraNvpApi, including Unit and Integration tests
...
Signed-off-by: Daan Hoogland <dhoogland@schubergphilis.com>
2013-12-23 14:30:03 +01:00
729a79e85c
Refactor db view based list apis to use new IAM acl search criteria.
2013-12-16 14:31:32 -08:00
add277a4aa
Separate network and VPC related cmd to use two different views.
2013-12-12 16:53:59 -08:00
be5e5cc641
All Checkstyle problems corrected
2013-12-12 12:26:07 -08:00
f33b247fc3
Moved the checkstyle project from parents to build to store all build tools in one location. Modified the config file to use 1024 for now.
2013-12-12 12:23:49 -08:00
5c12250dea
CLOUDSTACK-5278 Fixed cleaning up egress default rules on VR and SRX
...
1. Egress default policy rules is send to the firewall provider. It is up to the
provider to configure the rules.
2. The default policy rules are send for both allow and deny default policy.
3. On network shutdown rules for delete are send.
4. For VR and SRX, by default deny the traffic. So no default rule to deny traffic is required.
2013-12-10 14:19:03 +05:30
c60a256ebd
fixed egress rules for palo alto plugin and cleaned up extra api calls on master
...
Signed-off-by: Sheng Yang <sheng.yang@citrix.com>
2013-12-09 18:26:57 -08:00
4de09ee654
add Apache Licensed
2013-12-10 08:37:37 +07:00
be67f5d17a
CLOUDSTACK-5428: support NetScaler to be configured exclusively for GSLB
...
service and not used for LB
Fix adds a boolean flag to addNetscalerLoadBalancer api, which
will mark added NetScaler for exclusive GSLB service. A netscaler marked
as exclusive gslb service provider is not picked for any guest network's
lb provider.
2013-12-10 06:20:58 +05:30
267ff79bfb
post-rebasing
2013-12-09 23:33:15 +07:00
61e80f030a
remove unused code
2013-12-09 23:33:15 +07:00
7efab20300
fix staticNat after rebase
2013-12-09 23:33:15 +07:00
4d0602175c
refactor ovsProvider to new resource
2013-12-09 23:33:15 +07:00
0624fe5d03
remove unused table: ovs_nic_map
2013-12-09 23:33:15 +07:00
015ab6af8a
fix rebase master
2013-12-09 23:33:14 +07:00
9f82757eb9
tuna
2013-12-09 23:33:14 +07:00
3df8b912fc
add kvm support & LB service
2013-12-09 23:33:14 +07:00
9c702ff388
tuna add port forwarding support
2013-12-09 23:33:14 +07:00
d935d3865a
tuna
2013-12-09 23:33:14 +07:00
4e914b7087
re-factor gre controller
...
Signed-off-by: tuna <ng.tuna@gmail.com>
2013-12-09 23:33:14 +07:00
96188a3730
re-factor gre controller prototype
2013-12-09 23:33:14 +07:00
12a4d30007
add two tables for gre controller
2013-12-09 23:33:14 +07:00
ee7380ace2
CLOUDSTACK-5296: Add certificate chain support for netscaler
...
This patch adds support for trust chains in the netscaler.
I initially planned on using the 10.1 API's "bundle" feature but during
my testing I found that was not working. So I am doing the chain linking
myself. Also NS can have only one entity of a certificate ie lets say
two different users try to add the same certificate on the netscaler
only one of them will go through. The other one says resouce already
exists even though they have different files.
This can be a problem in trust chains where the chain can be shared
between multiple accounts/certificates. So, I am using the figerprint as
an identifier of a certificate and making sure that we delete it only
when no one references it.
2013-12-05 15:35:28 +05:30
f2c7db9947
Corrected parsing vlan tag in JuniperSrx resource
2013-12-04 16:17:05 +05:30
2774b62d64
Fixing bugs from Coverity related to Dereferenced Null after check and as return value.
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2013-11-27 11:18:00 +01:00
7a6751aa77
Make sure that if the file does not exist an Exception is thrown and that once it exists it is also closed after the properties are loaded.
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2013-11-26 08:22:29 +01:00
eb21239e3f
CLOUDSTACK-5224: Add missing configuration for Netscaler, F5, SRX, and VNMC
2013-11-25 12:03:49 -07:00
11c0c263f2
QueryChecker interface and ACL search criteria to be used for query api
...
for entities with db views created.
2013-11-22 16:36:38 -08:00
433a631916
Reformat of source code to set a stable base for the future. I couldn't get checkstyle enabled. There's still about a thousand errors from checkstyle. Most of it from length errors from comments and strings. Will attempt to remove those tonight. This change is so large I just want to get it in before any merge nightmares. The changes are fairly minor though and I did a full compile and start a server with the reformat code.
2013-11-21 07:56:47 -08:00
cf715ff491
Bump 4.3.0 to 4.4.0 in master
2013-11-21 16:01:15 +01:00
d620df2bdd
Reformatted all of the code.
2013-11-21 06:15:26 -08:00
224f479974
Removed trailing spaces
2013-11-21 04:08:01 -08:00
e4b22d0fca
Replace all tabs, particularly the ones in the comments
2013-11-21 03:39:58 -08:00
e0d2423f06
Refactoring account_type for Domain_Admin and Normal_User types
2013-11-20 16:53:59 -08:00
8d62744681
Reformat all source code. Added checkstyle to check the source code
2013-11-20 07:26:53 -08:00
91e176cb0d
Fix a bug in listVm logic to use revokedIds and grantedIds.
2013-11-19 16:41:40 -08:00
876b7e492f
Checkstyle adjustments in code and configuration
2013-11-18 19:22:42 +01:00
19e9849d86
Enabled the traffic lable support the hyperv hypervisor type. Modified the physical_network_traffic_types table to introduce hyperv_network lable column.
...
Modified associated VO's and impls classes. Modified the List/Update/Add TrafficType command api's and response classes.
Fixed the Unit tests
2013-11-08 20:21:18 +05:30
0076307863
Squashed merge of Ssl Termination feature
...
Bug: https://issues.apache.org/jira/browse/CLOUDSTACK-4821
FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/SSL+Termination+Support
This patch implements the SSL offload feature for loadbalancers
and includes the implementaion for this to work with Netscaler.
The following are the new API's that this patch adds
uploadSslCert
deleteSslCert
listSslCert
assignCertToLoadBalancer
removeCertFromLoadBalancer
Unit tests are also included in the patch.
2013-11-08 16:49:16 +05:30
ea2eafcd85
Summary: Implement stored-password encryption for Stratosphere plugin
...
BUG-ID: CLOUDSTACK-4929
Bugfix-for:
Reviewed-by:
Reported-by:
Signed-off-by: John Kinsella <jlk@stratosec.co> 1383882870 -0800
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-11-08 15:18:25 +05:30
62286fcc6d
Fix Palo Alto Firewall RAT issue
2013-11-07 10:44:45 -08:00
c06d8a750c
Fix for issues on Coverity related to IDs cv_1125383, cv_1125382, cv_1125380, cv_1125379, cv_1125378, cv_1125377, cv_1125376, cv_1125375, cv_1125374.
...
Those bugs are related to classes not implementing Serializable, nox overriding the equals and/or hashCode methods and with empty finalize method.
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2013-11-07 10:59:10 +01:00
8f8ad3f38e
Squashed commit of the Palo Alto Networks firewall integration plugin.
...
This patch adds a network plugin to support Palo Alto Networks firewall (their appliance and their VM series firewall).
More information in the FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Palo+Alto+Firewall+Integration
Features supported are:
- List/Add/Delete Palo Alto service provider
- List/Add/Delete Palo Alto network service offering
- List/Add/Delete Palo Alto network with above service offering
- Add instance to the new network (creates the public IP and private gateway/cidr on the PA as well as the source nat rule)
- List/Add/Delete Ingress Firewall rule
- List/Add/Delete Egress Firewall rule
- List/Add/Delete Port Forwarding rule
- List/Add/Delete Static Nat rule
- Supports Palo Alto Networks 'Log Forwarding' profile globally per device (additional docs to come)
- Supports Palo Alto Networks 'Security Profile Groups' functionality globally per device (additional docs to come)
Knowns limitations:
- Only supports one public IP range in CloudStack.
- Currently not verifying SSL certificates when creating a connection between CloudStack and the Palo Alto Networks firewall.
- Currently not tracking usage on Public IPs.
Signed-off-by: Sheng Yang <sheng.yang@citrix.com>
2013-11-06 10:08:22 -08:00
56070c644b
Fix for 1125389 RV: Bad use of return value - make sure the replace call is done after replaceAll and the correct value is returned
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2013-11-06 15:17:00 +01:00
ce3638bb03
Merge branch 'master' into rbac.
2013-11-04 15:49:29 -08:00
479f404aea
Fix several rat issues introduced by recent commits
2013-11-04 20:14:46 +01:00
9e5e9fdc67
Fix version and build paths for the checkstyle code
2013-11-04 20:01:14 +01:00
256763cf65
Fix checkstyle errors in Nicira NVP plugin
2013-11-04 15:24:54 +01:00
f39b6b2c56
Add checkstyle to the build process and enable it for the Nicira NVP plugin
2013-11-04 15:24:54 +01:00
Miguel Ferreira
Hugo Trippaers
Darren Shepherd
Min Chen
Syed Ahmed
Hiroaki KAWAI
Alex Huang
sbalineni
Prachi Damle
Sachchidanand Vaidya
Marcus Sorensen
Alena Prokharchyk
Laszlo Hornyak
Jayapal
Murali Reddy
wrodrigues
Daan Hoogland
Daan Hoogland
Koushik Das
Antonio Fornie
Jayapal
Will Stevens
tuna
wilderrodrigues
Rajesh Battala
John Kinsella
Sheng Yang