etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
34,084 Commits 323 Branches 325 Tags 859 MiB
Commit Graph

34084 Commits

Author SHA1 Message Date
Antonio Fornie cbea6d26e8 Fix and test GroupBy SQL query creation 
Signed-off-by: Ian Southam <isoutham@schubergphilis.com>
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:46 +01:00
Miguel Ferreira 8649fa005a Fix findbugs findings in cloud-plugin-network-elb 
Findings:
    - comparing Longs by reference
    - possible null pointer dereference

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:46 +01:00
Ian Southam 5a6ad11fa2 findbugs findings 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:46 +01:00
Ian Southam 33c2c87287 Findbugs finding 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:46 +01:00
miguelaferreira 1237bf3222 Fix findbugs findings in cloudstack-service-console-proxy-rdpclient 
Findings:
- 32 int shifted by an amount not in range -31..31:
	The shifts by 32 bits don't actually have any effect on the value
	(as shown by the tests)
- possible null pointer dereference
- repeated conditional test
- field only ever set to null
	All other uses of the field were to check if it was null,
	which it was, so it was removed

Other actions:
- Upgrade jUnit to version 4
- Add PowerMock dependency

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:46 +01:00
Hugo Trippaers ef2ced7564 Fix findbugs findings in cloud-plugin-network-ovs 
OvsTunnelManagerImpl.java:456, RC_REF_COMPARISON, Priority: High

Serveral low priority fixes
 2014-02-14 18:37:46 +01:00
Hugo Trippaers cc6938e3a8 Findbugs : Fix several "of concern" findings. 2014-02-14 18:37:46 +01:00
Hugo Trippaers 091694ceb2 Findbugs : NP_NULL_PARAM_DEREF_NONVIRTUAL fixed 2014-02-14 18:37:45 +01:00
Hugo Trippaers 26b32141a8 Findbugs : Fixes for several findings 
Made a comment on the use of ConcurrentHashMap for _agent
Conflicts:
	engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
 2014-02-14 18:37:45 +01:00
Hugo Trippaers 9b841af529 Findbugs : A map can't retrieve an object by index, so get(0) would 
return null. Changed to retrieve the first entry in the map.

Removed the ExecutionException try catch, this would prevent the
unittest from giving accurate information on exceptions. Avoid catching
checked exceptions in a unittest, use expected keyword on @Test instead.
 2014-02-14 18:37:45 +01:00
Hugo Trippaers d4d49578dc Findbugs : Fix a number of potential NPEs and minor findings 2014-02-14 18:37:45 +01:00
Alex Hitchins e0a4b7c891 Findbugs - Long equality fix. 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:45 +01:00
Alex Hitchins 39cfc4968c AJH Findbugs [8] - Added .toString() to enum. 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:45 +01:00
Alex Hitchins b8c228e151 AJH Findbugs [9] - Added object to map rather than string 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:45 +01:00
wrodrigues f414018a60 adding fix and unit tests for cloud-engine-api scariest 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:44 +01:00
wrodrigues 0ff943337c fixing FindBugs scariest for replaceFirst() method call that does not assign the return value 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:44 +01:00
Sander Botman 16aa73c2c8 Fixing some of the scary bugs possible null pointer: created testSetNicDevIdIfCorrectVifIsNotNull 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:44 +01:00
vetrivelc e171cb181c Fixed-Hardcoding-Issues 2014-02-14 07:44:54 -08:00
Likitha Shetty db91e54bf3 CLOUDSTACK-6112. Adding VPC router to a guest network fails with StringIndexOutOfBoundsException. 2014-02-14 17:01:27 +05:30
Girish Shilamkar 38f4000108 CLOUDSTACk-5674: Fix missing import 2014-02-14 15:12:27 +05:30
Girish Shilamkar 1eb98e135b CLOUDSTACK-5674: Fix a missing closing bracket. 2014-02-14 15:06:29 +05:30
Girish Shilamkar 2d93d83b44 CLOUDSTACK-5674: Added missing import for FAILED 2014-02-14 14:59:35 +05:30
Girish Shilamkar aa2831231c CLOUDSTACK-5674: apiclient was used before it was created. Fixed it. 2014-02-14 14:42:06 +05:30
Girish Shilamkar f3a77c79e8 CLOUDSTACK-5674: cls.fail does not work in setUpClass fixed it with assert. 2014-02-14 14:27:13 +05:30
Min Chen 4b75fa806a Fix a NPE bug in listAclPolicies. 2014-02-13 17:57:49 -08:00
Girish Shilamkar f0eb184d8a CLOUDSTACK-5674: Fix get_domain and remove dependency on ostype in get_template 2014-02-13 19:57:04 -05:00
Santhosh Edukulla c0d8b9e334 CLOUDSTACK-5674: getZoneForTests should return None if zone is "NA" in test_data.py 2014-02-14 10:45:14 +05:30
Min Chen 8072e50845 Fixed a bug for listTemplates with TemplateFilter=shared. 2014-02-13 16:47:41 -08:00
Min Chen 5bfc75cac9 Fix test build failure. 2014-02-13 11:21:07 -08:00
Girish Shilamkar f3364ca6a4 CLOUDSTACK-5674: Add missing test_data.py 2014-02-12 17:52:50 +05:30
Santhosh Edukulla c78292e9cd CLOUDSTACK-6082: Add alternate zone creation under deploy DC 2014-02-12 17:35:19 +05:30
Santhosh Edukulla 3dbb2ae488 CLOUDSTACk-5674: Added fix for CLOUDSTACK-5674 2014-02-12 17:34:34 +05:30
Santhosh Edukulla 7cc9423b8d CLOUDSTACk-5674: Added few misc changes to make it work. 2014-02-12 17:33:13 +05:30
Girish Shilamkar c1d34369aa Revert "CLOUDSTACK-5674: Few fixes" 
This reverts commit e6b93b0a68.
 2014-02-12 17:27:47 +05:30
Min Chen 5854c0bbeb Fix Path cannot be null error in creating ACL Policy. 2014-02-11 22:45:57 -08:00
Min Chen 97ec3f6628 Fix an AclEntityType cast bug. 2014-02-11 22:26:52 -08:00
Girish Shilamkar e6b93b0a68 CLOUDSTACK-5674: Few fixes 2014-02-11 14:54:46 +05:30
Girish Shilamkar 995e3f5b5d Revert "CLOUDSTACK-5674: Few new fixes" 
This reverts commit 3493f17bad.
 2014-02-11 12:36:07 +05:30
Girish Shilamkar 3493f17bad CLOUDSTACK-5674: Few new fixes 2014-02-09 16:04:31 -05:00
Marcus Sorensen ce6539bd43 add new devcloud-kvm config 2014-02-09 00:20:01 -07:00
Marcus Sorensen df77c4310a CLOUDSTACK-6103: Pass VM iso information along with 
PrepareForMigrationCommand, so that destination hypervisor can
mount pool. This further exposed an issue for KVM where iso
was not getting cleaned up upon successful migration, fixed as well.
 2014-02-14 00:34:48 -07:00
Brian Federle 63c22a1508 Session expire: show overlay on dialog to prevent clicking in UI 2014-02-13 15:06:09 -08:00
Brian Federle 0ea93d6904 Form dialog UI: Support on cancel action 
If args.cancel is passed to createForm widget, call it when cancel button is
clicked.

Example:

createForm: {
    cancel: function() { ... },
    ...
}
 2014-02-13 14:33:53 -08:00
Daan Hoogland 8e4d020cf8 remove nic with dhcp and tests 
Signed-off-by: Alena Prokharchyk <alena.prokharchyk@citrix.com>
 2014-02-13 10:39:02 -08:00
Jayapal 3136401d40 CLOUDSTACK-6083 corrected firewall rule cidr load issue 2014-02-13 14:42:38 +05:30
Marcus Sorensen b77b55f040 CLOUDSTACK-6089: Use resource tag's key to determine match in 
equals() method for ResourceTagResponse
 2014-02-12 17:00:10 -07:00
Marcus Sorensen 7064972997 Fix someone's broken push due to bad checkstyle (VMwareGuru.java unused imports) 2014-02-12 16:26:33 -07:00
Marcus Sorensen d33798f0d9 CLOUDSTACK-6089: Implement equals() method for ResourceTagResponse 
so that the java Set can properly determine if a ResourceTagResponse
is unique. This ensures we don't get duplicate resource tags showing
up any time a UserVmResponse is crafted (which can be quite often
due to the way the responses are crafted).
 2014-02-12 16:10:48 -07:00
Likitha Shetty 9f597ef130 CLOUDSTACK-6056. Enabling static NAT rule for a portable public IP fails with error "Failed to enable static nat". 
router.extra.public.nics isn't being honoured and so when an ip that is acquired from the additional VLAN range
is being configured it failed.
 2014-02-12 15:53:45 +05:30
Gaurav Aradhye 9174020d9a CLOUDSTACK-6066: Improved migration code to handle scenarios 
according to hypervisor type
 2014-02-12 10:04:39 +05:30