Commit Graph

8220 Commits

Author SHA1 Message Date
santhosh 32124df53c Added fix for CLOUDSTACK-6548
Signed-off-by: santhosh <santhosh.edukulla@gmail.com>
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-05-09 17:07:36 +02:00
Daan Hoogland 703e9f6f46 Revert "CLOUDSTACK-3272 Fixing NullPointerException for alerts"
This reverts commit 882bf079fa.
2014-05-09 13:24:32 +02:00
Murali Reddy 645f165429 CLOUDSTACK-6593: Connectivity service capabilites should be matched with
the provider only if at least one capability is specified

Fix avoids the check, and only if the createNetworkOffering
'StrechedL2'Subnet' capability is specified then it should match against
'Connectivity' service provider
2014-05-09 12:10:12 +02:00
Alena Prokharchyk d9b4b87c5c CLOUDSTACK-6601: added "forDisplay" parameter to listLoadBalancerRules API 2014-05-09 10:17:57 +02:00
Daan Hoogland 9450205f77 Revert "CLOUDSTACK-6485: private gateway network should not be associated with vpc"
This reverts commit 90600f1bdf.
2014-05-08 11:32:20 +02:00
sonal.ojha 882bf079fa CLOUDSTACK-3272 Fixing NullPointerException for alerts
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-05-08 11:13:05 +02:00
Alena Prokharchyk a3825f126f CLOUDSTACK-6596: UUID and display flag update support for LBStickinessPolicy and LBHealthCheckPolicy 2014-05-08 09:48:27 +02:00
Alena Prokharchyk 4c9bf8a70f CLOUDSTACK-6595: call expunge method marked with @ActionEvent from expunge thread context. So the action even EXPUNGE.VM is generated when vm is expunged by the thread. 2014-05-07 23:14:04 +02:00
Prachi Damle 95efad359e CLOUDSTACK-6581: IAM - Shared Network -Root Admin user is allowed to deploy VM in a shared network that is scoped for a specific domain/account.
Changes:
- Strict access check in NetworkModel is needed as CS 4.3
- We cannot go through accountMgr since accountMgr is relaxed for rootAdmin
2014-05-07 09:21:30 +02:00
Alena Prokharchyk 8985b8badc CLOUDSTACK-6585: added missing metadata support for LBStickiness/LBHealthcheck policies 2014-05-07 09:20:16 +02:00
Kelven Yang 60ad928ce7 CLOUDSTACK-6586: Move EventBus hookup on job framework to ApiServer to decouple job framework away from business logic related hookups. The decoupling is done through internal messaging facility provided inside management server. 2014-05-07 09:17:32 +02:00
Rajani Karuturi c081cf7b1a CLOUDSTACK-6531: stopping the router in case of command failures. Also added alerts for failures.
Signed-off-by: Jayapal <jayapal@apache.org>
2014-05-06 17:48:53 +02:00
Jayapal 3c33577998 CLOUDSTACK-6578: Fixed issue in delete remote access vpn command 2014-05-06 17:48:11 +02:00
Jayapal ca270cbdf7 CLOUDSTACK-6577: Disable service monitoring in RVR 2014-05-06 17:47:39 +02:00
Sam Schmit 3a3457e713 CLOUDSTACK-6472 listUsageRecords: Pull information from removed items as well, fixing NPEs/Null UUIDs with usage API calls. 2014-05-06 17:46:20 +02:00
Sebastien Goasguen 352a9f8587 Review from pyr https://reviews.apache.org/r/20557/ 2014-05-06 17:45:56 +02:00
Tanner Danzey f8419b9303 CLOUDSTACK-5907, CLOUDSTACK-6396: KVM/RBD & KVM/CLVM volumes mistakenly shown as OVM, disables snapshotting
modified:   server/src/com/cloud/api/ApiDBUtils.java

Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-05-05 15:29:14 +02:00
Mike Tutkowski dd3076987f CLOUDSTACK-6170 Corrected an issue related to the "Reinstall VM" command and managed storage with VMware 2014-05-03 14:04:49 +02:00
Min Chen 71e0cff46e CLOUDSTACK-6568:API:createVolume: Volume gets created with wrong domain
ID.
2014-05-03 14:02:16 +02:00
Min Chen 1085695b5c CLOUDSTACK-6569: IAM - Regular user is able to listNetworks of another
user in the same domain , by passing account and domainId.
2014-05-03 00:44:25 +02:00
Alena Prokharchyk d17c299fb4 LOUDSTACK-6475: cleanupVPC task - removed the transaction wrapping up multiple VPC destroy as the destroy operation has external calls, to prevent long-locked transaction.
Reviewed-by: Prachi Damle
2014-05-02 23:27:42 +02:00
Min Chen 96cd858d97 CLOUDSTACK-6556: Deploy VM failing with error "does
not have permission to access resource Ntwk".
2014-05-02 18:53:47 +02:00
Min Chen 9f798823ef CLOUDSTACK-6556: [Automation] Deploy VM failing with error "does not
have permission to access resource Ntwk".
2014-05-02 18:53:22 +02:00
Min Chen 4ebde83519 CLOUDSTACK-6535: IAM:MS:API createVMSnapshot doesn't preserve access
rights.
2014-05-02 18:52:51 +02:00
Prachi Damle c4ab1d5772 CLOUDSTACK-6560: IAM - Admin user is denied permission to create Egress rule for a user's network
Changes:
- CS 4.3 handled Network entity in two ways:
a) Specified "UseNetwork" access and did a strict check w.r.t who can use this network. Regular users and Domain Admin went through the strict check. Root admin got access always.
b) Specified "null" access and that meant admins can access this network for the calling API that passes null access.

- Fixing CS 4.4 IAM to handle this behavior:
a) "UseNetwork" is mapped to "UseEntry" and IAM check will be done only for domain admin and regular users when this access is specified. Root Admin is grated access.
b) If "null" access is specified, root and domain admin both are granted access. Regular users still go through IAM.
2014-05-02 18:51:19 +02:00
Prachi Damle 33c3752d0e CLOUDSTACK-6558 IAM - Admin user is able to deploy VM in a regular user's Security Group.
Changes:
- Even for SecurityGroup, go through IAM to do permission checks for all type of accounts
2014-05-02 18:50:52 +02:00
Min Chen a3a0f13bb8 CLOUDSTACK-6513: remove commented code. 2014-05-01 10:38:05 +02:00
Min Chen 554cab8ea1 CLOUDSTACK-6513: templateFilter=shared should not show self-owned
template.
2014-05-01 10:37:46 +02:00
Prachi Damle c32b7ab7c8 CLOUDSTACK-6517: IAM - Admin is allowed to create PortFowarding rule for a regular user, when admin does not have " UseEntry" permission for IpAddress.
Changes:
- IAM was applying ordering on accessTypes. Thus if an account had Operate, he got USe access as well. So even if IAM schema did not have 'UseEntry" permission for IpAddress, some other 'OperateEntry' permission on IpAddress was letting this operation go through.
- Fixed IAM to NOT do ordering of access types anymore. IAm will perform strict accessType check only.
- This fix is needed so that admin does not get permission to USE resources from other account just becase he has OPERATE access on those resources due to some other APIs.

- However due to this fix, we break backwards compatibilty with CS 4.3.
- CS 4.3 allowed root admin to do the createPF operation for a user by passing in networkId of the user.
- Same was the case for domain admins within their domains
- Why this worked was due to CS 4.3 simply returning true for root admin/domain admin

- So to maintain backwards compatibilty, we are adding the logic to return "true" for root admin and domain admin just like CS 4.3.
- Exception is: For Network, AffinityGroup and Templates, we still call IAM even for root admin/domain admin, since thats what CS 4.3 did. Just for these 3 resource_types, it used to perform access checks even for root admin/domain admin.
2014-05-01 08:36:39 +02:00
Min Chen 683c242ed3 CLOUDSTACK-6513: Optimize code by removing deprecated utility to
QueryManagerImpl as private method just used for listTemplates and
listAffinityGroups to avoid misuse by new list APIs.
2014-04-30 10:40:39 +02:00
Min Chen 4f9b298817 CLOUDSTACK-6532:Affinity Groups - As admin user, not able to list all
affinity groups available for regular users by passing account and
domainId paramater. This is to revert IAM way of implementing
listAffinityGroupsCmd, will bring it back when we have implemented real
impersonation.
2014-04-30 10:39:43 +02:00
Min Chen 4ca65496c2 CLOUDSTACK-6513: IAM - Templates - When templates are listed with
templatefilter="shared" is used , we see public templates also being
included in the list. This commit reverts listTemplates behavior to 4.3
old logic without using consistent interpretation of list parameters
adopted in new IAM model.
2014-04-30 10:38:02 +02:00
Min Chen 2f35ef2f9b CLOUDSTACK-6512:IAM - Not able to list shared networks in the Vm
deployment flow. This commit is to revert
ec5ee761d9 to still use old logic for
listNetworks to keep old behavior instead of new IAM model.
2014-04-30 10:36:57 +02:00
Rajani Karuturi 69e550f5ea Fixed CLOUDSTACK-6509 Cannot import multiple LDAP/AD users into a cloudstack account
Conflicts:
	api/src/com/cloud/user/AccountService.java
	plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
	plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java

Signed-off-by: Koushik Das <koushik@apache.org>
2014-04-29 13:37:28 +02:00
Nitin Mehta 8eb903ba48 CLOUDSTACK-6530: Populate the first class entities in the context to be available for publishing more information for the event bus, checking the displayable property etc. 2014-04-29 13:30:38 +02:00
Daan Hoogland 90600f1bdf CLOUDSTACK-6485: private gateway network should not be associated with vpc
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-04-28 14:59:23 +02:00
Sanjay Tripathi b9c136d9aa CLOUDSTACK-6480: Creating Service Offering with Implict Dedication planner
fails with message:  "Please specify the pciDevice and vgpuType correctly".
2014-04-28 14:58:44 +02:00
Amogh Vasekar 9c572eeae1 In 4.3, SSL was turned off by default.
However, for SSVM, the value from configuration server overrides the default in Config.java. Work around is to change in global properties.

Local testing, checking a fresh install has the above property false by default.

Signed-off-by: Nitin Mehta<nitin.mehta@citrix.com>
(cherry picked from commit 05802004e2)
2014-04-26 13:42:09 +02:00
Mike Tutkowski 6b342ffce7 CLOUDSTACK-6170 Updated logic to more accurately calculate how much space is currently allocated for a managed storage pool 2014-04-25 22:23:54 +02:00
Nitin Mehta 2f96d430c8 CLOUDSTACK-6499:
Made changes so that uploading custom certificate works for ssvm.
    1. Reboot ssvm only when private key is passed meaning the server cert is passed. This is because while uploading the server cert is the last to be uploaded. And we want to propagate the entire chain once uploading is done.
    2. Change the SecStorageSetupCommand sent to ssvm so that it also carries the root cert apart from having the chain and the server cert and key.
    3. Change ssvm agent code to be able to configure root cert to the java key store.
    4. Change ssvm configure ssl script to insert the chain certs correctly.
    5. Fix order of chain certificates for apache webserver in SSVM
    6. Remove double encoding and decoding for uploadCustomCertificate API from UI and server code respectively, so that API call without UI works fine
    7. Java 1.7 - disable using SNI since copyTemplate doesnt work for SSL.
2014-04-25 22:03:46 +02:00
Alena Prokharchyk 35767d1ee9 CLOUDSTACK-6436: listResourceDetails - don't return entries set with display=false, by default 2014-04-25 22:00:17 +02:00
Prachi Damle 3d072b0d02 CLOUDSTACK-6458: IAM - When a domain is deleted , the group created for this domian is not removed.
Changes:
- When domain is deleted or is removed during account cleanup, send message to IAM to remove the domain group
2014-04-25 21:57:18 +02:00
Min Chen 2bba381a63 CLOUDSTACK-6501:IAM - DomainAdmin - When listVirtualMachines is used
with listall=true and account and domainId , Vms owned by the account
account is not listed.
2014-04-25 21:27:13 +02:00
Alena Prokharchyk dceaa7ccef Revert "Return isolation methods as a part of listPhysicalNetworks call"
This reverts commit eb877a093c.
2014-04-22 18:06:33 -07:00
Alena Prokharchyk eb877a093c Return isolation methods as a part of listPhysicalNetworks call 2014-04-22 14:46:34 -07:00
Min Chen b6617843d2 CLOUDSTACK-6468:IAM - Templates - Admin user is not allowed to edit
template and set isExtractable() paramater.
2014-04-21 17:53:04 -07:00
Sheng Yang 3578c7137f CLOUDSTACK-6047: Make aggregation command timeout configurable
In case some environments has different performance or we found some commands
would took too long to execute, one global configuration item is introduced to
specify "time out in seconds per one command in aggregation commands".

By default it's 3 seconds. If admin feel it's too long, it can be adjust to as
low as 1 seconds, which runs still well in my machine.
2014-04-18 23:27:12 -07:00
Min Chen 7821da66cc Fix findBugs bug. 2014-04-18 17:35:01 -07:00
Min Chen c3a4a01781 Fix listAccountsCmd logic to be consistent with new interpretation of
listAll, isRecursive and domainId parameters.
2014-04-18 16:58:03 -07:00
Alena Prokharchyk 4a518908a3 Fixed NPE in listResourceDetalis logic 2014-04-18 16:31:52 -07:00