Commit Graph

12697 Commits

Author SHA1 Message Date
Suresh Kumar Anaparti 68030df10b
VM start error handling improvements and config to expose error to users (#12894)
* VM start error handling improvements, and config to expose error to user

* refactor
2026-03-27 15:35:08 -03:00
Vishesh d38c1f8d12
Fix error message while creating local storage pool (#12767)
* Fix error message while creating local storage pool
2026-03-27 10:29:13 +05:30
Fabricio Duarte 2416db2a44
Fix NPE on external/unmanaged instance import using custom offerings (#12884)
* Fix NPE on external/unmanaged instance import using custom offerings
2026-03-27 10:25:16 +05:30
Abhisar Sinha b22dbbe2d7
Fix Revert Instance to Snapshot with custom service offering (#12885)
* Fix revertVM with custom svc offering
2026-03-27 10:19:52 +05:30
Suresh Kumar Anaparti 1bff543e58
Merge branch '4.22' 2026-03-27 01:25:42 +05:30
Nicolas Vazquez c1af36f8fc
[4.22] Prevent unmanaging or reinstalling a VM if it is part of a CKS cluster (#12800) 2026-03-26 18:17:49 +05:30
Suresh Kumar Anaparti 84676afd5c
Check for null host before proceeding with VM volume operations in managed storage while restoring VM (#12879) 2026-03-26 07:58:52 -03:00
Suresh Kumar Anaparti 7c3637a2f5
Fix duplicate dummy templates, and update guest os for dummy template (#12780)
* Fix duplicate dummy template 'kvm-default-vm-import-dummy-template' entries

* Update guest os id of dummy template to 99 (Other Linux (64-bit)) from existing id: 1 (CentOS 4.5 (32-bit))

* update migration path to remove duplicate dummy templates
2026-03-24 18:01:26 +05:30
Nicolas Vazquez 7107d28db8
[VMware to KVM] Add guest OS for importing VM based on the source VM OS (#12802) 2026-03-24 15:06:38 +05:30
Suresh Kumar Anaparti bce55945ec
Mark VMs in error state when expunge fails during destroy operation (#12749)
* Mark VMs in error state when expunge fails during destroy operation

* fetch volume by external id (used by external plugins)

* review comments

* Update reorder hosts log to DEBUG, log line is too verbose to have on as INFO
2026-03-24 00:29:14 -03:00
Abhisar Sinha c19630f0a4 Fix snapshot copy resource limit concurrency 2026-03-19 14:42:49 +05:30
Fabricio Duarte 8608b4edd0 Fix snapshot copy resource limit concurrency
Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com>
2026-03-18 01:52:36 -03:00
Fabricio Duarte f333134456 Address merge issues 2026-03-17 19:28:16 -03:00
Daniel Augusto Veronezi Salvador e8d57d1b0d Implement/fix limit validation for secondary storage 2026-03-17 18:56:28 +01:00
João Jandre 86c9f7bd94 Fix backup list 2026-03-17 17:14:38 +01:00
Fabricio Duarte 9db630932e Address public IP limit validations 2026-03-17 16:45:33 +01:00
Fabricio Duarte c6b20b8cc7 Fix failing tests 2026-03-17 15:51:45 +01:00
Fabricio Duarte 88a12a801f Cleanup imported VM from disk on failure due to volume allocation + prevent duplicate volume and primary storage increment on import 2026-03-17 15:50:26 +01:00
Manoj Kumar e93ae1a4f4
New config key "allow.import.volume.with.backing.file" to skip volume backing (#12809)
* Added support for skipping volume backing when importing unmanaged volumes and VMs. This allows users to import volumes and VMs without creating a backing volume, which can be useful in certain scenarios where the backing volume is not needed or desired.

* cleanup conflicting key

* move configkey into VolumeImportUnmanageService

---------

Co-authored-by: rajujith <rajujith@gmail.com>
2026-03-17 11:34:34 -03:00
Fabricio Duarte 9c0c8da706 [22.0] Address limit checks for VM, CPU, memory, volume, and primary storage 2026-03-17 15:10:33 +01:00
Pearl Dsilva 3bd5410f9a
Add support to clone existing offerings and update them (#12357)
* Add support to clone existing offerings and update them

* add support for vpc & backup offerings to be cloned

* fix capability list and mapping of params

* Add support to clone network and vpc offering with the right parameters

* make fields non mandatory for clone offerings APIs

* Add UI support for cloning Compute and System Service offerings

* remove unnecessary changes

* fix license and pre-ccommit issues

* Add UI support to clone disk and network offering

* vpc & backup offering clone api

* add unit tests

* fix pre-commit checks

* increase test coverage

* combine add/clone disk/compute offering forms

* update license

* fix unit tests

* fix test failures

* fix test failure - unnecessary stubbings

* pre-commit check failure

* add recently added domain id for bkp offering to be inherited in clone operation

* extract common code wrt service capability in network & vpc offering in add/clone operations

* add some checks to prevent networkmode change when provider is nsx/netris from the source networkmode

* address copilot comments

* address comments

* combine check

* use appropriate zoneId during clone bkp offering

* add check

* fix issue with test

* remove unused imports

* prevent creating a bkp offering of a bkp repo that already exists

* extend clone disk and service offerings to domain admins
2026-03-17 12:01:43 +05:30
Abhisar Sinha 61afb4cb78 fix identation 2026-03-16 17:40:24 +01:00
Abhisar Sinha 23b19a9776 review comments 2026-03-16 17:40:24 +01:00
Fabricio Duarte dc7068a135 Address public IP limit validations 2026-03-16 11:47:32 +01:00
Fabricio Duarte e8f8aca694 Fix failing tests 2026-03-16 11:47:32 +01:00
Fabricio Duarte 497266270b Cleanup imported VM from disk on failure due to volume allocation + prevent duplicate volume and primary storage increment on import 2026-03-16 11:47:32 +01:00
Fabricio Duarte 0a4b4c6af0 [20.3] Address limit checks for VM, CPU, memory, volume, and primary storage 2026-03-16 11:47:32 +01:00
Fabricio Duarte 360b64ce1e Consider infinite resources when calculating secondary storage limit for upload operations 2026-03-16 11:47:32 +01:00
Abhisar Sinha 81a8ac8e1f secondary storage resource limit for upload 2026-03-16 11:47:32 +01:00
abh1sar 03dfe4d1f3 secondary storage resource limit for download 2026-03-16 11:47:32 +01:00
Abhisar Sinha 4bcd509193 Fix resource limit reservation and check during StartVirtualMachine 2026-03-16 11:47:32 +01:00
Daniel Augusto Veronezi Salvador 06ee2fea76 Implement/fix limit validation for secondary storage 2026-03-16 11:47:32 +01:00
dahn e0ef3a6947 Check resource reservation on volume snapshot creation 2026-03-16 11:47:32 +01:00
dahn b025e85fc5 Check resource reservation on volume creation 2026-03-16 11:47:32 +01:00
dahn 7faa1b650b [20.3] resource allocation vpc 2026-03-16 11:47:32 +01:00
dahn 1593944553 [20.3] Implement/fix limit validation for projects 2026-03-16 11:47:32 +01:00
dahn 4dd91feb27 [20.3] resource instance limits 2026-03-16 11:47:31 +01:00
dahn 89df318164 [20.3] resource allocation 2026-03-16 11:47:31 +01:00
Nicolas Vazquez 93239e09f1
Add conserve mode for VPC offerings (#12487) 2026-03-16 09:39:42 +01:00
Nicolas Vazquez 09ee0927e9
[4.22] Prevent Load Balancer rule creation when adding a VM from a different network (#12785) 2026-03-16 09:36:52 +01:00
Daman Arora 8c579538f9
CKS: Allow affinity group selection during cluster creation (#12386)
Co-authored-by: Daman Arora <daman.arora@shapeblue.com>
2026-03-13 10:58:55 +01:00
Abhisar Sinha f7f0e75122 Fixed a merge issue in ImageStoreUploadMonitorImpl 2026-03-13 15:19:28 +05:30
Fabricio Duarte 07c3dc86b2 [22.0] Consider infinite resources when calculating secondary storage limit for upload operations 2026-03-13 10:37:04 +01:00
Abhisar Sinha d722415105 [22.0] secondary storage resource limit for upload 2026-03-13 10:15:55 +01:00
abh1sar 4855d40e6e [22.0] secondary storage resource limit for download 2026-03-13 10:01:41 +01:00
Klaus de Freitas Dornsbach 74af9b9875
API key pair restructure (#9504)
Co-authored-by: Bernardo De Marco Gonçalves <bernardomg2004@gmail.com>
2026-03-09 14:20:17 +01:00
Abhishek Kumar c3d6a8cff7
server: fix templatetype during iso upload (#12151) 2026-03-09 14:20:28 +05:30
GaOrtiga 7ad68aafa5
Enable defining a network as redundant during restart through the UI (#7405)
Co-authored-by: Gabriel <gabriel.fernandes@scclouds.com.br>
Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
2026-03-04 17:00:54 +01:00
Suresh Kumar Anaparti 75620309c2
Merge branch '4.22' 2026-03-04 21:13:01 +05:30
Suresh Kumar Anaparti 65e54091ff
Merge branch '4.20' into 4.22 2026-03-04 21:12:15 +05:30
Suresh Kumar Anaparti 56dc11980f
test_accounts.py failure fix - keep the camelCase parameter "domainId" (#12689) 2026-02-27 11:36:18 +01:00
Suresh Kumar Anaparti da85858e93
unit test fix (after merge) 2026-02-26 12:01:15 +05:30
Suresh Kumar Anaparti a8bd02f8ba
Merge branch '4.22' 2026-02-26 11:12:20 +05:30
Suresh Kumar Anaparti b74f21b967
Merge branch '4.20' into 4.22 2026-02-26 11:11:41 +05:30
Erik Böck c748b69e70
Fix NPE during public IP listing when a removed network or VPC ID is informed for associatenetworkid parameter (#12372) 2026-02-23 13:03:36 +01:00
Erik Böck d0543449a6
Changes to the error message displayed during the removal of public templates that are used (#12373) 2026-02-23 11:21:04 +01:00
dahn da7ac80dc4
prevent user.uuid from being regenerated on each operation by reading it from the DB (#12632) 2026-02-23 11:12:13 +01:00
Abhishek Kumar 95816b44e9 extensions: allow reserved resource details
Adds a new request parameter for create/updateExtension API to allow
operator to provide detail names for the extension resources which will be reserved to be used by the extension. The end user won't be able to view or add details with these details names for the resource.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-02-22 18:08:03 +01:00
Daniel Augusto Veronezi Salvador d11d182c71 [22.0] Fix resource limit reservation and check during StartVirtualMachine 2026-02-22 18:05:20 +01:00
Daniel Augusto Veronezi Salvador 3d678e726a [22.0] resource reservation on volume snapshot creation 2026-02-22 17:23:39 +01:00
Daniel Augusto Veronezi Salvador 1f849caa0b [22.0] resource reservation on volume creation 2026-02-22 16:17:26 +01:00
Daniel Augusto Veronezi Salvador 831ef82ff9 [22.0] resource allocation vpc 2026-02-22 16:02:14 +01:00
Daniel Augusto Veronezi Salvador 8d269cf5be [22.0] Implement/fix limit validation for projects 2026-02-22 16:01:34 +01:00
Daniel Augusto Veronezi Salvador 003c840817 [22.0] resource instance limits 2026-02-22 15:42:31 +01:00
Daniel Augusto Veronezi Salvador 37e3657770 [22.0] resource allocation 2026-02-22 15:41:13 +01:00
Suresh Kumar Anaparti 30e6c224bd
Merge branch '4.22' 2026-02-19 13:20:04 +05:30
Suresh Kumar Anaparti 5caf6cd043
Merge branch '4.20' into 4.22 2026-02-19 13:19:14 +05:30
Suresh Kumar Anaparti 9dd93cef76
Support for custom SSH port for KVM hosts from the host url on add host and the configuration (#12571) 2026-02-18 20:05:51 +01:00
Suresh Kumar Anaparti 8c12a13216
Fix NPE during reset password (#12585) 2026-02-18 20:03:36 +01:00
Daan Hoogland a7dc5efad5 Merge release branch 4.22 to main
* 4.22:
  Fix issue when restoring backup after migration of volume (#12549)
  Usage: Heartbeat should not schedule usage job when a job is already running (#12616)
  Allow limit queries without random ordering (#12598)
  engine/schema: fix cluster/zone settings with encrypted values (#12626)
  Fix injection of preset variables into the JS interpreter (#12515)
  Fix issue with multiple KVM Host entries in host table (#12589)
  Add a Prometheus metric to track host certificate expiry (#12613)
  ssvm: delete temp directory while deleting entity download url (#12562)
2026-02-17 11:55:04 +01:00
Daan Hoogland 11df71e55c Merge branch '4.20' into '4.22' 2026-02-17 11:53:08 +01:00
Manoj Kumar c79b33c1fb
Allow enforcing password change for a user after reset by admin (root/domain) (#12294)
* API modifications for passwordchangerequired

* ui login flow for passwordchangerequired

* add passwordchangerequired in listUsers API response, it will be used in UI to render reset password form

* cleanup redundant LOGIN_SOURCE and limiting apis for first time login

* address copilot comments

* allow enforcing password change for all role types and update reset pwd flow for passwordchangerequired

* address review comments

* add unit tests

* cleanup ispasswordchangerequired from user_view

* address review comments

* 1. Allow enforcing password change while creating user
2. Admin can enforce password change on next login with out resetting password

* address review comment, add unit test

* improve code coverage

* fix pre-commit license issue

* 1. allow enter key to submit change password form
2. hide force password reset for disabled/locked user in ui

* 1. throw exception when force reset password is done for locked/disabled user/account
2. ui validation on current and new password being same
3. allow enforce change password for add user until saml is not enabled

* allow oauth login to skip force password change
2026-02-16 16:01:42 +05:30
Pearl Dsilva ae5308bdd2
Fix issue when restoring backup after migration of volume (#12549) 2026-02-13 15:14:58 +01:00
Fabricio Duarte 34f6f413a1
Fix injection of preset variables into the JS interpreter (#12515) 2026-02-11 16:12:09 +01:00
Nicolas Vazquez b7c970f45f
Fix issue with multiple KVM Host entries in host table (#12589) 2026-02-11 13:47:21 +01:00
Daan Hoogland d3e1976912 Merge release branch 4.22 to main
* 4.22:
  Fixes issue with loading Capacity dashboard when mulitple backup providers configured (#12550)
2026-02-09 13:06:28 +01:00
Daan Hoogland 7324ef45d4 Merge branch '4.20' into 4.22 2026-02-09 13:05:08 +01:00
Pearl Dsilva a0f35a186d
Fixes issue with loading Capacity dashboard when mulitple backup providers configured (#12550) 2026-02-09 12:12:28 +01:00
Daan Hoogland e929f2024a Merge branch '4.22' 2026-02-05 16:07:46 +01:00
Daan Hoogland cd6a8f61ca Merge branch '4.20' into 4.22 2026-02-05 15:32:36 +01:00
Erik Böck e32d08e50e
Create new generic method for resource UUID obtention in event's descriptions (#12502) 2026-02-05 11:23:40 +01:00
Abhisar Sinha 9ae696d1c8
Preserve VM settings on Instance Snapshot revert for Custom Service Offering (#12555) 2026-02-03 14:15:09 +01:00
Suresh Kumar Anaparti ce42ce54c2
Fix template details deletion while updating template from UI (#12559)
* Fix template details deletion while updating template from UI

* update the latest template details before submit
2026-02-03 14:21:43 +05:30
Wei Zhou b869913529
noVNC: support Spanish Latin American keyboard on VMware (#12484)
* noVNC: support Spanish Latin American keyboard

* Update server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
2026-02-02 15:16:54 +05:30
Suresh Kumar Anaparti a5b6bc3be6
Merge branch '4.22' 2026-01-30 21:15:58 +05:30
Suresh Kumar Anaparti 30d306622a
Merge branch '4.20' into 4.22 2026-01-30 21:15:21 +05:30
Suresh Kumar Anaparti 6bed3d4e64
Update storage usage / size in backup usage response (#12539) 2026-01-30 13:45:59 +01:00
Abhishek Kumar 18972caf5f
api,server: allow cleaning up vm extraconfig (#11974) 2026-01-30 13:54:01 +05:30
Dattu bac3421da4
Fixed: unnecessary regeneration of SSH keys in developer mode when they already existed. (#12059) 2026-01-30 08:42:41 +02:00
Abhishek Kumar bb8e7d39e6
api,server: allow configuring repetitive alerts (#11325)
* api,server: allow configuring repetitive alerts

Fixes #6613

Introduces support for configuring additional alert types that can be published repeatedly, beyond the default set.

Operators can now use the dynamic configuration `alert.allowed.repetitive.types` to specify a comma-separated list of alert type names that should be allowed for repetitive publication.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* add tests

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* test fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* allow repetition for custom alerts

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* remove refactoring

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

---------

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-01-30 08:41:25 +02:00
Suresh Kumar Anaparti ffb8b91ff5
Merge branch '4.22' 2026-01-29 19:42:07 +05:30
Suresh Kumar Anaparti f5778eaa32
Merge branch '4.20' into 4.22 2026-01-29 19:41:29 +05:30
Fabricio Duarte 7d52cd0e43
Fix calculation of the next time that Usage will execute in `removeRawUsageRecords` (#12518)
* Fix calculation of the next time that Usage will execute in `removeRawUsageRecords`

* Address copilot reviews
2026-01-29 15:38:12 +02:00
Wei Zhou aef3df7577
server: pass network label of physical network when plug nic for private gateway on hypervisor (#11846) 2026-01-29 14:47:08 +02:00
Abhishek Kumar 3626c515e8
server: fix listing resource limits (#12188) 2026-01-29 12:36:16 +01:00
Suresh Kumar Anaparti a55f85af50
Merge branch '4.22' 2026-01-29 15:55:03 +05:30
Suresh Kumar Anaparti d700e2db64
Merge branch '4.20' into 4.22 2026-01-29 15:51:58 +05:30
Bernardo De Marco Gonçalves c681d0d0a2
Change `vmsnapshot.max` setting scope to the account level (#11616) 2026-01-29 10:01:54 +01:00
Suresh Kumar Anaparti 26b57655ec
Deployment plan fixes for VM with last host, and last host in maintenance (#12062)
* Deployment plan fixes for VM with last host
- Consider last host when it is not in maintenance
- Fail deployment when user requests for last host consideration and last host doesn't exists or in maintenance

* changes

* msg update with vm/host name

* address comments

* Exclude last hosts with error or degraded state as well, for vm deploy

* review changes
2026-01-29 10:29:41 +02:00
Nicolas Vazquez 664f76c7e4
Fix KvmSshToAgentEnabled setting description and make it dynamic (#12533) 2026-01-29 09:24:58 +01:00