1f3d02b38a
Reverting the changes done to this file for coverity fixes
2014-07-10 23:35:27 +05:30
61fe959bb4
Removed invalid assertions from code. Now the MS can be run with assertions enabled (using -ea flag)
2014-07-10 12:18:29 +05:30
d51e8f44ae
CLOUDSTACK-7079: Fixed the issue where rollback was called after commit. As well, added few null checks
2014-07-09 15:58:43 +05:30
4f969057b2
CLOUDSTACK-7030. After the restart of MS in a clustered MS pool, not all hung worker VMs are recycled.
...
Recycle worker VMs that originally belonged to other management servers too because in case of MS restart, the owner MS might change.
2014-07-07 13:38:47 +05:30
a600d8408e
Fixed Resource Leaks, null dereferences, few other issues reported by coverity
2014-07-04 16:17:58 +05:30
b2283d7a28
Fixed few resource leaks and added secstoragefirewallcfg command support to simulator
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-06-24 23:19:47 +02:00
1c80185170
Fixed Resource Leaks, null dereferences, invalid value comparisons, invalid result set loop
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-06-21 12:38:46 +02:00
0c28f36ff1
Fix a number of resource leaks reported by Coverity
2014-06-13 14:42:35 +02:00
25580c7cd1
CLOUDSTACK-6859:Management Server PermGen run out of memory after some
...
time due to class leak.
2014-06-06 23:57:26 -07:00
20a31b43d6
CLOUDSTACK-6784: Expose data types via API so consumers of API can validate data
2014-05-27 15:23:23 -06:00
2a5bf65c78
CLOUDSTACK-6785: Allow async jobs to supply an injectedjobid
2014-05-27 15:23:02 -06:00
ba848087f8
Disable IAM feature from 4.4 release.
2014-05-22 18:27:08 -07:00
09ec127470
CLOUDSTACK-6743: Use edge-triggering in MessageDetector to handle bogus wakeup gracefully. Level triggering plus bogus wakeup can cause a tight loop to spin
2014-05-21 16:17:39 -07:00
6f2a193b7c
CLOUDSTACK-6720: Async job events are not published on event bus
...
fix ensures publishOnEventBus() is called on submit, update, complete
phase of job procesing
2014-05-20 17:13:58 +05:30
521ac796dd
Move EventBus hookup on job framework to ApiServer to decouple job framework away from business logic related hookups. The decoupling is done through internal messaging facility provided inside management server.
2014-05-06 15:48:22 -07:00
1d45b75298
CLOUDSTACK-6499:
...
Made changes so that uploading custom certificate works for ssvm.
1. Reboot ssvm only when private key is passed meaning the server cert is passed. This is because while uploading the server cert is the last to be uploaded. And we want to propagate the entire chain once uploading is done.
2. Change the SecStorageSetupCommand sent to ssvm so that it also carries the root cert apart from having the chain and the server cert and key.
3. Change ssvm agent code to be able to configure root cert to the java key store.
4. Change ssvm configure ssl script to insert the chain certs correctly.
5. Fix order of chain certificates for apache webserver in SSVM
6. Remove double encoding and decoding for uploadCustomCertificate API from UI and server code respectively, so that API call without UI works fine
7. Java 1.7 - disable using SNI since copyTemplate doesnt work for SSL.
2014-04-24 17:27:02 -07:00
da13165743
Change AccountManagerImpl.checkAccess to invoke SecurityChecker
...
interface that takes multiple controlled entities.
2014-04-17 17:53:01 -07:00
c031eb7d38
CLOUDSTACK-6242: exception handling improvements
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-04-15 08:07:15 +02:00
cd8801f6f7
Do app-level iteration to avoid mysql deadlocks
2014-04-02 15:46:50 -07:00
66486d4322
BUG-ID: CS-19697: Deal with possible DB deadlock issue, return the job into queue for next turn
2014-04-02 14:59:04 -07:00
b6cc6dd8e3
CLOUDSTACK-6305: protect lock leaking from unhandled exception
2014-03-28 15:30:07 -07:00
54c83c168f
removed redundant Integer instantiation in GenericDaoBase
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-28 18:40:25 +01:00
8b62b2cb92
findbugs: exclude known spiffy hacks a.k.a. false positives
2014-03-28 14:28:10 +01:00
ec01791936
Fix the missing java imports from automatic merge
2014-03-14 14:22:23 -07:00
12f7cbcb76
Deal with concurrent state update for VM and Host objects.
2014-03-14 14:07:39 -07:00
4402685e11
Update master to 4.5.0-SNAPSHOT
2014-03-14 14:55:26 +01:00
5310e66f30
Do not use row lock in sync-queue scheduling to work around mysql locking issues.
2014-03-13 16:59:56 -07:00
8e27120be4
Seperate job executor pools to avoid thread starvation situation.
2014-03-13 16:59:56 -07:00
84a528fad6
Merge branch 'master' into rbac
2014-03-13 14:52:37 -07:00
90c485e5d6
Fixed some problems reported by FindBugs
2014-03-13 13:45:30 -07:00
48e08fe676
Merge branch 'master' into rbac.
2014-03-06 14:02:20 -08:00
5dd4fb22ef
Remove cancelled jobs from job monitoring, correct mis-calculated time-unit in job cancellation.
2014-03-03 17:44:58 -08:00
b21662f890
make sure XS report VM state even if there is no running VM on the host.
2014-02-28 15:35:59 -08:00
537bf7ced1
add job path to help associate an API job to related internal job. Reviewed-By: Self
2014-02-28 15:35:59 -08:00
a8c9238d3d
CLOUDSTACK-6065: Fix NPE problem caused by the lack of context setup in threads from agent manager thread pool
2014-02-28 15:35:59 -08:00
441be43b8c
CLOUDSTACK-5358: Bring back concurrency control in sync-queue management
2014-02-28 15:35:57 -08:00
a0f932437c
Move mysql ha strategy to a plugin. Activate this plugin using the mysqlha profile or the noredist flag
2014-02-27 09:51:02 +01:00
ac00ab0087
Cleanup all mysql dependencies and set all to provided.
2014-02-21 14:55:11 +01:00
19b15a1bdc
Fix parameter index in getCount function.
2014-02-20 15:13:29 +01:00
f1139848e5
Slight optimization, don't run checkstyle on container or non-java projects.
2014-02-18 12:24:11 +01:00
443acac927
Fix functional issue introduced by some findbug changes.
2014-02-14 18:37:47 +01:00
97bad4f9b3
Fix checkstyle and license issues
2014-02-14 18:37:47 +01:00
cbea6d26e8
Fix and test GroupBy SQL query creation
...
Signed-off-by: Ian Southam <isoutham@schubergphilis.com>
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
5a6ad11fa2
findbugs findings
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
e0de79b170
Resource metadata: by default, all metadata is set with display=true (meaning that the detail is avaialble for display to the regular user). If admin wants to set a specific detail to be false, he has to specify it explicitly in addResourceDetail command
2014-02-10 12:05:59 -08:00
f84375442e
Merge branch 'master' into rbac
...
Conflicts:
api/src/org/apache/cloudstack/api/command/user/autoscale/ListAutoScaleVmProfilesCmd.java
api/src/org/apache/cloudstack/api/command/user/volume/ResizeVolumeCmd.java
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
server/src/com/cloud/api/ApiServer.java
server/src/com/cloud/api/query/QueryManagerImpl.java
server/src/com/cloud/template/TemplateAdapterBase.java
setup/db/db/schema-430to440.sql
tools/apidoc/gen_toc.py
2014-02-04 12:07:32 -08:00
dea320f7b9
RAT fix
...
added license header to test
2014-01-25 20:50:14 +01:00
e4da3775c9
removed redundant Long, Short, Double, Float and Boolean instantiations
...
- Added unit tests
- Added javadoc
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-01-25 20:09:45 +01:00
33cd1ab921
Merge branch 'master' into rbac
2014-01-22 11:23:51 -08:00
7ab3e277c4
Cosmetics
2014-01-22 10:11:20 +01:00
a0197006ef
Removed "host" config parameter definition from ClusterManager interface as it got moved to cloud-api package
2014-01-21 17:19:52 -08:00
929fbabaa2
Merge branch 'master' into rbac.
2014-01-17 14:37:08 -08:00
a9733b5df2
CLOUDSTACK-5731: Use general instance type to categorize VM work jobs to correctly serialize VM operations
2014-01-17 11:55:14 -08:00
14e399410b
CLOUDSTACK-5696: fix a regression caused by out-of-band sync changes
2014-01-15 16:22:27 -08:00
7164fc6e73
CLOUDSTACK-5696: Fix sync issue with out-of-band changes
2014-01-15 13:11:02 -08:00
68b8891c62
Removed all reminants of the IdentityService. Created the KeysManager to move the management
...
of keys out of management server
2014-01-14 13:11:35 -08:00
bae498c89e
Handle search of those entities without db view created using new ACL
...
model.
2014-01-13 21:55:56 -08:00
bc1eec9f70
Fixed a missing package name
2014-01-09 16:48:19 -08:00
5fb6edd684
Changed the package to name to org.apache.cloudstack
2014-01-09 16:12:26 -08:00
ae8560b195
Moved security out into its own jar. Will be adding more to it. Fixed a few white space issues brought up by checkstyle in eclipse.
2014-01-09 16:12:25 -08:00
a05d71a80c
CLOUDSTACK-5752: Use pesudo job context when API dispather directly calls into orchestration flow
2014-01-09 14:29:13 -08:00
87381d4236
CLOUDSTACK-5725: put origin flow context id into log4j context prefix to link jobs with the orchestration work flow in logging
2014-01-09 14:29:12 -08:00
69f49839d3
CLOUDSTACK-5726: Using runtime discovered dao (in AsyncJobManagerImpl.submitAsyncJob) to persist record has a problem to locate the right DAO instance, it causes corrupted field value be stored in database. Put in a work-around fix first to always initialize record fields in all cases
2014-01-09 14:29:12 -08:00
832c8e4728
CLOUDSTACK-5669: Always retrieve the most recent job result in OutComeImpl
2014-01-09 14:29:12 -08:00
bf9a554522
CLOUDSTACK-669: covert VMsnapshot orchestration flows to make them be serialized with other VM operations
2014-01-09 14:29:12 -08:00
fd0fabd3e2
CLOUDSTACK-5551: Search not working for Configuration parameters in (Account/zone/cluster/storage) settings page
...
Added filters while listing scoped configuration parameters.
Fixed: Some parameters are missing from UI settings tab because of missing scope entry in configuration table.
Signed-off-by: Koushik Das <koushik@apache.org>
2014-01-02 16:18:21 +05:30
9190b03056
CLOUDSTACK-5457: DBHA features is broken due to RuntimeException thrown from underlying layer. Fixed my catching in ClusterManagerImpl
...
Signed-off-by: Koushik Das <koushik@apache.org>
2013-12-19 17:07:13 +05:30
3c965d0685
CLOUDSTACK-669: convert volume attach/detach flows to make them be serialized with other VM operations
2013-12-18 16:14:07 -08:00
55a6df4501
Resources leaks, refactoring and testing
...
Removing resource leaks from UsageSanityChecker and
refactoring it (encapsulation, removal of copy and paste, constants...)
Modularize static method for closing Statments in TransactionLegacy
and reusing this new method from other classes (Upgrade2214to30)
Create Unit and Integration Tests for UsageSanityChecker
Add DBUnit cases and integration profile for nitegration tests as
a base for future DB tests
2013-12-18 10:55:04 +01:00
be5e5cc641
All Checkstyle problems corrected
2013-12-12 12:26:07 -08:00
26c1ba296c
CLOUDSTACK-669: put user vm work under new vmsync model
2013-12-11 16:29:59 -08:00
79a7ce871e
make SDN GRE work with XCP 1.6
2013-12-09 23:33:14 +07:00
226b193488
Fix for Coverity issues CID_1116744, CID_1116718 and CID_1116682, all related to resource leak
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2013-11-27 14:20:29 +01:00
d19688103b
Fixing coverity issues related to resource leak on FileInputStream being created anonymously
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2013-11-27 12:51:44 +01:00
433a631916
Reformat of source code to set a stable base for the future. I couldn't get checkstyle enabled. There's still about a thousand errors from checkstyle. Most of it from length errors from comments and strings. Will attempt to remove those tonight. This change is so large I just want to get it in before any merge nightmares. The changes are fairly minor though and I did a full compile and start a server with the reformat code.
2013-11-21 07:56:47 -08:00
cf715ff491
Bump 4.3.0 to 4.4.0 in master
2013-11-21 16:01:15 +01:00
d620df2bdd
Reformatted all of the code.
2013-11-21 06:15:26 -08:00
eaa250fd3c
Formatted again after all the tab expansions and eol removals
2013-11-21 04:47:01 -08:00
224f479974
Removed trailing spaces
2013-11-21 04:08:01 -08:00
e4b22d0fca
Replace all tabs, particularly the ones in the comments
2013-11-21 03:39:58 -08:00
62e9273581
Removed trailing spaces
2013-11-21 03:12:05 -08:00
278ef81a83
side-by-side VM sync management at manager level
2013-11-20 17:59:38 -08:00
8d62744681
Reformat all source code. Added checkstyle to check the source code
2013-11-20 07:26:53 -08:00
065e5afa08
Tests for DBUtil
...
This patch adds test for the lock management:
- getGlobalLock
- releaseGlobalLock
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2013-11-16 15:44:31 +01:00
c29cd9d3c7
CLOUDSTACK-4835: Update global configuration test cases failed in master Changes made in update/list configuration API to use ConfigDepot
...
CLOUDSTACK-4169: Scoped configuraion parameters logic moved to ConfigDepot
CLOUDSTACK-5163: missing parameters in configuration table
2013-11-15 12:19:31 +05:30
67fc2f53e2
CLOUDSTACK-4916: Fixing the issue with DB HA when there are more than 2 db nodes (Issue was mysql DriverManager was returning salve db nodes on random basis which was causing issue)
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-11-14 11:10:48 +05:30
5420cbe981
added license header
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2013-11-12 08:09:37 +01:00
f629d405eb
Test for DbUtil
...
test cases for
- isPersistable
- getColumnName
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2013-11-10 23:24:01 +01:00
dcd3c44279
CLOUDSTACK-4916: To Enable Master High Availability using mysql connector params and mysql's 2 way replication
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2013-11-08 16:18:14 +05:30
dc3d279272
CLOUDSTACK-4833:[Automation][BVT] Template and ISO test cases failing
...
from BVT suite, during LIST api call.
2013-11-07 15:19:19 -08:00
5cb3cd64e5
Fix CID 1116741,1116742 Resource leak
2013-11-07 16:23:20 +01:00
24c0513eea
Add servlet filter class that is compatible with the Spring Modularization
2013-11-06 15:24:44 -07:00
191dc80fa4
VM power state for job oritented sync processing
2013-11-05 19:00:37 -08:00
80813375ae
Allow disabling modules and extensions from module.properties
...
Discovery of modules is based on classpath scanning. In some situations it
may not be possible or desirable to change the classpath. To force a
module to not load you can create a file called modules.properties on the
classpath that can exclude specific modules from loading. Additionally
this same file can be used to exclude a specific extension. Extension
loading is typically done through global configuration. If you want to set
up an environment and you don't even want the extension/module loaded on
the first start, then using the config file is appropriate.
Example: modules.properties
modules.exclude=storage-image-s3,storage-volume-solidfire
extensions.exclude=ClusterScopeStoragePoolAllocator,ZoneWideStoragePoolAllocator
Typically you would want to place this file in /etc/cloudstack/management
2013-11-05 11:03:06 -07:00
78b1ac4126
CLOUDSTACK-3868: fixed "count" param in listUsageRecords API to return the actual number of records matching the search criteria. Used to return the wrong value - the number of records per page
...
Conflicts:
server/src/com/cloud/usage/UsageServiceImpl.java
utils/src/com/cloud/utils/db/GenericDaoBase.java
2013-10-31 15:25:57 -07:00
afaf6370dd
Fix change that broke db.properties.override
2013-10-31 09:21:34 -07:00
1460196496
Centralize loading of db.properties to one place
...
There is now a method DbProperites.getDbProperties() that will load the
db.properties in one place and do the proper decryption of values if needed
2013-10-30 17:03:13 -07:00
dbaa818d1e
InputStream use fix
...
Closes the FileInputStream opened at configuration in
- ClusterManagerImpl
- ClusterServiceServletAdapter
- TransactionLegacy
- AsyncJobManagerImpl
- DBEncryptionUtil
- EncryptionSecretKeyChecker
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2013-10-26 17:47:34 +02:00
891b85d516
Add missing licenses
2013-10-23 15:20:08 -07:00
76c22eae5b
Update to use new Transaction API
2013-10-23 11:23:18 -07:00
Santhosh Edukulla
Koushik Das
Likitha Shetty
Hugo Trippaers
Min Chen
Marcus Sorensen
Kelven Yang
Murali Reddy
Nitin Mehta
Ding Yuan
Laszlo Hornyak
Daan Hoogland
Alena Prokharchyk
Antonio Fornie
Ian Southam
Prachi Damle
Alex Huang
Harikrishna Patnala
Damodar Reddy
tuna
wilderrodrigues
Darren Shepherd