Commit Graph

36795 Commits

Author SHA1 Message Date
Wei Zhou fadd74aaca
network: fix vm can be deployed on L2 network of other accounts (#5784)
* Update #5769: fix domain admin can deploy vm on L2 network of other users

* test: fix test_storage_policy.py

* Update #5784: revert part of changes in #2420
2022-01-11 12:16:00 +05:30
dahn 028d338aaa
remove VmWorkJob after adding a nic to a vm (#5658)
Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>
Co-authored-by: Wei Zhou <weizhou@apache.org>
2022-01-10 16:31:50 +01:00
Hoang Nguyen 4916f3c90d
UI - Fix Locked "Override Root Disk Size" switch (#5843)
* Fix Locked "Override Root Disk Size" switch

* fixes ut
2022-01-10 19:04:46 +05:30
Hoang Nguyen 0f926b5d68
UI: Add s3 provider option to create secondary storage (#5726)
* add s3 provider option to create secondary storage

* fixes label name

* add storagepolicy for swift provider
2022-01-10 19:01:53 +05:30
SadiJr 5d7ea30f87
vmware: Remove restriction, in VMWare, to resize only SCSI disks (#5650)
Remove restriction, in VMWare, to resize only SCSI disks, because VMWare supports resize of subtypes of SCSI, like LSILOGIC, LSILOGIC SAS, etc

In VMWare, there are different types of SCSI controllers, such as BusLogic Parallel, LSI Logic Parallel, LSI Logic SAS, etc. All of these sub-types support the disk resize operation, the only exception is the IDE controller. However, in ACS, there is a logical restriction to allow only resizing of volumes of the specific SCSI type; thus, not allowing resizing of the SCSI sub-types. This PR corrects this behavior blocking the resize of volumes which uses IDE controller only.
More information can be found at:

https://www.starwindsoftware.com/blog/storage-controllers-in-vmware-vsphere
https://www.nakivo.com/blog/scsi-controller-and-other-vmware-controller-types/
https://docs.vmware.com/en/VMware-vSphere/7.0/com.vmware.vsphere.vm_admin.doc/GUID-5872D173-A076-42FE-8D0B-9DB0EB0E7362.html
https://communities.vmware.com/t5/ESXi-Discussions/Unable-to-increase-disk-Space/td-p/397823

Co-authored-by: SadiJr <sadi@scclouds.com.br>
2022-01-08 09:02:00 +05:30
Nicolas Vazquez 946f9156e5
vmware: Persist empty values instead of null (#5748)
This PR allows deploying VMware appliances missing default values on some properties
Fixes: #5747
2022-01-08 08:58:46 +05:30
slavkap 48006de3e3
kvm: Set RAW format to RBD DATADISK (#5801)
While deploying a VM with data disk on Ceph the volume format was in
QCOW2.

Fixes #5531
2022-01-08 08:54:21 +05:30
Abhishek Kumar feb4343abe
ui: fix create network/vpc offering form (#5840)
* ui: fix create network/vpc offering form

Fixes #5838

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix inlinemode

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-08 08:41:58 +05:30
Wei Zhou 84b9b61b9b
api: fix typo in Volume Destroy state - volume can be recovered (#5833)
* api: fix type Destroy volume can be recovered

* Update api/src/main/java/com/cloud/storage/Volume.java

Co-authored-by: dahn <daan.hoogland@gmail.com>
2022-01-07 13:19:26 +05:30
Wei Zhou 6d35b520d3
server: fix vm can be recovered by other accounts (#5822) 2022-01-07 13:13:48 +05:30
SadiJr e993a20e5a
[Veeam] Force ACS to use the template repository to clone job (#5774)
* [Veeam] Force ACS to use the repository of the template to clone job

* Address reviews

* Fix checkstyle

Co-authored-by: SadiJr <sadi@scclouds.com.br>
2022-01-07 11:12:57 +05:30
Suresh Kumar Anaparti 5c02f6d507
Merge branch '4.16' into main 2022-01-06 17:47:37 +05:30
Hoang Nguyen 3cbde8cd6c
UI - Hide shrink disk option on XCP-NG/Xenserver (#5829)
* hide shrink disk option on XCP-NG/Xenserver
2022-01-06 17:41:54 +05:30
dahn 2774bc156f
use physical size instead of virtual size for migration. (#5750)
* Use Physical size to evaluate if migration is possible

* Improve logging and consider files skipped as failure in complete migration

* skipped can't be negative

* remove useless method

* group multidisk templates for secstor migration

* use enum

* Update engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/DataMigrationUtility.java

Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Pearl d'Silva <pearl.dsilva@shapeblue.com>
2022-01-06 17:18:50 +05:30
Abhishek Kumar 51f69f7134
server: do not return inaccessible entity details to normal users (#5827)
Fixes #5534

As pre 3.x APIs allow using internal DB IDs, even normal users can use internal IDs.
This fix removes additional information in error message when the caller doesn't have access to the resource.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-01-06 16:42:57 +05:30
Suresh Kumar Anaparti 30ae9eedad
Merge branch '4.16' into main 2022-01-05 10:14:47 +05:30
Hoang Nguyen f071873d84
UI: Fix new UI missing 4 parameters when adding a BareMetal host (#5812)
* fix new UI missing 4 parameters when adding a BareMetal host

* remove test options

* add rule for hosttag with baremetal

* fixes password not provided
2022-01-04 15:13:31 +05:30
Daman Arora 610b2d0dd0
simplify code using optional chaining in compute views (#5635) 2022-01-04 12:23:28 +05:30
Rakesh 2bd1dc1e14
Enable resetting config values to default value (#4230)
* Enable resetting config values to default value

Provide reset button to zone,cluster,domain,account,
primary and secondary storage so that config values
can be reset to default value

* fix ui issue

* Update test/integration/smoke/test_reset_configuration_settings.py

* Update test/integration/smoke/test_reset_configuration_settings.py

Co-authored-by: Rakesh Venkatesh <rakeshv@apache.org>
Co-authored-by: dahn <daan.hoogland@gmail.com>
2022-01-03 21:55:30 +01:00
dahn e06a66ba14
ldap: truststore per domain (#5816)
Co-authored-by: Daan Hoogland <dahn@onecht.net>
2022-01-03 21:01:51 +05:30
Hoang Nguyen 4392cc4d48
ui: refactoring $notification according to the old version (#5819)
Related to PR #5549 changed the notification from $notification to $showNotification. This PR aims to change it back to the way it was for easier use while keeping the delete all button.
2022-01-03 20:59:49 +05:30
Rohit Yadav bf3d1338e0 Merge remote-tracking branch 'origin/4.16' 2022-01-03 19:38:31 +05:30
Rohit Yadav 11e59b3c34 Revert "README: again that time of the year! 🎄 (#5792)"
*Silently* reverts commit 4b7dcfa27b
without an explicit PR.
2022-01-03 19:38:02 +05:30
Daman Arora fc49f5d0d8
simplify code using object shorthand in project view (#5820) 2022-01-03 13:14:07 +05:30
dahn 5f93bc8948
assume a property is one when it isn't a number (#5647)
Co-authored-by: Daan Hoogland <dahn@onecht.net>
2022-01-03 12:53:18 +05:30
SadiJr 44f6730868
ui: Allow users to list VMs by Backup Offering Id in UI (#5818)
Co-authored-by: SadiJr <sadi@scclouds.com.br>
2021-12-31 00:07:59 +05:30
Rohit Yadav 204fd5cda8 merge: fix forward merge import issue
Fixes build failure on main branch

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2021-12-30 17:25:59 +05:30
Rohit Yadav c84198d76d Merge remote-tracking branch 'origin/4.16'
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2021-12-30 16:52:30 +05:30
Wei Zhou 4ba2ad5397
test: fix component test test_configdrive.py (#5528)
* test: fix test_configdrive.py and move it to smoke test

(sleep 30s as vm crashes after migration in ubuntu 20.04)

* Update test/integration/smoke/test_configdrive.py

Co-authored-by: dahn <daan.hoogland@gmail.com>

* test: fix test_configdrive.py

* Update #5528: move back to component test

Co-authored-by: dahn <daan.hoogland@gmail.com>
2021-12-30 16:31:31 +05:30
Hoang Nguyen 10bda8549b
ui: auto-prefill edit tariff label (#5714) 2021-12-30 16:27:56 +05:30
Abhishek Kumar d7a9873053
ui: fix add network offering for vpc (#5809)
* ui: fix add network offering for vpc

Fixes issues with form related to supported services provider and router service offering when offering to be created for VPC.

Fixes #5807

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix issues getting with making select element update on options change (loop infinity) (#72)

* fixes

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Co-authored-by: Hoang Nguyen <hoangnm@unitech.vn>
2021-12-30 16:26:54 +05:30
Hoang Nguyen eb04a46541
ui: Add clear all notification button (#5549)
* add clear all notification button

* change position set count notify

* get notification count

* set label transliteration

* add margin for notification

* change position of clear notification button
2021-12-30 16:24:17 +05:30
Daman Arora 49b2dfc6e4
ui: simplify code using optional chaining in ZoneWizardLaunchZone view (#5619)
* simplify code using optinal chaining in ZoneWizardLaunchZone view

* simplify code using optonal chaining
2021-12-30 16:23:42 +05:30
SadiJr d0721c5d66
ui: Change permission to access console proxy button (#5625)
This PR fixes #5623.

Also, some more information that is not present in the issue in question:

Although the proxy console access button does not appear in the UI, users with access permission to the VM in question have access to the console as well. Simply generate the console access link using another user, copy that link, and, on the user without access to the console button, type that link.

Co-authored-by: SadiJr <sadi@scclouds.com.br>
2021-12-30 16:23:02 +05:30
Daman Arora 7791b3c10c
ui: simplify code using optional chaining in the zone view (#5626) 2021-12-30 16:22:28 +05:30
Hoang Nguyen 5eccbc9521
ui: Add footer text option for login screen (#5628)
* add footer text option for login screen

* using single key for policy

* set empty for default policy text

* rename footer text key

* rename the footer text property name

* change position avoid breaking with docHelp

* change position of properties
2021-12-30 16:21:40 +05:30
SadiJr d8d5665903
api: Allow users to list VMs by Backup Offering Id (#5679)
Co-authored-by: SadiJr <sadi@scclouds.com.br>
2021-12-30 16:20:33 +05:30
Wei Zhou 8952cd5955
kvm: add hosts using cloudstack ssh private key (ccc21 hackathon) (#5684)
This PR provides the option to add kvm hosts with empty or wrong password.
To support this, the cloudstack ssh public key needs to be added in the ~/.ssh/authorized_keys on host.

Feature work:

1. get cloudstack public key from management server (/var/lib/cloudstack/management/.ssh/id_rsa.pub)

![image](https://user-images.githubusercontent.com/57355700/141449653-85f644b5-c32e-44ca-9c6b-77570262c046.png)


2. add the key to ~/.ssh/authorized_keys on kvm hosts

![image](https://user-images.githubusercontent.com/57355700/141449722-e906eea5-74fd-4f81-a4d3-41563beeb79c.png)

3. add kvm host with empty password

<img src="https://user-images.githubusercontent.com/57355700/141449865-6ffee1f0-b0d7-4ea4-b11a-32df42e2fe91.png" height="50%" width="50%">

Tested as:
1. add host, with correct password,  works as expected.
2. put host to maitenance, stop cloudstack-agent, cancel maintenance, remove the host. all work.
3. add host, with empty password (ssh public key is added to  ~/.ssh/authorized_keys),   works as expected.
4. put host to maitenance, stop cloudstack-agent, cancel maintenance. all work as expected.
2021-12-30 16:20:04 +05:30
Jayanth Reddy b63498d847
server: Fix a typo (#5761)
Fix a typo where the word "Security" is misspelled as "Secrity".
2021-12-30 16:17:15 +05:30
Wei Zhou 9798fa08b5
kvm: support qemu-system-x86>=5.2 (#5755) 2021-12-30 16:16:08 +05:30
Nicolas Vazquez c0ddda361a
[VMware] Fix service offerings listing on appliances deployment options (#5752)
* Fix list service offerings for VMware deployment options

* UI fix to allow selecting offerings
2021-12-30 16:13:41 +05:30
Marcus Sorensen dcdcd09058
Randomize managed volume copy host (#5789)
* Randomize managed volume copy host

* Managed volume copy was always returning first host that could see storage pools

* Fix null value in logging for ScaleIOPrimaryDataStoreDriver due to if/else logic error

Signed-off-by: Marcus Sorensen <mls@apple.com>

* Use String.format for ScaleIO debug message

Signed-off-by: Marcus Sorensen <mls@apple.com>

* Update debug message for ScaleIO copy methods

Signed-off-by: Marcus Sorensen <mls@apple.com>

Co-authored-by: Marcus Sorensen <mls@apple.com>
2021-12-30 16:11:00 +05:30
Daman Arora 7cb4604e98
simplify code using object shorthand in multiple files (#5766) 2021-12-30 15:29:25 +05:30
Daman Arora e3b0c0862f
simplify code using optional chaining in multiple config files (#5764)
* simplify code using optonal chaining in multiple config files

* add optional chaining to record too
2021-12-30 15:28:50 +05:30
Gabriel Beims Bräscher 62089767f6
Fix UI issue 5777 Root disk size is not shown as 'Disk Size' on VM deployment. (#5796)
In the UI, when selecting a service offering that has a root disk enforced, stills show the root disk size of the template (or the custom size gave by the user). This PR fixes this issue, that thas been reported in #5777.
Fixes: #5777
2021-12-30 15:21:11 +05:30
Abhishek Kumar d13057ace5
ui: show tags only for supported resources (#5798)
* ui: prevent incorrect tags displa for primary storage

Tags in info card of the UI are related to tags functionality(create/delete/lsitTags API)
UI was incorrectly showing storage tags as these tags in the UI.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* remove logging

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* ui: show tags only for supported resources

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2021-12-30 15:20:37 +05:30
Rohit Yadav 6728b696cd
kvm: don't always force scsi controller for aarch64 VMs (#5802)
* kvm: don't force scsi controller for aarch64 VMs

This would allow use of virtio disk controller with Ceph, etc or as
defined in the VM's root disk controller setting, rather than always
enforce SCSI.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* remove test that doesn't apply now

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* address review comment

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2021-12-30 15:19:32 +05:30
Pearl Dsilva 9a5a0738b0
ui: Fix configure Sticky policy form (#5814) 2021-12-30 10:31:24 +01:00
Hoang Nguyen ae62e1dd5e
fixes cannot add new port forwarding rules after auto select VM next time (#5690) 2021-12-30 09:53:51 +01:00
Suresh Kumar Anaparti 0c0254d8f5
Merge branch '4.16' into main 2021-12-28 01:40:23 +05:30