Commit Graph

125 Commits

Author SHA1 Message Date
Vishesh b5eebc4347
Fix codecov github action (#7747) 2023-07-18 13:27:01 +03:00
Vishesh c956d329f5
Fix test_vm_schedule's intermittent failures (#7726)
* Fix test_vm_schedule's intermittent failures

* Add smoke/test_vm_schedule to CI
2023-07-07 22:51:38 +05:30
dahn ae10263b3b
Possibility to choose the source NAT IP address on a isolated network or VPC (#6442)
Co-authored-by: NuxRo <nux@li.nux.ro>
Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
2023-06-09 14:51:53 +02:00
Abhishek Kumar c00a1ba532 Merge remote-tracking branch 'apache/4.18' into main 2023-06-08 15:34:46 +05:30
Vishesh 811b6293af
.github: Use parallel builds for github actions (#7592) 2023-06-07 13:17:29 +02:00
John Bampton 8d6241fb1b
Enable two more `flake8` rules (#7552) 2023-05-31 10:49:53 +02:00
Rohit Yadav 2f309b573b Merge remote-tracking branch 'origin/4.18' 2023-05-12 12:58:49 +05:30
Abhishek Kumar 44024a8a8b
github-actions: fix ui build workflow (#7522)
package-lock.json is not removed.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2023-05-12 12:54:23 +05:30
Rohit Yadav 0af56179a5 Merge remote-tracking branch 'origin/4.18' 2023-05-10 14:08:14 +05:30
Rohit Yadav 0e4a5a1fa4 .github: restrict sonar and CI actions to only apache/cloudstack
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2023-05-10 14:07:29 +05:30
Daan Hoogland 45928d2d9f vim-oops 2023-05-09 20:15:03 +02:00
Daan Hoogland 66cbe0a051 replace pull_request_target with pull_request 2023-05-09 18:40:20 +02:00
Daan Hoogland 216c565308 replace pull_request_target with pull_request 2023-05-09 18:39:10 +02:00
Daan Hoogland 35862d4532 no write for external forks 2023-05-09 17:35:12 +02:00
Alex 80c999cc81
GitHub Workflows security hardening (#6762)
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2023-04-25 16:35:39 +02:00
Daan Hoogland da58a20cc2 repair vi typo 2023-02-27 09:37:32 +01:00
Daan Hoogland 2fc443e909 bash evaluation within quotes 2023-02-26 21:51:56 +01:00
Daan Hoogland 3ee32244d8 bash evaluation as opposed to gha. 2023-02-26 19:32:46 +01:00
Wei Zhou 0457cc559e .github: allow only read permission in sonar-check.yml 2023-02-23 13:47:48 +01:00
Wei Zhou bc5dbe95e9
.github: use tag name as docker image name for new tags (#7233) 2023-02-20 12:42:57 +01:00
Wei Zhou ea18b86684
.github: disable Sonar check on forks as it requires crendential (#7199) 2023-02-13 11:58:05 +01:00
John Bampton dcf01f7bef
.github: Skip Coverage Check when forks are updated (#7177) 2023-02-13 09:48:31 +01:00
Harikrishna a3feccf70c
User two factor authentication (#6924)
Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2023-02-13 09:14:17 +01:00
Wei Zhou e32016d4a1
.github: set docker repository to apache (#7176)
Now the images are pushed to
https://hub.docker.com/r/asfjenkins/cloudstack-simulator/tags
2023-02-07 13:46:22 +01:00
Wei Zhou b93608eada
Github Action: Build docker image for cloudstack-simulator (#7122) 2023-02-07 10:37:44 +01:00
dahn 6f6cec5f56
.github: run all gha on ubuntu latest (#7091)
* run all gha on ubuntu latest

* replace latest with 22.04
2023-01-18 10:35:56 +05:30
John Bampton c0a32d00b7
Use Super-Linter Slim Image (#6610)
Co-authored-by: dahn <daan@onecht.net>
2023-01-12 13:41:28 +01:00
John Bampton 00426ede46
Add `pre-commit` workflow with 3 Git hooks (#6273)
Co-authored-by: dahn <daan@onecht.net>
2023-01-11 12:25:31 +01:00
Rohit Yadav c2b75f4c81 README: revert project logo and update README
Happy New Year - this reverts project logo and updates README and the
names of Github Actions badges used on README.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2023-01-05 17:59:08 +05:30
Rohit Yadav 9a18ea28dd .github: use ubuntu:22.04 for Sonar jacoco coverage checks
Apologies to commit this to main directly, this is because the
pull_request_target requires that Github Actions yaml changes are on the
source repo main branch.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-12-30 15:00:17 +05:30
Wei Zhou dc40ea130f
UI: fix ui test errors (#7030) 2022-12-29 09:08:54 +01:00
John Bampton bf5cacb3bb
gha(linters): enable 7 more Python `flake8` checks (#7005) 2022-12-21 16:53:35 +01:00
Rohit Yadav 2dc9f1e32c
.github: Migrate Travis to Github Actions and Simulator based CI (#6956)
Runs on default spec:
2-core CPU (x86_64)
7 GB of RAM
14 GB of SSD space

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-12-21 16:36:52 +05:30
John Bampton 8e538028b2
Enable Flake8 rule W391 (#6606)
Best practice is to have one blank line at the end of Python files.

Remove unneeded blank lines from the end of files
2022-11-13 11:00:07 +01:00
Step Security Bot de8aae1619
[StepSecurity] ci: Harden GitHub Actions in merge-conflict-checker.yml (#6802) 2022-10-08 11:40:43 +05:30
Rohit Yadav 4d41b6bc44 Merge remote-tracking branch 'origin/4.17' 2022-08-09 12:33:39 +02:00
Rohit Yadav 2d0a2e388d .github: add codecov coverage check
It seems codecov can overcome the pull_request_target limitation/issue
compared to sonarcloud coverage. We've some other Apache projects who
use `codecov` now and this ticket to add support with infra:
https://issues.apache.org/jira/browse/INFRA-23561

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-08-09 12:29:19 +02:00
John Bampton a039250b3b
.github: Lint modified files only with Super-Linter (#6531)
https://github.com/github/super-linter#standard-image
2022-07-07 11:57:29 +05:30
Rohit Yadav 711d4b9f0f Merge remote-tracking branch 'origin/4.17' 2022-07-01 11:26:10 +05:30
Rohit Yadav 85df82c2a9 Revert ".github: try using just sonarcloud job on pull_request target only"
This reverts commit aad73322af.
2022-07-01 11:25:27 +05:30
neilnaveen 15ab481928
chore: Set permissions for GitHub actions (#6467)
Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.

- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)

Signed-off-by: neilnaveen <42328488+neilnaveen@users.noreply.github.com>
2022-07-01 11:24:04 +05:30
Rohit Yadav 5fe095ee0a Merge remote-tracking branch 'origin/4.17' 2022-06-30 15:28:55 +05:30
Rohit Yadav aad73322af .github: try using just sonarcloud job on pull_request target only
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-06-30 15:27:20 +05:30
John Bampton 7ba43e447c
Enable flake8 rule W292 No newline at end of file (#6274)
https://www.flake8rules.com/rules/W292.html
2022-06-30 12:08:27 +05:30
Rohit Yadav 470de7fb54 .github: run coverage for pushes to main branch
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-05-04 02:23:47 +05:30
Rohit Yadav 17afe0510e .github: add support for PR decoration
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-05-04 01:02:38 +05:30
Rohit Yadav 2326b5e22a maven: update sonarcloud project
https://sonarcloud.io/project/configuration?id=apache_cloudstack

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-05-03 18:55:20 +05:30
Rohit Yadav c379430dab .github: sonarcloud integration fixes
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-27 18:15:27 +05:30
Rohit Yadav a2abd7fdc2 .github: fix typo in passing merge branch name
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-26 16:40:09 +05:30
Rohit Yadav 05e4f9515e .github: fix sonarcloud integration
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-26 16:35:07 +05:30
Rohit Yadav 9f27c992da .github: skip coverage data when string is empty
This fixes issue of empty rows in the PR coverage data

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-26 15:06:06 +05:30
Rohit Yadav 7233c38567 .github: enable PR sonar integration
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-26 14:43:23 +05:30
Rohit Yadav 40193a04eb .github: fix coverage issue, don't kick pkging automatically
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-20 16:37:32 +05:30
Rohit Yadav 15928f8cc8 .github: detect and kick packaging jobs
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-18 17:04:44 +05:30
Rohit Yadav cc139464f3 .github: use event specific sha and base_sha for comparing changes
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-18 15:31:20 +05:30
Rohit Yadav 1b2461b200 .github: debug github event using env variable
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-18 15:24:48 +05:30
Rohit Yadav b2086595ca .github: debug github event
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-18 15:19:13 +05:30
Rohit Yadav 976464ccb9 .github: enable fork-point while finding list of changes files
Hit same issue as https://github.com/tj-actions/changed-files/issues/355

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-18 14:46:32 +05:30
Rohit Yadav 023305e86d .github: fetch all history for comparing PR changes
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-18 14:37:11 +05:30
Rohit Yadav dcb9143330 .github: use pull_request_target which has access to token
This tries to add support for forked repo pull requests, to be able
to run quality checks on it and send comments on the PR. Hopefully,
this solves the issues faced recently.

Due to the way pull_request_target works, I can't send this as a PR
so committing directly to `main` and then sending a dummy PR from a fork
to test if it works as documented by github and elsewhere.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-18 14:28:05 +05:30
Rohit Yadav 2dcdc56115
.github: run coverage on pull request (#6265)
The pull_request_target doesn't seem to work for PRs from forks,
this reverts to use and kick the workflow for pull_request instead.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-15 20:35:22 +05:30
John Bampton cfa4f33940
.github/linters: Enable flake8 W293 blank line contains whitespace (#6268)
https://www.flake8rules.com/rules/W293.html
2022-04-15 20:32:52 +05:30
Rohit Yadav 9067938a0d .github: try kicking coverage via pull_request_target sync
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-14 18:03:36 +05:30
Rohit Yadav cd24cf2daa
.github: improve coverage run (#6238)
Add support to detect and kick UI builds and run quality
build and report coverage for the PR.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-14 17:51:36 +05:30
Rohit Yadav 72f13a6cea .github: fix incorrect tagging of PR author
Due to github push events and restrictive github action access, the
statement is changed without tagging the author with the assumption
that the PR author is subscribed to the PR events and should get a
notification and/or email.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-12 14:04:40 +05:30
Rohit Yadav 8add4df0fa
.github: fix github actions error
Fixes double wrapping of variable
2022-04-08 19:39:31 +05:30
Rohit Yadav 4c89f08ebf .github: fix github event/pr username for conflict msg advice
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-08 15:27:58 +05:30
Rohit Yadav 6bf812cdc9 .github: fix github action workflows
(commiting this directly to main, otherwise the PR will kick the actions
of the PR branch)

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-07 22:48:34 +05:30
Rohit Yadav 5630ca4411 .github: update action tag as per https://issues.apache.org/jira/browse/INFRA-23109
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-07 21:24:43 +05:30
Rohit Yadav 1cdacccdc0
maven: support JaCoCo and other quality checks (#6228)
This enables jacoco, which didn't run before with the -P quality due to
missing passing of jacoco arg line to surefire plugin.

This also adds support for jacoco/quality builds using Github action and
posting of the PR coverage data using a new action step.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-07 20:48:48 +05:30
Rohit Yadav 2b1c4fbe6e
.github: fix workflow settings and allow branch pushes to main by committers (#6225)
This fixes the comment message for merge conflict checker and resets the
github branch protection for main in case of need by the RM.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-07 13:49:03 +05:30
Rohit Yadav 1500e1f70c
.github: add merge conflict checker per RM request (#6221)
* .github: add merge conflict checker per RM request

Adds a merge conflict checker workflow per current RM (Nicolas's)
request.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* Update merge-conflict-checker.yml

* Update merge-conflict-checker.yml
2022-04-06 23:52:55 +05:30
Rohit Yadav 9a8c7b1a8c
.github: fix first PR welcome message by boring-cyborg (#6217)
* .github: fix first PR welcome message

Adds newlines

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* add community slack link

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* add rules for storage label

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* remove semantic yaml which is not needed now

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* disable the strict check to assist RM

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-06 23:52:26 +05:30
Rohit Yadav 133b195688
Probot integrations (#6211)
* .github: add boring-cyborg integration

This add boring-cyborg bot app added to apache org that provides:
- labeling PRs by file paths
- welcome and first msg for new contributors

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* .github: add semantic title checking app

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-06 16:50:00 +05:30
John Bampton 182899d0b5
Add Python flake8 linting for W291 trailing whitespace with Super-Linter (#4687)
* refactor: remove trailing whitespace from Python files

* Add the GitHub Super-Linter

Add Python flake8 linting for W291 trailing whitespace

* Add licenses
2022-03-28 11:40:26 -03:00