Prachi Damle
f5d4736c87
CLOUDSTACK-8079: If the cluster capacity threshold is reached, HA-enabled VM is not migrated on another host during HA
...
Changes:
- When there is HA we try to redeploy the affected vm using regular planners and if that fails we retry using the special planner for HA (which skips checking disable threshold)
Now because of job framework the InsufficientCapacittyException gets masked and the special planners are not called. Job framework needs to be fixed to rethrow the correct exception.
- Also the VM Work Job framework is not setting the DeploymentPlanner to the VmWorkJob. So the HA Planner being passed by HAMgr was not getting used.
- Now the job framework sets the planner passed in by any caller of the VM Start operation, to the job
2014-12-17 11:43:07 -08:00
Jayapal
8278d88f76
CLOUDSTACK-8030: Updated router to come up egress default ALLOW
...
On default iptables rules are updated to add ACCEPT egress traffic.
If the network egress default policy is false, CS remove ACCEPT and adds the DROP rule which
is egress default rule when there are no other egress rules.
If the CS network egress default policy is true, CS won't configure any default rule for egress because
router already came up to accept egress traffic. If there are already egress rules for network then the
egress rules get applied on VR.
For isolated network with out firewall service, VR default allows egress traffic (guestnetwork --> public network)
2014-12-10 10:13:41 +05:30
Jayapal
8f8e311110
CLOUDSTACK-8030: Updated router to come up egress default ALLOW
...
On default iptables rules are updated to add ACCEPT egress traffic.
If the network egress default policy is false, CS remove ACCEPT and adds the DROP rule which
is egress default rule when there are no other egress rules.
If the CS network egress default policy is true, CS won't configure any default rule for egress because
router already came up to accept egress traffic. If there are already egress rules for network then the
egress rules get applied on VR.
For isolated network with out firewall service, VR default allows egress traffic (guestnetwork --> public network)
2014-12-08 11:32:01 +05:30
Rohit Yadav
f40e31e061
CLOUDSTACK-7563: Fix potential NPE in checking answer
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit d42e3df9cf )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-12-02 16:46:09 +05:30
Rohit Yadav
d42e3df9cf
CLOUDSTACK-7563: Fix potential NPE in checking answer
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-12-02 16:14:29 +05:30
Loic Lambiel
99cb19787e
CLOUDSTACK-7404: Failed to start an instance when originating template has been deleted
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
(cherry picked from commit c1bf7eeeee )
2014-12-01 13:05:12 +01:00
Loic Lambiel
34e8483e80
CLOUDSTACK-7404: Failed to start an instance when originating template has been deleted
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
(cherry picked from commit c1bf7eeeee )
2014-12-01 13:04:34 +01:00
Laszlo Hornyak
3577423da9
removed executable flags from java classes
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-11-23 19:49:01 +01:00
Anthony Xu
02e22dba7d
CLOUDSTACK-7742:
...
root cause:
when vmsync reports system VM is down, CCP doesn't release the VM resource before starting it.
fix:
make sure cleanup is called for a VM when it is reported as Stopped
2014-11-19 16:30:56 -08:00
Anthony Xu
ab19edf09d
CLOUDSTACK-7742:
...
root cause:
when vmsync reports system VM is down, CCP doesn't release the VM resource before starting it.
fix:
make sure cleanup is called for a VM when it is reported as Stopped
2014-11-19 16:27:51 -08:00
Edison Su
d856a2acad
CLOUDSTACK-7946:
...
remove leftover state in volume and snapshot table in case of mgt server
shutdown during storage operation.
Reviewed-by: Min
2014-11-19 16:08:27 -08:00
Edison Su
67113ff0b2
CLOUDSTACK-7946:
...
remove leftover state in volume and snapshot table in case of mgt server
shutdown during storage operation.
Reviewed-by: Min
2014-11-19 16:06:37 -08:00
Sanjay Tripathi
dda2994936
CLOUDSTACK-7940: Exception printed completely on the UI. Not in a readable format.
2014-11-19 15:59:03 +05:30
Kishan Kavala
4e896938ee
BUG-ID: CLOUDSTACK-5324 when router requires upgrade throw ResourceUnavailableException with scope VirtualRouter. API willl return generic Network Unavailable error.
...
Reviewed-By: Damoder
2014-11-19 09:46:56 +05:30
Devdeep Singh
cffae8eef0
CLOUDSTACK-6924. To attach a volume if a volume needs to be moved to another storage
...
pool, the source and destination pools cannot be local and cluster/zone and vice versa.
Cloudstack detects it and throws a exception. However, the end user only sees an
unexpected exception and not the reason for failure. Fixed it by making sure the
reason for the failure is correctly captured and shown to the end user.
2014-11-14 11:19:19 +05:30
Santhosh Edukulla
ef6ec7b276
Fixed few coverity issues like invalid boxing unboxing issues, resource leaks, null dereferences
2014-11-13 17:26:24 +05:30
Koushik Das
2685ed36cc
CLOUDSTACK-7880: Creating shared network results in exception
...
This is due to event publish being wrapped in a transaction, moved it outside of transaction scope.
2014-11-11 16:35:20 +05:30
Koushik Das
6d268db217
CLOUDSTACK-7880: Creating shared network results in exception
...
This is due to event publish being wrapped in a transaction, moved it outside of transaction scope.
2014-11-11 16:32:20 +05:30
Damodar
781648fb10
CLOUDSTACK-7792: Usage Events to be captured based on Volume State Machine
2014-11-10 15:19:02 +05:30
Nitin Mehta
a8b89bea4f
CLOUDSTACK-7870: When Vm deployments fail and end in error state volume count should be decremented
2014-11-09 23:01:28 -08:00
Koushik Das
4d08bb8935
CLOUDSTACK-7867: Delete network resulting in exception
...
Publish event was getting called from within a DB transaction which is not allowed.
2014-11-08 13:50:31 +05:30
Koushik Das
e25de54b4c
CLOUDSTACK-7421
...
Unnecessary exception in MS logs while removing default NIC from VM. Following changes are made:
1. Changed the exception from CloudRuntimeException to InvalidParameterValueExecption.
2. Moved out validation logic to UserVMManagerImpl from VirtualMachineManagerImpl.
3. Handling InvalidParameterValueException from async API calls so that they are not logged as ERROR in MS logs.
2014-11-08 13:50:15 +05:30
Koushik Das
49115e0333
CLOUDSTACK-7867: Delete network resulting in exception
...
Publish event was getting called from within a DB transaction which is not allowed.
2014-11-08 13:46:54 +05:30
Koushik Das
0327c2b13e
CLOUDSTACK-7421
...
Unnecessary exception in MS logs while removing default NIC from VM. Following changes are made:
1. Changed the exception from CloudRuntimeException to InvalidParameterValueExecption.
2. Moved out validation logic to UserVMManagerImpl from VirtualMachineManagerImpl.
3. Handling InvalidParameterValueException from async API calls so that they are not logged as ERROR in MS logs.
2014-11-04 17:34:07 +05:30
Min Chen
07ba078ee6
CLOUDSTACK-7833: VM Async work jobs log "Was unable to find lock for the key vm_instance" errors as warning
2014-11-03 11:19:06 -08:00
Min Chen
684889f0b5
CLOUDSTACK-7833: VM Async work jobs log "Was unable to find lock for the key vm_instance" errors as warning
2014-11-03 10:52:47 -08:00
Santhosh Edukulla
1aef5cba66
Fixed Coverity Issues
2014-11-03 16:45:30 +05:30
Hugo Trippaers
4ebaf0a583
Bump master version to 4.6.0-SNAPSHOT after branching 4.5.0-SNAPSHOT
2014-10-29 14:54:23 +01:00
Min Chen
0d6f69b536
CLOUDSTACK-7778: Start VM checkWorkItem loop should also check VM DB state before going into idle waiting to exit faster.
2014-10-23 14:38:56 -07:00
Min Chen
94969b0654
CLOUDSTACK-7778: Start VM checkWorkItem loop should also check VM DB state before going into idle waiting to exit faster.
2014-10-23 14:28:23 -07:00
Daan Hoogland
8218ce0fe2
unexplained happy flow for restart network modified
2014-10-23 20:57:33 +02:00
Anthony Xu
4a13f81485
when host is pingtimeout and CCP can not determine the host status, put the host to Alert status , no VM HA.
2014-10-22 15:14:46 -07:00
Anthony Xu
c52e14730e
when host is pingtimeout and CCP can not determine the host status, put the host to Alert status , no VM HA.
2014-10-22 15:07:40 -07:00
Mike Tutkowski
97aa02ceb0
Commits related to taking snapshots that live on primary storage
2014-10-22 12:44:33 -06:00
Anthony Xu
0141b37784
CLOUDSTACK-7761:
...
Revert "when system VM ping times out, stop system VM"
This reverts commit ee23be1942 .
2014-10-21 17:21:17 -07:00
Anthony Xu
70112bd145
CLOUDSTACK-7761:
...
Revert "when system VM ping times out, stop system VM"
This reverts commit ee23be1942 .
2014-10-21 17:19:57 -07:00
Mike Tutkowski
57dacf99a2
Changed "boolean connectVolumeToHost(VolumeInfo, Host, DataStore)" to "boolean grantAccess(DataObject, Host, DataStore)"
...
Changed "void disconnectVolumeFromHost(VolumeInfo, Host, DataStore)" to "void revokeAccess(DataObject, Host, DataStore)"
2014-10-21 16:01:14 -06:00
Min Chen
e7fa3a2959
CLOUDSTACK-7563: Fix potential NPE from FingBugs.
2014-10-14 11:21:01 -07:00
Min Chen
4b8bfe2627
CLOUDSTACK-7563: Fix potential NPE from FingBugs.
2014-10-14 11:19:39 -07:00
Santhosh Edukulla
0a9742f914
Fixed few coverity issues
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-10-14 17:16:50 +05:30
Edison Su
1c1485e0f0
disable parallel for xenserver. Also for vmware, if full.clone is enabled and migratecommand will have the behavor of start/stop command
...
(cherry picked from commit d233f39c82 )
2014-10-13 00:39:33 -04:00
Anthony Xu
ee23be1942
when system VM ping times out, stop system VM
...
(cherry picked from commit 847e1e47ae )
2014-10-13 00:11:21 -04:00
Devdeep Singh
43a9bbf509
CLOUDSTACK-7598: When a vm deployed by cloudstack is stopped on the hypervisor
...
(outside cloudstack), the state of the vm is not updated in cloudstack db. The
ping task was not checking for resource (host) status by default. The power
state of the vms is returned as part of the resource status. Fixed the issue by
making sure ping task atleast tries once to get the resource status.
(cherry picked from commit 55b4ead495 )
2014-10-12 23:55:17 -04:00
Jayapal
7a4a0d7aaa
CLOUDSTACK-7622: Fixed deleting network when provider is disable
2014-10-12 23:54:20 -04:00
Edison Su
d233f39c82
disable parallel for xenserver. Also for vmware, if full.clone is enabled and migratecommand will have the behavor of start/stop command
2014-10-09 17:14:57 -07:00
Santhosh Edukulla
31a42d2b7a
Fixed few coverity patches
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-10-09 11:45:26 +05:30
Anthony Xu
847e1e47ae
when system VM ping times out, stop system VM
2014-09-30 12:35:44 -07:00
Hugo Trippaers
1c94017ff6
CID-1241966 Fix potential null deref
2014-09-30 11:27:51 +02:00
Devdeep Singh
55b4ead495
CLOUDSTACK-7598: When a vm deployed by cloudstack is stopped on the hypervisor
...
(outside cloudstack), the state of the vm is not updated in cloudstack db. The
ping task was not checking for resource (host) status by default. The power
state of the vms is returned as part of the resource status. Fixed the issue by
making sure ping task atleast tries once to get the resource status.
2014-09-25 13:13:56 +05:30
Jayapal
8c8c54f9f5
CLOUDSTACK-7622: Fixed deleting network when provider is disable
2014-09-25 10:31:51 +05:30
Harikrishna Patnala
c55bc0b2d1
CLOUDSTACK-7534: ResetVM for VM with attached datadisk fails when enable.ha.storage.migration is false
...
Separate global config to enable/disable Storage Migration during normal deployment
Introduced a configuration parameter named enable.storage.migration
2014-09-24 16:35:23 +05:30
Hugo Trippaers
8a13f44b44
Remove duplicate field in constructor
2014-09-18 16:02:26 +02:00
Daan Hoogland
7f440854f7
CLOUDSTACK-7184 retry-wait loop config to deal with network glitches
...
(cherry picked from commit a29f954a26 )
Conflicts:
engine/orchestration/src/com/cloud/agent/manager/DirectAgentAttache.java
2014-09-18 12:55:05 +02:00
Rohit Yadav
2cd99e3e72
CID-1116245: Lock for getting answers from SynchronousListener
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-18 11:56:29 +02:00
Rohit Yadav
3640c61207
CID-1116248: Synchornize method in SynchronousListener
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-18 11:54:31 +02:00
Anthony Xu
e5a91e40dd
in tagCommand, AsyncJobExecutionContext doesn't need to be created if it doesn't exist
2014-09-17 18:15:41 -07:00
Min Chen
1b15efb5f0
CLOUDSTACK-7563: ClassCastException in VirtualMachineManagerImpl in
...
handling various Agent command answer.
2014-09-16 12:12:17 -07:00
Min Chen
d5a8f1d875
CLOUDSTACK-7553: Clean up cached agentMap and pingMap in case of agents
...
connecting back to a different MS.
2014-09-15 17:37:51 -07:00
Nitin Mehta
0a4ab3251a
CLOUDSTACK-7513: listServiceOfferings API when called with VM's id also returns offerings to which it cant be upgraded. Adding the logic that when vmid is passed it looks for compatible offerngs using the storage type (local/shares), storage tags and also compute (cpu,speed, memory) in case the vm is running.
...
Also changed the scaleVm API to upgrade only when the destination offering has storage tags as a subset of current offering tags.
2014-09-15 11:02:34 -07:00
Bharat Kumar
2b7b837b28
CLOUDSTACK-6099 live migration is failing for vm deployed using dynaic compute offerings with NPE
2014-09-10 13:26:24 +02:00
Kishan Kavala
6f7c4863a2
CLOUDSTACK-7473: Vm migration is not supported for LXC. When host is put in maintenance mode, stop the Vms instead of migrating
2014-09-04 20:59:19 +05:30
Hugo Trippaers
dc3f0cbc63
Improve the handling of the findbug exclude files
2014-09-03 10:41:22 +02:00
Likitha Shetty
8ce6eba549
CLOUDSTACK-7415. Host remains in Alert after vCenter restart.
...
Management server PingTask should update PingMap entry for an agent only if it is already present in the Management Server's PingMap.
2014-08-25 13:24:28 +05:30
Santhosh Edukulla
19ffc93e2e
Fixed few coverity reported issues:Aug22 2014
2014-08-21 17:09:27 +05:30
Likitha Shetty
7dbff9b42c
CLOUDSTACK-7371. [VMware] Enabling primary storage maintenance fails when storages are across cluster.
...
1. While destroying a ROOT volume do the lookup of the associated VM under the DC and not just cluster.
2. In case of VMware, during VM start if a volume is being recreated no need to detach the old volume because
we now expunge it immediately and don't wait for the storage cleanup task to run.
2014-08-20 10:51:18 +05:30
Olivier Lemasle
de424061b2
CLOUDSTACK-7006: Restore template ID in ROOT volume usages
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-08-18 10:14:26 -04:00
Koushik Das
8bc7ae695d
CLOUDSTACK-7182: NPE while trying to deploy VMs in parallel in isolated network
...
- Check to see if network is implemented changed from 'state == Implementing||Implemented' to 'state == Implemented'.
The earlier check was a hack to prevent the issue described below.
- At the time of implementing network (using implementNetwork() method), if the VR needs to be deployed then it follows
the same path of regular VM deployment. This leads to a nested call to implementNetwork() while preparing VR nics. This
flow creates issues in dealing with network state transitions. The original call puts network in "Implementing" state
and then the nested call again tries to put it into same state resulting in issues. In order to avoid it, implementNetwork()
call for VR is replaced with below code.
2014-08-18 10:43:04 +05:30
Min Chen
fee2bfce49
CLOUDSTACK-7344:VOLUME.DELETE usage event missing for VM's in ERROR
...
state.
2014-08-13 22:15:47 -07:00
Santhosh Edukulla
e4d6cd8e6a
Fixed coverity reported concurrency issues
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-08-05 12:16:08 +05:30
Santhosh Edukulla
b7d3f1bd30
Fixed few coverity issues for resource synchronization
2014-08-04 16:09:26 +05:30
Alena Prokharchyk
ffeca8bbd2
CLOUDSTACK-7209: handle the case when network fails to implement NoTransitionException, and null is returned to the caller stack. All caller methods should verify if the return value is null before processing it further.
2014-08-01 09:47:28 -07:00
Saksham Srivastava
3d6c64d262
CLOUDSTACK-7206: Update vm_network_map table correctly
2014-08-01 13:58:06 +05:30
Santhosh Edukulla
bd3d8286d3
Fixed a simple coverity issue
2014-07-31 16:00:42 +05:30
Sheng Yang
f47cfc6eb1
CLOUDSTACK-7186: Revert "CLOUDSTACK-7182: NPE while trying to deploy VMs in parallel in isolated network"
...
This reverts commit 47d6a64b31 , which broke VPC
completely.
2014-07-28 16:02:21 -07:00
Anthony Xu
330c4ba578
completed the new vmsync TODOs in the code.
...
removed old vmsync logic
2014-07-28 12:51:37 -07:00
Murali Reddy
67876b215e
CLOUDSTACK-7191:On restartNetwork destroy the VR immediatley, instead of
...
cleanup the rules then destroy
fix adds a provision to specify if cleanup is needed on network on
shutdown. VR is marked as to not to require network rules clean up on
network shutdown as the VR is destroyed and recreated.
ran the simulator tests that test network life cycle
2014-07-28 17:09:42 +05:30
Koushik Das
47d6a64b31
CLOUDSTACK-7182: NPE while trying to deploy VMs in parallel in isolated network
...
The following changes are made:
- Check to see if network is implemented changed from 'state == Implementing||Implemented' to 'state == Implemented'.
The earlier check was a hack to prevent the issue described below.
- At the time of implementing network (using implementNetwork() method), if the VR needs to be deployed then
it follows the same path of regular VM deployment. This leads to a nested call to implementNetwork() while
preparing VR nics. This flow creates issues in dealing with network state transitions. The original call
puts network in "Implementing" state and then the nested call again tries to put it into same state resulting
in issues. In order to avoid it, implementNetwork() call for VR is replaced with below code.
2014-07-25 15:17:35 +05:30
Hugo Trippaers
676b2d1569
Fix overflow before widening issues reported by Coverity
2014-07-24 13:22:14 +02:00
Hugo Trippaers
e78bb1d225
Switch the catch to Throwable. Uncaught exceptions in a scheduled
...
threadpool executor will not report or log uncaught exceptions but will
kill the thread causing unexplained timeouts in CS.
2014-07-16 16:24:55 +02:00
Koushik Das
aacf8ef77b
Findbugs fixes in cloud-utils project and a few other places
2014-07-15 14:23:17 +05:30
Santhosh Edukulla
97d296bfbd
Fixed Coverity reported performance issues like inefficient string concatenations, wrong boxing or unboxing types, inefficent map element retrievals
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-07-01 22:06:25 +02:00
Hugo Trippaers
ab0dca0385
Catch possible exceptions in finally so they won't shadow the original exception.
2014-06-25 15:51:29 +02:00
Hugo Trippaers
cd0ef09344
Fix typo and add the right exception to the error map.
2014-06-25 15:51:28 +02:00
Kelven Yang
f756d4aa33
Make job info universally available across management server and resource agents
2014-06-24 16:28:22 -07:00
Mike Tutkowski
3d9eaf0753
Fixed some spacing issues from 4d6c682f18
2014-06-24 15:27:06 -06:00
punith-cloudbyte
4d6c682f18
supporting nfs protocol and resize feature for managed storage for xenserver
...
resize feature refactored
Signed-off-by: Mike Tutkowski <mike.tutkowski@solidfire.com>
2014-06-24 15:16:45 -06:00
Anshul Gangwar
450d890942
CLOUDSTACK-6830: Fixed during VM migration, volumes on zone wide primary store
...
requires storage migration resulting in failure of VM migration. This also improves
the hostsformigration api. Firstly we were trying to list all hosts and then
finding suitable storage pools for all volumes and then we were checking whether
vm migration requires storage migration to that host. Now the process is updated.
We are checking for only those volumes which are not in zone wide primary store.
We are verifying by comparing volumes->poolid->clusterid to host clusterid. If it
uses local or clusterids are different then verifying whether host has suitable
storage pools for the volume of the vm to be migrated too.
2014-06-20 16:32:19 +05:30
Alena Prokharchyk
3312394154
CLOUDSTACK-6934: don't try to detach volume from host when volume was never allocated to a primary storage
2014-06-18 12:39:36 -07:00
Kelven Yang
f529823566
Add ReflectionUse annotation for marking up *un-used* methods
2014-06-17 17:31:29 -07:00
Anshul Gangwar
aa21cdcd49
CLOUDSTACK-6897: when we try to attach the uploaded/allocated volume to a VM on zwps, then we were passing the podId of VM instead of storage pool to storage allocator. This resulting in use of Clusterscope storage allocator, allocating a storage pool for VM on zwps beacuse of pod id not null. This was resulting in scope conflict later
2014-06-13 14:47:00 +05:30
Anshul Gangwar
66d1eb92f0
CLOUDSTACK-6865 , CLOUDSTACK-6868: [hyperv] while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format. Now changed the behavior to set Image Format for volume only when it is not set
2014-06-13 13:26:02 +05:30
Rajani Karuturi
b666a1f3a5
Fixed issues reported by coverity NPEs, unwritten field access and self assignment
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-06-10 14:34:47 +05:30
Prachi Damle
3b3f4577b0
CLOUDSTACK-6476: Basic Zone with Multiple Pods Setup: DHCP server doesnt get deployed in the pod where the VM gets deployed
...
Changes:
PodId in which the router should get started was not being saved to the DB due to the VO's setter method not following the setXXX format. So when planner loaded the router from DB, it always got podId as null and that would allow planner to deploy the router in any pod. If the router happens to start in a different pod than the user VM, the Vm fails to start since the Dhcp service check fails.
Fixed the VO's setPodId method, that was causing the DB save operation fail.
2014-06-06 16:15:31 -07:00
Marcus Sorensen
7ce3034299
CLOUDSTACK-6790: Disable PXE ROM for system vm nics
2014-05-27 16:52:26 -06:00
Koushik Das
d5754d9101
CLOUDSTACK-6740: Direct agent command throttling improvements
...
List of changes:
1. Created a separate thread pool for handling cron and ping tasks. The size of the pool is based on direct.agent.pool.size. The existing direct agent pool will run all commands other than cron and ping.
2. For normal tasks (generated as part of user/admin API calls), if throttle limit is reached then tasks get queued up for subsequent execution once threads are available.
3. For cron and ping tasks (internally generated by MS like ping, VM sync etc.), if throttle limit is reached then these gets rejected. Since these are internally generated these can be rejected without any issues.
2014-05-22 14:15:42 +05:30
Devdeep Singh
245b7f4c39
CLOUDSTACK-6510: Fix gson serialization exception in storage migration. Gson couldn't serialize
...
a map with volume and storagepool objects for logging. Fixed by using volume and storage pool
ids instead of objects in the map.
2014-05-08 12:23:46 +05:30
root
4b89a45e57
CLOUDSTACK-3272 Latest changes to add global configuration parameters to control the publishing of events on the message bus
2014-05-07 10:09:03 +05:30
Anthony Xu
b3491bcbac
removed unused command ClusterSyncCommand
2014-05-01 11:45:19 -07:00
Harikrishna Patnala
ab39739bd8
CLOUDSTACK-6211: Xenserver - HA - SSVM fails to start due to running out of management Ip ranges when testing host down scenarios
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-04-18 17:52:49 +05:30
Prachi Damle
6397f1c82e
CLOUDSTACK-6329 [Automation] Changing service offering of VM from medium to small failing with NPE
...
- The hostAllocators were not getting set
2014-04-17 17:55:17 -07:00
Ding Yuan
c031eb7d38
CLOUDSTACK-6242: exception handling improvements
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-04-15 08:07:15 +02:00
Koushik Das
5e90b75c98
CLOUDSTACK-6402: Fix StopCommand so that VMs are not removed accidentally as part of vmsync
...
Added a new flag 'checkBeforeCleanup' to StopCommand based on which check is done to see if VM is running in HV host.
If VM is running then in this case it is not stopped and the operation bails out.
Also modified the MS code to call the StopCommand with appropriate value for the flag based on the context.
Currently it is only set to 'true' when called from the new vmsync logic based on powerstate of VM. For rest it
is set to 'false' meaning no change in behaviour.
2014-04-14 16:52:37 +05:30
Marcus Sorensen
11f5bdd78d
CLOUDSTACK-6191 Add support for specifying volume provisioning
...
type (thin, sparse, fat) in disk/compute offerings.
Submitted-by: Yoshikazu Nojima <mail@ynojima.net>
Reviewed-by: Marcus Sorensen, Mike Tutowski
2014-04-10 09:23:04 -06:00
Koushik Das
54e9a98e8b
CLOUDSTACK-6362: Parallel VM deployment - direct.agent.thread.cap needs to default to 1.0 (currently 0.1) to allow for parallel Vm deployments.
2014-04-09 12:28:01 +05:30
Alena Prokharchyk
3a889aa217
CLOUDSTACK-3886: Volume attach/detach implementation for ROOT disk
...
Implemented for Xen hypervisor only by now
Unittests are included
2014-04-03 11:39:56 -07:00
Kelven Yang
cd8801f6f7
Do app-level iteration to avoid mysql deadlocks
2014-04-02 15:46:50 -07:00
Anshul Gangwar
24820d20d3
CLOUDSTACK-6288: Changing default ImageFormat to vhdx for hyper-v and allowing registration of vhdx format templates.
...
Signed-off-by: Devdeep Singh <devdeep@gmail.com>
2014-04-01 14:00:24 +05:30
Edison Su
504a6cdee2
CLOUDSTACK-5432:sync vm and storage commands on mgt server for kvm
...
Conflicts:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
server/src/com/cloud/hypervisor/KVMGuru.java
2014-03-28 16:24:07 -07:00
Daan Hoogland
8b62b2cb92
findbugs: exclude known spiffy hacks a.k.a. false positives
2014-03-28 14:28:10 +01:00
Anthony Xu
6d103e62fe
use correct interval for cleanTask and transitionTask
2014-03-26 14:22:27 -07:00
Alex Huang
4ebb92c492
Fixed some warnings about using a deprecated constructor
2014-03-25 16:48:27 -07:00
Alex Huang
f445274ed3
Added a config to enable checking whether a db transaction is wrapped around communications with the agent. If it is, an exception is thrown. This assert has actually been there because it is part of CloudStack's design principle to not use db transactions as a way to enforce atomicity in executing things on hardware resources. However, the assert has been ignored since the move to maven which is not good with enabling asserts. Since then, there's been a lot of commands added that actually runs within db transaction. This is a big no no as the problem is that the remote operation may take a long time and the db can actually close the connection, causing a rollback of the transaction. We should not depend on transactions to enforce the atomicity anyways.
2014-03-25 16:35:49 -07:00
Anthony Xu
e3fc5a4d46
vm meta sync sync xstoolsversion as well
2014-03-24 15:48:21 -07:00
Laszlo Hornyak
2c4ac5e4d3
removed some redundant Boolean isntantiations
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-22 18:34:45 +01:00
Mike Tutkowski
7629d6f129
CLOUDSTACK-6170
2014-03-20 23:54:53 -06:00
Min Chen
a1831bc864
Revert "CLOUDSTACK-6170" due to unit test failure.
...
This reverts commit 50b5e2e247 .
2014-03-20 16:40:45 -07:00
Mike Tutkowski
50b5e2e247
CLOUDSTACK-6170
2014-03-20 16:52:52 -06:00
Murali Reddy
2b51207510
persist fact that network can span multiple zones, if network offering
...
has strechedL2Subnet capability and return the zones in which
network spans in the networkreponse object
2014-03-20 17:01:33 +05:30
Kelven Yang
ce1e53f451
Fix style-check issue after cherry-picks
2014-03-18 17:00:08 -07:00
Kelven Yang
d9506d2a05
Let VMSync be aware of HA take-over on VM state management.
2014-03-18 16:45:45 -07:00
Nitin Mehta
5d19a936a2
CLOUDSTACK-6247: Usage Events - hide them when display flag is off in the context of "Ability to have better control over first class objects in CS" feature
...
Work done for network offering.
2014-03-18 14:00:55 -07:00
Nitin Mehta
7442b56fa8
CLOUDSTACK-6247: Usage Events - hide them when display flag is off in the context of "Ability to have better control over first class objects in CS" feature
...
And when the flag is updated on the resource accordingly generate usage events again.
Also when display flag is false in deployvm cmd it should be false for the volumes associated with the vm as well
2014-03-18 14:00:25 -07:00
Daan Hoogland
e7e4753979
checkstyle: trailing spaces
2014-03-18 12:35:10 +01:00
edison
ed9ed446c2
CLOUDSTACK-5432: potential bugs in case of stop mgt server while
...
template is downloading, template_store_ref has leftover not in ready
state, when create vm from that template, the code doesn't check either
zone id, nor template_store_ref state.
Conflicts:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
2014-03-18 12:20:14 +01:00
Marcus Sorensen
d638d04cbf
CLOUDSTACK-6181: Merge of resize root feature (resize-root branch)
2014-03-14 07:17:33 -06:00
Min Chen
ae1d6a771b
Remove IAMEntityType to use existing VO interface class to annotate
...
entityType.
2014-03-17 17:19:55 -07:00
Mike Tutkowski
d55c4dd804
CLOUDSTACK-6170
2014-03-14 23:47:20 -06:00
Kelven Yang
5e4a4e8b34
Fix a regression that caused API job to return prematurely.
2014-03-14 17:31:16 -07:00
Kelven Yang
ec01791936
Fix the missing java imports from automatic merge
2014-03-14 14:22:23 -07:00
Kelven Yang
12f7cbcb76
Deal with concurrent state update for VM and Host objects.
2014-03-14 14:07:39 -07:00
Hugo Trippaers
4402685e11
Update master to 4.5.0-SNAPSHOT
2014-03-14 14:55:26 +01:00
Kelven Yang
4399e245f4
A typo that leads to opposite decision on determine whether or not to notify out-of-band VM state changes.
2014-03-13 17:17:15 -07:00
Kelven Yang
5a75a3e1f9
Give graceful state transition period to live with race-condition on VM startup time
2014-03-13 16:59:56 -07:00
Kelven Yang
6ad245e675
Restore to old HA logic, but suppress VM state change on resource state report to avoid interferring HA.
2014-03-13 16:59:56 -07:00
Kelven Yang
53f306e8e2
Send StopCommand(Cleanup) if out-of-band power-off VM is detected.
2014-03-13 16:59:56 -07:00
Min Chen
84a528fad6
Merge branch 'master' into rbac
2014-03-13 14:52:37 -07:00
Min Chen
99bdc8d875
Merge branch 'master' into rbac.
2014-03-13 11:05:03 -07:00
Alena Prokharchyk
1b83698dac
deployVm/startVm APIs: ability to define deploymentPlanner for VmToStart in the api call (available to ROOT admin only)
2014-03-13 10:23:34 -07:00
Sheng Yang
f45de30d1b
CLOUDSTACK-6047: Enable VR aggregation commands for VR start/reboot
2014-03-11 13:04:26 -07:00
Sanjay Tripathi
c7d31fe288
CLOUDSTACK-4760 : Enabling GPU support for XenServer.
...
CLOUDSTACK-4762 : Enabling VGPU support for XenServer.
This feature is to enable the GPU-passthrough and vGPU functionality,
with the help of this feature, admins/users will be able to leverage
the GPU graphics unit power by deploying a virtul machine with GPU or
vGPU support or by changing the service offering of an existing VM
at any later point of time. There GPU/vGPU enabled VMs are able to run
graphical applications.
For now, this feature is only supported with XenServer hypervisor but
can be extended to add the support of other hypervisors.
2014-03-11 15:44:51 +05:30
Mike Tutkowski
1d74daf6fe
CLOUDSTACK-6170
2014-03-10 11:43:54 -06:00
Mike Tutkowski
c427e8db1c
CLOUDSTACK-6170
2014-03-07 15:38:50 -07:00
Min Chen
48e08fe676
Merge branch 'master' into rbac.
2014-03-06 14:02:20 -08:00
Anthony Xu
370554e9d9
only ping timeout trigger host HA, otherwise there may be two threads try to HA the same VM
2014-03-05 16:50:33 -08:00
Anthony Xu
ad88bbb684
Use seperate path to sync VM metadata for XS
...
VM status sync only does VM status sync
2014-03-05 15:44:50 -08:00
Anthony Xu
ab1d3af460
Use seperate path to sync VM metadata for XS
...
VM status sync only does VM status sync
2014-03-05 15:44:50 -08:00
Mike Tutkowski
b06e66c50a
CLOUDSTACK-6170
2014-03-05 13:55:12 -07:00
Alena Prokharchyk
5a8d165afa
CLOUDSTACK-6198: use List DS for storing NicProfiles as public network can have more than one nic
...
Conflicts:
engine/api/src/com/cloud/vm/VirtualMachineManager.java
engine/api/src/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java
plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java
server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
server/test/com/cloud/vpc/MockNetworkManagerImpl.java
services/secondary-storage/controller/src/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java
2014-03-04 15:37:52 -08:00
Kelven Yang
90262a81ec
Do not do investigation for SSVM/CPVM agent host upon disconnect.
2014-02-28 15:36:00 -08:00
Kelven Yang
b21662f890
make sure XS report VM state even if there is no running VM on the host.
2014-02-28 15:35:59 -08:00
Kelven Yang
7c7bd0934a
pass InsufficientCapacityException across job boundary since some HA logic relies on it. Reviewed-By: Self
2014-02-28 15:35:59 -08:00
Kelven Yang
537bf7ced1
add job path to help associate an API job to related internal job. Reviewed-By: Self
2014-02-28 15:35:59 -08:00
Kelven Yang
fed85813e9
use lock table for locking
2014-02-28 15:35:58 -08:00
Kelven Yang
e6e12e33de
VirtualMachineManager.checkWorkItems() uses wrong time unit
2014-02-28 15:35:58 -08:00
Kelven Yang
38a1300141
pass NULL host when performing state transition to follow-up with VM power-off report
2014-02-28 15:35:58 -08:00
Kelven Yang
fa7d9ad1a8
VirtualMachineManager.migrateAway() need to put under management of new sync model
2014-02-28 15:35:58 -08:00
Kelven Yang
434f8dab72
Remove the hacking way of blocking VM state transition introduced by individual VM snapshot orchestration flow
2014-02-28 15:35:58 -08:00
Kelven Yang
58c26ee128
return the correct NicProfile after job completion for VPC AddVmToNetwork command
2014-02-28 15:35:58 -08:00
Kelven Yang
18b5fb5a3c
do not shutdown alien VMs upon host startup. Send StopCommand for out-of-band stopped VM to restore legacy XS/KVM behave
2014-02-28 15:35:58 -08:00
Kelven Yang
85adaf83c7
check report-missing event for VM in starting state.
2014-02-28 15:35:57 -08:00
Kelven Yang
13e956a10c
Add a missing initialization call to setup EntityManager in VmMigrateWork
2014-02-28 15:35:57 -08:00
Kelven Yang
86a63c49bc
propagate job execution runtime exception to API context
2014-02-28 15:35:57 -08:00
Kelven Yang
206a9ed53f
disable XS full host sync and delta sync when new sync model is enabled
2014-02-28 15:35:57 -08:00
Kelven Yang
90ea3249a8
disable cluster-scope report from XS resource
2014-02-28 15:35:57 -08:00
Kelven Yang
5d73217723
process the missing power report of a VM that exists in CloudStack but not in hypervisor
2014-02-28 15:35:57 -08:00
Kelven Yang
fda7219646
CLOUDSTACK-5928: disable host delta sync when new VM sync is enabled
2014-02-28 15:35:57 -08:00
Kelven Yang
441be43b8c
CLOUDSTACK-5358: Bring back concurrency control in sync-queue management
2014-02-28 15:35:57 -08:00
Prachi Damle
f41604fc6c
Renaming AclEntityType --> IAMEntityType
2014-02-25 16:43:17 -08:00
wrodrigues
3a7e4103fc
FindBugs findings: fixing equals() methods in 2 classes; commenting out dead variable in 1 class; adding 5 tests to cover the changes in the equals() methods.
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-25 15:18:16 +01:00
Koushik Das
167babd8c8
CLOUDSTACK-6124: During MS maintenance unfinished work items are not cleaned up resulting in them getting repeated for every subsequent maintenance
...
Updating the op_it_work table entry appropriately in db once the unfinished work item is completed.
2014-02-21 16:29:51 +05:30
Hugo Trippaers
97bad4f9b3
Fix checkstyle and license issues
2014-02-14 18:37:47 +01:00
Hugo Trippaers
26b32141a8
Findbugs : Fixes for several findings
...
Made a comment on the use of ConcurrentHashMap for _agent
Conflicts:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
2014-02-14 18:37:45 +01:00
Marcus Sorensen
df77c4310a
CLOUDSTACK-6103: Pass VM iso information along with
...
PrepareForMigrationCommand, so that destination hypervisor can
mount pool. This further exposed an issue for KVM where iso
was not getting cleaned up upon successful migration, fixed as well.
2014-02-14 00:34:48 -07:00
Daan Hoogland
8e4d020cf8
remove nic with dhcp and tests
...
Signed-off-by: Alena Prokharchyk <alena.prokharchyk@citrix.com>
2014-02-13 10:39:02 -08:00
Alena Prokharchyk
e0de79b170
Resource metadata: by default, all metadata is set with display=true (meaning that the detail is avaialble for display to the regular user). If admin wants to set a specific detail to be false, he has to specify it explicitly in addResourceDetail command
2014-02-10 12:05:59 -08:00
Min Chen
3b58a45e04
Merge branch 'master' into rbac.
2014-02-07 13:43:36 -08:00
Soheil Eizadi
6523c06869
NetworkManager Exception Fix Due to call to getDhcpServiceProvider()
2014-02-05 17:14:05 +01:00
Prachi Damle
f84375442e
Merge branch 'master' into rbac
...
Conflicts:
api/src/org/apache/cloudstack/api/command/user/autoscale/ListAutoScaleVmProfilesCmd.java
api/src/org/apache/cloudstack/api/command/user/volume/ResizeVolumeCmd.java
plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
server/src/com/cloud/api/ApiServer.java
server/src/com/cloud/api/query/QueryManagerImpl.java
server/src/com/cloud/template/TemplateAdapterBase.java
setup/db/db/schema-430to440.sql
tools/apidoc/gen_toc.py
2014-02-04 12:07:32 -08:00
Prachi Damle
022b9b8f80
Add access for domain wide createAffinityGroup
2014-02-03 18:14:56 -08:00
Prachi Damle
a6d07c873c
Changes to QuerySelector to list the parent group resources with recursive = true access
2014-02-03 17:49:33 -08:00
Prachi Damle
939b15169c
changes to support the domain wide resources for Network
2014-02-03 17:34:03 -08:00
Daan Hoogland
9778481d85
findbugs: handling of long values and wrappers
2014-02-03 20:19:11 +01:00
Koushik Das
580ebb0010
CLOUDSTACK-5989: Trying to start a vm while 'vm snapshot' is in progress results in inconsistency
...
The fix is to fail the start operation if a vm snapshot is in progress
2014-01-31 10:39:43 +05:30
Prachi Damle
d12422bf68
Add policies to domain group for CreateNetwork usecase for a domain wide shared network
2014-01-29 23:56:25 -08:00
Laszlo Hornyak
ebf57654e7
replaced Long instantiations with Autoboxing
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-01-25 15:01:03 +01:00
Mike Tutkowski
b5b4607f79
CLOUDSTACK-5873: [Automation] Failed to attach volume to VM, if the vm is created with option startvm=false
2014-01-22 11:17:39 -07:00
Mike Tutkowski
90e945fd74
Fixing an issue with expunge logic
2014-01-20 16:25:39 -07:00
Mike Tutkowski
37332ad9d4
CLOUDSTACK-5873: [Automation] Failed to attach volume to VM, if the vm is created with option startvm=false
2014-01-18 18:07:10 -07:00
Kelven Yang
a9733b5df2
CLOUDSTACK-5731: Use general instance type to categorize VM work jobs to correctly serialize VM operations
2014-01-17 11:55:14 -08:00
Anthony Xu
58a9a9b0cd
only send stop command when agent reports VM running and CS thinks it is stopped.
2014-01-17 11:50:13 -08:00
Prachi Damle
8a20d89d14
CLOUDSTACK-5895: CreateVolumeFromSnapshot can fail in a multiple pod environment with tagged storagepool
...
Changes:
- After finding the storagepool suitable to create the volume, we should not look for more pods
2014-01-17 11:22:20 -08:00
Mike Tutkowski
e9c9887ee0
CLOUDSTACK-5873: [Automation] Failed to attach volume to VM, if the vm is created with option startvm=false
2014-01-16 12:20:54 -07:00
Kelven Yang
7164fc6e73
CLOUDSTACK-5696: Fix sync issue with out-of-band changes
2014-01-15 13:11:02 -08:00
Murali Reddy
af657b3d71
CLOUDSTACK-5861: networks that failed to implement can not be destroyed
...
introduces a force option in delete network to forcifully delete a
network. This comes handy in rare cases where network fails to implenet
and network is in shutdown state, but network shutdown to rollback
implement process fails as well.
Conflicts:
api/src/org/apache/cloudstack/api/command/user/network/DeleteNetworkCmd.java
server/src/com/cloud/user/DomainManagerImpl.java
2014-01-13 23:28:35 +05:30
Mike Tutkowski
7ef78aac40
Merge from 4.3: CLOUDSTACK-5662: XenServer can't discover iSCSI targets with different credentials
2014-01-09 22:37:39 -07:00
Mike Tutkowski
6944bf9bba
Merge from 4.3: CLOUDSTACK-5662: XenServer can't discover iSCSI targets with different credentials
2014-01-09 22:02:43 -07:00
Kelven Yang
1e2e1ea051
CLOUDSTACK-5765: cleanup internal serialization and exception propagation issues
2014-01-09 14:29:13 -08:00
Kelven Yang
0965adb003
CLOUDSTACK-5672: Fix VM work job serialization issues in Add/Remove nic
2014-01-09 14:29:12 -08:00
Kelven Yang
87381d4236
CLOUDSTACK-5725: put origin flow context id into log4j context prefix to link jobs with the orchestration work flow in logging
2014-01-09 14:29:12 -08:00
Kelven Yang
ad6454d2bf
CLOUDSTACK-5767: Remove the logic of using underlying job related fields for volume specific logic.
2014-01-09 14:29:12 -08:00