Kelven Yang
54f177cacc
1) Make generic dao be able to persist UTF-8 string for internationalization support
...
2) Undo gson Unicode escape in API response object to avoid double escaping which can break Javascript from getting correct text content
3) Correct API layer in dealing with character encoding
4) Remove double escape in cloud.core.js
2010-11-30 09:40:54 -08:00
Kelven Yang
fa9c882d8c
Add VMWare hypervisor guru
2010-11-30 09:40:53 -08:00
nit
06c61f2fac
bug 7325 : We shouldn't allow attaching xen-pv-iso to any hypervisor other than xenserver.
...
status 7325: resolved fixed
2010-11-30 22:20:33 +05:30
nit
a6a774f6c0
bug 7369 : Resolving NPE while creating a private template from detached volume. The instance id is null when it is detached which was the culprit here.
...
status 7369: resolved fixed
2010-11-30 15:49:29 +05:30
anthony
fb0675bbf4
bug 7365: return both physical and virutal size when creating private template
...
status 7365: resolved fixed
2010-11-29 18:58:48 -08:00
anthony
d3325de5ae
1. limit xs-tools in xenserver related java file
...
2. don't populate xs-tools to template_host_ref
3. introduce a new template type PERHOST, which doesn't need to be populated to secondary storage
2010-11-29 18:21:08 -08:00
abhishek
0273872b34
bug 7362: we were missing the size validation check, when we create a volume from disk offering (the storage.max.volume.size param wasn't being used for validation). Fixed the same, made the validation method name more generic to be applicable to all validations, and changed the param description to denote GB as the unit
...
status 7362: resolved fixed
2010-11-29 17:23:16 -08:00
abhishek
bdf4426609
fixing the same issue in another command (found whilst checking references)
2010-11-29 13:38:06 -08:00
abhishek
1a0ec2a00f
bug 7346: fixing the corner case where list ip forwarding rules is called for a rule, which is yet to be expunged, but the vm is destroyed. if you call list here, an npe results
...
status 7346: resolved fixed
2010-11-29 13:35:04 -08:00
abhishek
dce3f9fa3b
bug 7344: preventing enabling of static nat on an ip for more than one instance. Check the nat flag, and error out if set
...
status 7344: resolved fixed
2010-11-29 11:56:34 -08:00
anthony
385054fccf
bug 7338: update template physical size
...
status 7338: resolved fixed
2010-11-29 11:23:47 -08:00
Alex Huang
d40700b286
Changed firewall rule's constructor
2010-11-29 09:38:13 -08:00
anthony
30fa6530f9
bug 6088: track template physical size in template_host_ref table
...
add migration from 21 to 22
after migration , SSVM needs to stop/start
status 6088: resolved fixed
2010-11-24 20:05:52 -08:00
Kelven Yang
23f274cfd2
Send AttachVolume command even if VM is not in running state under vmware case
2010-11-24 15:17:09 -08:00
Kelven Yang
dd9b1634f7
Allow host behind cluster to return real VNC host IP address
2010-11-24 15:17:08 -08:00
Kelven Yang
fd1beef28b
Someone commited a change in ConsoleProxyManagerImpl that breaks down system VM, let's blame git for now on this
2010-11-24 15:17:07 -08:00
alena
aa8aa6027a
Modified UserContext - got rid of accountName, domainId fields as we can get this information from Account field.
2010-11-24 14:29:08 -08:00
abhishek
1950bf7a99
changing the nat feature to work with kvm
2010-11-24 10:04:24 -08:00
alena
44737d24c5
bug 7196: fixed response object generation for authorizeNetworkGroupIngress command (response type is Network group response - the way it was in 2.1.x - instead of IngressRule response)
...
status 7196: resolved fixed
Also fixed revokeNetworkGroup command - didn't work via 8096 port
2010-11-24 09:50:04 -08:00
nit
d0530265d7
bug 7046 : Global admins should be allowed to extract all the times.
...
status 7046: resolved fixed
2010-11-24 19:33:15 +05:30
nit
841044e360
Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss
2010-11-24 18:38:23 +05:30
nit
8ea124ae79
bug 7046 : extracting templates should allow for exclusion of some templates. An attribute "extractable" would be set on templates by the template owner at upload time. It would specify if we allow the template to be extracted from the system. Default would be true ie "allow extraction". If set to false, it would not be possible to extract the template or any derivatives of the template. For example, volumes, snapshots or templates from that template.
...
status 7046: resolved fixed
2010-11-24 18:37:54 +05:30
kishan
f70071dc98
bug 6309: Added event VM.UPDATE along with changed fields
...
status 6309: resolved fixed
2010-11-24 18:36:35 +05:30
kishan
19dcbb8d8e
bug 7246: changed event name to TEMPLATE.CLEANUP when cleaning up templates on sec storage. Usage won't track this event
...
status 7246: resolved fixed
2010-11-24 17:48:19 +05:30
anthony
c39d211a48
merge from 2.1.x
2010-11-23 18:55:23 -08:00
abhishek
5543814f39
blocking the static natting of an ip address, if it is already source natted
2010-11-23 16:39:02 -08:00
abhishek
3d4b8ab4a0
bug 7263: changing the param name. Found a couple of bugs whilst testing this, the validation of vol size whilst cust vol creation was missing. Adding the same.
...
status 7263: resolved fixed
2010-11-23 16:20:30 -08:00
alena
f4908758b3
bug 7234: don't try to delete pod level vlan when it doesn't exist
...
status 7234: resolved fixed
2010-11-23 15:06:29 -08:00
alena
cb74030d01
bug 7298: throw an Exception when invalid job Id is specified in queryAsyncJobResult
...
status 7298: resolved fixed
2010-11-23 15:06:29 -08:00
abhishek
40c3a0afa2
bug 7249: during volume creation (root and data) for a vm, there was no state being set (we need to set it to ready). Hence, whilst re-attaching a detached vol, we hit a NPE. Fixed the root cause of the state not being set during vm creation, and consequently, fixed this npe
...
status 7249: resolved fixed
2010-11-23 14:24:29 -08:00
will
90467ab31d
merge 7277: Fixed the file separate so Extract Template works on Windows machine.
2010-11-23 11:13:47 -08:00
alena
10fb2a0f39
bug 7292: fixed assignig LB to non-source Nat ip address
...
status 7292: resolved fixed
2010-11-22 20:54:08 -08:00
will
7205a7507d
bug 7277: Fixed the logic to prevent System templates from being downloaded.
2010-11-22 17:13:30 -08:00
alena
3f1abbcbc8
Fixed assignToLoadBalancer command - admin couldn't assing LB rule in behalf of other user
2010-11-22 17:08:51 -08:00
abhishek
8995e5d2f7
changing the event logged to the right type, whilst starting user vms via cancelstoragemaintenance in master (already merged to 2.2.beta1)
2010-11-22 16:20:18 -08:00
alena
1491893bbc
bug 7281: throw an exception when fail to get isoPath - happens when Secondary Storage vm is not in UP state in cloud.hosts table.
...
status 7281: resolved fixed
2010-11-22 15:42:34 -08:00
alena
a646745516
bug 7227: applying Alex's fix - different way of desirializing List objects.
...
status 7227: resolved fixed
2010-11-22 14:08:43 -08:00
alena
6765e97976
Made ApiResponseHelper to use Long instead of long for response parameters to eliminate possible NPEs during building an api response.
2010-11-22 11:27:15 -08:00
alena
cdea2d210d
Better logging for api exceptions.
2010-11-22 11:27:15 -08:00
abhishek
0979b644ef
bug 7230: there was an issue trying to start user vms when the pool state is cancelmaintenance; fixing the same in 2.2RC2
...
status 7230: resolved fixed
2010-11-22 11:00:43 -08:00
Alex Huang
d38f7fd56d
Moved DAO to server
2010-11-22 07:40:41 -08:00
Alex Huang
1e44925564
api refactoring
2010-11-21 12:00:21 -08:00
alena
138e0914b6
bug 7245: don't try to set vm name for detached volume during expunge process.
...
status 7245: resolved fixed
Fixed couple of other problems:
* cleanup corresponding records in load_balancer_vm_map table when loadBalancerRule is removed.
* don't log "java.lang.IllegalStateException: getAttribute: Session already invalidated" exception when UI session expires
2010-11-19 20:08:18 -08:00
alena
6b61caad46
AssignToLoadBalancer - added missing transaction.commit to corresponding NetworkManager method.
2010-11-19 19:14:24 -08:00
alena
cec8ebd5cd
bug 7236: don't catch AsyncCommandQueued exception in ApiDispatcher
...
status 7236: resolved fixed
2010-11-19 18:40:32 -08:00
alena
5426b1487c
listPortForwardingRules: return empty response instead of throwing exception when ipAddress doesn't have any rules assigned.
2010-11-19 18:40:32 -08:00
abhishek
ca162bca11
bug 6936: for some reason, we had a check on pod-wide or account specific vlan creation. This seems to be a left over from legacy code. Removing the same. I tested to make sure both zone wide vlan and account specific vlan creation for direct tagged case works fine
...
status 6936: resolved fixed
2010-11-19 17:54:57 -08:00
alena
e1b74ea99e
RegisterTemplateCommand - ignore case in "hypervisor" parameter value - used to complain when "xen" was specified instead of "Xen"
2010-11-19 16:27:05 -08:00
alena
fe93821bb1
Fixed editZone command - if dns2 is not specified, keep the old value instead of updating it to NULL
2010-11-19 16:13:45 -08:00
Anthony Xu
fa499dadbc
bug 7220: the parameter type transfer may cause NPE
...
status 7220: resolved fixed
2010-11-19 15:56:04 -08:00
alena
a5dfaaf31b
API exception handling - print api command name to the log.
2010-11-19 15:48:58 -08:00
Alex Huang
5b4a6f27db
Changed networkconfigurations to network as per Sheng's suggestion
2010-11-19 15:44:42 -08:00
alena
a495f34d4f
Fixed enableAccount command - domain permission check was done incorrectly
2010-11-19 15:25:29 -08:00
alena
8362d0feba
Reverting back commit e5c137e303 as it wasn't meant to be in 2.2 RC1.
2010-11-19 14:23:39 -08:00
alena
e5c137e303
bug 7223: pagesize and page should be specified together in "list" api commands
...
status 7223: resolved fixed
2010-11-19 14:03:44 -08:00
edison
0c35f2f743
bug 7237: disk size is passed in diskProfile, no need size parameter in createcommand
...
status 7237: rresolved fixed
2010-11-19 11:55:27 -08:00
Chiradeep Vittal
394554770e
Enforce user limit on number of vpn users
2010-11-18 18:38:29 -08:00
alena
a0eaf32cad
Fixed updateAccount command to work via 8096 port.
2010-11-18 17:35:41 -08:00
alena
0b2b8e31d8
Fixed updateUser command - didn't work correctly via 8096 port (user account info was taken from UserContext instead of User object).
2010-11-18 17:07:20 -08:00
abhishek
d222a52ccb
bug 7232: resolving the sql exception
...
status 7232: resolved fixed
2010-11-18 16:47:08 -08:00
abhishek
317554d983
ensuring all the following have api values taken in, in GB (disk offering, service offering, custom vol creation and vm creation from cust disk offering)
2010-11-18 14:32:50 -08:00
Chiradeep Vittal
c53e165eaa
bug 6971: bring back l2tp port 1701
2010-11-18 14:06:01 -08:00
Chiradeep Vittal
a7547846bf
bug 6971: Dont confuse PF rules added for VPN to be LB rules
2010-11-18 14:05:28 -08:00
abhishek
6ae21932eb
realized that the var name used in response code might be confusing to a new reader. changing the name to be more intuitive
2010-11-18 11:20:01 -08:00
abhishek
18ff23c839
added a list method to list ip forwarding rules, optionally list a rule based on its public ip address
2010-11-18 11:15:13 -08:00
abhishek
020afa6e33
adding a list command for ip forwarding rules for 1:1 nat, to be consumed by the ui
2010-11-18 11:15:13 -08:00
abhishek
c4f1b35aef
returning the public ip address in the creation of firewall rule, for the UI to consume
2010-11-18 09:42:47 -08:00
alena
829d7482b3
bug 6864: allow domain admin to see only vms belonging to his domain and child domains
...
status 6864: resolved fixed
2010-11-17 23:09:19 -08:00
alena
91a87f9d8f
bug 7155: fixed NPE in AuditTrial which used to happen when logout command was executed when session was already invalidated.
...
status 7155: resolved fixed
2010-11-17 21:42:51 -08:00
alena
28dd8185dd
Fixes for listDomains API command:
...
* return all domains in the system when command is executed via 8096
* for domain admin return only his domains and subdomains.
2010-11-17 21:28:12 -08:00
alena
6f44238109
Fixed listDomainChildren api - now we can search by name when isRecursive flag set.
2010-11-17 20:40:39 -08:00
alena
a95b853a17
bug 6898: updateResourceLimit command requires domainId or account/domainId now if executed via 8096 port
...
status 6898: resolved fixed
2010-11-17 19:43:06 -08:00
alena
97a8349110
bug 6894: removed "account" request parameter in listAccounts command. Should use "name" if need to make search by account name
...
status 6894: resolved fixed
2010-11-17 19:21:02 -08:00
Alex Huang
a73e3dc9ac
new networking can be set by use.new.networking
2010-11-17 17:51:17 -08:00
Chiradeep Vittal
4c7bb302bc
bug 6971: Use PSK length configuration
...
validate global configurations
2010-11-17 16:32:50 -08:00
Kelven Yang
5490577469
1) Remove forwarding between eth1 and eth2 as it does not solve the problem of asymmetic routing
...
2) correct Eclipse project settings
3) If VM is hosted by vmware hypervisor, give the previous host preference to start on to fit VMware's VM-centric model
2010-11-17 15:55:04 -08:00
alena
9fefa33a36
bug 5701: listNetworkGroups api - apply page size parameter to the NetworkGroup instead of IngressRule.
...
status 5701: resolved fixed
2010-11-17 15:34:45 -08:00
Chiradeep Vittal
9640f12cce
bug 6971: revert some changes
2010-11-17 15:33:10 -08:00
Chiradeep Vittal
31e17b907d
bug 6971: ensure no conflicts with portforwarding rules for vpn udp ports
...
also, do not open up port 1701 -- only used on ppp interface not public interface
also clean up password generator, make it easier to use and more secure
moved some constants to NetUtils
heuristic to determine if an ip is one-to-one nat'ted
2010-11-17 15:32:50 -08:00
alena
2184dd1af2
bug 7195: introduced search by forVirtualNetwork parameter in listVmsCmd. Added "forVirtualNetwork" param to responses for all VM's apis.
...
status 7195: resolved fixed
2010-11-17 14:11:16 -08:00
abhishek
38292fcd02
bug 6929: we prevent upgrading of a router with a SO different from the type it was created with (eg. prevent a virtual offfering being upgraded to direct)
...
status 6929: resolved fixed
2010-11-17 12:59:54 -08:00
abhishek
1d1a2fa691
bug 6448: returning an error back from the api on trying to add a pf rule which already exists
2010-11-17 11:50:05 -08:00
alena
59b07f8047
bug 7162: made listZones by id work
...
status 7162: resolved fixed
2010-11-17 10:46:38 -08:00
alena
f2c1291f6d
Don't allow to update zone with new guestVlan range if the zone's network type is Basic
2010-11-17 10:46:38 -08:00
alena
c229e18a1e
Don't try to create guest vlan range for Default zone as it has Basic network type
2010-11-16 18:20:26 -08:00
abhishek
20262803fe
added entry for networktype to dbconfig for zone creation
2010-11-16 18:01:39 -08:00
alena
dae39942f1
bug 7192: Added networktype parameter for the zone
...
status 7192: resolved fixed
1) Zone has networktype parameter now, 2 values are supported: Basic and Advanced. "networktype" field is created in data_center table. The parameter is being set at creation time; we don't allow to modify it with updateZone command.
2) Only vlan of Untagged Direct type can be created in Basic network zone; any other vlan except for Untagged Direct can be created in Advanced zone
3) Allow NULL guest vlan range for the zone. Only vlan of Direct type can be created in zone with NULL guest vlan.
4) "Default" zone is Basic by default.
5) Changed "vnet" parameter to "vlan" in updateZone command to be consistent with createZone
2010-11-16 16:54:44 -08:00
abhishek
7575a03663
bug 6861: we were setting the account cleanup flag incorrectly, even for a vol which was never attached to a vm. Fixing the same
...
status 6861: resolved fixed
2010-11-16 16:11:55 -08:00
abhishek
10cfe07970
bug 6793: returning the right msg to the ui when we try to log in to a locked account
2010-11-16 14:15:08 -08:00
abhishek
e5e128545d
removing the tags support in the update commands for disk and service offerings
2010-11-16 13:25:25 -08:00
abhishek
0876136dc4
bug 7185: the tags logic in the update disk,service offerings was wrong. once a tag is created, it should not be modified. we should only append to the existing list of tags, adding more tags. fixing the same
...
status 7185: resolved fixed
2010-11-16 12:51:36 -08:00
alena
c5d78a726e
Modified exception handing in API. Following exceptions are supported now (location - BaseCmd.java):
...
* MALFORMED_PARAMETER_ERROR - when type of the request parameter is invalid (String instead of Long for id for example)
* PARAM_ERROR - when invalid parameter value is specified in api request. For example, id of non existing vm for StartVmCmd
* ACCOUNT_RESOURCE_LIMIT_ERROR - when user tries to exceed his resource limits by executing the api command.
* INSUFFICIENT_CAPACITY_ERROR - when resource fails to create/start due to insufficient capacity.
* RESOURCE_UNAVAILABLE_ERROR - when user tries to create a vm when storage is not available.
* RESOURCE_IN_USE_ERROR - when user tries to delete/modify resource while it's in use. For example, when we try to delete a network group when it contains ingress rules.
* NETWORK_RULE_CONFLICT_ERROR - when LB/PF rule to add conflicts with existing rule
* ACCOUNT_ERROR - when user is not authorized to execute operation on the resource.
* INTERNAL_ERROR
2010-11-16 11:56:34 -08:00
abhishek
92e3dc91c4
found a bug in the code where we were not decoding the params sent in eg. "a b" was being stored in the db as 'a%20b'. Fixing the same to have the right val persisted to the db
2010-11-16 11:46:55 -08:00
Alex Huang
ed31497188
ComponentLocator changes
2010-11-16 04:28:15 -08:00
Alex Huang
17afeade00
better componentslocator
2010-11-16 04:28:14 -08:00
alena
d43a8e983c
Fixed authorizeNetworkGroupIngress api command (it stopped working after API refactor)
2010-11-15 17:44:51 -08:00
alena
1a8d9a92a7
Modified all api calls to throw ApiServerException if null object is returned by the manager.
2010-11-15 17:44:51 -08:00
abhishek
d5ab597fcf
bug 6474,6475: porting over the expunge fixes for port forwarding rules to 2.2
...
status 6474,6475: resolved fixed
2010-11-15 17:33:05 -08:00
abhishek
c115a2e401
bug 7189: returning vmdisplayname if available for all port fwding crud cmds
...
status 7189: resolved fixed
2010-11-15 14:55:03 -08:00
abhishek
1e8d5675f6
bug 6865: fixing the alerts code which was broken; hence no alerts were being sent out
...
status 6865: resolved fixed
2010-11-15 14:38:39 -08:00