Commit Graph

226 Commits

Author SHA1 Message Date
abhishek 8995e5d2f7 changing the event logged to the right type, whilst starting user vms via cancelstoragemaintenance in master (already merged to 2.2.beta1) 2010-11-22 16:20:18 -08:00
abhishek 0979b644ef bug 7230: there was an issue trying to start user vms when the pool state is cancelmaintenance; fixing the same in 2.2RC2
status 7230: resolved fixed
2010-11-22 11:00:43 -08:00
Alex Huang d38f7fd56d Moved DAO to server 2010-11-22 07:40:41 -08:00
Alex Huang 1e44925564 api refactoring 2010-11-21 12:00:21 -08:00
alena 138e0914b6 bug 7245: don't try to set vm name for detached volume during expunge process.
status 7245: resolved fixed

Fixed couple of other problems:
* cleanup corresponding records in load_balancer_vm_map table when loadBalancerRule is removed.
* don't log "java.lang.IllegalStateException: getAttribute: Session already invalidated" exception when UI session expires
2010-11-19 20:08:18 -08:00
Anthony Xu fa499dadbc bug 7220: the parameter type transfer may cause NPE
status 7220: resolved fixed
2010-11-19 15:56:04 -08:00
Alex Huang 5b4a6f27db Changed networkconfigurations to network as per Sheng's suggestion 2010-11-19 15:44:42 -08:00
edison 0c35f2f743 bug 7237: disk size is passed in diskProfile, no need size parameter in createcommand
status 7237: rresolved fixed
2010-11-19 11:55:27 -08:00
abhishek 317554d983 ensuring all the following have api values taken in, in GB (disk offering, service offering, custom vol creation and vm creation from cust disk offering) 2010-11-18 14:32:50 -08:00
Kelven Yang 5490577469 1) Remove forwarding between eth1 and eth2 as it does not solve the problem of asymmetic routing
2) correct Eclipse project settings
3) If VM is hosted by vmware hypervisor, give the previous host preference to start on to fit VMware's VM-centric model
2010-11-17 15:55:04 -08:00
alena c5d78a726e Modified exception handing in API. Following exceptions are supported now (location - BaseCmd.java):
* MALFORMED_PARAMETER_ERROR - when type of the request parameter is invalid (String instead of Long for id for example)
* PARAM_ERROR - when invalid parameter value is specified in api request. For example, id of non existing vm for StartVmCmd
* ACCOUNT_RESOURCE_LIMIT_ERROR - when user tries to exceed his resource limits by executing the api command.
* INSUFFICIENT_CAPACITY_ERROR - when resource fails to create/start due to insufficient capacity.
* RESOURCE_UNAVAILABLE_ERROR - when user tries to create a vm when storage is not available.
* RESOURCE_IN_USE_ERROR - when user tries to delete/modify resource while it's in use. For example, when we try to delete a network group when it contains ingress rules.
* NETWORK_RULE_CONFLICT_ERROR - when LB/PF rule to add conflicts with existing rule
* ACCOUNT_ERROR - when user is not authorized to execute operation on the resource.
* INTERNAL_ERROR
2010-11-16 11:56:34 -08:00
abhishek 6d943abf55 bug 7119: code refactor away from the ms calls, to the share and prepare methods based on alex's recommendations
status 7119: resolved fixed
2010-11-15 11:17:36 -08:00
anthony 2537dc3058 bug 7149: merge from 2.1.x 2010-11-12 13:16:03 -08:00
abhishek e79e432807 we were using debug logging without checking ifDebugEnabled(), fixing that 2010-11-11 17:20:57 -08:00
abhishek fcd7f37839 bug 7037: adding more logging to the deletepool cmd
status 7037: resolved fixed
2010-11-11 17:20:57 -08:00
edison f30d3f4839 don't break other people 2010-11-11 17:13:21 -08:00
edison 0db9303bca don't break others 2010-11-11 17:04:10 -08:00
edison 8ca6f1669e start2command fro secondarys storage vm and make it work for KVM 2010-11-11 17:04:10 -08:00
edison 40481cfe6e add start2command for secondarystorage vm 2010-11-11 17:04:10 -08:00
edison 393666feea start2command for secvm 2010-11-11 17:04:10 -08:00
abhishek 709fc3686f another fix for a related bug on data volumes I found whilst testing the parent bug 2010-11-11 16:39:15 -08:00
abhishek 968dc0616f bug 7021: data disk wasn't being created for custom sizes. Also, we were having max size checks in GB, whereas disk offerings are in MB. Made the change there as well.The storage allocators were commented out in master, uncommented them.
Status 7021: resolved fixed
2010-11-11 15:45:21 -08:00
will a69f961bd8 bug 5903: Reworked the entire UI to accomodate the new snapshot policy in 2.2.
- Fixed issues with deleting snapshot policies
- Fixed maxsnaps being set wrong in the DB.
2010-11-10 19:19:18 -08:00
nit 351f98ceef bug 5363: SNAPSHOT.CREATE - Add Started event.
status 5363: resolved fixed
2010-11-09 19:37:01 +05:30
anthony 8df96da0a5 don't delete template if template check fail, give user a chance to check the template manually
use can delete the template though UI
2010-11-08 21:03:59 -08:00
anthony 4646be7587 for recursive snapshot, use UID_SYSTEM instead 2010-11-08 18:08:08 -08:00
anthony 0febfb4938 don't reschedule manual snapshot 2010-11-08 18:08:08 -08:00
anthony 3aad88e94b reschedule all polocies after management server restart, in case some schedules are missing 2010-11-08 18:08:08 -08:00
anthony 71a670defc snapshot code cleanup 2010-11-08 18:08:08 -08:00
anthony 9ee6d69c9f the default delta snapshot number between two full snapshots is 16, it is configurable 2010-11-08 18:08:07 -08:00
abhishek 7262b854a5 bug 7121: made the disk offering id optional, and added a check to ensure we never have both disk offering and snapshot ids to be null
status 7121: resolved fixed
2010-11-08 17:59:26 -08:00
Alex Huang aca8ef79cd a bunch of other changes for network refactoring 2010-11-08 12:29:37 -08:00
anthony 224da7e775 several snapshot fixes 2010-11-05 20:55:19 -07:00
abhishek 0b1bddb125 code realignment 2010-11-04 18:42:38 -07:00
abhishek 103278415e bug 7035: allowing cancel maintenance for all sp states except UP
status 7035: resolved fixed
2010-11-04 18:42:38 -07:00
abhishek 364e1e1c4a bug 7034,6869: fixing the storage pools issue, and the npe at load balancer if the router is not found.
status 7034, 6869: resolved fixed
2010-11-04 17:18:58 -07:00
abhishek e9bd0594bd bug 7022: fixing the custom size for volumes bug
status 7022: resolved fixed
2010-11-04 15:51:33 -07:00
abhishek 9a3d5c3ae3 forgot to throw the serverapiexception in the cancel maintenance cmd 2010-11-04 14:35:36 -07:00
abhishek 52d2111ed3 bug 6972: fixing the ssl cert warning
status 6972: resolved fixed
2010-11-04 14:11:28 -07:00
abhishek baa28d2022 returning serverapiexceptions for prepare and cancel pool maintenance; making it consistent with other pieces of code 2010-11-04 13:40:10 -07:00
abhishek 55e9378f9a don't set state to errorinmaintenance if cancel maintenance encounters a ps with a state !=Maintenance 2010-11-04 13:35:57 -07:00
abhishek d96a1a841d adding logic to prevent commands from being sent to the pool when it is NOT up; also adding better thread safety and db locking, along with a general refactor 2010-11-04 13:35:57 -07:00
abhishek 89f0c455e3 fixing the vm creation issue 2010-11-04 10:47:59 -07:00
nit 7dc7a4838a bug 4286: Fixing the extract functionality for Upload after new API framework. Also added a check to avoid system created templates and ISO's from getting extracted as per Mike.
status 4286: resolved fixed
2010-11-04 19:09:38 +05:30
abhishek 84ee08430a making changes to the list zones flow, to add the domain name to the table, and return it 2010-11-03 22:08:32 -07:00
Alex Huang e27bb550fe Harmony among gurus 2010-11-03 21:18:31 -07:00
alena 52a8370102 bug 6955: return embedded object for PreparePrimaryStorageForMaintenance
status 6955: resolved fixed
2010-11-03 14:30:35 -07:00
edison f3cc113525 bug 6933: send the snapshot related command to host on which vm created for kvm
status 6933: resolved fixed
2010-11-03 13:03:21 -07:00
abhishek 426e445811 bug 6904: during volume creation, we were NOT converting the size of the parent disk offering (which is in MB), to bytes. This is the size used to create the volume. I am adding the appropriate multipliers. Other flows like creating volume from snapshot etc should remain unaffected, as the parent volume created from the disk offering will be set right.
status 6904: resolved fixed
2010-11-03 11:13:06 -07:00
Kelven Yang 3c6b3b3e3d Add more volume info to BackupSnapshotCommand, to generalize multi-hypervisor usage 2010-11-02 17:04:07 -07:00
Alex Huang 5fe5450abc even more refactoring 2010-11-02 15:25:07 -07:00
Alex Huang 560d7a275e Removed InternalErrorException. Renamed the lock methods on the DAO objects to be more understandable. 2010-11-02 12:25:08 -07:00
Alex Huang 3279c26796 Removed a bunch of InternalErrorException 2010-11-02 12:25:08 -07:00
Kris McQueen 519633cd38 bug 6763: restore the volume lock when creating a snapshot for the volume to ensure only one thread is creating the snapshot at a time. 2010-10-29 13:53:00 -07:00
nit c9069303ce Code clean up for Extract functionality and making it more robust. 2010-10-28 18:45:12 +05:30
Alex Huang 4f9f249218 make console proxy work again with the new network configuration 2010-10-26 17:37:29 -07:00
Kris McQueen 28bcbc3bdd bug 6732: there is no longer a manual policy, so add in special handling for deleting manual snapshots. Also, in the process of deleting the snapshot, the snapshot might need to be retrieved from the database, so be sure to find including removed.
status 6732: resolved fixed
2010-10-26 16:47:21 -07:00
Kris McQueen 8fafc892d3 bug 6730: if a volume was never attached to a VM, then the poolId will be null and this will be flagged as not on shared storage. Since the code was deleting detached volumes only on shared storage, the never-attached volume was in an undeletable state. Instead, allow deletion of any detached volume, regardless of storage pool until some technical reason limits this from happening.
Also, the UI was not allowing volumes to be deleted due to a bug in looking at the vmname property of the volume.  The 'if' conditional always returned true that the volume was attached to a VM to due a boolean logic error.

status 6730: resolved fixed
2010-10-26 14:56:44 -07:00
Alex Huang 2bc938c3f8 checkins for problems. 2010-10-26 09:35:24 -07:00
nit 497c60d63d Extending extract functionlity for volumes to allow download. The
extraction can have two modes FTP_UPLOAD and HTTP_DOWNLOAD. In the former one
the user would provide the ftp url where the entity needs to be uploaded and in
the later the user would be provided a HTTP URL where from he/she can download
the entity. This url would be exposed for a specific time limit and would not
function after the time limit
2010-10-26 18:49:43 +05:30
Jessica Wang 958aaaaf87 new UI - instance page - refactor submenu. 2010-10-22 20:23:05 -07:00
Kris McQueen 365ac7501f bug 6672: Fix up volume commands. For createVolume, the command is supposed to create a database object, but not assign it to a storage pool until the user first attaches it to a vm instance. That allows the volume to start off hypervisor agnostic. For attachVolume, detachVolume, and listVolumes, the responses had minor issues (sourceType could be null, for example) in either the response generation, or the response handling by the UI.
status 6672: resolved fixed
2010-10-21 15:15:01 -07:00
Alex Huang d5d8f27cad Added more changes to the api 2010-10-21 15:11:49 -07:00
nit 6723549fc7 bug 6399: extending extract functionlity for templates and ISO's to allow download. The extraction can have two modes FTP_UPLOAD and HTTP_DOWNLOAD. In the former one the user would provide the ftp url where the entity needs to be uploaded and in the later the user would be provided a HTTP URL where from he/she can download the entity. This url would be exposed for a specific time limit and would not function after the time limit. 2010-10-20 11:40:03 +05:30
Alex Huang 794ca16a65 Added code to start domR 2010-10-19 11:52:01 -07:00
Chiradeep Vittal 4d37269961 fix local disk for system vms 2010-10-19 09:53:51 -07:00
Kelven Yang 2c919c5c01 Make unique name conforming with the name generated in template installation for routing template, some other minor fixes 2010-10-15 16:36:02 -07:00
anthony d41f7d78d9 DeleteStoragePool command fix
1. not delete SR in xenserver side, only delete it in database.
    2. remove a storagepool,  adding it back fails
2010-10-15 14:15:55 -07:00
Kris McQueen 8e086d7a21 resolving merge conflicts between 2.1.refactor and master 2010-10-12 16:28:16 -07:00
Kris McQueen 2740ba6c40 final merge of master->2.1.refactor preparing for merge back into master 2010-10-12 14:46:24 -07:00
Alex Huang ce091de3d2 more changes for refactor 2010-10-12 07:17:47 -07:00
anthony a93d36d81a should use _hostDao.listByCluster instead of _hostDao.listByPodId in some places 2010-10-08 18:10:15 -07:00
edison 2f39664f94 maybe it was an incorrect merge that snapshot was disabled for KVM
Re-enable it.
2010-10-07 18:56:42 -07:00
edison 3028dab141 fix systemvm template in direct attached mode, guest vm can't get gateway and dns server 2010-10-07 16:32:46 -07:00
Kris McQueen ec62ef3cd7 Injection doesn't work on private methods, restore the visibility of the methods so injection works. 2010-10-06 18:25:58 -07:00
Alex Huang 9d1270b35f console proxy started completely and running 2010-10-06 17:22:35 -07:00
anthony 0cb11027e9 back port from 2.1.x 2010-10-06 15:18:23 -07:00
Kris McQueen 9c593352d0 Fixing events for async jobs so that there's a scheduled event recorded with appropriate type/description whenever the API framework schedules the async command to run. A few miscellaneous fixes as well uncovered during regression testing (router response was not parsed correctly by UI, etc.) 2010-10-05 20:26:18 -07:00
Alex Huang 00f8de2687 console proxy vm is now started 2010-10-04 17:59:06 -07:00
Alex Huang 5f88268ef2 console proxy vm is now started but it is not reading the disk correctly 2010-10-04 17:59:06 -07:00
Alex Huang 652d86956c more files checked in 2010-10-04 12:04:59 -07:00
nit 09768ca751 bug 5363: Adding Scheduled and Started event for SNAPSHOT.CREATE.
status 5363: resolved fixed
2010-10-04 19:51:19 +05:30
edison b441deec94 Need to set all the system vms as read state 2010-09-30 20:39:34 -07:00
edison 26807bc701 bug 6362: Need to call guestos.getDisplayName to the guest os name now.
status 6362: resolved fixed
2010-09-30 12:26:37 -07:00
edison 7615f569ff after rebase, fix bugs 2010-09-29 18:41:55 -07:00
edison ad1ef80459 Now we have multiple routing template and buitin templates now, refactor template download code, that can handle it.
Basically, change the meaning of type field in template table: SYSTEM means sytem vm template, BUILIIN means buildin templates.
2010-09-29 18:41:55 -07:00
edison fb9f43d807 clean up hypervisor.type, actually hypevisor.type may only make sense on the UI in multi-hypervisor.
In our java code, we should not write code based on hypervisor.type.
2010-09-29 18:41:54 -07:00
edison 6fc7528809 create data volume is splitted into two stage:
1. create a volume entry in the database,
2. when user attaching the volume to a VM, then actually create the volume on storage pool.
2010-09-29 18:41:54 -07:00
edison 9e0f57bc0e change code for new UI 2010-09-29 18:40:52 -07:00
edison 8943cc6745 create volume
Conflicts:

	api/src/com/cloud/vm/VmCharacteristics.java
	core/src/com/cloud/dc/ClusterVO.java
	core/src/com/cloud/server/ManagementServer.java
	server/src/com/cloud/network/NetworkManager.java
	server/src/com/cloud/storage/allocator/AbstractStoragePoolAllocator.java
2010-09-29 18:40:51 -07:00
Kelven Yang 2337a9d99f Fix a NPE in AbstractStoragePoolAllocator.java when creating standalone volume 2010-09-29 18:40:51 -07:00
Kelven Yang 72e8b767fe Mount secondary storage as a datastore to implement ISO attachment 2010-09-29 18:40:50 -07:00
Kelven Yang 9db2925b77 Make database config recognize service offering change 2010-09-29 18:40:49 -07:00
edison b3427fc634 don't remove template 2010-09-29 18:40:48 -07:00
edison edb16aa117 change storage allocator policy based on hypervisor 2010-09-29 18:40:47 -07:00
edison 3aef9f408e step1 2010-09-29 18:40:47 -07:00
anthony b8c8aacca3 bug 6326: correctly update poolsToAvoid
status 6326: resolved fixed
2010-09-29 18:38:01 -07:00
anthony bca96b1079 pass guest OS name instead of guest ID when start system VM 2010-09-29 17:18:27 -07:00
anthony be5fa82229 remove snapshotpolicyRef 2010-09-29 16:24:57 -07:00
anthony 5b75f8e03b bug 6365: find policy from volumeId instead of snapshotID
status 6365: resolved fixed
2010-09-29 15:25:46 -07:00