Commit Graph

54 Commits

Author SHA1 Message Date
Alex Huang 11650bfc9d one big transaction to see if it's any faster 2011-08-03 14:39:59 -07:00
Chiradeep Vittal fd1dbe9683 bug 10884: do not lock if not necessary 2011-08-02 13:51:26 -07:00
Alex Huang 5c543ffdb1 bug 10884: fixed a bug where the security group keeps processing a vm that has been removed 2011-08-02 10:45:29 -07:00
Alex Huang 92b8b29fe4 Revert "sg improvements. don't use global lock"
This reverts commit 1d9961c588976a910d60c6420487c29a9080b73a.
2011-08-02 03:49:30 -07:00
Alex Huang 79ddba246d Revert "looks like lock tables don't return the tables locked"
This reverts commit 76781c10f8534acdd6f81c46952f88ade941e269.
2011-08-02 03:48:57 -07:00
Alex Huang 91550836cf looks like lock tables don't return the tables locked 2011-08-02 02:10:47 -07:00
Alex Huang 6905a1db1d sg improvements. don't use global lock 2011-08-01 22:59:59 -07:00
Chiradeep Vittal efaa63a428 bug 10884: try out a global lock instead of per-vm locks 2011-08-01 18:52:06 -07:00
Chiradeep Vittal b4b87b1de8 bug 10920: avoid deadlocks by avoiding locks on the index on step 2011-08-01 15:32:23 -07:00
Chiradeep Vittal 3951699542 bug 10920: convert seconds to milliseconds 2011-07-30 18:19:58 -07:00
Chiradeep Vittal f49469270e bug 10920: avoid deadlocks by not using order by random 2011-07-30 12:54:50 -07:00
Chiradeep Vittal 41e6aeae96 bug 10884:
1. cleanup was scheduled wrong (seconds vs ms)
2. when finding a work item to do, lock one random row to reduce contentions by thundering herds of workers
3. cleanup thread also finds scheduled work items and gets threads to work on them. this way other mgmt servers can take jobs
4. add lots of trace logs
5. commit transactions when returning early
2011-07-29 16:28:06 -07:00
Alex Huang c00b9bf5aa fixed problems with security group. it's possible for threads to disappear due to exceptions. Also it needed to define in memory transaction boundary 2011-07-29 10:41:36 -07:00
Chiradeep Vittal 1226a49976 bug 10884: use the proper keys this time 2011-07-27 17:58:59 -07:00
Chiradeep Vittal 8cc694a579 bug 10884: bump up thread pool and cleanup less often 2011-07-27 14:44:52 -07:00
alena 30e8ed3ab6 Don't allow to specify security groups when deployVm in Vmware setup.
Also fixed a couple of other problems:
* verify security group ids before vm creation
* don't create "default" security group (if missing) as a part of deployVm process when vm is deployed from vmWare template
2011-05-20 18:52:58 -07:00
alena c2afcdec52 bug 9873: always add default security group to the SG list when deploy vm in 1) Basic zone 2) Advance zone using SG enabled network
status 9873: resolved fixed

Following fixes were made as a part of the checkin:

* When deploy user vm and SG doesn't exist in the DB, create it automatically.
* SecurityGroup enabled use vm start: if map to default group is not present in security_group_vm_map table, create one.
* Added "name" (securityGroupName) parameter back to deleteSecurityGroup/authorizeSecurityGroupIngress/deployVm. Mutually exclusive with security group id parameter.

Conflicts:

	api/src/com/cloud/api/commands/AuthorizeSecurityGroupIngressCmd.java
	api/src/com/cloud/api/commands/DeleteSecurityGroupCmd.java
	api/src/com/cloud/api/commands/DeployVMCmd.java
	server/src/com/cloud/api/ApiDBUtils.java
	server/src/com/cloud/vm/UserVmManagerImpl.java
2011-05-17 15:08:13 -07:00
alena 5db28c57e4 bug 9492: allow security group removal when it has ingress rules, but not assigned to any vms yet
status 9492: resolved fixed
2011-04-25 16:43:39 -07:00
alena 41e5e38fef bug 9336: securityGroups can be used by other securityGroups in the same domain only; no cross domain SG authentication
status 9336: resolved fixed

Following changes were made:

* deleteSecurityGroup/authorizeSecurityGroupIngress - removed account/domainId parameters as SG is uniquely identified by id now
* removed account_name field from securityGroup DB table; removed allowed_security_group/allowed_sec_grp_acct from security_ingress_rule.
These values were used for api response generation only for performance purposes; added caching on API level to improve performance
* Added missing security checks for securityGroups/ingressRules
2011-04-22 11:35:29 -07:00
alena 1a6d78eae4 Code cleanup. No need to declare runtime exceptions (CloudRuntimeException, InvalidParameterException, PermissionDenied exceptions) 2011-04-21 16:26:53 -07:00
Frank 92155522f2 Add license header to files 2011-04-14 11:23:14 -07:00
nit debe236a8d bug 8710: CONTD....Introducing a new user role in cloudstack called RESOURCE_DOMAIN_ADMIN. The role would have all the domain_admin rights and the rights to list zone,pods,clusters and so on. More info in the bug 2011-04-11 19:40:37 +05:30
alena a47a4c8cfe bug 9272: fixed the race condition bug when we tried to remove vm from SG after it was expunged (expunge interval was really small, 60 sec).
status 9272: resolved fixed

When do search for vm, do includingRemoved search.
2011-04-04 15:47:14 -07:00
alena 1932652125 bug 5912: Added events and logging for securityGroup create/delete
status 5912: resolved fixed
2011-03-25 15:23:18 -07:00
alena 1cf735c537 bug 8968: use search criteria when list security group by id
status 8968: resolved fixed
2011-03-14 13:45:11 -07:00
Edison Su 8eaa53f282 fix transaction rollback in security group listener, which cause state machine update failed 2011-03-04 10:58:24 -05:00
Edison Su 9ad5139fda fix delete security group rule 2011-03-03 13:44:48 -05:00
Edison Su 8240ae7e8c fix migration 2011-02-28 12:16:40 -05:00
Edison Su b20808d223 minor fix 2011-02-28 12:16:40 -05:00
Edison Su 9b51886850 fix migration issue 2011-02-28 12:16:40 -05:00
Edison Su adbd20ca5a bug 8655: add security group for direct tagged network 2011-02-23 15:53:14 -05:00
alena 15f59e6f58 bug 8637: throw ResourceAllocationException when resource limit is exceeded.
status 8637: resolved fixed
2011-02-18 12:26:58 -08:00
Edison Su 08285af33f fix capacity caclulation issue after migration 2011-02-09 13:33:42 -05:00
abhishek 73eb597ba6 bug 8335: adding the security group objects to the list virtual machines response 2011-02-08 11:48:39 -08:00
abhishek 2a38a58be0 bug 8335: changing the deployVm flow to take in a list of security group ids instead of a list of security group names 2011-02-03 11:37:49 -08:00
Edison Su a46155e895 bug 8094: send networkrulesforssvm command to agent, no matter security group is enabled or not
status 8094: resolved fixed
2011-02-02 16:26:54 -05:00
abhishek 24acc66124 bug 8331: changing the revoke logic to work by taking in the entity id. All other params are obsolete at this point
status 8331: resolved fixed
2011-02-02 13:49:56 -08:00
Edison Su fc97034000 refactor vmstatelistener 2011-01-26 11:01:43 -05:00
Edison Su d45f5cd5bf bug 8119: don't boot from iso, if iso is dettached
status 8119: resolved fixed
2011-01-22 04:04:52 -05:00
Edison Su 4b355ca301 bug 8118: add security group back
status 8118: resolved fixed
2011-01-22 04:04:52 -05:00
abhishek 31c9cce6c3 bug 7949: changing security group code to use ids instead of name
status 7949: resolved fixed
2011-01-20 14:21:32 -08:00
Alex Huang d43717eef8 merge changes 2011-01-14 15:12:13 -08:00
abhishek e28882b8ee eliminating use of multiple variables; using the same var for all protocols (denoting ports for tcp/udp and type/code for icmp) 2011-01-11 14:20:02 -08:00
abhishek e4c3f556c2 bug 7942: we were not using the right values for record creation when the proto=icmp. Using the right vals
status 7942: resolved fixed
2011-01-11 13:57:53 -08:00
abhishek ffb8d54dff changing a few obsolete names to std convention 2011-01-07 16:49:51 -08:00
abhishek fec9a6d566 not iterating over cidr list if null 2011-01-07 16:22:28 -08:00
Alex Huang 4eba6d10d7 Moved State into VirtualMachine like other States of objects 2011-01-04 15:01:34 -08:00
Alex Huang 544fa7ff1b remote access vpn, user ip address changes 2010-12-29 09:32:54 -08:00
abhishek d73e06a938 bug 7509: adding search by id for security groups, also refactoring a few method names to use the new scheme
status 7509: resolved fixed
2010-12-16 16:47:57 -08:00
abhishek 5154ba1539 bug 6361: this is a good point to commit; 1st round of refactor is done, code is clean compiling and ms is deploying 2010-12-16 15:37:19 -08:00