Commit Graph

29860 Commits

Author SHA1 Message Date
Gaurav Aradhye 538d6630db CLOUDSTACK-8632: Unable to revert snapshot on XenServer 2015-07-20 12:28:29 +05:30
Daan Hoogland 2f0813aa3e coverity 1288575: replace all close with try-with-resource
not strictly necessary in all but one case. done consequently.
2015-07-19 14:47:05 +02:00
Daan Hoogland 4ef40e215a style: empty line removed
This closes #229
2015-07-17 14:57:51 +02:00
Daan Hoogland a6f17b33e8 style: leading space removed
This closes #189
2015-07-17 13:35:37 +02:00
Daan Hoogland 03b076cd1b coverity 1116668: conditionally close ds provided connection
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #599
2015-07-17 13:22:43 +02:00
Daan Hoogland 4f1eb8d6dd coverity 1116711: findLostHost trivial try-with-resource inserted
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-07-17 13:22:42 +02:00
Daan Hoogland e92e800930 coverity 1116696: iprange adding code cleaned
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-07-17 13:22:42 +02:00
Daan Hoogland f15eaec254 coverity 1116759: possible null-pointer before indexOf-call move the if-block inside the next, guarded one
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #600
2015-07-17 13:12:26 +02:00
Daan Hoogland 8849d506cb coverity 1116718: neglected jarinputstream when no entry found
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-07-17 13:12:26 +02:00
Daan Hoogland 0c72f7743f Merge branch 'CLOUDSTACK-7539' of https://github.com/DaanHoogland/cloudstack
This closes #572
2015-07-17 12:41:34 +02:00
Wido den Hollander fbe3b04a43 CLOUDSTACK-8628: Send an alert when fencing a KVM host failed
Also change the logging a bit so that you get useful logs when
not running on DEBUG level

Signed-off-by: Wido den Hollander <wido@widodh.nl>

This closes #580
2015-07-17 12:33:11 +02:00
Wido den Hollander d1f76a2a84 CLOUDSTACK-8628: kvm: Disable Fencing when no NFS storage pools are present
On NFS we write a heartbeat, but without those we can not safely
fence off a host.

If we fence without knowing about a heartbeat we can cause a split-brain situation.

Signed-off-by: Wido den Hollander <wido@widodh.nl>
2015-07-17 12:33:11 +02:00
Daan Hoogland c3d28e1b96 CLOUDSTACK-7539: no return in synchronised block 2015-07-17 11:07:57 +02:00
Wido den Hollander 8d96aab9b2 CLOUDSTACK-8581: Do not make attributes final and don't set them to null
Signed-off-by: Wido den Hollander <wido@widodh.nl>

This closes #582
2015-07-17 10:07:04 +02:00
Wido den Hollander 4b61f5a17a CLOUDSTACK-8581: Make the code which initiates the S3TO object more readable
All arguments are now on a own line which makes the code easier to read

Signed-off-by: Wido den Hollander <wido@widodh.nl>
2015-07-17 10:07:04 +02:00
Wido den Hollander 178a9f555d CLOUDSTACK-8581: S3, make connection TTL and TCP KeepAlive configureable
Signed-off-by: Wido den Hollander <wido@widodh.nl>
2015-07-17 10:07:04 +02:00
Boris Schrijver b1e5906923 CLOUDSTACK-8642: SSO Method not allowed bug fix. Due to CLOUDSTACK-8505 and commit 1c81b241e7
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #598
2015-07-16 17:00:05 +02:00
wilderrodrigues 984fafce77 CLOUDSTACK-8641 - Adding unit tests
- Making sure that the boolean value is false and also that the updateHostPassword() method gets called.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #596
2015-07-16 18:28:27 +05:30
wilderrodrigues c3c8baf259 CLOUDSTACK-8641 - When calling "update hostpassword" API it throws NPE if the update_passwd_on_host if not informed
- On getUpdatePasswdOnHost() method, if updatePasswdOnHost is null then return false.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-07-16 18:28:27 +05:30
wilderrodrigues b29d8e7280 CLOUDSTACK-8616 - Adding important remark about the use of buildsystemvm.sh
- For package installation/update please refer to: cloud-tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh

Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #587
2015-07-16 13:14:49 +02:00
wilderrodrigues 08348593a2 CLOUDSTACK-8616 - the systemvm packages are installed from install_systemvm_packages.sh
- Adding keepalived installation in the right script. I added the change on the buildsystemvm.sh, which is no longer used.

Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-07-16 13:14:49 +02:00
wilderrodrigues 4b3db3d117 CLOUDSTACK-8616 - Add a cron job to restart ConntrackD on reboot
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-07-16 13:14:48 +02:00
wilderrodrigues f78a65c05a CLOUDSTACK-8616 - Installing KeepaliveD from Debian Wheezy backports
- preempt delay reverted on version 1.2.13 - from the backports
     - vrrp : Revert "Honor preempt_delay setting on startup.".
     - See changelog: http://www.keepalived.org/changelog.html
   - Refactoring some variable names to avoid misunderstanding

Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-07-16 13:14:48 +02:00
wilderrodrigues 12ee36a55f CLOUDSTACK-8616 - Add keepalived start on reboot
- Runs check_heartbeat.sh every 30 seconds

CLOUDSTACK-861 - Copy/Paste error

   - Paste the wrong command in the crontab line.

Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-07-16 13:14:48 +02:00
wilderrodrigues 20be22c698 CLOUDSTACK-8616 - Removing the Priority form KeepaliveD configuration
- We use no preempt mode with state set as EQUAL to both nodes, no need to have Priotities setup
   - Do not add IPs as comments to the configuration. If a new guest interface is added, the file will change anyway.
     - This was used in the past when keepalived would restart for each new interface added
   - Removed the long sleep form the tests: we now sleep 5 seconds per PF rule added

CLOUDSTACK-8616 - Fix keepalived.ts/2 files comparison

   - Add call to set_fault() in case of router transits to that state
   - Removing commented out code

CLOUDSTACK-8616 - Fixing check_heartbeat.sh.templ

CLOUDSTACK-8616 - Call set_fault from the check_heartbeat.sh script

Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-07-16 13:14:48 +02:00
Likitha Shetty f5ed824ea2 CLOUDSTACK-8598. CS reports volume migration as successful but the volume is not migrated in vCenter.. For the following disk operations - migration, snapshot creation, resize, detach and template creation, CS should do an exact disk match between volume path and vCenter disk name. If the exact matching fails to find a disk, CS should fall back to the old method of partial matching on a trimmed disk.
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #543
2015-07-16 10:44:58 +02:00
pritisarap12 5eccf88508 CLOUDSTACK-8588 - Remove redundant skip test for LXC
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #526
2015-07-16 09:03:25 +02:00
Gaurav Aradhye d73f64a518 CLOUDSTACK-8582: Skipping unsuitable test cases for simulator
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #532
2015-07-16 10:30:14 +05:30
pritisarap12 c5d016c372 CLOUDSTACK-8556: Unable to delete attached volume in cleanup
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #481
2015-07-16 10:28:00 +05:30
pritisarap12 b73e486d02 CLOUDSTACK-8549-Update test_concurrent_snapshots_limits.py asesrt statement
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #386
2015-07-16 10:26:26 +05:30
nitt10prashant 8e1f01d779 CLOUDSTACK-8626 :[Automation]fixing test/integration/component/test_ps_max_limits.py for lxc hypervisor
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #579
2015-07-16 10:21:28 +05:30
Rohit Yadav 47d2d07eb9 CLOUDSTACK-8457: SAML UI Dialog fixes to use local $form
This uses local selector to access the DOM elements, the previous commit
would find a global element which is not in the context and fail changing the
element in the opened dialog.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #583
2015-07-15 18:36:46 +05:30
Funs ca68bb0ef7 xenserver: Improved message for peeples to actually see what the problem is.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #576
2015-07-15 18:24:39 +05:30
Wido den Hollander 6d92abcb76 CLOUDSTACK-8635: Depend on the headless JRE for Ubuntu packages
This will install less packages on the system running CloudStack.

The -headless JRE doesn't include packages for running on desktops

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #588
2015-07-15 18:12:25 +05:30
sanjeev 87e53eae53 CLOUDSTACK-8633: Changing file permissions from 755 to 440
Reviewed-By: Raja

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #591
2015-07-15 18:08:08 +05:30
Priti Sarap 373b107b96 CLOUDSTACK-8636: Verify failure of creation of Custom disk offering with disksize parameter
- Clear disk offering in tearDown() class if gets created

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #592
2015-07-15 18:03:28 +05:30
Priti Sarap abf216aed6 CLOUDSTACK-8637: Verify that VM with same Display name creation fails if vm.instancename.flag=true
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #594
2015-07-15 18:02:24 +05:30
nitt10prashant 373b2c787e CLOUDSTACK-8631 :changing if condition in component/test_ss_max_limits.py
This closes #585
2015-07-15 13:44:06 +05:30
Daan Hoogland a1ff7e24f3 coverity 1311707: only sql exception on select would have been caught. passing all runtime exceptions through
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #584
2015-07-14 13:41:09 +02:00
Daan Hoogland 3c125c0dc1 coverity 1311708: sql exception caught instead of generic (runtime)
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-07-14 13:41:09 +02:00
Daan Hoogland e62d952375 coverity 1311706: to generic exeption handling on xapi call
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-07-14 13:41:09 +02:00
pavan018 03e8176bab Passing firewal service parameter for LB rule creation
Firewall service parameter addition typos
2015-07-14 15:57:56 +05:30
Daan Hoogland df5f715090 coverity 1148416: auto close server socket
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #578
2015-07-14 11:53:22 +02:00
Daan Hoogland 9681fefaef coverity in upgrade code 1164030: memory upgrade for ssvm 1164031: image store details encryption
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-07-14 11:53:22 +02:00
Daan Hoogland c53959513e findbugs: create wrapper to deal with static field
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #573
2015-07-14 11:50:39 +02:00
Daan Hoogland 10853bfa8a adhere to naming conventions for enums
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-07-14 11:50:39 +02:00
Koushik Das 2df190d0ee CLOUDSTACK-8623: CPVM fails to start after MS is restarted during its initial start-up process
Added unit tests

This closes #571
2015-07-14 10:56:05 +05:30
Koushik Das 9ec2a6c29c CLOUDSTACK-8623: CPVM fails to start after MS is restarted during its initial start-up process
If SSVM cannot be started then the existing entry is removed and a new SSVM gets created. Made similar changes for CPVM as well.
Also cleaned up some log messages in SSVM and CPVM manager code.
2015-07-14 10:55:19 +05:30
Rohit Yadav 76a10351a5 CLOUDSTACK-8457: SAML UI enhancements
Add option to authorize SAML SSO for user when adding user. Appends a domain to
user/account name if global setting is enabled, useful in case of multiple IDP
server. By default the setting is set to false (keep as it is).

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #575

(cherry picked from commit 7d11c7bc70)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-07-14 10:20:30 +05:30
Wido den Hollander 63688e70a0 kvm: More verbose logging around storage pools in the Agent 2015-07-13 16:53:26 +02:00