f659958c24
CS-15430 Create snapshot should fail if creating snapshot results in exceeding snapshot resource limit for domain-admin or user accounts
...
Reviewed-by: devdeep.singh@citrix.com
Change:
1. Before creating the snapshot, we synchronized checkresourcelimit to allow the users to create the snapshot and increment the resource count.
2. Depending on the failure of snapshot creation/ backup, we are decrementing the resource count.
2012-07-06 15:08:46 +05:30
f2546dd2bd
CS-15459: fixed listTags for userVms
2012-07-05 18:33:23 -07:00
447f018b13
VPC: fixed CS-15465 - lb creation for ip not associated with any networks
2012-07-05 18:06:52 -07:00
f9d512f163
ResourceTags: resourcetags support for Project/Vpc/NetworkACL/StaticRoute
2012-07-05 17:33:20 -07:00
7c647223f2
VPC: don't fail when create/remove static route when VPC VR is in Stopped state
2012-07-05 17:26:25 -07:00
3a557c2998
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
...
Conflicts:
server/src/com/cloud/network/NetworkManagerImpl.java
2012-07-05 17:06:02 -07:00
f1ec4fddd3
CS-15217: Security: Malicious user is able to get the size of the cloud by enumerating IDs
...
Description:
As part of the fix for Bug CS-13127, a new overloaded function,
addProxyObject() was added to facilitate transparent db id to
uuid conversions when db IDs were added to exceptions that were
thrown in the Cloudstack mgmt server code. However, it turns out
that there are quite many db IDs still in the code that are
being directly embedded in the String message that is passed
during exception creation.
In this commit, we modify the default constructor of
InvalidParameterValueException so that it takes a second
argument of type List<IdentityProxy>. This will help developers
see that there is a second parameter required, and make them
look into what that parameter is about. Hopefully, this will
stop db IDs from being embedded into the exception message.
The parameter can be set to null though, since there are many
places in the code that don't embed any DB IDs in the exception.
This is still a WIP, so the older default constructor for
InvalidParameterValueException has not been removed yet. When
all instances of throw new InvalidParameterValueException()
have been moved over to the new default constructor, the old
one will be removed, else compilation will break. The reason
for having to do this in batches is that there are way too
many places in the code that throw exceptions, and they all
cannot be covered in a single commit without it taking much
time.
In following commits, all other exceptions will be changed
in the same way as InvalidParameterValueException.
2012-07-05 16:48:36 -07:00
a0a5e25e32
CS-15456: Prohibit creating more than one VPN gateway of VPC
2012-07-05 15:45:21 -07:00
21cdd08948
VPC: don't allow vm to be a part of more than one VPC
2012-07-05 15:28:30 -07:00
24023fd14d
VPC: don't allow vpcs for the same account with overlapping cidrs
2012-07-05 15:20:44 -07:00
a44843af69
VPC: added "forVpc" (boolean) parameter to listRouters call - filter by the fact if router belongs to VPC or not
2012-07-05 14:04:34 -07:00
d8cdb89721
VPC: added field networkacl_service_provided to physical_network_service_providers table
2012-07-05 13:56:55 -07:00
2699e2c508
VPC: CS-15447 - fail vpc creation when vpc provider is not enabled at least in one physical network in the target zone
2012-07-05 13:34:34 -07:00
f1ac568a91
VPC : check if dns1 is null
2012-07-05 11:53:04 -07:00
e6d73fb114
VPC: added dns1/dns2 + networkDomain to the list of bootload args passed on VPC VR start
2012-07-05 10:32:51 -07:00
931c3eb78e
VPC: removed NetworkACL interface; added getTrafficType() to Firewall
2012-07-05 10:22:49 -07:00
892ee23ca5
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-07-05 11:32:24 +05:30
922d254b72
CS-13376- Vm is stuck in Stopping state when MS is rebooted after the stop command was issued, but answer wasn't recieved from the backend yet
2012-07-05 11:29:01 +05:30
7d6db010ac
CS-15429: Create Instance should fail if creating instance results in exceeding volume resource limit for domain-admin or user accounts
...
Reviewed-by: devdeep.singh@citrix.com
Change: Adding a check for diskOfferingId
2012-07-05 11:27:48 +05:30
c6448d0e8e
CS-13376- Vm is stuck in Stopping state when MS is rebooted after the stop command was issued, but answer wasn't recieved from the backend yet
2012-07-05 11:24:24 +05:30
a4740b314f
CS-13376: Vm is stuck in Stopping state when MS is rebooted after the stop command was issued, but answer wasn't recieved from the backend yet..removing trailing whitespaces in the code
2012-07-04 22:04:20 +05:30
75026053bc
CS-13376: Vm is stuck in Stopping state when MS is rebooted after the stop command was issued, but answer wasn't recieved from the backend yet
2012-07-04 21:51:32 +05:30
1ac1bcb2f6
VPC: createLB rule - removed duplicated check for ip services when createLB rule
2012-07-03 17:34:49 -07:00
3383c79452
VPC: added zoneName to the VPC api response
2012-07-03 17:14:07 -07:00
3a56e3c55c
VPC: CS-15426 - In Basic zone always pass control nic when prepare nics for the VR
2012-07-03 17:10:12 -07:00
5a175e871c
VPC: CS-15355 - fixed router when deployVm in Basic zone
2012-07-03 17:10:12 -07:00
a899391b6e
VPC: fixed response tag for VpcRespnse
2012-07-03 16:12:37 -07:00
ca5a53ce4d
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-07-03 15:43:35 -07:00
e71732babc
CS-14952: Nexus vSwitch: vCenter IP Address and DataCenter information is not present in the "virtual_supervisor_module" table. VSwitch Crendentials are not encrypted.
...
Description:
Qualifying the VSM password stored in virtual_supervisor_module
as encryptable. The encryption/decryption is transparently done
by the cloudstack DAO layer.
2012-07-03 15:41:42 -07:00
9f6d03b87b
VPC: added "forVpc" parameter to listNetworkOfferings command. If true, the offeirng can be used for vpc networks only
2012-07-03 15:37:07 -07:00
1011dfd31c
Resource tags: 1) Remove tag records when correspdonding cloudStack object gets removed
...
2) added "tags" request parameter to the banch of list* Api commands (listVirtualMachines, listSnapshots - all commands are listed in the resource tags functional spec)
2012-07-03 14:47:07 -07:00
f5f356c150
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-07-03 14:01:07 -07:00
9e3330374f
CS-15151: Cluster_details table stores Vcenter Cluster credentials in clear text
...
Description:
Encrypting password values before they're written out to
the cluster_details db, and decrypting them when reading
in the values from the db.
2012-07-03 13:47:29 -07:00
2742c50484
CS-15385 : fix vm start in basic zone
2012-07-03 11:30:59 -07:00
1e67de0ac5
VPC: added missing FirewallService to the VR provider
2012-07-03 09:34:45 -07:00
a8c1568b37
Fix for CS-15345
...
During account cleanup, associated network is accessed without checking whether it is present or not. Added a check to use it only when present.
2012-07-03 18:52:36 +05:30
6af13737fa
VPC: corrected the name for PublicIp interface (mistakenly renamed it as a part of previous checkin)
2012-07-02 17:31:47 -07:00
e3ca32af2a
VPC: remove network ACLs from VPC VR when shutdown guest network
2012-07-02 16:44:43 -07:00
c5cdd6947f
CS-6840: Fix 0 id returned by createVpnConnection
2012-07-02 16:15:43 -07:00
b071260878
CS-15274: Fix NPE on CreateVlanIpRangeCmd()
...
Signed-off-by: Sheng Yang <sheng.yang@citrix.com>
2012-07-02 15:08:09 -07:00
481f59df3b
VPC: multiple fixes:
...
* Separate service for NetworkACL - "NetworkACL" service
* allow having just one network supporting LB in the VPC
* perform check against VPC when upgrade network to the new network offering (the same set of checks when you add new network to the VPC)
2012-07-02 14:14:34 -07:00
1791c7533b
cloudstack 3.0 API - listVpnConnections API - add gatewayIp, guestCidrList,ipsecPsk, ikePolicy, espPolicy, lifetime property (get it from customerGateway object).
2012-07-02 13:39:34 -07:00
4415c67604
VPC: createPrivateGateway - consists of plug nic + ipassoc (no setsource nat is needed)
2012-07-02 12:58:30 -07:00
60da16fe8b
cloudstack 3.0 API - listVpnConnections API - add publicip property (get it from vpnGateway object).
2012-07-02 10:24:10 -07:00
b09e43f977
CS-15300 Limits on domain admin accounts
...
Reviewed-by: devdeep.singh@citrix.com
change: fix for listResourceLimits
2012-07-02 20:13:06 +05:30
618d2541c8
CS-6840: Add status checking for site 2 site VPN
2012-06-29 18:58:52 -07:00
0f06bc6643
VPC : network usage works in VPC
2012-06-29 17:33:17 -07:00
49d8b650e9
VPC: listPrivateGateways command is available for regular user too (he needs to know the gatewayId for the static route creation)
2012-06-29 15:17:17 -07:00
e07ec3cd2c
cloudstack 3.0: (1) API - CreateVpnConnection API, ListVpnConnections API: set object name for API response.
...
(2) UI - Add site-to-site VPN dialog - call CreateVpnConnection API after CreateVpnCustomerGateway API returns success.
2012-06-29 14:55:26 -07:00
6cf45ad29b
cloudstack 3.0 API: CreateVpnCustomerGateway API, ListVpnCustomerGateways API: set object name for API response.
2012-06-29 14:40:00 -07:00
07ef43bc84
VPC: added vpccidr to the list of VPC router bootload args
2012-06-29 13:59:49 -07:00
37f29ccb11
VPC: set networkId to be null for IP address when the last PF/LB rule is removed for it and the IP belongs to VPC
2012-06-29 13:46:20 -07:00
3f61f42a7e
Fix for CS-15300 Limits on domain admin accounts
2012-06-29 23:53:32 +05:30
d922b99c64
cloudstack 3.0 API: CreateVpnGateway API, ListVpnGateways API: set object name for API response.
2012-06-29 11:05:10 -07:00
077ca1489c
bug CS-15389: Added prepareStop to Virtualmachine manager and moved network usage collection into prepareStop of VR manager
2012-06-28 18:07:47 -07:00
7a5d3f365d
Fixed unittest
2012-06-28 17:21:42 -07:00
e6383fc845
VPC: when add guest network to VPC, verify that the list of network services is within the list of services supported by VPC offering
2012-06-28 17:13:39 -07:00
c4cf065a3f
bug CS-15221: Encrypt config value before changing category to Hidden. Regression due to af1fc1cf5d361cb6d43e0107a644c42f645a0ccc
...
status CS-15221: resolved fixed
reviewed-by: Nitin
2012-06-28 15:54:45 -07:00
fc44c5203e
bug CS-15168: Use cagetory from DB instead of Config.java, set category to Hidden during upgrade if they are not already
...
status CS-15168: resolved fixed
reviewed-by: Nitin
2012-06-28 15:49:53 -07:00
66a918f51a
CS-6840: List all objects without require parameter
2012-06-28 15:25:15 -07:00
ceb4445166
VPC: createPF/createLBrule: 1) don't allow to pass openFirewall=true 2) when no openFirewall is passed in, defaulted to false if the public ip belongs to VPC
2012-06-28 14:19:14 -07:00
90b96642a7
Static route can be created for generic VpcGateway now, not just Private gateway
2012-06-28 13:14:54 -07:00
23c96451a7
CS-6840: Add hypervisor commands for site-to-site vpn
2012-06-27 19:06:32 -07:00
8670b703d2
CS-6840: Add Site2SiteVpnServiceProvider
2012-06-27 19:05:48 -07:00
52e80e5fb0
CS-6840: Add commands for site-to-site vpn
2012-06-27 19:05:41 -07:00
67a434243b
CS-6840: Add data structure for site-to-site vpn tables
2012-06-27 19:05:33 -07:00
edb8e04b0e
VPC: update public IP info in domain_router table once the VR gets the public nic
2012-06-27 17:41:41 -07:00
709e878e43
CS-15356: cloudstack 3.0 API - updateZone API - when internaldns2 parameter is not being passed to updateZone API, leave it as is (i.e. remain original value of internaldns2).
2012-06-27 16:43:55 -07:00
74043d28e4
VPC: delete network ACLs as a part of network cleanup
2012-06-27 15:58:09 -07:00
4c187a66d1
Merge branch '3.0.x' of ssh://git.cloud.com/var/lib/git/cloudstack-oss into 3.0.x
2012-06-27 15:37:50 -07:00
73a3c8f496
Bug CS-15372: IdentityProxy info should be copied over during exception handling in API layer for create(), like it is done in execute().
...
Description:
1. Added exception processing for uuid lists in exceptions,
for commands of type BaseAsyncCreateCmd.
2. Added nullpointer check in addProxyObject().
3. Miscellaneous whitespace reformatting for git patching.
2012-06-27 15:33:19 -07:00
bc9b23dfcd
VPC: implemented vpc cleanup thread that cleans up Inactive VPCs (that were failed to delete)
2012-06-27 15:12:56 -07:00
67f4776243
VPC: fixed ip addres assignment in createLB rule
2012-06-27 14:09:33 -07:00
a65655e559
VPC: as there is no support for FirewallRules/remoteAccessVPN in the VPC, removed the networkId from the list of parameters for corresponding api calls
2012-06-27 14:09:33 -07:00
e2fd2f7515
VPC: don't generate empty SetStaticRoute command during VR start when there are no static routes for the VPC
2012-06-27 10:31:44 -07:00
0b620bc852
VPC: fixed list public ips by vpcId
2012-06-26 16:35:56 -07:00
9936e9b731
VPC: 1) Don't allow to delete private gateway when it has static routes assigned. Routes have to be removed first.
...
2) Re-apply static routes as a part of VPC VR start
2012-06-26 15:14:29 -07:00
8a7e525aa9
VPC: fixed getEntityOwnerId() in AssociateIpAddress command to return vpc owner if vpcId is passed in. Added action events for create/delete privateGateway/staticRoutes
2012-06-26 14:08:13 -07:00
ccb075de6f
VPC: added vpcId to SetStaticNatRule and CreateLoadBalancerConfig commands
2012-06-26 13:36:33 -07:00
9d88781e8c
VPC: implementation for Add/delete/list StaticRoute. Agent implementation is yet to be done
2012-06-26 11:11:26 -07:00
2f678f5697
Applied patch https://reviews.apache.org/r/5522/diff/
2012-06-25 21:19:01 -07:00
0f863b3025
Fixed unittest
2012-06-25 20:38:16 -07:00
a539c6e824
VPC: intermidiate checkin to Static Routes
2012-06-25 18:08:19 -07:00
84a4a7c1c8
VPC: update ip address object after the ip is associated with the network
2012-06-25 16:26:19 -07:00
32c858ecd2
VPC: finilize start for the VR - send ip assoc commands only after plug nic is done for all public nics
2012-06-25 15:59:23 -07:00
b407b8831c
VPC: initial checkin for Static Routes
2012-06-25 15:16:17 -07:00
8cbf5f749f
VPC: Don't allow to do ip assoc to the network in the VPC. The ip should be assigned to the VPC itself
2012-06-25 13:19:28 -07:00
9971120897
VPC: moved NetworkACL manager to the vpc folder
2012-06-25 13:19:28 -07:00
c2e3833651
VPC : typo in FirewallRuleVO
2012-06-25 13:09:56 -07:00
12bfac6857
VPC: CS-15354 - fixed updateNetworkServiceProvider for VpcVirtualRouter
2012-06-25 11:31:53 -07:00
515340b5e3
VPC: listPrivateGateways API implementation
2012-06-25 10:12:10 -07:00
f56795d22b
Fix bug CS-15261.
...
In case IP address is passed to deployVirtualMachine API, the default property on NIC was not getting set and as a result there was a failure down the line and VM creation was failing.
2012-06-25 15:21:20 +05:30
05332128e9
VPC: resend private gateway as a part of VPC VR start
2012-06-22 15:47:15 -07:00
d1700606dd
VPC: fixed NPE in network ACL delete (ip address is null for the rule of this type_
2012-06-22 15:06:58 -07:00
ba7fddac3b
VPC: implemented add/delete Private gateway
2012-06-22 15:06:58 -07:00
a96a259923
VPC: apply dhcp entries only after all guest nics are plugged
2012-06-22 10:06:26 -07:00
f013c28536
Fixed unittest
2012-06-21 15:43:02 -07:00
516628273f
VPC: apply firewall ACLs as a part of VPC router start/restart and VPC network implement
2012-06-21 15:10:15 -07:00
4ea750680b
Added NicTO to SetSourceNat command, CreateLoadBalancerConfigCommand, SetNetworkACLCommand
...
Conflicts:
api/src/com/cloud/agent/api/routing/SetNetworkACLCommand.java
2012-06-21 10:05:31 -07:00
e56dbdf78e
canUseForDeploy is always false for system networks
2012-06-20 15:42:41 -07:00
Deepti Dohare
Alena Prokharchyk
Vijayendra Bhamidipati
Sheng Yang
anthony
Pranav Saxena
Koushik Das
Jason Bausewein
Jessica Wang
kishan