etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
27,829 Commits 325 Branches 325 Tags 885 MiB
Commit Graph

2712 Commits

Author SHA1 Message Date
Daan Hoogland 8a8849354c findbugs: masking fields removed 2015-06-24 12:24:12 +02:00
Daan Hoogland 8a99df77b6 findbugs volumeInfo is known to not be null 
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #515
 2015-06-23 23:27:04 +02:00
Daan Hoogland e8984d16ed findbugs: move assert to a place where it still makes sense 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2015-06-23 23:27:03 +02:00
Daan Hoogland c0a1009740 findbugs: (un)boxing of long from string 2015-06-22 13:18:14 +02:00
Rafael da Fonseca fe4f0b1a58 Specify all dependency versions in pom.xml 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #497
 2015-06-22 13:01:19 +02:00
Rafael da Fonseca 83488e01af Reduce about 1k String objects from being instantiated 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-22 13:01:19 +02:00
Rafael da Fonseca 9d19191bc6 Root cause of failure is memory abuse in XenTest.java class ;) This should fix it 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-22 13:01:19 +02:00
Rafael da Fonseca 301a7b9a7e Specify all external dependencies in pom Upgrade to lang3 and change usage of deprecated xmlparse method 
Add another missing dependency

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-22 13:01:19 +02:00
Rafael da Fonseca 1603f722c4 Cleanup some lint checker warning in base classes 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-22 13:01:18 +02:00
Rafael da Fonseca 540b163cfc Resolve unsafe cast warnings reported by lint checker Add some debug config to compiler plugin 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-22 13:01:18 +02:00
Rafael da Fonseca b929db1f1a Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in ElastistorPrimaryDataStoreLifeCycle.java 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #503
 2015-06-22 10:54:55 +02:00
Rafael da Fonseca a17852aaf4 Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING warning in ElastistorUtil.java 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #504
 2015-06-22 10:54:19 +02:00
Rafael da Fonseca 0d8c64ea56 Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in OvmResourceBase.java 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #502
 2015-06-22 10:50:48 +02:00
Rafael da Fonseca dc359c505e Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in BareMetalResourceBase.java 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #501
 2015-06-22 10:50:12 +02:00
Daan Hoogland bbb165a037 findbugs: use preferred encoding explicitly 2015-06-20 10:36:15 +02:00
Daan Hoogland 9eff27a080 findbugs: static member should be final 
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #495
 2015-06-20 00:57:59 +02:00
Daan Hoogland 871ba9c521 findbugs: ignored return value should have been returned down stack 
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #494
 2015-06-20 00:57:01 +02:00
Daan Hoogland e3407a3939 findbugs: encoding using preferred Charset 2015-06-19 23:03:05 +02:00
Sanjay Tripathi 9044a02d9a VM Snapshot Usage for DATA disk is reported as the size of the DATA disk instead of the actual snapshot size. 
This closes #485
 2015-06-19 15:55:21 +05:30
Daan Hoogland 0952580096 findbugs: try-with-resource to circumvent not handling an exception on 
close
 2015-06-17 12:41:04 +02:00
Daan Hoogland 6da6c5f762 findbugs: log unhandled exception as warning 2015-06-17 12:35:39 +02:00
Sanjay Tripathi d702b63bfb CLOUDSTACK-8569: The latter snapshot export for the same volume will fail is 2 snapshot exports are queued 
This closes #469
 2015-06-17 15:27:03 +05:30
Sanjay Tripathi 47278556f5 CLOUDSTACK-8567 Migrating primary storage causes name_label field to blank. 
This closes #468
 2015-06-17 14:46:51 +05:30
Daan Hoogland 41c1fddaee findbugs: better message and fallback to defaultCharset 2015-06-16 11:57:15 +02:00
Rafael da Fonseca 0851e4e54b Catch encoding exception 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #464
 2015-06-16 11:24:51 +02:00
Rafael da Fonseca 9f2ebdf443 Fix findbugs encoding issue in VmwareStorageProcessor.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #460
 2015-06-16 08:56:33 +02:00
Rafael da Fonseca 9bb920af65 Fix findbugs warning in VmwareStorageManagerImpl.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #461
 2015-06-16 08:53:56 +02:00
Rafael da Fonseca 3d48af41a8 Fix findbugs encoding issue in VmwareResource.java Key file should be UTF-8 encoded in VR 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #462
 2015-06-16 08:51:54 +02:00
Rafael da Fonseca 34d097f349 Fix 4 findbugs warnings in JuniperSrxResource Data should be read and written in UTF-8 to the SRX Buffers were being used for reading but not for writing, PrintWriter was auto-flushing and code was explicitly flushing again, causing unnecessary operation to be performed. 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #399
 2015-06-15 21:49:43 +03:00
Wido den Hollander 4b4c52ea77 CLOUDSTACK-8560: Stat the resulting image after copying from template and return the size 
This way we update the DB with the actual size of the disk after deployment from template
 2015-06-15 17:55:56 +02:00
Rafael da Fonseca 9511831f0a Fix 2 findbugs warnings in ElastistorUtil.java Unnecessary boxing/unboxing of long value 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #429
 2015-06-15 12:09:47 +03:00
Rafael da Fonseca ea31a674a4 Fix findbugs warning in ElastistorPrimaryDataStoreLifeCycle.java Unnecessary boxing/unboxing of primitive value 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #428
 2015-06-15 12:09:45 +03:00
Rafael da Fonseca 6f330f7ab6 Fix findbugs warning in PaloAltoResource.java Unnecessary boxing/unboxing of primitive value 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #427
 2015-06-15 12:09:43 +03:00
Rafael da Fonseca 1494487f72 Fix findbugs warning in NetscalerResource.java Unnecessary boxing/unboxing of primitive value 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #426
 2015-06-15 12:09:41 +03:00
Rafael da Fonseca be474f95a1 Fixed 4 findbugs warnings in CitrixResourceBase.java Unnecessary boxing/unboxing of primitive values 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #425
 2015-06-15 12:09:39 +03:00
Rafael da Fonseca 16ddd498d5 Fix findbugs warning in UcsManagerImpl.java Integer was being created to assign value to int 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #424
 2015-06-15 12:09:37 +03:00
Rafael da Fonseca 9ba4e9cb86 Fix findbugs warning in OvmResourceBase.java CreatePrivateTemplateAnswer constructor takes long as physicalSize parameter, Long was being created instead 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #423
 2015-06-15 12:09:36 +03:00
Rafael da Fonseca 9d2fef0de8 Fix findbugs warning in HypervDirectConnectResource.java Two boxed Longs were being created instead of simple long 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #422
 2015-06-15 12:09:34 +03:00
Rafael da Fonseca 30457556f9 Fix findbugs warning in BareMetalResourceBase.java Boxed Integer was being instantiated to assign to an int variable 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #421
 2015-06-15 12:09:32 +03:00
Rafael da Fonseca 85ad1b7e0f Fix 3 findbugs encoding warnings in VmwareStorageProcessor.java Ova templates and metadata should be written to file in UTF-8 Fix warning in UUID generation 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #411
 2015-06-15 12:09:13 +03:00
Rafael da Fonseca ccd7d41ee3 Resolve findbugs encoding warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #392
 2015-06-15 12:07:55 +03:00
Rafael da Fonseca 980d858c34 Add import statements, remove unused FileReader import 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #393
 2015-06-15 12:07:49 +03:00
Rafael da Fonseca 9ad8c70baa Fix findbugs encoding warning, all .xml files contain only utf-8/us-ascii compatible characters 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-06-15 12:07:49 +03:00
Rafael da Fonseca 967da97f51 Fix 2 findbugs warnings in VmwareStorageManagerImpl.java Template files and metadata should be written to file in UTF-8 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #410
 2015-06-15 12:06:19 +03:00
Rafael da Fonseca 11fec86ba3 Fix 1 findbugs warning in VmwareResource.java 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #409
 2015-06-15 12:06:11 +03:00
Rafael da Fonseca 474065e98b Fix findbugs encoding warning in VmwareServerDiscoverer.java Input string should only contain safe characters, since it's derived from a Long object. This just gets rid of the findbugs warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #408
 2015-06-15 12:06:01 +03:00
Rafael da Fonseca f8b364b7c7 Was safe either way as this piece of code should only run in linux, this just gets rid of the findbugs warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #402
 2015-06-15 12:04:47 +03:00
Rafael da Fonseca 3299f23ea2 Fix findbugs encoding warning in LibvirtCreatePrivateTemplateFromVolumeCommandWrapper Libvirt templates should be written in UTF-8, default was already doing that so this just gets rid of the findbugs warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #401
 2015-06-15 12:04:24 +03:00
Rafael da Fonseca b869a16332 Remove unused import to fix checkstyle warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #400
 2015-06-15 12:04:19 +03:00
Rafael da Fonseca 949e97dec6 Fix findbugs warning in LibvirtConsoleProxyLoadCommandWrapper Encoding is now specified in both server and clients for the console proxy getstatus command For some reason, findbugs did not detect unsafe encoding issue in ConsoleProxyResource.java, is properly specified now though... CitrixConsoleProxyLoadCommandWrapper was specifying system default encoding for operation, should be ok because default for xenserver is UTF-8 since it's linux based, but it's best to specify exact encoding set on the server end to be consistent 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-06-15 12:04:18 +03:00