Commit Graph

12334 Commits

Author SHA1 Message Date
Abhisar Sinha a9fb479805 Use executor service for pollImageTransferProgress 2026-04-13 09:41:15 +05:30
Abhisar Sinha 9af2c941ae rename image_transfer disk_id to volume_id 2026-04-13 09:41:14 +05:30
Abhisar Sinha ff12afb8a4 don't allow image transfer creation if image transfer entry is already there. 2026-04-13 09:41:12 +05:30
Fabricio Duarte 9f57a4dd19
Unhide setting `js.interpretation.enabled` (#12605)
* Unhide setting 'js.interpretation.enabled'

* Fix grammar mistake
2026-04-10 23:45:07 -03:00
Manoj Kumar b196e97cc3
Prevent deletion of account and domain if either of them has deleted protected instance (#12901) 2026-04-10 15:51:22 +02:00
Abhisar Sinha df7ff97271
Create volume on a specified storage pool (#12966) 2026-04-10 14:27:39 +02:00
Bernardo De Marco Gonçalves 27e4d979f1
Clean up backup references to their schedules when the schedules are deleted (#12401)
* clean up backup schedule references after their deletion

* drop unused column

* address reviews
2026-04-10 14:51:52 +05:30
Suresh Kumar Anaparti 11538df710
Merge branch '4.22' 2026-04-10 12:02:40 +05:30
Abhishek Kumar 40cadd0369 merge fixes
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 23:52:05 +05:30
Abhishek Kumar 2f673568aa cleanup; return tags with specific key only
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 18:27:53 +05:30
Abhishek Kumar d804b7597b address orphan trnasfers
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 18:27:43 +05:30
Nicolas Vazquez b5858029bb
Fix listing service offerings with different host tags (#12919) 2026-04-09 10:55:47 +02:00
Daman Arora 7ba5240b31
Block backup deletion while create-VM-from-backup or restore jobs are in progress (#12792)
* Block backup deletion while create-VM-from-backup or restore jobs are in progress

* Add tests

* Fix exception message

* Update test

Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com>
2026-04-09 11:09:01 +05:30
Abhishek Kumar 1ddccaa767 fix storagedomain retrieval
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:30:56 +05:30
Abhishek Kumar 10782021e4 addressed with finalizing transfers before backup
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:30:56 +05:30
Abhishek Kumar 800faa4a6f add log
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:30:56 +05:30
Abhishek Kumar 1669c0d496 fix db list issue
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:30:56 +05:30
Abhishek Kumar c588e67d6c changes for adding syncqueueitem for backup to block other operations on
vm

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:30:56 +05:30
Abhisar Sinha 6e420fecd2 fix config export to test backup apis 2026-04-09 10:30:56 +05:30
Abhisar Sinha dc480e07d3 Implement backend for delete vm checkpoint 2026-04-09 10:30:56 +05:30
Abhisar Sinha b84ff6b99a move checkpoint to vm details 2026-04-09 10:30:54 +05:30
Abhisar Sinha d6055c9ae2 create volume on storage refactor 2026-04-09 10:30:11 +05:30
Abhishek Kumar b52daa2be5 changes for access checks
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:30:11 +05:30
Abhisar Sinha 6f4758d062 expiry timeouts for idle image transfers 2026-04-09 10:30:11 +05:30
Abhisar Sinha 2d2f74078f Support local storage and shared mount point 2026-04-09 10:30:10 +05:30
Abhishek Kumar bad164c991 fixes
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:30:10 +05:30
Abhisar Sinha e32a6ab7d9 Make veeam-kvm exclusive with other providers
finalize all pending image transfers when finalize backup is called
2026-04-09 10:30:10 +05:30
Abhisar Sinha ca0ad93d61 Remove dependency on backup offering. Make backup export service exclusive to other backup providers. 2026-04-09 10:30:08 +05:30
abh1sar b6d480cfb1 hide kvm backup export service apis behind a global config 2026-04-09 10:29:11 +05:30
abh1sar 8d42d5f186 change name from IncrementalBackupService to KVMBackupExportService 2026-04-09 10:29:11 +05:30
Abhishek Kumar 5b71847813 fix network listing
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:29:11 +05:30
Abhishek Kumar 38c8b70cf3 server,engine-schema: allow retrieving volume stats for stopped vms
Earlier, we were finding only those instance which have host_id equal to
the given host. Changed code now also returns those VMs which have host_id as NULL and last_host_id as the given host.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:29:08 +05:30
Abhishek Kumar 3bce25db2b fix check for blank instance
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:26:32 +05:30
Abhishek Kumar 1f72a2284c changes for restore with template; refactor
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:26:29 +05:30
Abhisar Sinha 10ad7967cd bug fixes 2026-04-09 10:25:09 +05:30
Abhishek Kumar 05a5b03d95 changes for user assignement; refactor
- make service account configurable
- allow assigning vm, volume to network account

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:25:07 +05:30
Abhishek Kumar a0be1fb772 temp fix for orphan image transfer listing and backup removal
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:23:37 +05:30
Abhisar Sinha b68e541b31 remove hostIpaddress from startNbdCommand 2026-04-09 10:23:37 +05:30
Abhishek Kumar 0dadbadb52 fix start nbd server
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:23:37 +05:30
Abhisar Sinha 8655f61631 fix pre-commit 2026-04-09 10:23:37 +05:30
Abhishek Kumar 27a2eb0869 fix
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:23:37 +05:30
Abhishek Kumar f9070985d5 changes
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:23:37 +05:30
Abhisar Sinha 30136c814a Image server on kvm host - with image_server.py http server 2026-04-09 10:23:33 +05:30
Abhishek Kumar 0b4b02da63 changes to backup and checkpoints api
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:22:38 +05:30
Abhishek Kumar aa7d4bc590 changes for backup job fix
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:22:38 +05:30
Abhishek Kumar 4853453930 kvm hosts and clusters only
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:22:38 +05:30
Abhishek Kumar a89f872b4f wip
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:22:35 +05:30
Abhisar Sinha fba7c634cb ut failure in UserVmManagerImplTest 2026-04-09 10:21:48 +05:30
Abhisar Sinha 586134d392 Support file backend for cow format: api and server 2026-04-09 10:21:47 +05:30
Abhishek Kumar a3669298af worker vm deployment wip
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:19:16 +05:30
Wei Zhou ca4112e7d0 api/server: create dummy KVM VM without volume and network is optional 2026-04-09 10:17:56 +05:30
Abhisar Sinha c36cd2c26c Backup of stopped VMs 2026-04-09 10:14:22 +05:30
abh1sar da62e9a3ed Support multiple disks and checkpoints 2026-04-09 10:14:21 +05:30
Abhishek Kumar b926c7474d server changes
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:14:21 +05:30
Abhisar Sinha 2350661ee3 Added progress to upload Image Transfers 2026-04-09 10:14:19 +05:30
Abhishek Kumar 7b45d2e118 wip: changes for imagetransfer handling
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:13:26 +05:30
Abhisar Sinha 10f65b67d7 image upload working 2026-04-09 10:13:26 +05:30
Abhisar Sinha aae158b2af upload fix-1 2026-04-09 10:13:26 +05:30
Abhisar Sinha 5389fe60aa Image server with disk upload 2026-04-09 10:13:24 +05:30
Abhisar Sinha 23ecb1f5ce Image server basic working version in SSVM. 2026-04-09 10:12:15 +05:30
abh1sar 73df3cbef7 Create volume on the given storage pool 2026-04-09 10:12:15 +05:30
Abhisar Sinha f396c5cc74 Basic working version-1 2026-04-09 10:12:11 +05:30
Abhishek Kumar a30eb280e5 changes for discovery
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-04-09 10:10:57 +05:30
Suresh Kumar Anaparti e2d18c0748
Merge branch '4.22' 2026-04-02 10:30:18 +05:30
Wei Zhou 470812100e
server: set template type to ROUTING or USER if template type is not specified when upload a template (#12768) 2026-04-02 09:34:28 +05:30
Suresh Kumar Anaparti e10c066cc1
Fix NPE during VM setup for pvlan (#12781)
* Fix NPE during VM setup for pvlan

* review comments
2026-04-01 16:29:44 +02:00
julien-vaz 4f93ba888c
Refactor Quota Summary API (#10505)
* Refactor Quota Summary API

* Fixes imports

* Fix QuotaServiceImplTest

* Update plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaSummaryCmd.java

Co-authored-by: Fabricio Duarte <fabricio.duarte.jr@gmail.com>

* Fix QuotaSummaryCmd

* Remove unnecessary imports

* Remove unused createQuotaSummaryResponse declarations

* Remove unnecessary imports

* Update plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaSummaryCmd.java

Co-authored-by: dahn <daan.hoogland@gmail.com>

* Fix QuotaSummaryCmd

* Fix QuotaResponseBuilderImplTest

* Refactor test

* Fix QuotaSummaryCmd

* Fix projectid behavior

* Simplify QuotaSummary and deprecate listall

* Fix createQuotaSummaryResponse

* Remove unused import

* Apply suggestions + some adjustments

* Remove duplicated check

* Fix checkstyle

* Adjust entity owner

* Remove unused method + fix tests

* Add missing @ACL to some parameters

* Adjust how the parameters behave

* Allow domain admins and users to use keyword

* Address reviews

---------

Co-authored-by: Julien Hervot de Mattos Vaz <julien.vaz@scclouds.com.br>
Co-authored-by: Fabricio Duarte <fabricio.duarte.jr@gmail.com>
Co-authored-by: dahn <daan.hoogland@gmail.com>
2026-03-31 20:29:30 -03:00
Henrique Sato 7eea9ed448
Add API to enable/disable NICs for KVM (#12819) 2026-03-31 10:14:20 +02:00
Suresh Kumar Anaparti 68030df10b
VM start error handling improvements and config to expose error to users (#12894)
* VM start error handling improvements, and config to expose error to user

* refactor
2026-03-27 15:35:08 -03:00
Vishesh d38c1f8d12
Fix error message while creating local storage pool (#12767)
* Fix error message while creating local storage pool
2026-03-27 10:29:13 +05:30
Fabricio Duarte 2416db2a44
Fix NPE on external/unmanaged instance import using custom offerings (#12884)
* Fix NPE on external/unmanaged instance import using custom offerings
2026-03-27 10:25:16 +05:30
Abhisar Sinha b22dbbe2d7
Fix Revert Instance to Snapshot with custom service offering (#12885)
* Fix revertVM with custom svc offering
2026-03-27 10:19:52 +05:30
Suresh Kumar Anaparti 1bff543e58
Merge branch '4.22' 2026-03-27 01:25:42 +05:30
Nicolas Vazquez c1af36f8fc
[4.22] Prevent unmanaging or reinstalling a VM if it is part of a CKS cluster (#12800) 2026-03-26 18:17:49 +05:30
Suresh Kumar Anaparti 84676afd5c
Check for null host before proceeding with VM volume operations in managed storage while restoring VM (#12879) 2026-03-26 07:58:52 -03:00
Suresh Kumar Anaparti 7c3637a2f5
Fix duplicate dummy templates, and update guest os for dummy template (#12780)
* Fix duplicate dummy template 'kvm-default-vm-import-dummy-template' entries

* Update guest os id of dummy template to 99 (Other Linux (64-bit)) from existing id: 1 (CentOS 4.5 (32-bit))

* update migration path to remove duplicate dummy templates
2026-03-24 18:01:26 +05:30
Nicolas Vazquez 7107d28db8
[VMware to KVM] Add guest OS for importing VM based on the source VM OS (#12802) 2026-03-24 15:06:38 +05:30
Suresh Kumar Anaparti bce55945ec
Mark VMs in error state when expunge fails during destroy operation (#12749)
* Mark VMs in error state when expunge fails during destroy operation

* fetch volume by external id (used by external plugins)

* review comments

* Update reorder hosts log to DEBUG, log line is too verbose to have on as INFO
2026-03-24 00:29:14 -03:00
Abhisar Sinha c19630f0a4 Fix snapshot copy resource limit concurrency 2026-03-19 14:42:49 +05:30
Fabricio Duarte 8608b4edd0 Fix snapshot copy resource limit concurrency
Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com>
2026-03-18 01:52:36 -03:00
Fabricio Duarte f333134456 Address merge issues 2026-03-17 19:28:16 -03:00
Daniel Augusto Veronezi Salvador e8d57d1b0d Implement/fix limit validation for secondary storage 2026-03-17 18:56:28 +01:00
João Jandre 86c9f7bd94 Fix backup list 2026-03-17 17:14:38 +01:00
Fabricio Duarte 9db630932e Address public IP limit validations 2026-03-17 16:45:33 +01:00
Fabricio Duarte c6b20b8cc7 Fix failing tests 2026-03-17 15:51:45 +01:00
Fabricio Duarte 88a12a801f Cleanup imported VM from disk on failure due to volume allocation + prevent duplicate volume and primary storage increment on import 2026-03-17 15:50:26 +01:00
Manoj Kumar e93ae1a4f4
New config key "allow.import.volume.with.backing.file" to skip volume backing (#12809)
* Added support for skipping volume backing when importing unmanaged volumes and VMs. This allows users to import volumes and VMs without creating a backing volume, which can be useful in certain scenarios where the backing volume is not needed or desired.

* cleanup conflicting key

* move configkey into VolumeImportUnmanageService

---------

Co-authored-by: rajujith <rajujith@gmail.com>
2026-03-17 11:34:34 -03:00
Fabricio Duarte 9c0c8da706 [22.0] Address limit checks for VM, CPU, memory, volume, and primary storage 2026-03-17 15:10:33 +01:00
Pearl Dsilva 3bd5410f9a
Add support to clone existing offerings and update them (#12357)
* Add support to clone existing offerings and update them

* add support for vpc & backup offerings to be cloned

* fix capability list and mapping of params

* Add support to clone network and vpc offering with the right parameters

* make fields non mandatory for clone offerings APIs

* Add UI support for cloning Compute and System Service offerings

* remove unnecessary changes

* fix license and pre-ccommit issues

* Add UI support to clone disk and network offering

* vpc & backup offering clone api

* add unit tests

* fix pre-commit checks

* increase test coverage

* combine add/clone disk/compute offering forms

* update license

* fix unit tests

* fix test failures

* fix test failure - unnecessary stubbings

* pre-commit check failure

* add recently added domain id for bkp offering to be inherited in clone operation

* extract common code wrt service capability in network & vpc offering in add/clone operations

* add some checks to prevent networkmode change when provider is nsx/netris from the source networkmode

* address copilot comments

* address comments

* combine check

* use appropriate zoneId during clone bkp offering

* add check

* fix issue with test

* remove unused imports

* prevent creating a bkp offering of a bkp repo that already exists

* extend clone disk and service offerings to domain admins
2026-03-17 12:01:43 +05:30
Abhisar Sinha 61afb4cb78 fix identation 2026-03-16 17:40:24 +01:00
Abhisar Sinha 23b19a9776 review comments 2026-03-16 17:40:24 +01:00
Fabricio Duarte dc7068a135 Address public IP limit validations 2026-03-16 11:47:32 +01:00
Fabricio Duarte e8f8aca694 Fix failing tests 2026-03-16 11:47:32 +01:00
Fabricio Duarte 497266270b Cleanup imported VM from disk on failure due to volume allocation + prevent duplicate volume and primary storage increment on import 2026-03-16 11:47:32 +01:00
Fabricio Duarte 0a4b4c6af0 [20.3] Address limit checks for VM, CPU, memory, volume, and primary storage 2026-03-16 11:47:32 +01:00
Fabricio Duarte 360b64ce1e Consider infinite resources when calculating secondary storage limit for upload operations 2026-03-16 11:47:32 +01:00
Abhisar Sinha 81a8ac8e1f secondary storage resource limit for upload 2026-03-16 11:47:32 +01:00
abh1sar 03dfe4d1f3 secondary storage resource limit for download 2026-03-16 11:47:32 +01:00
Abhisar Sinha 4bcd509193 Fix resource limit reservation and check during StartVirtualMachine 2026-03-16 11:47:32 +01:00
Daniel Augusto Veronezi Salvador 06ee2fea76 Implement/fix limit validation for secondary storage 2026-03-16 11:47:32 +01:00