Commit Graph

1459 Commits

Author SHA1 Message Date
Sheng Yang 21fe5e1087 bug 14074: Specify networkId for list public ip
status 14074: resolved fixed
2012-03-12 12:00:31 -07:00
Sheng Yang 476c671374 Refactor VirtualNetworkApplianceManagerImpl
Add separate create command for dhcp, userdata and password.
2012-03-09 19:02:47 -08:00
Sheng Yang d62d3b5a01 Refactor rules appling in the VirtualNetworkApplianceManagerImpl 2012-03-09 18:00:06 -08:00
Vijayendra Bhamidipati df51744979 Bug 13127: API error text refer to database ids instead of uuids
Description:

	Removed some wrong invocations to addProxyObject() when
	throwing exceptions in NetworkManagerImpl.java.

	Replaced db ids with uuids in various points in the code
	of NetworkManagerImpl.java, where exceptions are thrown.
2012-03-09 01:13:36 -08:00
Sheng Yang e152e64ac0 Fix several wrong ResourceUnavailableException scopes 2012-03-08 11:55:31 -08:00
Alena Prokharchyk 65e160b7e6 bug 14173: add eip/elb network offering (if missing) during the management server start
status 14173: resolved fixed
2012-03-07 10:02:24 -08:00
Vijayendra Bhamidipati 57c54e23d6 Bug 14060: Include a CloudStack error code in an Exception Response
Bug 13127: API error text refer to database ids instead of uuids

Code-Reviewers: Ewan Mellor, Kelven Yang

Description:

	1. A new class CSExceptionErrorCode has been added to utils.
	   It contains a list of error codes for each type of
	   Exception class. Use fully qualified package paths for
	   Exceptions in CSExceptionErrorCode.  We log any exception
	   name not found in the list of error codes for exceptions.

	2. Whenever we throw an exception exobj anywhere in the
	   CS code, the CSErrorCode is set in the base class
	   constructor.

	3. We add a new field csErrorCode in classes CloudException,
	   RuntimeCloudException, ExecutionException and
	   ExceptionResponse.

	4. Two places in ApiServer.java were wrongly modified when
	   putting in changes for bug 13127 to not throw an exception.
	   This has been corrected in this commit.
2012-03-05 17:39:09 -08:00
Sheng Yang 1cd4ef5f07 bug 14110: Fix error message
status 14110: resolved fixed
2012-03-05 11:02:19 -08:00
Sheng Yang 887256ad12 bug 14076: Fix the exception scope
status 14076: resolved fixed
2012-03-01 14:58:40 -08:00
Alena Prokharchyk ce433f9df2 Wrap deletePhysicalNetwork in transaction 2012-02-29 11:02:57 -08:00
Vijayendra Bhamidipati 59631452b9 Bug 13127: API error text refer to database ids instead of uuids
Description:

	Modify Exception handling to enable addition of multiple
	uuids in a single exception thrown by API functions. Both
	XML and JSON outputs will store all uuids and Fieldnames.
	This will make it easier to provide more information when
	an exception occurs - for example, a zone id, a cluster id,
	host id, and then a specific property id.
2012-02-27 17:55:03 -08:00
Vijayendra Bhamidipati bfe1122bc6 Bug 13127: API error text refer to database ids instead of uuids
Description:

	Added a field name for the db id in the IdentityProxy class, and
	modified setProxyObject() to take an additional id name parameter.
	This will let us know the name of the uuid that we are returning.
	E.g.- domainId, zoneId, etc. The client can view this field in
	the json/xml output. Modified the JSON/XML serialization routines
	to append this new parameter to the serialized output for Exception
	Responses.
2012-02-27 17:55:01 -08:00
Vijayendra Bhamidipati c3fbe29cf8 Bug 13127: API error text refer to database ids instead of uuids
Description:

	1) Added a setProxyObject() method to CloudException and RuntimeCloudException
	2) Modified a bunch of throw exceptions in NetworkManagerImpl.java to call setProxyObject() before throwing an exception.
	3) Changed scope of ProxyIdentity attribute to protected.
	4) Added routines to ServerApiException to get/set IdentityProxy object, and
	   routine in RuntimeCloudException to get the Idproxy object.
	5) Modified the exception handling around the dispatcher and handlerequest()
	   to copy over the IdentityProxy information before rethrowing an exception
	   eventually back to handle().
	6) Removed duplicate IdentityProxy object in ServerApiException.
	   It was extending RuntimeCloudException which already had an
	   IdentityProxy object.
2012-02-27 17:54:56 -08:00
Vijayendra Bhamidipati 768d7a2a26 Bug 13127: API error text refer to database ids instead of uuids
Description:

1)	Moved RuntimeCloudException from api/ to utils/.

	Added simple constructor to RuntimeCloudException.

	Modified all classes that extended RuntimeException
	to extend RuntimeCloudException. These classes
	are listed below:

		ServerApiException
		CloudAuthenticationException
		CloudExecutionException
		AsyncCommandQueued
		HypervisorVersionChangedException
		RuntimeCloudException

2)	Added overloaded constructed to CloudException.
	Modified all classes that extend Exception to extend CloudException instead.
	These classes are listed below:

		ConcurrentOperationException
                ConflictingNetworkSettingsException
                ConnectionException
                DiscoveryException
                InsufficientCapacityException
                ManagementServerException
                ResourceUnavailableException
                VirtualMachineMigrationException
                AgentControlChannelException
                OperationTimedoutException.java
                UnsupportedVersionException.java
                UsageServerException.java
                UnableDeleteHostException.java
                AgentAuthnException.java
                HttpCallException.java
                ActiveFencingException.java
                ClusterInvalidSessionException.java
                GreTunnelException.java
                OvsVlanExhaustedException.java
2012-02-27 17:54:53 -08:00
Kelven Yang 2d9a949ff8 bug 13989: get domr control IP from NIC table, the old private ip in domain_router table is no longer valid under basic zone configuration. Reviewed-By: Anthony 2012-02-27 15:05:18 -08:00
Alena Prokharchyk 8f988b97cb Clone services map when do provider/service verification during network offering addition.
Reviwed-by: Prachi Damle
2012-02-24 15:32:01 -08:00
Kelven Yang b597362e50 bug 13989: GetDomRVersion command context is not correctly set for VMware under Basic zone configuration. Reviewed-By: Anthony 2012-02-24 10:01:07 -08:00
Alena Prokharchyk 6612744c61 bug 13971: return only offerings with matching tags when zoneId is passed in and corresponding zone has more than 1 physical network
status 13971: resolved fixed
Reviewed-by: Prachi Damle
2012-02-23 16:52:50 -08:00
Alena Prokharchyk f03fc196ad bug 13961: always return NetworkUsageAnswer from the networkUsageCommand
status 13961: resolved fixed
Reviewed-by: Alex Huang
2012-02-23 11:15:38 -08:00
Sheng Yang e2c7fe5f4f Fix debug messages in RulesManagerImpl
Reviewed-by: Edison
2012-02-23 10:58:57 -08:00
Alena Prokharchyk 99b0fbbdcb bug 13925: don't allow to delete the network when there are vms in Error state (these vms has to be cleaned up by expunge process first)
status 13925: resolved fixed
Reviewed-by: Sheng Yang
2012-02-22 11:55:08 -08:00
Alena Prokharchyk 2992c608c4 bug 13919: do includingRemoved Nic search when remove firewall rules during the vm expunge
status 13919: resolved fixed
Reviewed-by: Sheng Yang
2012-02-21 18:02:44 -08:00
prachi 760c62eb15 Bug 13224 - Network Usage - Netscaler - External device is being queried multiple times (up to 8 times) whenever the Network Usage task is run.
Reviewed-by: Kishan

Changes:
- Separated out the External Network Usage task from the ExternalLBDeviceMgr because ExternalLbDeviceMgrImpl :: start() was getting multiple times during management server satrtup. The reason for this is that this is the baseclass for F5 and NetScalarElement.
- This caused us to schedule the ExternalNetworkUsageTask multiple times
- Also we have LBRulesMgr calling this ExternalLbDeviceMgrImpl  by creating an instance of this class which is declared abstract
- Hence having a separate implementation to manage the network usage stats should solve this.
2012-02-21 17:16:07 -08:00
Alena Prokharchyk 2e9511e2ae Changed isElastic to isSystem for the publicIpAddress assigned during the vm deployment in EIP enabled network
Reviewed-by: Chiradeep
2012-02-21 15:39:49 -08:00
Sheng Yang a9a1475302 bug 13915: Fix VirtualRouter get gateway IP when others used as SourceNatServiceProvider
status 13915: resolved fixed

Reviewed-by: Edison
2012-02-21 15:24:14 -08:00
kishan d0612151d8 Bug 13823: Throw network conflict expection when LB rules conflict
Status 13823: resolved fixed
Reviewed-By: Nitin
2012-02-22 01:15:29 +05:30
kishan 11e4ded985 Bug 13619: Throw exception when not traffic sentinel host is not available. Update last_collection timestamp when atleast 1 IP has nonzero bytes
Status 13619: resolved fixed
Reviewed-By: Nitin
2012-02-21 23:41:37 +05:30
Alena Prokharchyk 4dea695e09 bug 13871: use perzone and peraccount (no spaces in values) when compare source nat capabilities
status 13871: resolved fixed
Reviewed-by: Chiradeep Vittal
2012-02-21 10:06:29 -08:00
Murali reddy 4e9b312bf2 bug 13855: F5 - Hold time paramS for sticky policies are not getting programmed in F5
- configuring unique persistence profile for each LB rule with sticky method applied
  - removing source based sticky method for source based LB method which is not supported by F5
2012-02-21 22:04:37 +05:30
frank a1fa313902 Bug 13568 - secondary storage VM's static route for nfs server breaks things!
status 13568: resolved fixed
reviewed-by: Sheng Yang
2012-02-17 16:24:32 -08:00
Sheng Yang 4f08afb784 bug 13867: Pass hostId instead of external firewall device Id
status 13867: resolved fixed

Reviewed-by: Anthony
2012-02-17 15:28:06 -08:00
Sheng Yang d94189a3d9 bug 13829: Add default capacity for SRX
And per Alex's request, add default value directly into the database, rather
than using it at last minute of implemention.

status 13829: resolved fixed

Reviewed-by: Alex
2012-02-17 15:25:41 -08:00
Sheng Yang 79454ce4d8 bug 13829: Fix NPE in ExternalFirewallDeviceManagerImpl
Reviewed-by: Edison
2012-02-17 13:30:08 -08:00
Alena Prokharchyk 50fc52ee9b bug 13854: don't allow to remove network offerings if its in use by existing networks
status 13854: resolved fixed
Reviewed-by: Alex Huang
2012-02-17 12:58:54 -08:00
kishan 74ce678baf Bug 13802: Log VPN user remove usage event when user fails to get applied
Status 13802: resolved fixed
Reviewed-By: Nitin
2012-02-17 14:17:28 +05:30
kishan ced6fd46b8 Bug 12954: Added usage for security groups. Usage will be generated for each security group that is assigned to a Vm.
Status 12954: resolved fixed
Reviewed-By: Nitin
2012-02-17 13:50:18 +05:30
Alena Prokharchyk ebe664cff2 bug 13041: in Basic zone just restart all exising domRs in the zone during the networkRestart, don't try to create a new one
status 13041: resolved fixed
reviewed-by: Sheng Yang
2012-02-16 14:58:16 -08:00
Alena Prokharchyk 13f4d92d2a bug 13813: fixed network offering search to use traffic type when locate physical network in the zone
status 13813: resolved fixed
Reviewed-by: Frank
2012-02-16 10:40:00 -08:00
Alena Prokharchyk ee77167fae bug 13801: fixed broken check for extending vnet ranges during physical network update
status 13801: resolved fixed
Reviwed-by: Kelven Yang
2012-02-16 10:01:07 -08:00
Murali reddy c544d85988 bug 13625: F5 - NullPointerException seen when trying to delete/restart a network that was failed to implement properly during implement network
Reviewed-By: Abhi
status 13625: resolved fixed

adding logic to gracefully exit shutdown operation, if earlier network failed to implement
2012-02-16 18:47:37 +05:30
Murali reddy 4b728abedb bug 13722: When we try to create a network when there is no capacity in F5, we should not attempt to create the network
Reviewed-By:Jana
status 13722: resolved fixed

thorwing resource unavaiable exception when there is not enough capacity to implement network
2012-02-15 19:05:44 +05:30
Murali reddy a338fe5003 bug 13664: F5 device can be added in "Dedicated" mode but Network offering allows for only "shared" LB isolation to be set.
Reviewed-By: nitin.mehta@citrix.com
status 13664: resolved fixed

added dedicated mode as capability to F5 load balancer element
2012-02-15 17:16:59 +05:30
Sheng Yang 3a37ab6772 bug 13715: Modify changeCidr parameter of updateNetwork API
We expect user to use following sequence when update virtual router provided
network offering to external firewall devices offering:
1. Shutdown all the user VMs.
2. Modify network to new offering.
3. Click "Allow CIDR change" in the pop-up dialog, which would pass
changeCidr=true to the updateNetwork API.

We would shutdown guest network before we update the network for new
offering(with changeCidr = true), in order to re-implement the network.

status 13715: resolved fixed

Reviewed-by: Alex
2012-02-14 19:34:23 -08:00
frank ede4c502f2 Bug 13662 - OVM host remain in Alert state, Unable to create deployment for OVM instance
Bug 13641 - OVM add host to OVM cluster results in host remaining in state: Alert
Bug 13652 - OVM add primary storage to OVM cluster FAIL

making Ovm work on Acton

status 13662: resolved fixed
status 13641: resolved fixed
status 13652: resolved fixed

reviewed-by: edison
2012-02-14 15:12:46 -08:00
Alena Prokharchyk 5e9a15c07d bug 13708: make a search by traffic type when locate physical network in the zone
status 13708: resolved fixed
reviewed-by: Prachi Damle
2012-02-14 12:47:33 -08:00
Sheng Yang 03aa8d727c bug 13643: Fix assigned router gateway IP
The ExternalGuestNetworkGuru need to respect some of existed IP assignment,
especially router. Otherwise router can't get correct IP address(gateway IP).

status 13643: resolved fixed

Reviewed-by: Alex
2012-02-13 17:10:10 -08:00
Alena Prokharchyk 4f2e9a5195 Don't allow guest network creation when guestCidr is not configured in corresponding zone 2012-02-10 11:02:26 -08:00
Edison Su 5f897816ab bug 13579: set default timeout to -1
status 13579: resolved fixed
2012-02-09 16:49:50 -08:00
Sheng Yang 14142363a1 Better error message for changeCidr 2012-02-09 14:40:18 -08:00
Naredula Janardhana Reddy 023d06124f Bug 12812:
Summary of changes:
   - applyLoadBalancerConfig(long lbRuleId) method applies only one rule if it is Netscalar otherwise applies all the rules in add/revoke state.
2012-02-09 12:05:29 +05:30