Commit Graph

5058 Commits

Author SHA1 Message Date
Alena Prokharchyk 4f741c833c bug 14170: issues #1-#3 are fixed 2012-03-07 13:37:16 -08:00
Alena Prokharchyk 65e160b7e6 bug 14173: add eip/elb network offering (if missing) during the management server start
status 14173: resolved fixed
2012-03-07 10:02:24 -08:00
Alena Prokharchyk f3935d667f bug 14156: return instancename parameter in userVm response to ROOT admin only 2012-03-06 13:39:13 -08:00
prachi 5148145d18 Bug 14028 - Add hostid parameter to StartVmCmd to enable admins to start VM on a particular host
Changes:
- Added hostid to StartVMCmd. Only root admin can use it.
2012-03-05 17:50:23 -08:00
Vijayendra Bhamidipati 57c54e23d6 Bug 14060: Include a CloudStack error code in an Exception Response
Bug 13127: API error text refer to database ids instead of uuids

Code-Reviewers: Ewan Mellor, Kelven Yang

Description:

	1. A new class CSExceptionErrorCode has been added to utils.
	   It contains a list of error codes for each type of
	   Exception class. Use fully qualified package paths for
	   Exceptions in CSExceptionErrorCode.  We log any exception
	   name not found in the list of error codes for exceptions.

	2. Whenever we throw an exception exobj anywhere in the
	   CS code, the CSErrorCode is set in the base class
	   constructor.

	3. We add a new field csErrorCode in classes CloudException,
	   RuntimeCloudException, ExecutionException and
	   ExceptionResponse.

	4. Two places in ApiServer.java were wrongly modified when
	   putting in changes for bug 13127 to not throw an exception.
	   This has been corrected in this commit.
2012-03-05 17:39:09 -08:00
prachi 996110c928 Bug 14000 - Neither Admin or regular user can create a VM when the Pod is disabled
Bug 14006 - Admin could not create a VM when the cluster is Disabled

Changes:
- For Root admin, planner will not filter out the disabled pods or clusters from the resource list
2012-03-05 17:04:22 -08:00
prachi d2ecd8c89a Bug 13999 - Non-admin user should not be able to take snapshots
Changes:

If Zone is disabled, deny permission to regular user while creating snapshots
2012-03-05 17:04:13 -08:00
Alena Prokharchyk 96cdc408d4 bug 14103: mark account for cleanup only in cleanupAccount and disableAccount method, not in the callers methods
status 14103: resolved fixed
2012-03-05 16:19:12 -08:00
frank d7fb9177d1 allow more commands when resource state in maintenance mode 2012-03-05 15:38:06 -08:00
frank b55997d39b allow SetupCommand when resource is in maintenance mode.
Since maintenance is resource state not agent status right now
2012-03-05 15:38:00 -08:00
frank 77ba5d0f8e Bug 14068 - Db upgrade: resource_state is incorrect for the host in UP state after the db upgrade from 2.2.x to 3.0
Bug 14099 - Db upgrade for storage network

status 14068: resovled fixed
status 14099: resovled fixed
2012-03-05 15:37:46 -08:00
Sheng Yang 1cd4ef5f07 bug 14110: Fix error message
status 14110: resolved fixed
2012-03-05 11:02:19 -08:00
kishan de997c1e45 Bug 13952: Changed category of Usage configs
Status 13952: resolved fixed
Reviewed-By: Abhi
2012-03-05 18:58:49 +05:30
kishan 637b228130 Bug 14081: Added 3.0.0 templtae upgrade support. Added unit test case and DB dump
Status 14081: resolved fixed
Reviewed-By: Abhi
2012-03-05 17:25:38 +05:30
Likitha Shetty 9e716e6de3 Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2012-03-05 10:33:12 +05:30
Alena Prokharchyk 66e7e64915 Db upgrade for security group provider 2012-03-02 16:07:42 -08:00
Sheng Yang d58f0a976d Fix element_id upgrade with network_id=0 2012-03-02 11:15:56 -08:00
kishan d74260e197 Added systemVm template upgrade queries for XenServer 2012-03-02 20:33:26 +05:30
Alena Prokharchyk 6a1d7e309d More fixes to 2.2.x - 3.0 db upgrade 2012-03-01 18:31:50 -08:00
Alena Prokharchyk fa0e25d146 bug 14080: do EQ instead of LIKE search when search for duplicated users during the user update
status 14080: resolved fixed
2012-03-01 15:11:46 -08:00
Sheng Yang 887256ad12 bug 14076: Fix the exception scope
status 14076: resolved fixed
2012-03-01 14:58:40 -08:00
kishan 93b859970f Bug 14039: Changed SSO key category Secure
Status 14039: resolved fixed
Reviewed-By: Abhi
2012-03-01 21:00:48 +05:30
Likitha Shetty 25db257a9a Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2012-03-01 14:39:43 +05:30
Alena Prokharchyk 152dfe4fd2 More fixes to the db upgrade 2012-02-29 16:26:44 -08:00
Alena Prokharchyk e992a25e1a bug 14033: root/domain admin limits are always Unlimited. Return it as Unlimited in listResourceLimit response
status 14033: resolved fixed
2012-02-29 15:15:36 -08:00
Alena Prokharchyk 25676aa3c6 bug 14017: 1) Don't allow NULL value for Boolean type of config 2) Added a null check when compare config values
status 14017: resolved fixed
2012-02-29 13:09:47 -08:00
Alena Prokharchyk ce433f9df2 Wrap deletePhysicalNetwork in transaction 2012-02-29 11:02:57 -08:00
Likitha Shetty 6915bd7e6a Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2012-02-29 18:48:48 +05:30
Kelven Yang 5aade501dc fix merge conflicts 2012-02-28 17:06:23 -08:00
Kelven Yang 52ebf15e7c Console proxy refactoring incremental check-in - new VNC protocol implementation 2012-02-28 17:03:38 -08:00
Sheng Yang 0d2693c1c4 Add element_id for 3.0 upgrade 2012-02-28 16:19:38 -08:00
Alena Prokharchyk 2eaefc4aa8 Fixed unittest and some issues with 2.2.14-3.0 upgrade 2012-02-28 15:17:14 -08:00
Likitha Shetty 62610f9207 Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2012-02-28 15:03:01 +05:30
Vijayendra Bhamidipati 83101a752f Bug 13127: API error text refer to database ids instead of uuids
Description:

	Modified the IdentityTypeAdapter's custom serializer to
	identify whether this is an exception response that is being
	serialized, by checking if the idFieldName is set. If so,
	serialize both uuid and the uuidProperty (for eg, zoneId and
	"zoneId" (string)) and pass back the json representation of that.

	Modified XML serializer also to build a list of uuids+fieldnames.

	Introduced a new field "cserrorcode" in ExceptionResponse. This
	refers to an error code that can be according to the specific
	Exception being thrown. This will be serialized as usual. There
	shouldn't be any need to do a db lookup for conversion for these
	error codes.
2012-02-27 17:55:06 -08:00
Vijayendra Bhamidipati 59631452b9 Bug 13127: API error text refer to database ids instead of uuids
Description:

	Modify Exception handling to enable addition of multiple
	uuids in a single exception thrown by API functions. Both
	XML and JSON outputs will store all uuids and Fieldnames.
	This will make it easier to provide more information when
	an exception occurs - for example, a zone id, a cluster id,
	host id, and then a specific property id.
2012-02-27 17:55:03 -08:00
Vijayendra Bhamidipati bfe1122bc6 Bug 13127: API error text refer to database ids instead of uuids
Description:

	Added a field name for the db id in the IdentityProxy class, and
	modified setProxyObject() to take an additional id name parameter.
	This will let us know the name of the uuid that we are returning.
	E.g.- domainId, zoneId, etc. The client can view this field in
	the json/xml output. Modified the JSON/XML serialization routines
	to append this new parameter to the serialized output for Exception
	Responses.
2012-02-27 17:55:01 -08:00
Vijayendra Bhamidipati e5b4cf5cf1 Bug 13127: API error text refer to database ids instead of uuids
Description:

	1) Put in an IdentityProxy object in the ExceptionResponse class.
	   This allows us to copy over the IdentityProxy object contained
	   in the exception caught by handlerequest() when thrown by the
	   command's execute() method, into the Response object that is
	   prepared to return an exception response to the calling API
	   invocation.

	2) Modified the GSON serialization method to conver the entire
	   exception object into JSON format and not just the error text.

	3) Modify the updateDomain API to populate the exception it throws
	   upon detecting a duplicate domain to include the tablename and
	   domain db id in the exception's IdentityProxy object.

	NOTE:
	1) We can modify the base exception classes and the ExceptionResponse
	   class to contain a list of IdentityProxy objects rather than a
	   single one.
	2) We will need to modify all commands such that wherever applicable
	   (wherever a db id is involved), they populate the IdentityProxy
	   object(s) before throwing an exception.
2012-02-27 17:54:58 -08:00
Vijayendra Bhamidipati c3fbe29cf8 Bug 13127: API error text refer to database ids instead of uuids
Description:

	1) Added a setProxyObject() method to CloudException and RuntimeCloudException
	2) Modified a bunch of throw exceptions in NetworkManagerImpl.java to call setProxyObject() before throwing an exception.
	3) Changed scope of ProxyIdentity attribute to protected.
	4) Added routines to ServerApiException to get/set IdentityProxy object, and
	   routine in RuntimeCloudException to get the Idproxy object.
	5) Modified the exception handling around the dispatcher and handlerequest()
	   to copy over the IdentityProxy information before rethrowing an exception
	   eventually back to handle().
	6) Removed duplicate IdentityProxy object in ServerApiException.
	   It was extending RuntimeCloudException which already had an
	   IdentityProxy object.
2012-02-27 17:54:56 -08:00
Vijayendra Bhamidipati 768d7a2a26 Bug 13127: API error text refer to database ids instead of uuids
Description:

1)	Moved RuntimeCloudException from api/ to utils/.

	Added simple constructor to RuntimeCloudException.

	Modified all classes that extended RuntimeException
	to extend RuntimeCloudException. These classes
	are listed below:

		ServerApiException
		CloudAuthenticationException
		CloudExecutionException
		AsyncCommandQueued
		HypervisorVersionChangedException
		RuntimeCloudException

2)	Added overloaded constructed to CloudException.
	Modified all classes that extend Exception to extend CloudException instead.
	These classes are listed below:

		ConcurrentOperationException
                ConflictingNetworkSettingsException
                ConnectionException
                DiscoveryException
                InsufficientCapacityException
                ManagementServerException
                ResourceUnavailableException
                VirtualMachineMigrationException
                AgentControlChannelException
                OperationTimedoutException.java
                UnsupportedVersionException.java
                UsageServerException.java
                UnableDeleteHostException.java
                AgentAuthnException.java
                HttpCallException.java
                ActiveFencingException.java
                ClusterInvalidSessionException.java
                GreTunnelException.java
                OvsVlanExhaustedException.java
2012-02-27 17:54:53 -08:00
U-CITRITE\vijayendra1 698c1ebe12 Bug 13127: API error text refer to database ids instead of uuids
Description:

1)	Adding two new classes, CloudException and RunTimeCloudException.
	The former extends Exception and the latter RunTimeException.
	These will be used by classes that formerly directly extended
	Exception and RuntimeException. These two classes have an attribute
	of type IdentityProxy to enable exceptions fill in db ids in separate
	attribute fields rather than in a string. Doing so will allow the
	serialization module (GSON for JSON and other for XML) to kick in
	and convert this db id to a uuid in ApiServer.java just before the
	JSON/XML responses are sent out.

2)	Moving IdentityProxy.java from api/ to utils/ since
	both CloudException and RuntimeCloudException refer to it.

3)	Changing references to IdentityProxy class from api/ to utils/.

4)	While rebasing to master, a new file was added, merging
	api/src/com/cloud/api/response/IsoVmResponse.java to this diff.
2012-02-27 17:54:50 -08:00
Kelven Yang 7eded374b7 bug 13860: add sanity check to ApiResponseSerializer when serializing XML response. Reviewed-By: Anthony 2012-02-27 16:07:39 -08:00
Kelven Yang 2d9a949ff8 bug 13989: get domr control IP from NIC table, the old private ip in domain_router table is no longer valid under basic zone configuration. Reviewed-By: Anthony 2012-02-27 15:05:18 -08:00
Alena Prokharchyk 50b2c26d3e Fixed XML api writer
Reviewed-by: Alena
2012-02-27 12:38:30 -08:00
Likitha Shetty 61ec79da44 Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2012-02-27 14:43:50 +05:30
Alena Prokharchyk 8f988b97cb Clone services map when do provider/service verification during network offering addition.
Reviwed-by: Prachi Damle
2012-02-24 15:32:01 -08:00
Kelven Yang b597362e50 bug 13989: GetDomRVersion command context is not correctly set for VMware under Basic zone configuration. Reviewed-By: Anthony 2012-02-24 10:01:07 -08:00
Alena Prokharchyk 6612744c61 bug 13971: return only offerings with matching tags when zoneId is passed in and corresponding zone has more than 1 physical network
status 13971: resolved fixed
Reviewed-by: Prachi Damle
2012-02-23 16:52:50 -08:00
Alena Prokharchyk c052d96428 bug 13966: cleanup the vm (stop it on the backend) when work step is Release. Also never retry when finalizeStart failed
status 13966: resolved fixed
reviewed-by: Alex Huang
2012-02-23 15:13:47 -08:00
frank d9019b3f70 Bug 13962 - CloudRuntimeException: Failed to update keypairs on disk: cannot create key file null/.ssh/id_rsa
Changes for Script.java:
1. Even the script is non-timeout one, set default timeout to one hour. This avoid a wrongn script forever hang
2. When InterruptedException happens, check if timeout is really reached, if not, continue

status 13962: resolved fixed
reviewed-by: Alex, Edison
2012-02-23 13:43:10 -08:00
anthony cde66fb4fe bug 13832: fixed NPE
status 13832: resolved fixed
2012-02-23 13:27:01 -08:00
Alena Prokharchyk f03fc196ad bug 13961: always return NetworkUsageAnswer from the networkUsageCommand
status 13961: resolved fixed
Reviewed-by: Alex Huang
2012-02-23 11:15:38 -08:00
Sheng Yang e2c7fe5f4f Fix debug messages in RulesManagerImpl
Reviewed-by: Edison
2012-02-23 10:58:57 -08:00
Alena Prokharchyk 836a063a9e bug 13924: default Firewall provider to Juniper when Juniper is a provider for Pf/StaticNat or source nat service
status 13924: resolved fixed
reviewed-by: Will Chan
2012-02-22 18:46:04 -08:00
Alena Prokharchyk 6b9abf832b bug 13944: when delete the account, expunge detached volumes on the backend
status 13944: resolved fixed
Reviewed-by: Frank Zhang
2012-02-22 17:59:22 -08:00
prachi f619e26c48 Bug 13850 - VM stuck in starting state if it is started during the HA-Work of the corresponding router
Reviewed-By: Kelven

Changes:
- Update the pending work Item to be DONE if we are changing the VM state during fullSync.
2012-02-22 17:36:00 -08:00
prachi e37732c4de Bug 13766 - VMs are still running after disabling the zone
Reviewed-by: Sheng Yang

Changes:
- Do not check if allocation_state is 'Enabled' in planner if the caller is Root Admin.
- This should let Root Admin create a VM in a disabled Zone.
2012-02-22 17:34:00 -08:00
Edison Su 90020679a4 bug 13771: don't send pre snapshot if it's migrated
status 13771: resolved fixed
Reviewed-by: anthony
2012-02-22 17:21:24 -08:00
Alena Prokharchyk 798accae10 Added isTagged parameter to listNetworkOfferings api. When set to true, it will return offerings with not null tag values
Reviewed-by: Jessica Wang
2012-02-22 16:09:35 -08:00
Alena Prokharchyk d4a8db75d7 bug 13763: fixed api doc for logout command
status 13763: resolved fixed
Reviewed-by: Jessica Tomechak
2012-02-22 15:17:22 -08:00
Alena Prokharchyk 99b0fbbdcb bug 13925: don't allow to delete the network when there are vms in Error state (these vms has to be cleaned up by expunge process first)
status 13925: resolved fixed
Reviewed-by: Sheng Yang
2012-02-22 11:55:08 -08:00
Likitha Shetty 2f8181de5e Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2012-02-22 10:18:57 +05:30
Alena Prokharchyk 2992c608c4 bug 13919: do includingRemoved Nic search when remove firewall rules during the vm expunge
status 13919: resolved fixed
Reviewed-by: Sheng Yang
2012-02-21 18:02:44 -08:00
prachi 760c62eb15 Bug 13224 - Network Usage - Netscaler - External device is being queried multiple times (up to 8 times) whenever the Network Usage task is run.
Reviewed-by: Kishan

Changes:
- Separated out the External Network Usage task from the ExternalLBDeviceMgr because ExternalLbDeviceMgrImpl :: start() was getting multiple times during management server satrtup. The reason for this is that this is the baseclass for F5 and NetScalarElement.
- This caused us to schedule the ExternalNetworkUsageTask multiple times
- Also we have LBRulesMgr calling this ExternalLbDeviceMgrImpl  by creating an instance of this class which is declared abstract
- Hence having a separate implementation to manage the network usage stats should solve this.
2012-02-21 17:16:07 -08:00
Edison Su bc73ac7e59 bug 13910: release cpu/memory after expunged
status 13910: resolved fixed
Reviewed-by: prachi
2012-02-21 16:22:49 -08:00
Alena Prokharchyk 2e9511e2ae Changed isElastic to isSystem for the publicIpAddress assigned during the vm deployment in EIP enabled network
Reviewed-by: Chiradeep
2012-02-21 15:39:49 -08:00
Sheng Yang a9a1475302 bug 13915: Fix VirtualRouter get gateway IP when others used as SourceNatServiceProvider
status 13915: resolved fixed

Reviewed-by: Edison
2012-02-21 15:24:14 -08:00
kishan d0612151d8 Bug 13823: Throw network conflict expection when LB rules conflict
Status 13823: resolved fixed
Reviewed-By: Nitin
2012-02-22 01:15:29 +05:30
Alena Prokharchyk 12b79da6c2 bug 13903: return vm's hostName as a displayName when displayName is null in bunch of api responses
status 13903: resolved fixed
Reviewed-by: Kelven Yang
2012-02-21 10:46:00 -08:00
kishan 11e4ded985 Bug 13619: Throw exception when not traffic sentinel host is not available. Update last_collection timestamp when atleast 1 IP has nonzero bytes
Status 13619: resolved fixed
Reviewed-By: Nitin
2012-02-21 23:41:37 +05:30
Alena Prokharchyk 4dea695e09 bug 13871: use perzone and peraccount (no spaces in values) when compare source nat capabilities
status 13871: resolved fixed
Reviewed-by: Chiradeep Vittal
2012-02-21 10:06:29 -08:00
Murali reddy 4e9b312bf2 bug 13855: F5 - Hold time paramS for sticky policies are not getting programmed in F5
- configuring unique persistence profile for each LB rule with sticky method applied
  - removing source based sticky method for source based LB method which is not supported by F5
2012-02-21 22:04:37 +05:30
abhi 8213a2e225 bug 13884: fixing spell vm.destroy.forcestop 2012-02-21 10:06:44 +05:30
Likitha Shetty 1f91b76b06 Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2012-02-20 10:44:39 +05:30
frank a1fa313902 Bug 13568 - secondary storage VM's static route for nfs server breaks things!
status 13568: resolved fixed
reviewed-by: Sheng Yang
2012-02-17 16:24:32 -08:00
Alena Prokharchyk 31a3b878a3 bug 13864: for elastic IP address return the purpose (staticNat or Lb) in listPublicIpAddresses api response
Reviewed-by: Frank
2012-02-17 15:42:21 -08:00
Alena Prokharchyk 4d27f3c44b bug 13866: return publicIp info in listVms api response when vm is linked to public ip via static nat
Reviewed-by: Frank
2012-02-17 15:42:17 -08:00
Sheng Yang 4f08afb784 bug 13867: Pass hostId instead of external firewall device Id
status 13867: resolved fixed

Reviewed-by: Anthony
2012-02-17 15:28:06 -08:00
Sheng Yang d94189a3d9 bug 13829: Add default capacity for SRX
And per Alex's request, add default value directly into the database, rather
than using it at last minute of implemention.

status 13829: resolved fixed

Reviewed-by: Alex
2012-02-17 15:25:41 -08:00
Alena Prokharchyk 313659d730 Return hostName as displayName in the listvms api resonse, just the way it was before 41df47cc6873b4d8acd0503b16535051a3cbde14)
Reviewed-by: Kelven Yang
2012-02-17 14:51:25 -08:00
Sheng Yang 79454ce4d8 bug 13829: Fix NPE in ExternalFirewallDeviceManagerImpl
Reviewed-by: Edison
2012-02-17 13:30:08 -08:00
Edison Su fe18cd5d7e bug 13845: as you can't add physical devices name from UI when you create zone, use kvm.{guest|public|private}.devices in the global configuration.
status 13845: resolved fixed
Reviewed-by: frank
2012-02-17 13:20:30 -08:00
Edison Su 289a641d4f bug 13789: don't shutdown host if it's a forward agent
status 13789: resolved fixed
Reviewed-by: frank
2012-02-17 13:04:03 -08:00
Alena Prokharchyk 50fc52ee9b bug 13854: don't allow to remove network offerings if its in use by existing networks
status 13854: resolved fixed
Reviewed-by: Alex Huang
2012-02-17 12:58:54 -08:00
kishan 9c5fb5f199 Bug 13741: Added new Config category Secure. Any config in secure category will encrypted along with the Hidden category configs
Status 13741: resolved fixed
Reviewed-By: Nitin
2012-02-17 16:42:32 +05:30
Nitin Mehta 87be3ca686 Bug 13836: NPE fix. If snapshot is already removed say so-do not try and delete it again.
Reviewed-By: Kishan
2012-02-17 16:29:49 +05:30
kishan 4ec26ae3cb Bug 13794: When snapshot backup fails, snapshot.delete event is not required. Snapshot.create is logged only afetr successfull backup.
Status 13794: resolved fixed
Reviewed-By: Nitin
2012-02-17 16:17:39 +05:30
Likitha Shetty b9761cd654 Bug 4644 (Pranav) 2012-02-17 15:38:10 +05:30
Nitin Mehta 560d54a49c Bug 13059: cast the long to float else the fraction would be 0 - java basics :).
Reviewed-By: Kishan
2012-02-17 15:08:35 +05:30
kishan 74ce678baf Bug 13802: Log VPN user remove usage event when user fails to get applied
Status 13802: resolved fixed
Reviewed-By: Nitin
2012-02-17 14:17:28 +05:30
kishan ced6fd46b8 Bug 12954: Added usage for security groups. Usage will be generated for each security group that is assigned to a Vm.
Status 12954: resolved fixed
Reviewed-By: Nitin
2012-02-17 13:50:18 +05:30
prachi eb43f780f7 Bug 13824 - VM deployment fails due to volume not being recreatable
Reviewed-By: Alex

Changes:
- Reuse the same storagepool where the Volume is ready on each retry of VM deployment until the cluster where the volume is has capacity
- After the cluster is out of capacity, we look in other clusters and find a new storagepool.
- At this point if the volume is recreatable on the new storagepool, depoyment will succeed provided everytyhing else goes through
- But if the volume is not recreatable and its cluster is out of capacity, we will still fail to deploy the VM
2012-02-16 17:04:25 -08:00
Edison Su cdf10ccc2e bug 13771: Long.equals is not ==
status 13771: resolved fixed
Reviewed-by: anthony
2012-02-16 17:02:55 -08:00
Alena Prokharchyk ebe664cff2 bug 13041: in Basic zone just restart all exising domRs in the zone during the networkRestart, don't try to create a new one
status 13041: resolved fixed
reviewed-by: Sheng Yang
2012-02-16 14:58:16 -08:00
Alena Prokharchyk 13f4d92d2a bug 13813: fixed network offering search to use traffic type when locate physical network in the zone
status 13813: resolved fixed
Reviewed-by: Frank
2012-02-16 10:40:00 -08:00
Alena Prokharchyk ee77167fae bug 13801: fixed broken check for extending vnet ranges during physical network update
status 13801: resolved fixed
Reviwed-by: Kelven Yang
2012-02-16 10:01:07 -08:00
Murali reddy c544d85988 bug 13625: F5 - NullPointerException seen when trying to delete/restart a network that was failed to implement properly during implement network
Reviewed-By: Abhi
status 13625: resolved fixed

adding logic to gracefully exit shutdown operation, if earlier network failed to implement
2012-02-16 18:47:37 +05:30
Nitin Mehta d5a7419b1f Bug 13692: Query was giving cluster id weven when it was pod level information.
Reviewed-By: Kishan
2012-02-16 14:47:15 +05:30
abhi fac8091c9f bug 13673: stopping alien VMs during sync for Xenserver 2012-02-16 12:35:36 +05:30
Edison Su 20b9562432 bug 13781: reload host detail after host reconnect
status 13781: resolved fixed
Reviewed-by: frank
2012-02-15 18:54:50 -08:00
Alena Prokharchyk 2fb10fe9d7 bug 13700: delete projects as a part of domain cleanup
status 13700: resolved fixed
reviwed-by: Frank
2012-02-15 16:34:50 -08:00
Alena Prokharchyk 4d28fb16b9 bug 13742: check only for Pending invitations while inviting the same account to the project again
status 13742: resolved fixed
2012-02-15 11:02:33 -08:00
Murali reddy 4b728abedb bug 13722: When we try to create a network when there is no capacity in F5, we should not attempt to create the network
Reviewed-By:Jana
status 13722: resolved fixed

thorwing resource unavaiable exception when there is not enough capacity to implement network
2012-02-15 19:05:44 +05:30
Murali reddy a338fe5003 bug 13664: F5 device can be added in "Dedicated" mode but Network offering allows for only "shared" LB isolation to be set.
Reviewed-By: nitin.mehta@citrix.com
status 13664: resolved fixed

added dedicated mode as capability to F5 load balancer element
2012-02-15 17:16:59 +05:30
abhi eb105fb06b Bug 13471: disabling agent lb 2012-02-15 12:12:23 +05:30
Sheng Yang 3a37ab6772 bug 13715: Modify changeCidr parameter of updateNetwork API
We expect user to use following sequence when update virtual router provided
network offering to external firewall devices offering:
1. Shutdown all the user VMs.
2. Modify network to new offering.
3. Click "Allow CIDR change" in the pop-up dialog, which would pass
changeCidr=true to the updateNetwork API.

We would shutdown guest network before we update the network for new
offering(with changeCidr = true), in order to re-implement the network.

status 13715: resolved fixed

Reviewed-by: Alex
2012-02-14 19:34:23 -08:00
anthony ae3c1966c1 bug 13712: do not download removed template
status 12712: resolved fixed

reviewed-by: edison
2012-02-14 18:32:28 -08:00
Alena Prokharchyk d55850526c Don't change the domain state when the domain can't be removed (cleanup=false and there are resources referencing it)
Reviewed-by: Edison Su
2012-02-14 17:17:10 -08:00
frank ede4c502f2 Bug 13662 - OVM host remain in Alert state, Unable to create deployment for OVM instance
Bug 13641 - OVM add host to OVM cluster results in host remaining in state: Alert
Bug 13652 - OVM add primary storage to OVM cluster FAIL

making Ovm work on Acton

status 13662: resolved fixed
status 13641: resolved fixed
status 13652: resolved fixed

reviewed-by: edison
2012-02-14 15:12:46 -08:00
Alena Prokharchyk 17349dfe12 bug 13695: deleteAccount - remove account from projects as a part of account cleanup process
status 13695: resolved fixed
Reviewed-by: Frank
2012-02-14 14:06:49 -08:00
Alena Prokharchyk 136d9e7295 bug 13699: use correct way of checking VM permission during the service offering upgrade
status 13699: resolved fixed
2012-02-14 13:05:59 -08:00
Alena Prokharchyk 5e9a15c07d bug 13708: make a search by traffic type when locate physical network in the zone
status 13708: resolved fixed
reviewed-by: Prachi Damle
2012-02-14 12:47:33 -08:00
prachi 63fd5d1f64 Bug 13703 - [External Service Providers] Unable to find a Discoverer to load the resource: 1 for hypervisor type : null
Changes:
- in case of external service providers, there is no discoverer that could load the resource.
- So we have to rely on agentMgr to load the resource as earlier.
2012-02-14 12:17:25 -08:00
Kelven Yang a72d419f8c bug 13679: cosmetic fix to remove NPE warning message from log. Reviewed-By: anthony 2012-02-14 12:08:50 -08:00
Sheng Yang 03aa8d727c bug 13643: Fix assigned router gateway IP
The ExternalGuestNetworkGuru need to respect some of existed IP assignment,
especially router. Otherwise router can't get correct IP address(gateway IP).

status 13643: resolved fixed

Reviewed-by: Alex
2012-02-13 17:10:10 -08:00
Alena Prokharchyk d5532d7de0 Update apikey/secretkey in transaction 2012-02-13 11:11:56 -08:00
Nitin Mehta 8f869b6a18 Bug 13591: Remove unwarranted log messages that we are printing with every answer recieved from the agent.
Reviewed-By: Kishan
2012-02-13 16:33:52 +05:30
abhi 20968a408c bug 13549: cleanup stopped/starting VMs if present on host during MS startup
reveiewed-by: kishan
2012-02-13 07:25:01 +05:30
Alena Prokharchyk 294d3a2fda Code format fixes 2012-02-10 15:10:21 -08:00
Alena Prokharchyk 4f2e9a5195 Don't allow guest network creation when guestCidr is not configured in corresponding zone 2012-02-10 11:02:26 -08:00
Alena Prokharchyk 26d272021f Guest cidr is optional for Advance zone (zone can have just Shared networks) 2012-02-10 10:45:05 -08:00
Nitin Mehta b2c7986ba3 Bug 13059: Remove topused flag.
Reviewed-By: Kishan
2012-02-10 17:07:21 +05:30
kishan 9a6e0abe8c Bug 13599: Used IdentityDao to map usage records to correct UUIDs
Status 13599: resolved fixed
Reviewed-By: Nitin
2012-02-10 16:34:02 +05:30
kishan c7337f00be Bug 12802: Updated generate usage records API description
Status 12802: resolved fixed
Reviewed-By: Nitin
2012-02-10 12:00:14 +05:30
Nitin Mehta 680ab2f908 Bug 13059: Using Float instead of float for percentage.
Reviewed-By: Kishan
2012-02-10 11:11:47 +05:30
Alex Huang a3b2f3d118 bug 13478: added exception printing. Reviewed-by: Anthony 2012-02-09 16:50:27 -08:00
Edison Su 5f897816ab bug 13579: set default timeout to -1
status 13579: resolved fixed
2012-02-09 16:49:50 -08:00
Alex Huang 166790ad70 propagate fix from 2.2.14 2012-02-09 16:44:55 -08:00
Edison Su 498d57fa3d fix upgrade 2012-02-09 14:56:41 -08:00
Edison Su e6d6e3b90a bug 13470: check the correct old certificate
status 13470: resolved fixed
Reviewed-by: anthony
2012-02-09 14:56:41 -08:00
Edison Su 5b11e67a18 Agent disconnected due to so many Fencecommand send to agent, cause agent can't get pingaswer from mgt server, then agent thinks it's ping timeout, reconnect to mgt server. 2012-02-09 14:56:41 -08:00
Edison Su a670c0e66e cleanup 2012-02-09 14:56:40 -08:00
Edison Su 1ab89dd436 add cert chain in db, and also open the api to upload a cert chain 2012-02-09 14:56:40 -08:00
Sheng Yang 14142363a1 Better error message for changeCidr 2012-02-09 14:40:18 -08:00
frank aa9d250280 port copy template fix to acton 2012-02-09 14:19:08 -08:00
Nitin Mehta faaa7593de Bug 13059: Used and total capacity were not showing in some cases becuae the constructor was not setting it.
Reviewed-By: Kishan
2012-02-09 20:55:51 +05:30
Nitin Mehta d82fad81bf Bug 13564: Incorrect format was coming for kvm since there was a ohardcoding on the extension to be of size 3 Instead take the format from the ENUM.
Reviewed-By: Kishan
2012-02-09 20:14:13 +05:30
Naredula Janardhana Reddy 023d06124f Bug 12812:
Summary of changes:
   - applyLoadBalancerConfig(long lbRuleId) method applies only one rule if it is Netscalar otherwise applies all the rules in add/revoke state.
2012-02-09 12:05:29 +05:30
prachi 05af078358 Bug 8791 - user dispersing allocator
Changes:
To migrate systems using 'use.user.concentrated.pod.allocation' as true and 'vm.allocation.algorithm' as true, we need to
add following changes:

- There will be 5 values to 'vm.allocation.algorithm': 'random', 'firstfit', 'userdispersing', 'userconcentratedpod_random', 'userconcentratedpod_firstfit'
- 'userconcentratedpod_random' means we apply user concentration to pods and clusters. To hosts and pools we use random ordering.
- 'userconcentratedpod_firstfit' means we apply user concentration to pods and clusters. To hosts and pools we use firstfit ordering.
2012-02-08 17:03:38 -08:00
Sheng Yang 5dcff263e1 Provide a better error message for changeCidr 2012-02-08 16:53:42 -08:00
Sheng Yang fadec7afe7 Add "changecidr" parameter for updateNetwork API
CIDR may be different after update to a service offering contained external
network element, user is required to acknowledge this, otherwise the update
won't process
2012-02-08 15:57:50 -08:00
Sheng Yang 9317eb6bc3 Revert dynamic cidr change 2012-02-08 15:54:22 -08:00
Sheng Yang 18ec438793 Revert zone guest cidr setting 2012-02-08 15:54:16 -08:00
Sheng Yang 99b7b73d7f bug 12747: release ip when no static nat rule existed
status 12747: resolved fixed
2012-02-08 15:54:03 -08:00
Sheng Yang 58fe40715f bug 13540: Fix release ip fail to clean up iptables rules
The rule cleanup must be done before ip disassociated.

status 13540: resolved fixed
2012-02-08 15:53:56 -08:00
Alena Prokharchyk fad3c7eab4 bug 13522: mark network for GC when domR starts with startRouter command, not as a part of user vm start/deploy
status 13522: resolved fixed
2012-02-08 13:33:06 -08:00
Nitin Mehta 78e79856af Bug 13059: Removed the code which was deleting capacity entries on every MS restart.
Reviewed-By: Kishan
2012-02-08 20:44:57 +05:30
kishan 17659d1500 Bug 12972: Added VPN_USER_REMOVE usage events when VPN is disabled. VPN_USER_ADD events added when VPN is enabled again. VPN usage will be generated only when VPN is enabled.
Status 12972: resolved fixed
Reviewed-By: Nitin
2012-02-08 19:57:08 +05:30
kishan 278833eb29 Bug 13420: Send alert of type 18 when sending alert for SSVM
Status 13420: resolved fixed
Reviewed-By: Nitin
2012-02-08 18:50:42 +05:30
Nitin Mehta e6beb08f1b Bug 13059: Keeping the param name more intuitive Also adding the ciode for listing used and total capacity as well.
Reviewed-By: Kishan
2012-02-08 18:03:22 +05:30
Murali reddy 35ea4b7df1 using proper transaction semantics while adding netscaler device 2012-02-08 17:40:47 +05:30
Nitin Mehta cbc47b9021 Bug 13059: For listing top consumed resources only uyse enabled zone for sec storage Also improve the transaction logic.
Reviewed-By: Kishan
2012-02-08 15:34:56 +05:30
kishan 034b5890e6 Bug 13454: Drop both foreign keys, indexes of ssh_keypairs and add again
Status 13454: resolved fixed
Reviewed-By: Nitin
2012-02-08 15:26:21 +05:30
Naredula Janardhana Reddy 31fe8bd815 Summary of HAProxy stickines param changes:
- converted all mandatory params to optional, and internally fill with default value before sending to haproxy. default value is available through description.
  - accept holdtime without units.
2012-02-08 14:56:41 +05:30
abhi 44c172bdc2 bug 12980: added trust store for ssl 2012-02-08 13:07:19 +05:30
Nitin Mehta 1fc0afe3f2 Bug 13059: Remove the listTipConsumedResources api and introduced a sortbyusage flag in the listCapacity call.
Reviewed-By: Kishan
2012-02-08 11:50:55 +05:30
prachi d0e63bc377 Bug 13099 - table physical-network-traffic-types needs to be updated when xen network device setting is modified in the global settings
Changes:
- DB upgrade changes
-- make the global setting hidden.
-- During upgrade set network labels from global config
2012-02-07 18:41:29 -08:00
prachi dbe2305352 Bug 13099 table physical-network-traffic-types needs to be updated when xen network device setting is modified in the global settings
Changes:
- We do not need these global setting anymore. These will be hidden since 3.0
- The default traffic label will be picked from the global setting which is null by default. When traffic label is null it means the resource uses tag on the default gateway
- Changes to invoke discoverer to reload the resource object on host connection
- Since a zone can have many physical networks, there can be multiple guest, public networks. Only the zone wide storage and management traffic label will be stored in host_details henceforth.
- If traffic labels are updated, discoverer should update the host_details
2012-02-07 18:41:23 -08:00
Alena Prokharchyk bd765999ba Fixed listTopConsumedResources to work w/o specifying page/pageSize 2012-02-07 14:38:23 -08:00
Alena Prokharchyk c17e9344a7 bug 13508: fixed inconsistencies in key names during db upgrade
status 13508: resolved fixed
Reviewed-by: Will Chan

Conflicts:

	setup/db/db/schema-2213to2214.sql
2012-02-07 13:40:53 -08:00
Alena Prokharchyk cad392cd68 bug 13335: fixed listProjectInvitations by projectId
status 13335: resolved fixed
2012-02-07 13:16:27 -08:00
anthony 22bbd8e766 bug 13478: check null
status 13478: resolved fixed

reviewed-by: edison
2012-02-07 10:56:24 -08:00
frank 02075c3a2d Bug 13476 - Public IP's are not shown in the UI for the System VMs
status 13476: resolved fixed
2012-02-07 10:58:11 -08:00
Nitin Mehta ce26703e5c Bug 13059: Make DB changes to list top consumed resources for enabled resources only. For this introdiuced a new state called capacity state in the op_host_capacity table and would be updated on every operation of zone pod cluster and host
Reviewed-By: Kishan
2012-02-07 20:53:25 +05:30
Murali reddy 8fbdd2919e bug 12488: Netscaler - Invalid error message presented to the user when deployVm fails to implement network becasue of insuffucient capacity in Netscaler.
status 12488: resolved fixed
2012-02-07 19:15:36 +05:30
Murali reddy a665f9bf50 bug 13180: Netscaler - SDX - Capacity field is not respected by the VPX instances that are created by SDX
status 13180: resolved fixed
2012-02-07 18:21:34 +05:30
Murali reddy 5f8936eb2f bug 13179: Netscaler - Admin is allowed to delete the SDX instance when there are existing vpx instances that was created
status 13179: resolved fixed
2012-02-07 14:18:43 +05:30
Alena Prokharchyk 207f0db318 bug 13474: fixed 3)
status 13474: resolved fixed
reviewed-by: Will Chan
2012-02-06 19:57:17 -08:00
Alena Prokharchyk d7b290cb9c bug 13474: fixed 1) 2) and 4)
reviewed-by: Frank

Conflicts:

	server/src/com/cloud/upgrade/dao/Upgrade2213to2214.java
	setup/db/db/schema-2213to2214.sql
2012-02-06 18:35:51 -08:00
Alena Prokharchyk c4d9a4c82b Agent LB: never get a part of the hosts from the xen cluster; skip the cluster if it has more hosts than we need
Reviewed-by: Alex Huang
2012-02-06 16:42:58 -08:00
Alena Prokharchyk 950429e582 bug 12361: db upgrade for Direct account specific networks 2012-02-06 14:58:40 -08:00
Alena Prokharchyk c4b15a0eeb Fixed code formatting in 2214-30 upgrade 2012-02-06 14:58:40 -08:00
frank b59c3c595e return netmask in listStorageNetworkIpRangeCmd 2012-02-06 14:37:56 -08:00
Nitin Mehta 93b8178f19 Bug 13059: Introduce a new api to list top consumed resources in cloudstack.
Reviewed-By: Kishan
2012-02-06 20:32:40 +05:30
Naredula Janardhana Reddy ce22712293 Bug 12812:
Summary of changes:  Database changes will be rollbacked while applying the LB rule to the Netscaler device.
   - Database changes will be rollbacked to previous state during the following Lb API's:
      1) assignVM to LB rule
      2) remove VM from LB rule
      3) updateLb rule
      4) deleteLb rule
      5) create/attach sticky policy to Lb rule
      6) delete sticky policy from Lb rule
   - Database changes of the Lb rule will be not be rolledback during:
       1) Removing IP
       2) removing VM
2012-02-06 19:16:34 +05:30
abhi 74f1a821a4 bug 13134: added encryption for ldap password 2012-02-06 16:31:58 +05:30
abhi e8f4b2d83b Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2012-02-06 15:03:09 +05:30
abhi 59c7150af7 bug 13439: full sync at management server restart, disabling hourly sync 2012-02-06 15:01:44 +05:30
kishan b5d465f74a Bug 12649: Added ROOT to domain path and removed trailing slash
Status 12649: resolved fixed
Reviewed-By: Abhi
2012-02-06 14:27:55 +05:30
kishan b0aaf75c3b Bug 13454: Remove foriegn keys in ssh_keypairs table and again with correct constraint name
Status 13454: resolved fixed
Reviewed-By: Nitin

Conflicts:

	server/src/com/cloud/upgrade/dao/Upgrade2213to2214.java
2012-02-06 14:04:56 +05:30
frank 074d33d9f3 DB upgrade for Bug 6849 - Randomize systemvm passwords 2012-02-03 17:40:07 -08:00
frank 890bfffe2f Bug 6849 - Randomize systemvm passwords (edit)
status 6849: resolved fixed
2012-02-03 17:28:58 -08:00
anthony a70ea7f745 bug 13241: before update cluste guid, check if this guid is used,
status 13241: resolved fixed
2012-02-03 17:01:04 -08:00
Alena Prokharchyk 1490e45a1c Fixed format style in a bunch of files (replaced tabs with spaces as a part of it) 2012-02-03 13:49:11 -08:00
Murali reddy 1f0ea28cc4 bug 12568: load balancer/firewall device capacity when admin does not specify a value 2012-02-03 23:48:26 +05:30
kishan b15e5d6730 Bug 13326: Include isElastic flag in IPAddress usage response
Reviewed-By: Nitin
2012-02-03 18:03:04 +05:30
kishan 1c95ed5012 Bug 13433: Updated removed index for async_job table
Reviewed-By: Nitin
2012-02-03 18:03:04 +05:30
kishan a388ed792f Bug 13326: Added is_elastic flag to IP address usage. Added new column in usage_ip_address, defaults to false. size column will contain is_elastic info in cloud_usage table
Status 13326: resolved fixed
Reviewed-By: Nitin
2012-02-03 18:01:30 +05:30
Nitin Mehta deadf815ca Bug 13423: Drop i_op_vm_ruleset_log__instance_id, u_op_vm_ruleset_log__instance_id key (if exists) and re-add u_op_vm_ruleset_log__instance_id again.
Reviewed-By: Kishan
2012-02-03 15:54:48 +05:30
prachi 65b7a27407 Bug 13229 - Network Usage - Netscaler - NetworkUsage not being called when Lb rules are deleted and when releasing the Ip adress that has Lb rules.
Reviewed-by: Kishan

Changes:
- When an LB rule is deleted or the IP address having an LB rule configured is released, ExternalNetworkUsageCommand is fired to gather the usage
accumulated on that IP after the last run of the ExternalNetworkUsage job.
2012-02-02 17:23:51 -08:00
Alena Prokharchyk a8476ac0de bug 12361: 2214-3.0 db upgrade for redundant routers 2012-02-02 14:43:37 -08:00
Kelven Yang 8060918805 bug 13428: upgrade newly issued realhostip certificate. Reviewed by: Anthony 2012-02-02 11:49:20 -08:00
frank de7a763ff9 avoid both PodBaseNetworkGuru and StorageNetworkGuru reply to storage network
design call
2012-02-02 11:31:43 -08:00
frank e30ca89c7c Bug 13185 - CloudStack UI shows incorrect info for SSVM public IP
status 13185: resolved fixed
2012-02-02 10:52:18 -08:00
Alena Prokharchyk 504af05df4 bug 13335: fixed name/displayText network update
status 13335: resolved fixed
2012-02-02 10:34:06 -08:00
kishan f1a30a21aa Bug 13133: Added snapshot delete event when a recurring snapshot deletes oldest snap
Status 13133: resolved fixed
Reviewed-By: Nitin
2012-02-02 18:56:07 +05:30
Alena Prokharchyk 78f6fc9e43 bug 12361: Inermediate checkin to 2.2.14-3.0 db upgrade 2012-02-01 16:46:56 -08:00
Jessica Wang 46c0024a34 bug 13362: fix error message in StorageManagerImpl.java 2012-02-01 15:49:21 -08:00
Alena Prokharchyk 2f17d465dc Fixed 2.2.14-3.0 db upgrade for usage
Added unittest as well
2012-02-01 13:33:53 -08:00
Alena Prokharchyk edd4c84ca1 Add domain name info for private zones in listZones api response 2012-02-01 11:26:00 -08:00
Alena Prokharchyk 879ab9a5cc More logging to domain checker 2012-02-01 11:07:13 -08:00
Alena Prokharchyk cfea031b28 Fixed deploy vm for Project in private zone 2012-02-01 11:03:12 -08:00
abhi ae609f6801 bug 13408: added more loggin to assignVM 2012-02-01 18:45:25 +05:30
abhi b6e5419370 bug 12899: checking if static nat rule is in place, throw error if there. Let the caller clear it first before assigning VM to another account 2012-02-01 18:08:32 +05:30
Naredula Janardhana Reddy aea81205ef Bug 11845:
Summary of Changes:
    - created a generic way for LB rule validations, so as LB device(like Haproxy) specific validations can be done syncronously.
    - Removed asyncronous validations from Haproxy and done syncronously.
2012-02-01 18:01:11 +05:30
kishan a072cdfec6 Bug 12071: Drop and re-create usage event created index in cloud_usage DB
Status 12071: resolved fixed
Reviewed-By: Nitin
2012-02-01 17:07:28 +05:30
Naredula Janardhana Reddy 72fb7256d7 Bug 13297,13375,12705 :
Summary of changes :
        - Added a new flag -s to ipassoc command to carry if the ip address is
used for SNAT or not.
        - SNAT is completly decoupled from the first flag. first flag is used
to decide if the ip address is first ip address of the interface.
        - -s and -f are independent, SNAT can be enabled on the non-first ip
also.
2012-02-01 12:39:10 +05:30
prachi fc7758c455 Bug 13224 - Network Usage - Netscaler - External device is being queried multiple times (up to 8 times) whenever the Network Usage task is run.
Reviewed-By: Kishan

Changes:
- Added local cache to store the usage answer per LB device per zone
- Also there can be multiple domainRouters for an account. We can avoid processing the same account for usage by maintaining accounts already processed.
2012-01-31 18:29:07 -08:00
Kelven Yang 00ffe10b05 bug 12017: when owner host is not in UP state, mark VM state as UNKNOWN 2012-01-31 17:20:16 -08:00
anthony 5c0b585aa0 bug 12844: fixed a regression
reviewed-by : edison

Conflicts:

	server/src/com/cloud/agent/manager/AgentManagerImpl.java
2012-01-31 17:12:49 -08:00
Alena Prokharchyk f5681d1f7b bug 13396: escape double quotes in error json response
status 13396: resolved fixed
2012-01-31 16:26:53 -08:00
anthony cb8f55a6f6 bug 12844, 13394: 1. if connect to host fails, don't need to investigate
2. add ha parameter to dissconnect host to indicate if HA VMs on this host

status 12844, 13394: resolved fixed

reviewed-by : edison

Conflicts:

	server/src/com/cloud/agent/manager/AgentManagerImpl.java
	server/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java
2012-01-31 15:33:39 -08:00
Alena Prokharchyk c2f99796bb Return only VirtualRouter as a firewall provider in listSupportedNetworkServices api response 2012-01-31 14:37:44 -08:00
prachi 08bb9eaf47 Bug 11426 - UpdateResourceCount api: don't recalculate the resources for System account
Changes:
- Throw error is anyone tries to update the resource limits for ROOT domain using updateResourceLimit API
- For ROOT domain always return -1 (infinite) limit
- DB upgrade: remove any limits set for ROOT domain
2012-01-31 14:21:03 -08:00
frank 7359789541 Bug 13394 - HA XEN- After host is disconnected from network & reconnected to network, host remains in Connecting state
get current update count before update agent status otherwise the operation would fail because someone before he
update the update count
status 13394: resolved fixed
2012-01-31 13:57:25 -08:00
Alena Prokharchyk 07545236d7 bug 13381: fixed update availablity for network offering
status 13381: resolved fixed
2012-01-31 11:49:09 -08:00
Nitin Mehta 2ef6ed809f Bug 11789: The calculation for storage allocated capacity would go through the the common function throught which dashboard calculates the capacity as well.
Reviewed-By: Prachi
2012-01-31 13:18:57 +05:30
Nitin Mehta 33857e21e3 Bug 11789: Created a function for calculation of allocated primary storage. The dashboard calculation would go through this.
Reviewed-By: Kishan
2012-01-31 12:31:18 +05:30
Alex Huang c42f50c4b0 Used a different way to allocate guest ip address. not in used yet. 2012-01-30 16:10:10 -08:00
Alena Prokharchyk 37d38427c6 Fixed transaction start in createLB rule 2012-01-30 15:53:54 -08:00
Alena Prokharchyk cd56bf9f60 Only Virtual Router can be specified as a provider for the Firewall service 2012-01-30 15:26:43 -08:00
Alena Prokharchyk 0196eb5679 bug 12821: no VPN support on Juniper
status 12821: resolved fixed
2012-01-30 15:07:04 -08:00
Kelven Yang 8f2b6dc791 do not default display name from null to other name like host name 2012-01-30 14:57:50 -08:00
Kelven Yang cb959aa377 bug 13369: recycle roger hung worker VMs in vCenter 2012-01-30 14:21:56 -08:00
Alena Prokharchyk 1b54901caa bug 13290: fixed listNetworks for the domain admin in Basic zone
status 13290: resolved fixed
2012-01-30 13:45:16 -08:00
Alena Prokharchyk 529d0706e1 SpecifyVlan should always be true for shared network offerings and for network offerings with specifyIpRanges=true
SpecifyIpRanges should always be true for Shared network offerings
2012-01-30 12:34:49 -08:00
Alena Prokharchyk 9219d4c41d bug 12361: more fixes to DB upgrade for network_offerings table
Added unittest for testing network offerings db upgrade
2012-01-30 11:20:13 -08:00
Nitin Mehta f88ddbe86e Bug 13066: StorageOverProv-Start using bigdecimal for better precision. Change allocators and dashboard code for the same.
Status 12897: resolved fixed
Reviewed-By: Kishan
2012-01-30 17:27:30 +05:30
kishan 8f2cf82b24 Bug 12996: Removed createConfiguration API command
Status 12996: resolved fixed
Reviewed-By: Nitin
2012-01-30 14:36:50 +05:30
kishan 08df288bf5 Bug 13175: Fixed typos. minotoring instead of monitoring, assignbed instead of assigned
Status 13175: resolved fixed
Reviewed-By: Nitin
2012-01-30 14:31:48 +05:30
Chiradeep Vittal fcd90b269e allow Mac OS developers to run management server natively 2012-01-27 16:27:19 -08:00
Alena Prokharchyk 8eed9004cd Fixed broken unittest 2012-01-27 14:44:34 -08:00
Edison Su ecf774a0d7 bug 13357: startupanswer is advanced before agentmonitor got processed, so it's possible that pingcommand received by mgt server ahead of agentmonitor initializes pingmap
status 13357: resolved fixed
2012-01-27 14:08:14 -08:00
kishan cdbf85e3e6 Bug 12649: Added new param path to listDomains respone
Status 12649: resolved fixed
Reviewed-By: Nitin

Conflicts:

	server/src/com/cloud/api/ApiResponseHelper.java
2012-01-27 17:58:48 +05:30
Edison Su 5e2f02fdd5 bug 13315: add httpproxy support in ssvm, only basic auth. User can add secstorage.proxy = http://username:password@hostname:port
status 13315: resolved fixed
2012-01-26 18:46:44 -08:00
prachi e48e7226bd Bug 13239 - java.lang.NullPointerException seen in management server logs when netscaler instance is unreachable whenever network usage thread is executed
Changes:
- Added Null check for lbvserver
- Need not process the usage answer when we get some error.
2012-01-26 16:40:16 -08:00
prachi 93ff791497 Bug 13314 - acton-bet3:vmware/xen:fail to attach "VMware Tools Installer ISO" to instance
Changes:
- 'sameOwner' check cannot be used for ISO's
- So need to make two access checks: See if caller has access to VM and ISO and also check if the VM's owner has access to the ISO.
2012-01-26 16:02:52 -08:00
frank c40a421eb6 Bug 13250 - Not able to start System Vms when 2 physical networks are configured
if admin didn't specify storage traffic type before enabling zone, create default
storage traffic type with the same configuration of mgmt traffic type.

UI need a warning to admin, will file another bug for this

status 13250: resolved fixed
2012-01-26 14:06:34 -08:00
anthony 3615b15c39 bug 13338:
increate timeout for sshcheck to 10 minutes
if sshcheck fails, finalizeCommandsOnStart fails, no exception

status 13338: resolved fixed
2012-01-26 12:22:24 -08:00
Kelven Yang c1fb754de7 VM display name can be NULL in schema, leave it as NULL instead of empty string when user does not provide a optional VM display name 2012-01-26 11:30:40 -08:00
Kelven Yang e751dad940 VM display name will stay empty if user does not provide, VM host name is default to UUID for now 2012-01-26 11:10:00 -08:00
Alena Prokharchyk 57e3a5a0aa bug 13232: listPublicIpAddresses by staticNat/sourceNat properties
status 13232: resolved fixed
2012-01-25 17:31:53 -08:00
Kelven Yang 8083b29235 bug 13306: remove sensive DB id info from VM display name 2012-01-25 17:16:21 -08:00
Alena Prokharchyk 3b1db5fa20 bug 13203: removed firewall.rule.ui.enabled global config
status 13203: resolved fixed
2012-01-25 16:49:31 -08:00
Alena Prokharchyk 4dec3c890a bug 13282: release elastic IP of the vm on vmStop
status 13282: resolved fixed
2012-01-25 15:03:46 -08:00
Alena Prokharchyk ebfc1d1d32 bug 13308: list networks belonging to subdomains when listAll=true is passed to listNetworks
status 13308: resolved fixed
2012-01-25 13:37:19 -08:00
Alena Prokharchyk c09faa109d bug 13296: release public ip addresses in the basic zone during the account cleanup
status 13296: resolved fixed
2012-01-25 11:26:37 -08:00
Alena Prokharchyk 7ea3c8933d bug 13305: don't allow to create ip forwarding rules when elasticIP is enabled for the network offering
status 13305: resolved fixed

Reviewed-by: Will Chan
2012-01-25 10:57:34 -08:00
Alena Prokharchyk 88d3f1ba03 bug 13295: apply specific security check for the network
status 13295: resolved fixed

Reviewed-by: Will Chan
2012-01-25 10:57:24 -08:00
Nitin Mehta c59f3087f7 Bug 12897: Make updatehostpassword more robust and allow it to be used only for Xenserver hyperVisor
Status 12897: resolved fixed
Reviewed-By: Kishan
2012-01-25 14:56:42 +05:30
Nitin Mehta f558aa07c5 Bug 12740: Allow root admins and system user to bypass the ACL layer.
Reviewed-By: Kishan
2012-01-25 12:29:04 +05:30
Alena Prokharchyk 03b4ac91e1 Get new elasticIp when disassociateIP is called for static nat non-elastic IP 2012-01-24 15:15:22 -08:00
frank 748603f62d Bug 13269 - vmware - host put in maintenance mode> cancel maintenance mode> host remains in Connecting state
we use 'update count' to make sure agent status transformation is atomic.
However, atomic means success or fail which is not true for agent status.
some important transformation occassionally fails because race condition that
some other one is changing it simultaneously which finally makes agent stuck in a
wrong status.

use reenterent lock to serialize the agent status transformation. this memory lock
works in clusterd environement as well because in our design an agent is only active
in one mgmt server

status 13269: resolved fixed
2012-01-24 15:14:02 -08:00
Alena Prokharchyk 5307d21210 DisableStaticNat: if elasticIP service is enabled for the network offering, always allocate new elastic ip and create static nat rule for it when disableStaticNat is called 2012-01-24 14:06:01 -08:00
Alena Prokharchyk 0e13bb58e3 bug 13250: don't check physicalNetworkId for control traffic type 2012-01-24 12:49:30 -08:00
Murali reddy 73805cdc45 bug 12828: SRX - Not able to deploy Vm using network that uses SRX for PF,Firewall,SorceNat,StaticNat,VPN services
status 12828; resolved fixed
2012-01-24 20:05:42 +05:30
prachi 6a7fd4d96c Bug 13248 - NPE: DeployVMCmd fired during 2.2.x regression test on Acton build
Changes:
- After deployment of Router failed, we did not throw out the error inorder to retry the start using another hypervisorType.
- But there is no other hypervisor to try, causing the failed and expunged router to be passed on further leading to an NPE later
- So in case there are no more hypervisors to retry the router start, we should throw out the original error.
2012-01-23 17:58:25 -08:00
prachi f80ed99879 Bug 13035 - cleanup required for virtual router deployment log entry
- adding in null check
2012-01-23 15:27:12 -08:00
prachi 4329004cd3 Bug 13035 - cleanup required for virtual router deployment log entry
- logging only the datacenter since rest of the information in deploymest destiination is not applicable to the router being deployed
2012-01-23 15:27:11 -08:00
Alena Prokharchyk c125496691 bug 13207: check providers/services combination before performing actual network offering upgrade
status 13207: resolved fixed
2012-01-23 14:52:07 -08:00
Alena Prokharchyk 665e8cb7c1 Allow LB rules creation for elasticIP 2012-01-23 11:41:00 -08:00
Alena Prokharchyk a40b8b31d3 Remove elastic IP only when the last lb rule is being removed 2012-01-23 11:41:00 -08:00
Nitin Mehta 23cfbb6cab Bug 13059: Make zoneId in ListCapacity call optional. When no parameter is passed list capacity for all zones.
Reviewed-By: Kishan
2012-01-23 20:32:50 +05:30
prachi 03653b936e NAAS Changes: Before enabling a Zone, Check if the zone has:
- For Advance zone,  a physical Network with Public/Management trafficType
- For Basic zone,  a physical Network with Management trafficType
2012-01-20 17:21:53 -08:00
Edison Su ecab972060 execute fencecommand in seq for kvm, as there are only 5 default nio reading work threads on kvm agent. pinganswer may not be got serviced immediately, then agent will reconnect to mgt server again and again 2012-01-20 17:04:27 -08:00
Alena Prokharchyk 79e9e292dd bug 12571: fixed error message in createSnapshotPolicy
status 12571: resolved fixed
2012-01-20 14:31:38 -08:00
Alena Prokharchyk 8bcf30da85 bug 12869: more changes to NAAS feature 2012-01-20 14:16:30 -08:00
Edison Su bced9a6e48 advanced startup command 2012-01-20 11:54:32 -08:00
anthony 6297820981 bug 12830: propagate ISO to other zone on demand
status 12830: resolved fixed
2012-01-20 11:44:01 -08:00
Alena Prokharchyk ba826ddc21 Fixed listing public IP addresses 2012-01-20 11:34:54 -08:00
Alena Prokharchyk 57ddf63676 Special permission check for networks 2012-01-20 11:01:38 -08:00
anthony bf490210ed fixed a merge bug in checkin
cleanup snapshot in secondary storage in background
2012-01-19 20:52:18 -08:00
anthony 86aef08865 cleanup snapshot in secondary storage in background
Conflicts:

	core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java
	server/src/com/cloud/storage/StorageManager.java
	server/src/com/cloud/storage/StorageManagerImpl.java
2012-01-19 20:44:44 -08:00
prachi be04ff861c Bug 13078 - Management Server does not respect selected OS Preference for any host within a single pod.
Changes:
- Once the HostAllocators have listed suitable hosts, planner should not reshuffle the list since that would lose the prioritization applied by the HostAllocators.
- E.g: HostAllocators chooses that host first which matches the guest OS category. If planner shuffles the list, that preferrence is lost.
2012-01-19 16:59:38 -08:00
frank 89b9c51d34 Bug 13189 - Exception logged while removing host
status 13189: resolved fixed
2012-01-19 16:50:36 -08:00
Sheng Yang 52ef2fca06 bug 12988: Fix typo
status 12988: resolved fixed
2012-01-20 08:03:49 +08:00
Alena Prokharchyk 03cce245cf Fail to create vm when corresponding elastic ip failed to apply on the backend 2012-01-19 14:13:49 -08:00
Murali reddy d92c361efd bug 12826:enable NetScaler in basic zone for load balancing and static NAT
NetScaler element should not firewall service provider in basic zone
2012-01-19 14:05:12 -08:00
Murali reddy 40ac2f5cdf bug 12826: enable NetScaler in basic zone for load balancing and static NAT
status 12826: resolved fixed
2012-01-19 14:00:07 -08:00
Alena Prokharchyk d4d345a587 Don't retry to re-create the vm when failed to allocate public ip 2012-01-19 14:00:07 -08:00
Alena Prokharchyk a9e4af0866 Can't release/disable static nat for IP when the IP is elastic 2012-01-19 13:58:36 -08:00
Alena Prokharchyk 4f46c3b160 Mark ip as not elastic when disable static nat is called on it 2012-01-19 13:58:36 -08:00
Alena Prokharchyk 212c22b256 Added isElastic flag to ip address 2012-01-19 13:58:35 -08:00
Alena Prokharchyk 1d0ffc4575 EnableStaticNat for newly allocated address - if eIp is enabled, and the target vm already assigned to the ip, reassign the vm to the new ip 2012-01-19 13:58:35 -08:00
Alena Prokharchyk 6325d21c50 Get new elasticIp when releaseIpAddress is called for elasticIP of the vm 2012-01-19 13:58:35 -08:00
Alena Prokharchyk 6deeb7ddc9 Firewall service is enabled in default elb/eip network offering
Also added more handling for error cases scenarios
2012-01-19 13:58:35 -08:00
Alena Prokharchyk 0e8104cca1 Disassociate ip address - always allocate a new IP and enable static nat for it when elactic IP is enabled 2012-01-19 13:58:35 -08:00
Alena Prokharchyk 359185f567 System is the owner of the first elastic ip address for the vm 2012-01-19 13:58:35 -08:00
Alena Prokharchyk d5752eca61 Error deployVm when elasticIp/staticNat failed to assign to the vm 2012-01-19 13:58:34 -08:00
Alena Prokharchyk 0f6f231ee6 Elastic IP - when deployVm, get ip address and enable static nat on it. On vm destroy release the Ip 2012-01-19 13:58:34 -08:00
Alena Prokharchyk 630cbb2243 Added elb and eip capabilities to network offering response 2012-01-19 13:57:37 -08:00
Alena Prokharchyk a8758d292e ElasticLB support in Basic zone.
When elb capability is enabled on the network offering, we:

1) on each createLB command:
* associate ip address to the LB rule owner
* create LB rule

2) on each deleteLb command:
* delete the rule
* disassociate ip address

The rule belongs to the owner, so proper usage events are generated
2012-01-19 13:57:37 -08:00
Alena Prokharchyk 9322482018 Netscaler can enable individual services (in some cases LB can be handled by Netscaler, and firewall by some other external provider) 2012-01-19 13:57:00 -08:00
Alena Prokharchyk 5adfc9953f Can enable/disable static nat and create IpForwarding/Firewall rules in Basic zone now.
Made Netscaler a StaticNat/Firewall provider. Murali will take care of actual implementation on the backend.
2012-01-19 13:56:59 -08:00
Alena Prokharchyk ff1e8413f1 1) Added StaticNat/Firewall/Lb capabilities to Netscaler element. Renamed it to "NetscalerElement" from NetscalerLoadBalancingElement as it serves more services now
2) Added elasticIp and elasticLb network capabilities. Provided support to create network offering with these capabilities.
3) Added one more default network offering having elasticip and elasticlb
4) Public network support to Basic zone. You can associate/disassociate IP addresses now
2012-01-19 13:56:59 -08:00
frank 11b98e4389 validate conditions before adding/deleting storage network traffic type 2012-01-19 13:44:42 -08:00
Alena Prokharchyk ad1076f21d bug 12983: resource limits for projects 2012-01-19 10:04:28 -08:00
prachi aa3e8a05be Bug 12993 - NullPointer Exception thrown when listRouters() is called.
Changes:
- Adding null checks.
2012-01-18 17:21:30 -08:00
Alena Prokharchyk c3e0f060ab bug 12986: return domain level networks when listAll is passed along with account/domainId
status 12986: resolved fixed
2012-01-18 14:45:19 -08:00
Alena Prokharchyk d20e10edd3 bug 12919: pass all lb rules in transition (revoke/add) state to the backend when apply a single LB rule
status 12919: resolved fixed
2012-01-18 14:15:21 -08:00
prachi 1e675f45ba Bug 11593 - CIDR conflicts with zone when extending pod but not when creating it
Changes:
- Now we validate Pod's CIDR only against other Pod's CIDR. No need to validate against guest CIDR and
public vlan CIDR.
2012-01-18 11:33:49 -08:00