etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
34,202 Commits 324 Branches 325 Tags 912 MiB
Commit Graph

2533 Commits

Author SHA1 Message Date
Wei Zhou 1a47719588
kvm: set cpu topology only if cpucore per socket is positive value (#4527) 
This PR fixes a regression issue in #4497

In cloudstack 4.14 or before, the cpu topology is set only when cpucore per socket is set (to 4 or 6).
in other conditions, there is no cpu topology in vm xml definition.

with #4497, vm will have cpu topology in its xml definition, if cpucore per socket is not set.

    <topology sockets='<vm cpu cores>' cores='1' threads='1'/>
Not sure if it causes any issue. I think it would be better not to add this part in vm xml definition if cpucore per socket is not set.
 2020-12-10 14:29:28 +05:30
Rohit Yadav e0242d5793
xenserver: check and eject patch vbd for systemvms (#4525) 
XenServer 7.1 has an file descriptor/tapdisk iso-caching issue where new systemvm.iso are not recognised and inside the VR/ssvm/cpvm file IO error is seen. This was only reproducible with XS7.1 (intermittently), the fix was to check and eject the systemvm.iso (old/stale/cached), then insert the new systemvm.iso and then eject it.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2020-12-10 00:42:41 +05:30
Wei Zhou 93f3d35207
kvm: FIX cpucorespersocket is not working on KVM (#4497) 2020-12-09 15:07:51 +01:00
Alexandru Bagu cd356c0513
change debug to warn for unknown exceptions (#4521) 
Co-authored-by: Alexandru Bagu <abagu@bsss-MacBook-Pro.local>
 2020-12-09 12:24:54 +01:00
Harikrishna 51034be270
Fix migrateVMwithVolumes API in case of multiple volumes on VMware (#4480) 
Problem:
When migrateVMwithVolumes API is tried on a VM with two volumes to migrate to a different host and tried to migrate only one volume, Cloudstack migrates both the Volumes but then marks only one of them migrated. This makes volume inaccessible due to inconsitency in path of volume in cloudstack and vsphere

Solution:
Set the target datastore in relocate spec properly for each volume
 2020-11-20 12:38:06 +00:00
Spaceman1984 87e1fa9e02
Removed sensitive info from UI/API when volume attach/detach fails (#4476) 
* Removed sensitive info from UI when attach/detach fails

* minor formatting change
 2020-11-19 04:39:37 +05:30
nvazquez 7d7e7f7941 Check there is at least a host to verify pool compatibility for a storage policy 2020-10-26 09:07:23 -03:00
nvazquez 85f5512ec3 Fix unit test failure 2020-10-25 02:53:43 -03:00
nvazquez c405e5dc31 Add new API to check storage policy compatible pools and fix marvin test for storage policies 2020-10-25 02:19:22 -03:00
nvazquez 8c68843142 Fix boot into hardware 2020-10-21 11:47:15 -03:00
nvazquez f1f490b151 Fix restore VM workflow - clone and replace existing VM instead of cloning and moving disks 2020-10-20 19:47:27 -03:00
nvazquez 67794aba23 Fix reinstall VM bug 2020-10-20 03:00:21 -03:00
nvazquez 88c02efd27 Fix deploy-as-is templates GC 2020-10-19 15:05:58 +05:30
Harikrishna Patnala 048e8c8744 Fixed the issue of VM deletion not cleaning the VM folder on vVols datastore. Fixed it by deleting the VM as complete entity including the extra root disks. 2020-10-19 15:05:58 +05:30
Harikrishna Patnala 5fdabc1cb0 Added storage policy details to disk while creating disk and restricted migration of volumes to storage pools which are not storage policy compliance 2020-10-19 15:05:58 +05:30
Harikrishna Patnala 46b5322d9b Adding vSphere storage policy to disk on start command and attach volume command 2020-10-19 15:05:58 +05:30
nvazquez d69283a013 Fix reset/restore VM 2020-10-19 15:05:57 +05:30
Harikrishna Patnala 9dd1d60db9 Fix multidisk VM deployment on vVol datastore 2020-10-19 15:05:57 +05:30
Harikrishna Patnala 388a9c2c6d Reconcile chaininfo after attaching volume 2020-10-19 15:05:57 +05:30
Harikrishna Patnala 9b923ba9dc Handle detach volume of datastore cluster if the volume name has changed at vCenter level and reconsile the chaininfo 2020-10-19 15:05:57 +05:30
Harikrishna Patnala 588b7a1c90 Cleanup volume wrapper VM(ROOT-xxx) while deploying VM in case of any failure. since the same name will be used on retries and that will eventually fails saying volume wrapper VM already exists. 2020-10-19 15:05:57 +05:30
nvazquez 897cc4bdba Fix nested virt marvin test 2020-10-19 15:05:57 +05:30
nvazquez 94bebe8792 Revert back deploy as is column on templates but keep it as default for new templates 2020-10-19 15:05:57 +05:30
nvazquez 46d412d998 Fix for system VMs 2020-10-19 15:05:57 +05:30
nvazquez 9b51a706db Set deploy-as-is to default on VMware 2020-10-19 15:05:57 +05:30
Harikrishna Patnala 2f03877723 Search in possible folders for volume while dettaching the volume 2020-10-19 15:05:57 +05:30
Harikrishna Patnala 9543fd6e6a Fix startcommand on Datastore cluster when the volume datastore in CloudStack mismatches with vCenter datastore. Volume could have migrated with in datastore cluster which caused the mismatch 
Fix dettach volume when volume is not on CloudStack intended datastore
 2020-10-19 15:05:57 +05:30
nvazquez 78aa3df440 Fix reboot deploy-as-is VMs 2020-10-19 15:05:57 +05:30
nvazquez 667cb53772 Fix mismatch from OVF nic adapter type and expected adapter type string 2020-10-19 15:05:57 +05:30
Harikrishna Patnala bb90ce5bd7 Fix for dettached disk migrations from vVols to other datastores 2020-10-19 15:05:57 +05:30
nvazquez 7a8dd46b32 Fix deploy as-is disks cleanup 2020-10-19 15:05:57 +05:30
Harikrishna Patnala 89aa25d023 VM deployment from ISO not working on VSAN65, fixed by adding a backup to create disk using old way 2020-10-19 15:05:57 +05:30
nvazquez c6c4bfe30c Fix deploy as is with datadisks 2020-10-19 15:05:57 +05:30
nvazquez acf872cdab Relocate deploy-as-is cloned VM if does not end on the host receiving the start command and restore deployment logs 2020-10-19 15:05:57 +05:30
nvazquez edfbed34ad Use network adapter from OVF on deploy-as-is 2020-10-19 15:05:57 +05:30
nvazquez 61e7625d49 Do not set user-configurable details for deploy-as-is VMs 2020-10-19 15:05:57 +05:30
Harikrishna Patnala 44dc0c6072 Fixed rat failure on new class DeployAsIsHelper.java 
Also removed some unused imports during rebase
 2020-10-19 15:05:57 +05:30
nvazquez 19c83fef64 Fix zone to zone scope volume migrations NPE 2020-10-19 15:05:57 +05:30
Harikrishna Patnala 6ebfdc6854 Dettached datadisk migration failed between NFS storages. 
Fixed the issue of worker VM name being null
 2020-10-19 15:05:57 +05:30
nvazquez bb4ce2118d Add new template and vm deploy as is details table and refactor 2020-10-19 15:05:57 +05:30
Harikrishna Patnala fab6b41c90 Delete VM fix which does not move detached disks to fcd folder 
vVols attach disk fix
 2020-10-19 15:05:56 +05:30
Harikrishna Patnala f74262b12a Snapshot on dettached volume considering wrong path, corrected it 2020-10-19 15:05:56 +05:30
Harikrishna Patnala f53f11b010 Fix seeding template issue after PR merging 2020-10-19 15:05:56 +05:30
Harikrishna Patnala f825a94dc4 Fixed volume migrations to and fro vVols datastorewq 2020-10-19 15:05:56 +05:30
Harikrishna Patnala 700ab1a5ef vVols datastore support added 2020-10-19 15:05:56 +05:30
Harikrishna Patnala 5652097ef0 Added backup on fail over scenrio in case of new create disk method 2020-10-19 15:05:56 +05:30
nvazquez d864e9dc39 [VMware] Full OVF properties support 2020-10-19 15:05:56 +05:30
Harikrishna Patnala 04d400f055 Handle import unmanaged VM into CloudStack to support any type of datastore 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 40934ba9ff Fix travis failures by removing dependency of vmware from storage. 
Added a new command class to verify the vCenter details provided while adding primary storage
 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 570f3214b8 Handle VMFS6 sesparse format disk files 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 0a412ac6da Handle volume copy from secondary to primary in case of vSAN 2020-10-19 14:57:16 +05:30
Harikrishna Patnala af84743fd9 Fix addition of datastore clusters not to configure it as non NFS storage 2020-10-19 14:57:16 +05:30
Harikrishna Patnala b88df5ee5b Fixed a smoke test while taking snapshot 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 2dd6e184d5 Fix simulator code for SimulatorStorageProcessor.java 2020-10-19 14:57:16 +05:30
Harikrishna Patnala a5531a9e86 Changed artifact id from pbm for vmware-pbm for policy based management 2020-10-19 14:57:16 +05:30
Pearl Dsilva e211b92324 Changed workflow for storing volumes in sec storage 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 36d65905b1 Base folder creation on datstores restrict only to primary storages, for secondary storage datastore it is not required 2020-10-19 14:57:16 +05:30
Harikrishna Patnala c8a28f34ee Use clonevm task while creating template from volume 
Old way is by taking snapshot of entire VM and then clone from that snapshot with the required disk
 2020-10-19 14:57:16 +05:30
Pearl Dsilva 4178a7cd90 inter-cluster migration support 2020-10-19 14:57:16 +05:30
Harikrishna Patnala 5aac6c3f0f Fix immutable list to add another entry to list 2020-10-19 14:57:16 +05:30
Harikrishna Patnala ed7efdf4d2 Generalise linked clone formats which are different for each datastore type 2020-10-19 14:57:16 +05:30
Harikrishna Patnala c9c38c0f37 Handle datastore clusters in list storage pools to list only parent not the children in the Datastore cluster 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 53fa3beecf Register Disk to first class disk whereever possible 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 41b3fc19d6 Add Datastore cluster and the child entities which are datastores in the cluster into CloudStack 
Setting scope is still pending.
 2020-10-19 14:57:15 +05:30
Harikrishna Patnala f858387b3c Import storagepolicies when vmware datacenter is added or updated 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 48786b2d31 DataStore Clusters addition as a storage pool 2020-10-19 14:57:15 +05:30
Harikrishna Patnala c45b83a158 Logging variable name change 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 586fa7eeaf Added listVsphereStoragePoliciesCmd 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 233e665b34 Fix response list on importVsphereStoragePoliciescmd 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 778148ba16 Fix importstorage policies to update deleted policies on vcenter 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 18340e96b1 importVsphereStoragePolices improvements 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 6df819028e UI changes and accept any type of datastore as presetup in vmware 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 4bbb747b23 VMFS to presetup change 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 3d9edeeb9d Bug fixing on default base folder 2020-10-19 14:57:15 +05:30
Harikrishna Patnala aa07959f2a Use VStorageObjectManager for disk operations. 
Created disks using VStorageObjectManager
Removed redundant code around attach volume and create volumes
 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 487bb03c4d Added Storagepolicy while creating diskoffering. CreateDiskOffering API now takes storagepolicy as a parameter with UUID value 2020-10-19 14:57:15 +05:30
Harikrishna Patnala fb0a96e7fb Check if datastore is complaince with the storagepolicy provided in the disk offering. 
Added corresponding manager objects from PBM sdk to do the job.
Made dao layer changes to read the storage policy in diskoffering
 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 27e5dfa633 Updated code to handle sync of storage policies when importVsphereStoragePolicies API is called multiple times 2020-10-19 14:57:15 +05:30
Harikrishna Patnala a951e5f57f Fixed unit test failure 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 8b23ea90b8 Moved Dao and VO files to different packages 2020-10-19 14:57:15 +05:30
Harikrishna Patnala a4ec86a652 Added Storage policy id to VO 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 037fcfd032 Fixed bean creation errors on VsphereStoragePolicyDaoImpl 2020-10-19 14:57:15 +05:30
Harikrishna Patnala b8b4f0f9ad Added importVsphereStoragePolicies API and scheme changes 2020-10-19 14:57:15 +05:30
Harikrishna Patnala a72782f2e5 Fix root folder issue on datastore 2020-10-19 14:57:15 +05:30
Harikrishna Patnala 0701dc9d9c Initial commit adding few required managed object classes and added pbm sdk 2020-10-19 14:57:15 +05:30
Daan Hoogland 644731edad Merge branch '4.14' 2020-10-15 18:02:00 +00:00
Wei Zhou be5df8d9ed
kvm: fix wrong VM CPU usage (#4381) 2020-10-15 13:57:59 +02:00
Abhishek Kumar 5b419b90d0
vmware: use hotPlugMemoryIncrementSize only for valid value (#4348) 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
 2020-10-14 16:05:57 +05:30
Spaceman1984 1bbb29d034
Fixed vm-templates not being removed from primary storage with storag… (#4389) 
* Fixed vm-templates not being removed from primary storage with storage garbage collection

* Update vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java

Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>

* Var name

Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
 2020-10-12 15:54:12 +05:30
Abhishek Kumar d3be14d4c8
hypervisor: Add Citrix Hypervisor 8x product name support (#4271) 
* changes for supporting Citrix Hypervisor product name

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
 2020-10-12 15:50:43 +05:30
Spaceman1984 479ef8aafa
VMware: match hardware version for worker VM when taking a snapshot (#4321) 
* Add hardware version to worker VM

* Added worker VM hardware version when creating a template from a volume and migrating a detached volume

* Add null parameter back that was removed by merge
 2020-10-09 17:06:07 +02:00
Rohit Yadav 86fcb14238 Merge remote-tracking branch 'origin/4.14' 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2020-09-24 12:20:29 +05:30
Abhishek Kumar ca1e02fab9
vmware: search unmanaged instances using hypervisor name (#4328) 
VMware code keeps a cache of existing VMs on a hypervisor host using cloud.vm.internal.name property of the VM. Searching for unmanaged instances/VMs on a host might not return an expected result when this property differs from the actual name of the VM.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
 2020-09-24 11:01:33 +05:30
Rohit Yadav 4f8b88baea
vmware: while plugging in nics get existing sorted nic devices (#4336) 
In large environments, with VR having multiple nics when plugging in
nic, it must get existing nics by sorted device ID otherwise it may
cause incorrect nic plugging/order.

Fixes #4246

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2020-09-24 10:59:39 +05:30
Pearl Dsilva 90e72b1e40
vmware: Create template from detached data-disks on VMWare (#4294) 
Creation of templates from detached data disks results in a Null Pointer Exception on VMWare, as it expects the volume to be attached to a VM.
To fix this behavior and make it consistent with other hypervisors, creation of the template from the volume in case not attached to a VM is facilitated by creating a worker VM, attaching the disk to the worker VM, creating the template from it, and then destroying the VM.

Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
 2020-09-18 08:25:17 +05:30
Rohit Yadav bb73bedb55 Merge remote-tracking branch 'origin/4.14' 2020-08-21 15:39:00 +05:30
Rohit Yadav 05ae3f8d81 Merge remote-tracking branch 'origin/4.13' into 4.14 2020-08-21 15:38:18 +05:30
Sid Kattoju 1da76d27f1
iscsi session cleanup now configurable, filters iscsi partitions (#4219) 
Added property to agent.properties that enables or disables the iscsi session clean up feature. #4210
Added a condition to prevent disk partitions from being cleaned up. #4216
 2020-08-21 14:38:36 +05:30
davidjumani 3872bf1ff9
kvm: Enable PVLAN support on L2 networks (#4040) 
This is an extention of #3732 for kvm.
This is restricted to ovs > 2.9.2
Since Xen uses ovs 2.6, pvlan is unsupported.
This also fixes issues of vms on the same pvlan unable to communicate if they're on the same host
 2020-08-20 15:46:34 +05:30
Spaceman1984 d57aa83517
server: Added nfs minor version support (#4180) 
This PR adds minor version support when mounting nfs on the SSVM as requested in #2861

The global setting "secstorage.nfs.version" has been changed to use the String data type which allows any minor version to be specified.
 2020-08-19 14:53:38 +05:30